Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23239
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23239#discussion_r239690045
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -198,11 +198,45 @@ protected final void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23239#discussion_r239507673
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -198,11 +198,45 @@ protected final void
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23239#discussion_r239302780
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -198,11 +198,45 @@ protected final void
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23239#discussion_r239256853
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -174,11 +174,6 @@ public static float getFloat(Object object, long
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/23239
[SPARK-26021][SQL][followup] only deal with NaN and -0.0 in UnsafeWriter
## What changes were proposed in this pull request?
A followup of https://github.com/apache/spark/pull/23043
