[GitHub] [yunikorn-site] craigcondit closed pull request #252: [YUNIKORN-1540] Fix default placeholder image in documentation

2023-01-18 Thread GitBox
craigcondit closed pull request #252: [YUNIKORN-1540] Fix default placeholder image in documentation URL: https://github.com/apache/yunikorn-site/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [yunikorn-site] craigcondit opened a new pull request, #252: [YUNIKORN-1540] Fix default placeholder image in documentation

2023-01-18 Thread GitBox
craigcondit opened a new pull request, #252: URL: https://github.com/apache/yunikorn-site/pull/252 ### What is this PR for? Fix the default placeholder image listed in documentation. ### What type of PR is it? * [x] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] -

[GitHub] [yunikorn-k8shim] pbacsko closed pull request #515: [YUNIKORN-1534] Add binpacking test suites

2023-01-18 Thread GitBox
pbacsko closed pull request #515: [YUNIKORN-1534] Add binpacking test suites URL: https://github.com/apache/yunikorn-k8shim/pull/515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [yunikorn-k8shim] manirajv06 opened a new pull request, #515: [YUNIKORN-1534] Add binpacking test suites

2023-01-18 Thread GitBox
manirajv06 opened a new pull request, #515: URL: https://github.com/apache/yunikorn-k8shim/pull/515 ### What is this PR for? addendum pr for go mod changes ### What type of PR is it? * [ ] - Improvement ### Todos * [ ] - Task ### What is the Jira issue?

[GitHub] [yunikorn-k8shim] pbacsko closed pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-18 Thread GitBox
pbacsko closed pull request #513: [YUNIKORN-1534] Add binpacking test suites URL: https://github.com/apache/yunikorn-k8shim/pull/513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [yunikorn-k8shim] pbacsko commented on pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-18 Thread GitBox
pbacsko commented on PR #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513#issuecomment-1386829711 +1 merging soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [yunikorn-k8shim] manirajv06 commented on pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-17 Thread GitBox
manirajv06 commented on PR #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513#issuecomment-1386513640 > LGTM, I just have a question about the version. Also, please check if the missing "\n" in the `Sprintf()` calls is a problem or not. Modified the version. Newline is not

[GitHub] [yunikorn-site] yangwwei merged pull request #251: [YUNIKORN-1539] Add KubeConf talk info to events page

2023-01-17 Thread GitBox
yangwwei merged PR #251: URL: https://github.com/apache/yunikorn-site/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-k8shim] pbacsko commented on pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-17 Thread GitBox
pbacsko commented on PR #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513#issuecomment-1385758329 LGTM, I just have a question about the version. Also, please check if the missing "\n" in the `Sprintf()` calls is a problem or not. -- This is an automated message from the

[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-17 Thread GitBox
pbacsko commented on code in PR #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513#discussion_r1072498437 ## test/e2e/bin_packing/bin_packing_test.go: ## @@ -0,0 +1,199 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license

[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-17 Thread GitBox
pbacsko commented on code in PR #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513#discussion_r1072497012 ## go.mod: ## @@ -41,6 +41,7 @@ require ( k8s.io/component-base v0.23.14 k8s.io/klog v1.0.0 k8s.io/kube-scheduler v0.23.14 +

[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-17 Thread GitBox
pbacsko commented on code in PR #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513#discussion_r1072495817 ## test/e2e/bin_packing/bin_packing_test.go: ## @@ -0,0 +1,199 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license

[GitHub] [yunikorn-k8shim] manirajv06 commented on pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-17 Thread GitBox
manirajv06 commented on PR #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513#issuecomment-1385659494 Found some issues in calculating node available resources and fixed the same. Based on the recent runs, don't see any instability in bin packing test results. @pbacsko

[GitHub] [yunikorn-k8shim] yuchaoran2011 merged pull request #514: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-16 Thread GitBox
yuchaoran2011 merged PR #514: URL: https://github.com/apache/yunikorn-k8shim/pull/514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-core] yuchaoran2011 merged pull request #496: [YUNIKORN-1495]Update thr copyright years in NOTICE file to 2023

2023-01-14 Thread GitBox
yuchaoran2011 merged PR #496: URL: https://github.com/apache/yunikorn-core/pull/496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-site] yuchaoran2011 merged pull request #250: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-14 Thread GitBox
yuchaoran2011 merged PR #250: URL: https://github.com/apache/yunikorn-site/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-scheduler-interface] yuchaoran2011 merged pull request #83: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-14 Thread GitBox
yuchaoran2011 merged PR #83: URL: https://github.com/apache/yunikorn-scheduler-interface/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-web] yuchaoran2011 merged pull request #100: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-14 Thread GitBox
yuchaoran2011 merged PR #100: URL: https://github.com/apache/yunikorn-web/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-web] HuangTing-Yao opened a new pull request, #100: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-14 Thread GitBox
HuangTing-Yao opened a new pull request, #100: URL: https://github.com/apache/yunikorn-web/pull/100 ### What is this PR for? Update NOTICE file in root folder ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation * [

[GitHub] [yunikorn-site] HuangTing-Yao opened a new pull request, #250: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-14 Thread GitBox
HuangTing-Yao opened a new pull request, #250: URL: https://github.com/apache/yunikorn-site/pull/250 ### What is this PR for? Update NOTICE file in root folder ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation * [ ]

[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #514: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-14 Thread GitBox
codecov[bot] commented on PR #514: URL: https://github.com/apache/yunikorn-k8shim/pull/514#issuecomment-1383069546 #

[GitHub] [yunikorn-scheduler-interface] HuangTing-Yao opened a new pull request, #83: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-14 Thread GitBox
HuangTing-Yao opened a new pull request, #83: URL: https://github.com/apache/yunikorn-scheduler-interface/pull/83 ### What is this PR for? update NOTICE file in root folder ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] -

[GitHub] [yunikorn-k8shim] HuangTing-Yao opened a new pull request, #514: [YUNIKORN-1495]Update the copyright years in NOTICE files to 2023

2023-01-14 Thread GitBox
HuangTing-Yao opened a new pull request, #514: URL: https://github.com/apache/yunikorn-k8shim/pull/514 ### What is this PR for? update NOTICE file in root folder ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #496: [YUNIKORN-1495]Update thr copyright years in NOTICE file to 2023

2023-01-14 Thread GitBox
codecov[bot] commented on PR #496: URL: https://github.com/apache/yunikorn-core/pull/496#issuecomment-1383068060 # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/496?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [yunikorn-core] HuangTing-Yao opened a new pull request, #496: [YUNIKORN-1495]Update thr copyright years in NOTICE file to 2023

2023-01-14 Thread GitBox
HuangTing-Yao opened a new pull request, #496: URL: https://github.com/apache/yunikorn-core/pull/496 ### What is this PR for? Update NOTICE file in root folder ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation *

[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-12 Thread GitBox
codecov[bot] commented on PR #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513#issuecomment-1380122413 #

[GitHub] [yunikorn-k8shim] manirajv06 opened a new pull request, #513: [YUNIKORN-1534] Add binpacking test suites

2023-01-12 Thread GitBox
manirajv06 opened a new pull request, #513: URL: https://github.com/apache/yunikorn-k8shim/pull/513 ### What is this PR for? Added bin packing node sorting policy test suites ### What type of PR is it? * [ ] - Improvement ### Todos * [ ] - Task ### What is the

[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #512: [YUNIKORN-1525] data race: TestTryReserve

2023-01-10 Thread GitBox
codecov[bot] commented on PR #512: URL: https://github.com/apache/yunikorn-k8shim/pull/512#issuecomment-1377217032 #

[GitHub] [yunikorn-k8shim] pbacsko opened a new pull request, #512: [YUNIKORN-1525] data race: TestTryReserve

2023-01-10 Thread GitBox
pbacsko opened a new pull request, #512: URL: https://github.com/apache/yunikorn-k8shim/pull/512 ### What is this PR for? Fix data race issues in `application_test.go`. Don't manipulate `Context.applications` directly. ### What type of PR is it? * [x] - Bug Fix * [ ] -

[GitHub] [yunikorn-k8shim] pbacsko closed pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

2023-01-10 Thread GitBox
pbacsko closed pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2 URL: https://github.com/apache/yunikorn-k8shim/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

2023-01-10 Thread GitBox
pbacsko commented on code in PR #511: URL: https://github.com/apache/yunikorn-k8shim/pull/511#discussion_r1065506290 ## test/e2e/framework/helpers/yunikorn/rest_api_utils.go: ## @@ -404,12 +406,13 @@ func (c *RClient) LogNodesInfo(outputDir string) error { return err }

[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

2023-01-10 Thread GitBox
pbacsko commented on code in PR #511: URL: https://github.com/apache/yunikorn-k8shim/pull/511#discussion_r1065506290 ## test/e2e/framework/helpers/yunikorn/rest_api_utils.go: ## @@ -404,12 +406,13 @@ func (c *RClient) LogNodesInfo(outputDir string) error { return err }

[GitHub] [yunikorn-k8shim] manirajv06 commented on pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

2023-01-09 Thread GitBox
manirajv06 commented on PR #511: URL: https://github.com/apache/yunikorn-k8shim/pull/511#issuecomment-1376825506 Cleaned up all debug statements. All tests are passing consistently, ready for merge. Raised https://issues.apache.org/jira/browse/YUNIKORN-1533 for v1.22.15 failures. It is

[GitHub] [yunikorn-core] craigcondit closed pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-09 Thread GitBox
craigcondit closed pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues URL: https://github.com/apache/yunikorn-core/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #495: [YUNIKORN-1520] TestApplyConf: poor unit test coverage

2023-01-08 Thread GitBox
codecov[bot] commented on PR #495: URL: https://github.com/apache/yunikorn-core/pull/495#issuecomment-1375171264 # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/495?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [yunikorn-core] wusamzong opened a new pull request, #495: [YUNIKORN-1520] TestApplyConf: poor unit test coverage

2023-01-08 Thread GitBox
wusamzong opened a new pull request, #495: URL: https://github.com/apache/yunikorn-core/pull/495 ### What is this PR for? I add some test for ApplyConf(). The test contains three part: 1. Cover error cases for SubmitACL & AdminACL 2. Check if `isManaged` will changed to `true`

[GitHub] [yunikorn-web] dependabot[bot] opened a new pull request, #99: Bump json5 from 1.0.1 to 1.0.2

2023-01-08 Thread GitBox
dependabot[bot] opened a new pull request, #99: URL: https://github.com/apache/yunikorn-web/pull/99 Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v1.0.2 Fix:

[GitHub] [yunikorn-site] yangwwei merged pull request #249: [YUNIKORN-1522] Add Chinese translation for release announcement 1.1

2023-01-06 Thread GitBox
yangwwei merged PR #249: URL: https://github.com/apache/yunikorn-site/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #494: [YUNIKORN-1453] Remove asks from completed applications

2023-01-06 Thread GitBox
codecov[bot] commented on PR #494: URL: https://github.com/apache/yunikorn-core/pull/494#issuecomment-1373718018 # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/494?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [yunikorn-core] pbacsko opened a new pull request, #494: [YUNIKORN-1453] Remove asks from completed applications

2023-01-06 Thread GitBox
pbacsko opened a new pull request, #494: URL: https://github.com/apache/yunikorn-core/pull/494 ### What is this PR for? If the application is completed, we should clean up containers which hold `AllocationAsk` objects . ### What type of PR is it? * [ ] - Bug Fix * [x] -

[GitHub] [yunikorn-site] wusamzong opened a new pull request, #249: [YUNIKORN-1522] Add Chinese translation for release announcement 1.1

2023-01-05 Thread GitBox
wusamzong opened a new pull request, #249: URL: https://github.com/apache/yunikorn-site/pull/249 ### What is this PR for? I translate the page `release announce of v1.1.0` to Chinese In addition, I also synchronized the version information in the `Download` page ### What type

[GitHub] [yunikorn-site] wusamzong closed pull request #248: [YUNIKORN-1522]- Add Chinese translation for release announcement 1.1

2023-01-05 Thread GitBox
wusamzong closed pull request #248: [YUNIKORN-1522]- Add Chinese translation for release announcement 1.1 URL: https://github.com/apache/yunikorn-site/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [yunikorn-site] wusamzong opened a new pull request, #248: Yunikorn 1522

2023-01-05 Thread GitBox
wusamzong opened a new pull request, #248: URL: https://github.com/apache/yunikorn-site/pull/248 ### What is this PR for? I translate the page `release announce of v1.1.0` to Chinese In addition, I also synchronized the version information in the `Download` page ### What type

[GitHub] [yunikorn-core] pbacsko commented on a diff in pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-05 Thread GitBox
pbacsko commented on code in PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#discussion_r1062282285 ## pkg/scheduler/objects/queue.go: ## @@ -1571,3 +1593,84 @@ func (sq *Queue) recalculatePriority() int32 { sq.currentPriority = curr return

[GitHub] [yunikorn-k8shim] pbacsko closed pull request #510: [YUNIKORN-1524] remove blacklist from e2e tests-prediction

2023-01-05 Thread GitBox
pbacsko closed pull request #510: [YUNIKORN-1524] remove blacklist from e2e tests-prediction URL: https://github.com/apache/yunikorn-k8shim/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

2023-01-04 Thread GitBox
wilfred-s commented on code in PR #511: URL: https://github.com/apache/yunikorn-k8shim/pull/511#discussion_r1062113520 ## test/e2e/gang_scheduling/gang_scheduling_test.go: ## @@ -31,12 +31,18 @@ import (

[GitHub] [yunikorn-core] wilfred-s closed pull request #493: [YUNIKORN-1529] Data race in TestTimeoutPlaceholderAllocReleased

2023-01-04 Thread GitBox
wilfred-s closed pull request #493: [YUNIKORN-1529] Data race in TestTimeoutPlaceholderAllocReleased URL: https://github.com/apache/yunikorn-core/pull/493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-04 Thread GitBox
wilfred-s commented on code in PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#discussion_r1062038862 ## pkg/scheduler/objects/queue.go: ## @@ -1571,3 +1593,84 @@ func (sq *Queue) recalculatePriority() int32 { sq.currentPriority = curr return

[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-04 Thread GitBox
wilfred-s commented on code in PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#discussion_r1062084065 ## pkg/scheduler/objects/queue.go: ## @@ -628,6 +635,8 @@ func (sq *Queue) AddApplication(app *Application) { defer sq.Unlock()

[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-04 Thread GitBox
wilfred-s commented on code in PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#discussion_r1062038862 ## pkg/scheduler/objects/queue.go: ## @@ -1571,3 +1593,84 @@ func (sq *Queue) recalculatePriority() int32 { sq.currentPriority = curr return

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #493: [YUNIKORN-1529] Data race in TestTimeoutPlaceholderAllocReleased

2023-01-04 Thread GitBox
codecov[bot] commented on PR #493: URL: https://github.com/apache/yunikorn-core/pull/493#issuecomment-1371288511 # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/493?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [yunikorn-core] pbacsko opened a new pull request, #493: [YUNIKORN-1529] Data race in TestTimeoutPlaceholderAllocReleased

2023-01-04 Thread GitBox
pbacsko opened a new pull request, #493: URL: https://github.com/apache/yunikorn-core/pull/493 ### What is this PR for? Data race was detected by Go in `TestTimeoutPlaceholderAllocReleased`. Don't use unlocked access to `Application.placeholderTimer`. ### What type of PR is it?

[GitHub] [yunikorn-core] pbacsko commented on a diff in pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-04 Thread GitBox
pbacsko commented on code in PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#discussion_r1061282100 ## pkg/scheduler/objects/queue.go: ## @@ -1571,3 +1593,84 @@ func (sq *Queue) recalculatePriority() int32 { sq.currentPriority = curr return

[GitHub] [yunikorn-core] pbacsko commented on a diff in pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-04 Thread GitBox
pbacsko commented on code in PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#discussion_r1061278496 ## pkg/scheduler/objects/queue.go: ## @@ -1571,3 +1593,84 @@ func (sq *Queue) recalculatePriority() int32 { sq.currentPriority = curr return

[GitHub] [yunikorn-core] pbacsko commented on a diff in pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-04 Thread GitBox
pbacsko commented on code in PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#discussion_r1061278188 ## pkg/scheduler/objects/queue.go: ## @@ -628,6 +635,8 @@ func (sq *Queue) AddApplication(app *Application) { defer sq.Unlock()

[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

2023-01-03 Thread GitBox
codecov[bot] commented on PR #511: URL: https://github.com/apache/yunikorn-k8shim/pull/511#issuecomment-1370487920 #

[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

2023-01-03 Thread GitBox
wilfred-s commented on PR #511: URL: https://github.com/apache/yunikorn-k8shim/pull/511#issuecomment-1370482473 @manirajv06 we probably need YUNIKORN-1525 fixed so we can get the unit tests to pass and run the e2e tests. I kicked of the build again and see if it at least gets us passed

[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-03 Thread GitBox
wilfred-s commented on code in PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#discussion_r1061089397 ## pkg/scheduler/objects/queue.go: ## @@ -1571,3 +1593,84 @@ func (sq *Queue) recalculatePriority() int32 { sq.currentPriority = curr return

[GitHub] [yunikorn-k8shim] manirajv06 opened a new pull request, #511: [YUNIKORN-1528] Add gang scheduling test suites - Phase 2

2023-01-03 Thread GitBox
manirajv06 opened a new pull request, #511: URL: https://github.com/apache/yunikorn-k8shim/pull/511 ### What is this PR for? Cover the left out test methods of Gang scheduling test suite. ### What type of PR is it? * [ ] - Improvement ### Todos * [ ] - Task

[GitHub] [yunikorn-core] 0yukali0 commented on a diff in pull request #492: [YUNIKORN-1446] Adopting table-driven style in the acl unit test

2023-01-02 Thread GitBox
0yukali0 commented on code in PR #492: URL: https://github.com/apache/yunikorn-core/pull/492#discussion_r1060276119 ## pkg/common/security/acl_test.go: ## @@ -19,119 +19,206 @@ package security import ( + "errors" + "fmt" "testing" - -

[GitHub] [yunikorn-core] 0yukali0 commented on a diff in pull request #492: [YUNIKORN-1446] Adopting table-driven style in the acl unit test

2023-01-02 Thread GitBox
0yukali0 commented on code in PR #492: URL: https://github.com/apache/yunikorn-core/pull/492#discussion_r1060262256 ## pkg/common/security/acl_test.go: ## @@ -19,119 +19,206 @@ package security import ( + "errors" + "fmt" "testing" - -

[GitHub] [yunikorn-core] 0yukali0 commented on a diff in pull request #492: [YUNIKORN-1446] Adopting table-driven style in the acl unit test

2023-01-02 Thread GitBox
0yukali0 commented on code in PR #492: URL: https://github.com/apache/yunikorn-core/pull/492#discussion_r1060261909 ## pkg/common/security/acl_test.go: ## @@ -19,119 +19,206 @@ package security import ( + "errors" + "fmt" "testing" - -

[GitHub] [yunikorn-site] wilfred-s closed pull request #239: [YUNIKORN-1407] Adding Chinese translation of App Placement Rules

2023-01-02 Thread GitBox
wilfred-s closed pull request #239: [YUNIKORN-1407] Adding Chinese translation of App Placement Rules URL: https://github.com/apache/yunikorn-site/pull/239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [yunikorn-core] wilfred-s commented on pull request #479: [YUNIKORN-1466] Track dynamic preemption priority for queues

2023-01-02 Thread GitBox
wilfred-s commented on PR #479: URL: https://github.com/apache/yunikorn-core/pull/479#issuecomment-1369311493 @pbacsko Please fix the conflicts so we can do a final review on the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #492: [YUNIKORN-1446] Adopting table-driven style in the acl unit test

2023-01-02 Thread GitBox
wilfred-s commented on code in PR #492: URL: https://github.com/apache/yunikorn-core/pull/492#discussion_r1060226609 ## pkg/common/security/acl_test.go: ## @@ -19,119 +19,206 @@ package security import ( + "errors" + "fmt" "testing" - -

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #492: [YUNIKORN-1446] Adopting table-driven style in the acl unit test

2023-01-01 Thread GitBox
codecov[bot] commented on PR #492: URL: https://github.com/apache/yunikorn-core/pull/492#issuecomment-1368712359 # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [yunikorn-core] 0yukali0 opened a new pull request, #492: [YUNIKORN-1446] Adopting table-driven style in the acl unit test

2023-01-01 Thread GitBox
0yukali0 opened a new pull request, #492: URL: https://github.com/apache/yunikorn-core/pull/492 ### What is this PR for? Current ACL unit tests do not adopt table-driven style, so I rewrite the ACL unit test file. ### What type of PR is it? * [ ] - Bug Fix * [x] -

[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #510: [YUNIKORN-1524] remove blacklist from e2e tests-prediction

2022-12-30 Thread GitBox
codecov[bot] commented on PR #510: URL: https://github.com/apache/yunikorn-k8shim/pull/510#issuecomment-1368168639 #

[GitHub] [yunikorn-k8shim] zhuqi-lucas opened a new pull request, #510: [YUNIKORN-1524] remove blacklist from e2e tests-prediction

2022-12-30 Thread GitBox
zhuqi-lucas opened a new pull request, #510: URL: https://github.com/apache/yunikorn-k8shim/pull/510 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide -

[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #507: [YUNIKORN-1492] Add gang scheduling test suites

2022-12-30 Thread GitBox
wilfred-s closed pull request #507: [YUNIKORN-1492] Add gang scheduling test suites URL: https://github.com/apache/yunikorn-k8shim/pull/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [yunikorn-site] yuchaoran2011 merged pull request #246: [YUNIKORN-1313] update release procedure for helm signing

2022-12-30 Thread GitBox
yuchaoran2011 merged PR #246: URL: https://github.com/apache/yunikorn-site/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-site] yuchaoran2011 merged pull request #244: [YUNIKORN-1503] Chinese translation of troubleshooting

2022-12-30 Thread GitBox
yuchaoran2011 merged PR #244: URL: https://github.com/apache/yunikorn-site/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-site] yuchaoran2011 commented on a diff in pull request #244: [YUNIKORN-1503] Chinese translation of troubleshooting

2022-12-30 Thread GitBox
yuchaoran2011 commented on code in PR #244: URL: https://github.com/apache/yunikorn-site/pull/244#discussion_r1059288752 ## i18n/zh-cn/docusaurus-plugin-content-docs/current/user_guide/troubleshooting.md: ## @@ -96,97 +90,100 @@ Available logging levels: | 4 |

[GitHub] [yunikorn-site] wusamzong commented on a diff in pull request #244: [YUNIKORN-1503] Chinese translation of troubleshooting

2022-12-30 Thread GitBox
wusamzong commented on code in PR #244: URL: https://github.com/apache/yunikorn-site/pull/244#discussion_r1059282381 ## i18n/zh-cn/docusaurus-plugin-content-docs/current/user_guide/troubleshooting.md: ## @@ -20,73 +20,67 @@ title: Troubleshooting * See the License for the

[GitHub] [yunikorn-site] wusamzong commented on a diff in pull request #244: [YUNIKORN-1503] Chinese translation of troubleshooting

2022-12-30 Thread GitBox
wusamzong commented on code in PR #244: URL: https://github.com/apache/yunikorn-site/pull/244#discussion_r1059282163 ## i18n/zh-cn/docusaurus-plugin-content-docs/current/user_guide/troubleshooting.md: ## @@ -96,97 +90,100 @@ Available logging levels: | 4 | Panic

[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #507: [YUNIKORN-1492] Add gang scheduling test suites

2022-12-29 Thread GitBox
wilfred-s commented on code in PR #507: URL: https://github.com/apache/yunikorn-k8shim/pull/507#discussion_r1059266841 ## test/e2e/Wrappers.go: ## @@ -0,0 +1,143 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See

[GitHub] [yunikorn-site] yuchaoran2011 merged pull request #247: [YUNIKORN-1521] fix broken release announcement links

2022-12-29 Thread GitBox
yuchaoran2011 merged PR #247: URL: https://github.com/apache/yunikorn-site/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-site] yuchaoran2011 merged pull request #245: [YUNIKORN-1504] Chinese translation of Run MPI jobs in workload

2022-12-29 Thread GitBox
yuchaoran2011 merged PR #245: URL: https://github.com/apache/yunikorn-site/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-site] yuchaoran2011 commented on a diff in pull request #244: [YUNIKORN-1503] Chinese translation of troubleshooting

2022-12-29 Thread GitBox
yuchaoran2011 commented on code in PR #244: URL: https://github.com/apache/yunikorn-site/pull/244#discussion_r1059258896 ## i18n/zh-cn/docusaurus-plugin-content-docs/current/user_guide/troubleshooting.md: ## @@ -96,97 +90,100 @@ Available logging levels: | 4 |

[GitHub] [yunikorn-k8shim] zhuqi-lucas commented on a diff in pull request #508: [YUNIKORN-1499] Use fine-grained K8s access control in example deployments.

2022-12-29 Thread GitBox
zhuqi-lucas commented on code in PR #508: URL: https://github.com/apache/yunikorn-k8shim/pull/508#discussion_r1058835170 ## deployments/scheduler/yunikorn-rbac.yaml: ## @@ -26,7 +66,49 @@ metadata: subjects: - kind: ServiceAccount name: yunikorn-admin +namespace:

[GitHub] [yunikorn-core] wilfred-s closed pull request #489: [YUNIKORN-1487] Add test for NewConfiguredQueue()

2022-12-28 Thread GitBox
wilfred-s closed pull request #489: [YUNIKORN-1487] Add test for NewConfiguredQueue() URL: https://github.com/apache/yunikorn-core/pull/489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #489: [YUNIKORN-1487] Add test for NewConfiguredQueue()

2022-12-27 Thread GitBox
wilfred-s commented on code in PR #489: URL: https://github.com/apache/yunikorn-core/pull/489#discussion_r1058062419 ## pkg/scheduler/objects/queue_test.go: ## @@ -1545,6 +1545,67 @@ func TestApplyConf(t *testing.T) { assert.Assert(t, root.guaranteedResource == nil) }

[GitHub] [yunikorn-site] wusamzong opened a new pull request, #245: [YUNIKORN-1504] Chinese translation of Run MPI jobs in workload

2022-12-27 Thread GitBox
wusamzong opened a new pull request, #245: URL: https://github.com/apache/yunikorn-site/pull/245 ### What is this PR for? I translate the page `Run MPI jobs` to Chinese ### What type of PR is it? * [x] - Task ### What is the Jira issue? * Open an issue on Jira

[GitHub] [yunikorn-site] wusamzong opened a new pull request, #244: [YUNIKORN-1503] Chinese translation of troubleshooting

2022-12-27 Thread GitBox
wusamzong opened a new pull request, #244: URL: https://github.com/apache/yunikorn-site/pull/244 ### What is this PR for? I translate the page `troubleshooting` to Chinese ### What type of PR is it? * [x] - Bug Fix ### What is the Jira issue? * Open an issue on

[GitHub] [yunikorn-site] wilfred-s closed pull request #242: [YUNIKORN-1500] Remove references to obsolete periodic state dump

2022-12-27 Thread GitBox
wilfred-s closed pull request #242: [YUNIKORN-1500] Remove references to obsolete periodic state dump URL: https://github.com/apache/yunikorn-site/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #507: [YUNIKORN-1492] Add gang scheduling test suites

2022-12-27 Thread GitBox
wilfred-s commented on PR #507: URL: https://github.com/apache/yunikorn-k8shim/pull/507#issuecomment-1366255927 Can you check the call you do in the before suite? looks like the REAT call is failing in all setups. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #508: [YUNIKORN-1499] Use fine-grained K8s access control in example deployments.

2022-12-27 Thread GitBox
wilfred-s commented on code in PR #508: URL: https://github.com/apache/yunikorn-k8shim/pull/508#discussion_r1057970059 ## deployments/scheduler/yunikorn-rbac.yaml: ## @@ -26,7 +66,49 @@ metadata: subjects: - kind: ServiceAccount name: yunikorn-admin +namespace:

[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #509: [YUNIKORN-1438] remove deprecated linters

2022-12-27 Thread GitBox
wilfred-s closed pull request #509: [YUNIKORN-1438] remove deprecated linters URL: https://github.com/apache/yunikorn-k8shim/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [yunikorn-core] wilfred-s closed pull request #491: [YUNIKORN-1438] remove deprecated linters

2022-12-27 Thread GitBox
wilfred-s closed pull request #491: [YUNIKORN-1438] remove deprecated linters URL: https://github.com/apache/yunikorn-core/pull/491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [yunikorn-core] wilfred-s closed pull request #490: [YUNIKORN-1496] update golangci-lint

2022-12-27 Thread GitBox
wilfred-s closed pull request #490: [YUNIKORN-1496] update golangci-lint URL: https://github.com/apache/yunikorn-core/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #509: [YUNIKORN-1438] remove deprecated linters

2022-12-25 Thread GitBox
codecov[bot] commented on PR #509: URL: https://github.com/apache/yunikorn-k8shim/pull/509#issuecomment-1364653483 #

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #491: [YUNIKORN-1438] remove deprecated linters

2022-12-25 Thread GitBox
codecov[bot] commented on PR #491: URL: https://github.com/apache/yunikorn-core/pull/491#issuecomment-1364652611 # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/491?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [yunikorn-k8shim] HuangTing-Yao opened a new pull request, #509: [YUNIKORN-1438] remove deprecated linters

2022-12-25 Thread GitBox
HuangTing-Yao opened a new pull request, #509: URL: https://github.com/apache/yunikorn-k8shim/pull/509 ### What is this PR for? Remove deprecated linters - deadcode - varcheck - structcheck ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ]

[GitHub] [yunikorn-core] HuangTing-Yao opened a new pull request, #491: [YUNIKORN-1438] remove deprecated linters

2022-12-25 Thread GitBox
HuangTing-Yao opened a new pull request, #491: URL: https://github.com/apache/yunikorn-core/pull/491 ### What is this PR for? Remove deprecated linters - deadcode - varcheck - structcheck ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] -

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #490: [YUNIKORN-1496] update golangci-lint

2022-12-25 Thread GitBox
codecov[bot] commented on PR #490: URL: https://github.com/apache/yunikorn-core/pull/490#issuecomment-1364651110 # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/490?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [yunikorn-core] HuangTing-Yao opened a new pull request, #490: [YUNIKORN-1496] update golangci-lint

2022-12-25 Thread GitBox
HuangTing-Yao opened a new pull request, #490: URL: https://github.com/apache/yunikorn-core/pull/490 ### What is this PR for? Upgrade golangci-lint to 1.50.1 version. ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation

[GitHub] [yunikorn-site] yangwwei merged pull request #243: [YUNIKORN-1409] Adding Chinese translation of User and Group Resolution

2022-12-24 Thread GitBox
yangwwei merged PR #243: URL: https://github.com/apache/yunikorn-site/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [yunikorn-site] craigcondit commented on pull request #242: [YUNIKORN-1500] Remove references to obsolete periodic state dump

2022-12-24 Thread GitBox
craigcondit commented on PR #242: URL: https://github.com/apache/yunikorn-site/pull/242#issuecomment-1364585571 Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [yunikorn-core] codecov[bot] commented on pull request #489: [YUNIKORN-1487] Add test for NewConfiguredQueue()

2022-12-23 Thread GitBox
codecov[bot] commented on PR #489: URL: https://github.com/apache/yunikorn-core/pull/489#issuecomment-1364478261 # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/489?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [yunikorn-core] wusamzong opened a new pull request, #489: [YUNIKORN-1487] Add test for NewConfiguredQueue()

2022-12-23 Thread GitBox
wusamzong opened a new pull request, #489: URL: https://github.com/apache/yunikorn-core/pull/489 ### What is this PR for? I add a test for NewConfiguraedQueue(). The test contains three part: 1. check simple variable assignment 2. adding leaf to queue 3. adding non-leaf to

  1   2   3   4   5   6   7   8   9   10   >