Re: Review Request 45896: Atlas Integration : Support Atlas HA

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45896/#review127780 --- Ship it! Look at you, back in the mix :) - Nate Cole On

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review127769 --- Fix it, then Ship it!

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127772 --- I know that this is to support GTID on MySQL and preventing

Review Request 45921: Not all log and PID dirs have "hadoop" group

2016-04-08 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45921/ --- Review request for Ambari and Myroslav Papirkovskyy. Bugs: AMBARI-15776

Re: Review Request 45899: After enabling NN HA with HAWQ installed, duplicate properties are seen on HAWQ config tab

2016-04-08 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45899/#review127761 --- Ship it! Ship It! - Matt On April 7, 2016, 3:26 p.m.,

Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45924/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar,

Re: Review Request 45921: Not all log and PID dirs have "hadoop" group

2016-04-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45921/#review127750 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8,

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127749 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8,

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45778/#review127756 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 5:45

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Sid Wagle
> On April 8, 2016, 12:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java, > > lines 687-692 > > > > > > This is a very dangerous query. This can

Re: Review Request 45928: AMBARI-15719: Make list of reassignable components stack driven instead of hardcoding them in the UI code

2016-04-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45928/#review127814 --- Ship it! Ship It! - Alejandro Fernandez On April 8, 2016,

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-08 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/#review127793 --- Ship it! Ship It! Maybe you should add some more tests with

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
> On Апрель 8, 2016, 3:04 п.п., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 186 > > > > > > Should we initialize if Storm/Kafka are not

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127801 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8,

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
> On Апрель 8, 2016, 3:04 п.п., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 574 > > > > > > Nit StormAns -> StormAnd fixed - Dmytro

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Sumit Mohanty
> On April 8, 2016, 3:04 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 186 > > > > > > Should we initialize if Storm/Kafka are not

Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/ --- Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, and Vitalyi

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/ --- (Updated Апрель 8, 2016, 3:04 п.п.) Review request for Ambari, Andrew

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
> On Апрель 8, 2016, 3:04 п.п., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 186 > > > > > > Should we initialize if Storm/Kafka are not

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/ --- (Updated April 8, 2016, 5:20 p.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/#review127818 --- Ship it! Ship It! - Nate Cole On April 7, 2016, 8:36 p.m.,

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? most of it is a move (the logsearch module), so its pretty

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review127861 ---

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? > > Oliver Szabo wrote: > most of it is a move (the

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review127828 --- This is a pretty massive patch. Please allow some time for the

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/ --- (Updated April 8, 2016, 6 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45937/#review127853 ---

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Jayush Luniya
> On April 8, 2016, 1:32 p.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py, > > line 218 > > > > > > Use the AMBARI- JIRA number. +1 - Jayush

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. Can the patch be broken down in more granular chunks? - Jayush --- This is an

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45924/#review127857 ---

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? > > Oliver Szabo wrote: > most of it is a move (the

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45937/#review127875 --- Ship it! Ship It! - Robert Levas On April 8, 2016, 4:09

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-08 Thread Sid Wagle
> On April 8, 2016, 12:18 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, lines 66-70 > > > > > > Since this is contacting AMS, is there a better place to get this > >

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Sid Wagle
> On April 8, 2016, 12:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java, > > lines 687-692 > > > > > > This is a very dangerous query. This can

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45937/ --- (Updated April 8, 2016, 8:09 p.m.) Review request for Ambari, John Speidel and

Re: Review Request 45937: Support Atlas / Storm integration

2016-04-08 Thread Tom Beerbower
> On April 8, 2016, 7:27 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py, > > line 195 > > > > > > Please dont use "/usr/hdp"

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/ --- (Updated April 8, 2016, 8:56 p.m.) Review request for Ambari, Jonathan Hurley,