Re: Review Request 46021: Audit logging cleanup and tests

2016-04-11 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/ --- (Updated ápr. 11, 2016, 2:11 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-11 Thread Robert Levas
> On April 11, 2016, 8:25 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > lines 1148-1161 > > > > > > Would it be better to just try

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-11 Thread Jonathan Hurley
> On April 11, 2016, 8:25 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > lines 1148-1161 > > > > > > Would it be better to just try

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
> On Апрель 8, 2016, 12:18 п.п., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, line 24 > > > > > > Why not urllib2? urllib2 doesn't have urlencode() method. Common usage

Re: Review Request 46032: Restarting ambari-server after successful blueprint deploy of large cluster makes it unresponsive

2016-04-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46032/#review128128 --- Ship it! Ship It! - Robert Nettleton On April 11, 2016,

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Oliver Szabo
> On April 8, 2016, 7:43 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json, > > line 23 > > > > > > Use service-level RCO instead of adding to the HDP stack. This

Review Request 46032: Restarting ambari-server after successful blueprint deploy of large cluster makes it unresponsive

2016-04-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46032/ --- Review request for Ambari, Daniel Gergely, Laszlo Puskas, Robert Levas, Sandor

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
> On Апрель 8, 2016, 12:18 п.п., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, lines 66-70 > > > > > > Since this is contacting AMS, is there a better place to get this >

Review Request 46017: AMBARI-15760 Add show_logs routines to Ranger Tagsync start/stop

2016-04-11 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46017/ --- Review request for Ambari, Andrew Onischuk and Gautam Borad. Bugs:

Re: Review Request 46054: Enable Hive Interactive is turned ON by default

2016-04-11 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46054/#review128293 --- Ship it! Ship It! - Yusaku Sako On April 11, 2016, 10:11

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-11 Thread Alejandro Fernandez
> On April 11, 2016, 8:10 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/fcntl_based_process_lock.py, > > line 29 > > > > > > Can we make this more robust

Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect validation error shown

2016-04-11 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45990/#review128297 --- Ship it! Ship It! - Jaimin Jetly On April 11, 2016, 9:17

Review Request 46068: Kafka tools-log4j template missing when upgraded

2016-04-11 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46068/ --- Review request for Ambari, Alejandro Fernandez and Sumit Gupta. Bugs:

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/#review128097 --- Ship it! Just a comment on the upgrade. Also, are there any

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
> On Апрель 7, 2016, 11:57 п.п., Sid Wagle wrote: > > Very nice pythonic changes to reduce verbosity (y) > > > > Why are we not chanigng the current script type alerts to use new scheme ? current script alert is to HDFS awared, but AmsAlert is a general implementation for checking any

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
> On Апрель 7, 2016, 11:57 п.п., Sid Wagle wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, line 157 > > > > > > OrderedDict support is only 2.7+ Made it unordered. For currently supported

Review Request 46021: Audit logging cleanup and tests

2016-04-11 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and

Review Request 46018: HDFS script alerts moved to UNKNOWN status with "Unable to calculate the standard deviation for 1 datapoints"

2016-04-11 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46018/ --- Review request for Ambari, Sumit Mohanty, Jeff Sposetti, and Sid Wagle. Bugs:

Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text from description

2016-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45974/#review128099 --- ambari-server/src/main/resources/alerts.json (line 43)

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review128100 ---

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-11 Thread Myroslav Papirkovskyy
> On Квітень 11, 2016, 3:36 після полудня, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java, > > lines 701-708 > > > > > > This solution is still far

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
> On Апрель 8, 2016, 12:18 п.п., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, lines 117-118 > > > > > > Any reason you chose to use httplib here instead of urllib2? I

Re: Review Request 46018: HDFS script alerts moved to UNKNOWN status with "Unable to calculate the standard deviation for 1 datapoints"

2016-04-11 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46018/#review128095 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 11, 2016,

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-11 Thread Sid Wagle
> On April 11, 2016, 12:36 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java, > > lines 701-708 > > > > > > This solution is still far from ideal.

Re: Review Request 45978: AMBARI-15679: Stack definition for Logsearch

2016-04-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128139 --- Ship it! Ship It! - Robert Nettleton On April 9, 2016,

Re: Review Request 46000: Parallel execution should only be allowed on commands that have auto retry enabled

2016-04-11 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46000/#review128086 --- Ship it! Ship It! - Sandor Magyari On April 11, 2016, 4:27

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar
> On April 11, 2016, 6:27 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 89 > > > > > > status should be

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45972/ --- (Updated April 11, 2016, 6:41 p.m.) Review request for Ambari, Alejandro

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45972/ --- (Updated April 11, 2016, 6:48 p.m.) Review request for Ambari, Alejandro

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-11 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/ --- (Updated April 11, 2016, 6:41 p.m.) Review request for Ambari, Jonathan

Re: Review Request 45832: Add ignore-bad-hosts flag to hawq activate standby custom action

2016-04-11 Thread bhuvnesh chaudhary
> On April 7, 2016, 5:53 a.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py, > > line 59 > > > > > > Would a service restart be required afer bad hosts

Re: Review Request 46046: Not all operations shown on 'Background Operations' window

2016-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46046/#review128218 --- Ship it! So with this change, we're basically removing the

Re: Review Request 46046: Not all operations shown on 'Background Operations' window

2016-04-11 Thread Nate Cole
> On April 11, 2016, 3:33 p.m., Jonathan Hurley wrote: > > So with this change, we're basically removing the ability to get back all > > cluster and host requests in the same query, right? I think that's OK. Correct. We could make the /requests (no cluster) one include the cluster-based

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review128204 ---

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review128212 --- Ship it! Ship It! - Jonathan Hurley On April 11, 2016, 2:41

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45972/#review128206 --- Fix it, then Ship it!

Re: Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode

2016-04-11 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45713/ --- (Updated April 11, 2016, 10:36 a.m.) Review request for Ambari, Zhe (Joe)

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review128183 ---

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45972/ --- (Updated April 11, 2016, 6:22 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46018: HDFS script alerts moved to UNKNOWN status with "Unable to calculate the standard deviation for 1 datapoints"

2016-04-11 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46018/#review128160 --- Ship it! Ship It! - Aravindan Vijayan On April 11, 2016,

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128169 ---

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128171 ---

Re: Review Request 46000: Parallel execution should only be allowed on commands that have auto retry enabled

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46000/#review128196 --- ambari-agent/src/main/python/ambari_agent/ActionQueue.py (line

Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46037/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-11 Thread Masahiro Tanaka
> On April 11, 2016, 4:21 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh, > > line 84 > > > > > > I wonder where this $destdir

Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46037/#review128172 --- Ship it! Ship It! - Dmytro Sen On Апрель 11, 2016, 4:57

Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46037/ --- (Updated April 11, 2016, 6:03 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 45989: Blueprint: Presence/absence of HiveServer2 Interactive component in the template should be validated against related configurations

2016-04-11 Thread Sumit Mohanty
> On April 11, 2016, 5:46 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 40 > > > > > > What's this print for? Secret code :-) Remains of a

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review128233 ---

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45972/ --- (Updated April 11, 2016, 8:24 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46001: Exception seen in ambari-agent during restart.

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46001/#review128240 --- Ship it! Ship It! - Alejandro Fernandez On April 11, 2016,

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-11 Thread Andrii Voloshyn
> On Квітень 11, 2016, 5:51 після полудня, Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py, > > line 47 > > > > > > Does this mean that

Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect validation error shown

2016-04-11 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45990/#review128242 --- Matt - any update on the testing? - Mahadev Konar On April 10,

Review Request 46047: AMBARI-15812 : Changes to widgets to incorporate "rate" function in AMS not done in Upgrade path.

2016-04-11 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46047/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 46046: Not all operations shown on 'Background Operations' window

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46046/#review128236 --- Ship it! Ship It! - Alejandro Fernandez On April 11, 2016,

Re: Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

2016-04-11 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/#review128091 --- Ship it! Ship It! - Sandor Magyari On April 8, 2016, 9:20

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-11 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/ --- (Updated ápr. 11, 2016, 3:51 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-11 Thread Robert Nettleton
> On April 11, 2016, 9:10 p.m., Alejandro Fernandez wrote: > > Hi Alejandro, Thanks for the review comments. Please see my responses below, which ended up in a separate post, rather than a comment reply. Thanks - Robert --- This

Re: Review Request 46000: Parallel execution should only be allowed on commands that have auto retry enabled

2016-04-11 Thread Sumit Mohanty
> On April 11, 2016, 6:32 p.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py, line 163 > > > > > > What was failing because of these multiple threads? Parallel start/stop

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review128244 ---

Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect validation error shown

2016-04-11 Thread Matt
> On April 11, 2016, 1:32 p.m., Mahadev Konar wrote: > > Matt - any update on the testing? I just deployed the new build with my code. The issue has been fixed. I was just about to update the review. - Matt --- This is an

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128252 ---

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Robert Nettleton
> On April 11, 2016, 9:02 p.m., Alejandro Fernandez wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java, > > line 42 > > > > > > Please add some

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128245 ---

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128247 ---

Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect validation error shown

2016-04-11 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45990/ --- (Updated April 11, 2016, 2:17 p.m.) Review request for Ambari, Jaimin Jetly

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-11 Thread Jayush Luniya
> On April 11, 2016, 5:51 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py, > > line 47 > > > > > > Does this mean that on

Review Request 46052: Provide backward compatibility for kdc_host in krb5-conf for krb5.conf templates

2016-04-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46052/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and

Re: Review Request 46047: AMBARI-15812 : Changes to widgets to incorporate "rate" function in AMS not done in Upgrade path.

2016-04-11 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46047/#review128258 --- Ship it! Ship It! - Sid Wagle On April 11, 2016, 9:32 p.m.,

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review128262 --- Ship it! Ship It! - Alejandro Fernandez On April 8, 2016, 6

Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text with more info

2016-04-11 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45974/ --- (Updated April 11, 2016, 9:47 p.m.) Review request for Ambari, Jonathan

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Oliver Szabo
> On April 11, 2016, 9:02 p.m., Alejandro Fernandez wrote: > > pom.xml, line 438 > > > > > > What's the additional build time? I noticed you comments, but i close this now. for the future use:

Review Request 46006: Ambari install failing in RHEL7 while trying to install ATS

2016-04-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46006/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-15798

Review Request 46061: AMBARI-15816: EU/RU - cannot resume upgrade after pausing on a manual task

2016-04-11 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46061/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-15816

Re: Review Request 46000: Parallel execution should only be allowed on commands that have auto retry enabled

2016-04-11 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46000/#review128280 --- Ship it! Ship It! - Mahadev Konar On April 11, 2016, 4:27

Review Request 46062: PXF service check must occur only after PXF is started

2016-04-11 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46062/ --- Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam

Re: Review Request 46062: PXF service check must occur only after PXF is started

2016-04-11 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46062/#review128284 --- Ship it! Ship It! - Matt On April 11, 2016, 4:23 p.m.,

Re: Review Request 46062: PXF service check must occur only after PXF is started

2016-04-11 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46062/#review128285 --- Ship it! Ship It! - Lav Jain On April 11, 2016, 11:23 p.m.,

Re: Review Request 46062: PXF service check must occur only after PXF is started

2016-04-11 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46062/#review128288 --- Ship it! Ship It! - jun aoki On April 11, 2016, 11:23 p.m.,