Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

2016-04-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46137/#review129369 --- ambari-server/src/main/python/ambari_server/serverUpgrade.py

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-18 Thread Jayush Luniya
> On April 18, 2016, 5:33 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py, > > line 137 > > > > > > Add null checks and check reponse

Re: Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode

2016-04-18 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45713/#review129356 --- Ship it! Ship It! - Srimanth Gunturi On April 11, 2016,

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

2016-04-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46137/#review129378 --- Ship it! - Alejandro Fernandez On April 18, 2016, 5:39 p.m.,

Re: Review Request 46310: Use exclude list in order to merge hive-interactve-site from hive-site. Both will show common props in their config bag.

2016-04-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46310/#review129383 --- Ship it! Ship It! - Swapan Shridhar On April 18, 2016, 2:11

Review Request 46338: AMBARI-15949 Tweaks to Alerts hyperlink display

2016-04-18 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46338/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.

Re: Review Request 46332: Upgrade Checks Fail After New Host Is Added To Cluster

2016-04-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46332/#review129361 --- Ship it!

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

2016-04-18 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46137/ --- (Updated April 18, 2016, 10:39 a.m.) Review request for Ambari, Ajit Kumar,

Re: Review Request 46337: Upgrading Ambari should delete any pyc files

2016-04-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46337/#review129379 --- Ship it! Ship It! - Alejandro Fernandez On April 18, 2016,

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-18 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/ --- (Updated April 18, 2016, 4:47 p.m.) Review request for Ambari, Alejandro

Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

2016-04-18 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46137/ --- Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and Sid

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

2016-04-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46137/#review129370 --- ambari-server/src/main/python/ambari_server/serverUpgrade.py

Review Request 46337: Upgrading Ambari should delete any pyc files

2016-04-18 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46337/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15947

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

2016-04-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46137/#review129382 --- Ship it! Ship It! - Sid Wagle On April 18, 2016, 5:39 p.m.,

Re: Review Request 46338: AMBARI-15949 Tweaks to Alerts hyperlink display

2016-04-18 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46338/#review129406 --- Ship it! Ship It! - Richard Zang On April 18, 2016, 6:12

Re: Review Request 46345: HDFS /etc/hadoop/conf Points To Wrong Location After Adding Host

2016-04-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46345/#review129421 ---

Re: Review Request 46263: AMBARI-15906 Make Ranger TagSync to be installed as a slave and optional

2016-04-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46263/#review129410 --- Ship it! Ship It! - Alejandro Fernandez On April 15, 2016,

Re: Review Request 46272: AMBARI-15914 Ranger stack changes to remove audit to db config params

2016-04-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46272/#review129411 --- Ship it! Ship It! - Alejandro Fernandez On April 15, 2016,

Re: Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode

2016-04-18 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45713/ --- (Updated April 18, 2016, 11:48 a.m.) Review request for Ambari, Zhe (Joe)

Re: Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

2016-04-18 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46294/#review129409 --- Ship it! Ship It! - bhuvnesh chaudhary On April 16, 2016,

Re: Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

2016-04-18 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46294/#review129408 --- Ship it! Ship It! - Matt On April 15, 2016, 5:56 p.m., jun

Review Request 46345: HDFS /etc/hadoop/conf Points To Wrong Location After Adding Host

2016-04-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46345/ --- Review request for Ambari, Alejandro Fernandez and Nate Cole. Bugs:

Re: Review Request 46310: Use exclude list in order to merge hive-interactve-site from hive-site. Both will show common props in their config bag.

2016-04-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46310/#review129405 ---

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-18 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review129420 ---

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129418 ---

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
> On April 18, 2016, 8:19 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java, > > line 57 > >

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Jian He
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/ --- (Updated April 18, 2016, 10:20 p.m.) Review request for Ambari, Aravindan

Re: Review Request 46345: HDFS /etc/hadoop/conf Points To Wrong Location After Adding Host

2016-04-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46345/#review129440 --- Ship it! Ship It! - Jayush Luniya On April 18, 2016, 8:13

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Jian He
> On April 18, 2016, 8:19 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java, > > line 280 > > > > > >

Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46351/ --- Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Yusaku Sako.

Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

2016-04-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46355/ --- Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, and

Review Request 46358: Incorporate 'llap status check' to be used for (1). Before Hive Server Interactive start, and (2). status call.

2016-04-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46358/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 46358: Incorporate 'llap status check' to be used for (1). Before Hive Server Interactive start, and (2). status call.

2016-04-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46358/ --- (Updated April 19, 2016, 1:42 a.m.) Review request for Ambari, Alejandro

Re: Review Request 46359: HAWQ Immediate Stop cluster fails with key error

2016-04-18 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46359/#review129469 --- Ship it! Ship It! - Lav Jain On April 19, 2016, 1:20 a.m.,

Review Request 46359: HAWQ Immediate Stop cluster fails with key error

2016-04-18 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46359/ --- Review request for Ambari. Bugs: AMBARI-15960

Review Request 46360: Atlas Integration :Use stack advisor to suggest correct integration related configs

2016-04-18 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46360/ --- Review request for Ambari, John Speidel and Robert Levas. Bugs: AMBARI-15939

Re: Review Request 46342: AMBARI-15952 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129462 --- Thank you for the patch Jian. You can go ahead and close the

Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46351/#review129465 --- Fix it, then Ship it! Fix it and Ship It.

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-18 Thread Balázs Bence Sári
> On April 15, 2016, 1:52 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 181-184 > > > > > > Let's be consistent. Either: > > pk_sc_desired_state > >

Review Request 46317: Basic authentication for Logsearch service

2016-04-18 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46317/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.

Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46327/ --- Review request for Ambari, John Speidel and Sumit Mohanty. Bugs: AMBARI-15791

Re: Review Request 46317: Basic authentication for Logsearch service

2016-04-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46317/#review129324 --- Ship it! Ship It! - Robert Nettleton On April 18, 2016,

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46327/#review129331 --- Could we get some more background context as to why this change

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45924/#review129326 --- Generally for trunk we don't separate tests into different jira.

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46327/#review129329 --- Ship it! Ship It! - Sumit Mohanty On April 18, 2016, 1:07

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46327/#review129328 ---

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Dmytro Sen
> On Апрель 18, 2016, 1:39 п.п., Robert Nettleton wrote: > > Could we get some more background context as to why this change is > > necessary? I've checked the associated Apache JIRA, and there isn't much > > information there. > > > > In particular, can the submitter please explain why this

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Dmytro Sen
> On Апрель 18, 2016, 1:39 п.п., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 858 > > > > > > Why is this

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Dmytro Sen
> On Апрель 18, 2016, 1:39 п.п., Robert Nettleton wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java, > > line 4900 > > > > > > I'm not

Review Request 46334: DB version checker failure: Command line switch --skip-database-validation is broken

2016-04-18 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46334/ --- Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.

Re: Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

2016-04-18 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46294/#review129412 --- Ship it! Ship It! - Alexander Denissov On April 16, 2016,

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-18 Thread Don Bosco Durai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review129415 ---

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129425 ---

Review Request 46363: Kerberos wizard stuck trying to schedule service check operation

2016-04-18 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46363/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, Sumit

Review Request 46353: AMBARI-15957: Ambari functional tests: Support auto start for service components

2016-04-18 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46353/ --- Review request for Ambari, Ajit Kumar, Sumit Mohanty, and Sid Wagle.

Re: Review Request 46172: Pass request object to delete API in resource providers

2016-04-18 Thread Jayush Luniya
> On April 15, 2016, 12:10 a.m., Jayush Luniya wrote: > > Ship It! @Ajit, can you close this review? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46172/#review129039

Re: Review Request 46169: Add dryrun method on request object

2016-04-18 Thread Jayush Luniya
> On April 15, 2016, 12:05 a.m., Jayush Luniya wrote: > > Ship It! @Ajit, can you close this review? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46169/#review129037

Re: Review Request 46363: Kerberos wizard stuck trying to schedule service check operation

2016-04-18 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46363/ --- (Updated April 18, 2016, 11:12 p.m.) Review request for Ambari, Jonathan

Re: Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

2016-04-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46355/#review129475 --- Do you need to also set these new values on upgrade? I see that

Re: Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

2016-04-18 Thread Sid Wagle
> On April 19, 2016, 3:13 a.m., Jonathan Hurley wrote: > > Do you need to also set these new values on upgrade? I see that you put > > defaults in, but the thresholds will never show in existing configurations. Ahh dank missed upgrade, thanks for the reminder, will post updates tomorrow. -

Re: Review Request 46359: HAWQ Immediate Stop cluster fails with key error

2016-04-18 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46359/#review129485 --- Ship it! Ship It! - Alexander Denissov On April 19, 2016,

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-18 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/ --- (Updated April 18, 2016, 10:01 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129445 --- Ship it! Ship It! - Sid Wagle On April 18, 2016, 10:24

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Jian He
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/ --- (Updated April 18, 2016, 10:24 p.m.) Review request for Ambari, Aravindan

Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46351/#review129447 ---

Re: Review Request 46352: Add quick links to the hs2 interactive UI on Ambari

2016-04-18 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46352/#review129449 --- Ship it! Ship It! - Yusaku Sako On April 18, 2016, 11:48

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129444 --- Ship it! Looks good to me. - Aravindan Vijayan On April 18,

Review Request 46352: Add quick links to the hs2 interactive UI on Ambari

2016-04-18 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46352/ --- Review request for Ambari, Srimanth Gunturi and Yusaku Sako. Bugs:

Re: Review Request 46342: AMBARI-15952 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129448 --- Ship it! Ship It! - Aravindan Vijayan On April 18, 2016,

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-18 Thread Balázs Bence Sári
> On April 15, 2016, 1:52 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 181-184 > > > > > > Let's be consistent. Either: > > pk_sc_desired_state > >

Re: Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode

2016-04-18 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45713/#review129352 --- Ship it! Ship It! - Sumit Mohanty On April 11, 2016, 5:36

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Robert Nettleton
> On April 18, 2016, 1:39 p.m., Robert Nettleton wrote: > > Could we get some more background context as to why this change is > > necessary? I've checked the associated Apache JIRA, and there isn't much > > information there. > > > > In particular, can the submitter please explain why this

Re: Review Request 46332: Upgrade Checks Fail After New Host Is Added To Cluster

2016-04-18 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46332/#review129342 --- Ship it! Ship It! - Robert Levas On April 18, 2016, 10:13

Re: Review Request 46196: Logsearch: reading config values from external property files

2016-04-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46196/#review129297 --- Ship it! Ship It! - Jayush Luniya On April 15, 2016, 4:03