Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-04-21 Thread Nahappan Somasundaram
Please use the following document to collaborate: https://docs.google.com/a/hortonworks.com/document/d/1RcAth8M1oEDOjIZ0qMaCAtatCyz6qdLWuEcZLC4Ejbs/edit?disco=Aq7NM04=comment_email_document Thank you. On Thu, Apr 21, 2016 at 7:41 PM -0700, "Ajit Kumar"

Re: Review Request 46500: Regenerating keytabs on re-imaged hosts results in error during 'Creating Principals'

2016-04-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46500/#review129923 --- Ship it! Ship It! - Sid Wagle On April 21, 2016, 5:01 p.m.,

Review Request 46500: Regenerating keytabs on re-imaged hosts results in error during 'Creating Principals'

2016-04-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46500/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, Srimanth

Re: Review Request 46500: Regenerating keytabs on re-imaged hosts results in error during 'Creating Principals'

2016-04-21 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46500/#review129924 --- Ship it! Ship It! - Oliver Szabo On April 21, 2016, 5:01

Re: Review Request 46500: Regenerating keytabs on re-imaged hosts results in error during 'Creating Principals'

2016-04-21 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46500/#review129921 --- Ship it! Ship It! - Srimanth Gunturi On April 21, 2016,

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/#review129926 --- Ship it! Ship It! - Sid Wagle On April 21, 2016, 3:51 p.m.,

Review Request 46508: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics (Patch 2)

2016-04-21 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46508/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 46508: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics (Patch 2)

2016-04-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46508/#review129945 --- Ship it! Ship It! - Sid Wagle On April 21, 2016, 7:10 p.m.,

Review Request 46509: Remove performing service check during "Remove Standby Wizard"

2016-04-21 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46509/ --- Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr

Review Request 46507: Updates LogSearch Integration to obtain LogSearch credential from configuration

2016-04-21 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46507/ --- Review request for Ambari, Oliver Szabo and Sumit Mohanty. Bugs: AMBARI-16021

Re: Review Request 46511: Installer wizard: Starting Services hangs because of LLAP status check.

2016-04-21 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46511/ --- (Updated April 21, 2016, 8 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

2016-04-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review129931 ---

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-21 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45792/ --- (Updated April 21, 2016, 1:23 p.m.) Review request for Ambari, Jaimin Jetly,

Review Request 46513: YARN ATS Should Advertise a Version

2016-04-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46513/ --- Review request for Ambari, Alejandro Fernandez and Nate Cole. Bugs:

Re: Review Request 46460: AMBARI-16002 Integrate Red Hat Satellite option in Ambari Web

2016-04-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46460/#review129960 --- Ship it! Ship It! - Nate Cole On April 20, 2016, 7:32 p.m.,

Re: Review Request 46507: Updates LogSearch Integration to obtain LogSearch credential from configuration

2016-04-21 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46507/#review129965 --- Ship it! Ship It! - Sumit Mohanty On April 21, 2016, 7:11

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

2016-04-21 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46509/#review129946 --- Ship it! Better run unit tests on ambari-web instead of

Re: Review Request 46513: YARN ATS Should Advertise a Version

2016-04-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46513/#review129967 --- Ship it! Ship It! - Alejandro Fernandez On April 21, 2016,

Re: Review Request 46511: Installer wizard: Starting Services hangs because of LLAP status check.

2016-04-21 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46511/ --- (Updated April 21, 2016, 8:28 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46543: After HSI is enabled in install wizard the validation call does not send HSI in the component list of the host_group resulting in validation errors

2016-04-21 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46543/ --- (Updated April 21, 2016, 10:39 p.m.) Review request for Ambari, Srimanth

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-21 Thread Keta Patel
> On April 21, 2016, 3:23 p.m., Di Li wrote: > > ambari-web/app/templates/main/service/widgets/create/step3.hbs, line 24 > > > > > > Why are these styled as warnings? Shouldn't they be errors? Hello Di, I have

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-21 Thread Keta Patel
> On April 21, 2016, 3:23 p.m., Di Li wrote: > > ambari-web/app/templates/main/service/widgets/create/step3.hbs, line 34 > > > > > > Can you restore inline error display instead of the single warning > > display at

Review Request 46543: After HSI is enabled in install wizard the validation call does not send HSI in the component list of the host_group resulting in validation errors

2016-04-21 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46543/ --- Review request for Ambari, Srimanth Gunturi and Yusaku Sako. Bugs:

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

2016-04-21 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46509/ --- (Updated April 21, 2016, 11:01 p.m.) Review request for Ambari, Alexander

Re: Review Request 46507: Updates LogSearch Integration to obtain LogSearch credential from configuration

2016-04-21 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46507/#review129969 --- Ship it! Ship It! - Oliver Szabo On April 21, 2016, 7:11

Re: Review Request 46544: AMBARI-16028: Namenode marked as INITIAL standby could potentially never start if other namenode is down

2016-04-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46544/ --- (Updated April 21, 2016, 10:24 p.m.) Review request for Ambari, Alejandro

Review Request 46544: AMBARI-16028: Namenode marked as INITIAL standby could potentially never start if other namenode is down

2016-04-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46544/ --- Review request for Ambari, Alejandro Fernandez, Robert Nettleton, and Sumit

Re: Review Request 46543: After HSI is enabled in install wizard the validation call does not send HSI in the component list of the host_group resulting in validation errors

2016-04-21 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46543/#review129975 --- Ship it! Ship It! - Yusaku Sako On April 21, 2016, 10:39

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-21 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46475/ --- (Updated April 21, 2016, 10:51 p.m.) Review request for Ambari, Andrii Tkach

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-04-21 Thread Ajit Kumar
> On April 22, 2016, 12:01 a.m., Ajit Kumar wrote: > > Can you explain what from_version and to_version represent here? > > Nahappan Somasundaram wrote: > from_version is the current version; to_version is the version ambari is > moving to. > In case of a clean install, from_version is

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-04-21 Thread Nahappan Somasundaram
> On April 21, 2016, 5:01 p.m., Ajit Kumar wrote: > > Can you explain what from_version and to_version represent here? from_version is the current version; to_version is the version ambari is moving to. In case of a clean install, from_version is 0.0.0.0 - Nahappan

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-04-21 Thread Nahappan Somasundaram
> On April 21, 2016, 5:33 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 822 > > > > > > I want to understand the motivation behind this table first.

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-04-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/#review130009 --- ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-21 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45792/ --- (Updated April 21, 2016, 5:26 p.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-04-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/#review129995 --- ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql

Review Request 46547: [PREVIEW] Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP

2016-04-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46547/ --- Review request for Ambari, Siddharth Seth and Swapan Shridhar. Bugs:

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-04-21 Thread Nahappan Somasundaram
> On April 21, 2016, 5:01 p.m., Ajit Kumar wrote: > > Can you explain what from_version and to_version represent here? > > Nahappan Somasundaram wrote: > from_version is the current version; to_version is the version ambari is > moving to. > In case of a clean install, from_version is

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

2016-04-21 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/ --- (Updated ápr. 21, 2016, 12:36 du) Review request for Ambari, Alejandro

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-21 Thread Alexandr Antonenko
> On April 21, 2016, 11:23 a.m., Alexandr Antonenko wrote: > > ambari-web/app/mixins/wizard/assign_master_components.js, line 978 > > > > > > This check can be simplified, after you added: > >

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

2016-04-21 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/#review129880 --- Ship it! Ship It! - Oliver Szabo On April 21, 2016, 8:33

Re: Review Request 46486: Add logging to check_host.py

2016-04-21 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46486/ --- (Updated April 21, 2016, 11:52 a.m.) Review request for Ambari and Vitalyi

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

2016-04-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/#review129882 --- Fix it, then Ship it!

Re: Review Request 46486: Add logging to check_host.py

2016-04-21 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46486/#review129886 --- Ship it! Ship It! - Vitalyi Brodetskyi On April 21, 2016,

Review Request 46486: Add logging to check_host.py

2016-04-21 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46486/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-16006

Re: Review Request 46487: Add sles 12 as the os family for HDP 2.5.

2016-04-21 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46487/#review129889 --- Ship it! Ship It! - Andrew Onischuk On April 21, 2016, 1:06

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

2016-04-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review129891 ---

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

2016-04-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review129888 ---

Review Request 46490: Update HDFS HA alerts definitions during upgrade

2016-04-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46490/ --- Review request for Ambari, Andrew Onischuk and Sumit Mohanty. Bugs:

Re: Review Request 46448: Restart button took about 5 minutes to appear after a config change for zookeeper

2016-04-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46448/ --- (Updated April 21, 2016, 4:24 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

2016-04-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review129890 ---

Re: Review Request 46490: Update HDFS HA alerts definitions during upgrade

2016-04-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46490/#review129893 --- Ship it! Ship It! - Dmitro Lisnichenko On April 21, 2016,

Review Request 46487: Add sles 12 as the os family for HDP 2.5.

2016-04-21 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46487/ --- Review request for Ambari, Andrew Onischuk and Dmytro Sen. Bugs: AMBARI-16007

Re: Review Request 46016: AMBARI-15752 Ambari support for additional config params for Ranger KMS to support HSM

2016-04-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46016/#review129887 --- Ship it! Ship It! - Jonathan Hurley On April 20, 2016, 7:14

Re: Review Request 46493: ambari-agent.log gets flooded up with exceptions from status commands

2016-04-21 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46493/#review129895 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 21, 2016,

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45924/#review129898 --- Ship it! - Nate Cole On April 18, 2016, 12:22 a.m., Gautam

Re: Review Request 46492: Remove example AMS alert definitions from HDFS/alert.json

2016-04-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46492/#review129894 --- Ship it! Ship It! - Dmitro Lisnichenko On April 21, 2016,

Review Request 46492: Remove example AMS alert definitions from HDFS/alert.json

2016-04-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46492/ --- Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty. Bugs:

Review Request 46493: ambari-agent.log gets flooded up with exceptions from status commands

2016-04-21 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46493/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-16014

Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/ --- Review request for Ambari, Daniel Gergely, Laszlo Puskas, Sandor Magyari, Sumit

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

2016-04-21 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46475/#review129904 --- ambari-web/app/templates/main/service/widgets/create/step3.hbs

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/#review129905 --- Fix it, then Ship it!

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/#review129906 ---

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/#review129907 --- Ship it! Ship It! - Laszlo Puskas On April 21, 2016, 3:19

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/#review129910 --- Ship it! Ship It! - Sandor Magyari On April 21, 2016, 3:19

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/ --- (Updated April 21, 2016, 5:51 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45998: AMBARI-15792: HIVE service_check doesn't work properly

2016-04-21 Thread Andrew Onischuk
> On April 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this? > > Andrew Onischuk wrote: > before we can commit we need an apache jira for this change, and +1 from > Hadoop QA. > > Do you have one? If yes specify its

Re: Review Request 45998: AMBARI-15792: HIVE service_check doesn't work properly

2016-04-21 Thread Masahiro Tanaka
> On 4月 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this? > > Andrew Onischuk wrote: > before we can commit we need an apache jira for this change, and +1 from > Hadoop QA. > > Do you have one? If yes specify its id

Re: Review Request 45998: AMBARI-15792: HIVE service_check doesn't work properly

2016-04-21 Thread Andrew Onischuk
> On April 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this? > > Andrew Onischuk wrote: > before we can commit we need an apache jira for this change, and +1 from > Hadoop QA. > > Do you have one? If yes specify its

Re: Review Request 45998: AMBARI-15792: HIVE service_check doesn't work properly

2016-04-21 Thread Masahiro Tanaka
> On 4月 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this? > > Andrew Onischuk wrote: > before we can commit we need an apache jira for this change, and +1 from > Hadoop QA. > > Do you have one? If yes specify its id

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-21 Thread Akhil PB
> On April 4, 2016, 10:45 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs, > > line 60 > > > > > > Can use bunded conditional

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-21 Thread Andrew Onischuk
> On April 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this? before we can commit we need an apache jira for this change, and +1 from Hadoop QA. Do you have one? If yes specify its id in "Bugs" field here. - Andrew

Review Request 46484: Enhance Health Check for the Cluster before upgrading.

2016-04-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan