Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes

2016-05-05 Thread Ashwin Rajeev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47023/#review131911 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131962 --- Ship it! Ship It! - Jayush Luniya On May 5, 2016, 2:50

Review Request 47038: Re-installation of components when there are no INSTALL_FAILED components returns 500 error

2016-05-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47038/ --- Review request for Ambari, Jonathan Hurley and Jayush Luniya. Bugs:

Re: Review Request 47038: Re-installation of components when there are no INSTALL_FAILED components returns 500 error

2016-05-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47038/#review131959 --- Ship it! Ship It! - Jayush Luniya On May 5, 2016, 7:44

Review Request 47047: AMBARI-16282 Refactor the VDF installer code to handle multi-stack and multi-version scenario

2016-05-05 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47047/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and

Re: Review Request 47044: AMBARI-16280. 'hive.llap.zk.sm.connectionString' config is not set to ZK quorum value on installation of the hive service.

2016-05-05 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47044/#review131954 --- Ship it! Ship It! - Jaimin Jetly On May 5, 2016, 9:56 p.m.,

Re: Review Request 47018: [preview] Ambari Upgrade shouldn't automatically add stack configs

2016-05-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47018/#review131865 --- It feels to me like we should not be touching the stack for this,

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-05 Thread Robert Levas
> On May 5, 2016, 1:10 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, lines > > 1092-1096 > > > > > > This syntax is so painful. Anyway to clean this up? maybe INSERT

Re: Review Request 47034: Alert Targets Should Be Allowed To Be Disabled Without Deleting Them

2016-05-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47034/#review131895 --- Ship it! Ship It! - Nate Cole On May 5, 2016, 2:37 p.m.,

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-05 Thread Robert Levas
> On May 5, 2016, 9:58 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrincipalEntity.java, > > line 46 > > > > > > Seems dangerous; why not just start at

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

2016-05-05 Thread Sebastian Toader
> On May 5, 2016, 6:19 p.m., Sid Wagle wrote: > > Don't the subsequent CG calls need to do an update vs create? Unless we are > > always creating CG with configs and no hosts and then update request with > > hosts. The CG is created when there is a host matched to the host request. While

Re: Review Request 47022: Change default username for Logsearch server to ambari_admin

2016-05-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47022/#review131870 --- Fix it, then Ship it! The patch looks fine to me, just needs a

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/#review131860 --- Ship it!

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

2016-05-05 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47014/#review131871 --- Ship it! Ship It! - Srimanth Gunturi On May 5, 2016, 3:55

Re: Review Request 46999: AMBARI-16261: LogFeeder logs are not showing up in LogSearch

2016-05-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46999/#review131872 --- Ship it! Ship It! - Robert Nettleton On May 5, 2016, 12:49

Re: Review Request 47022: Change default username for Logsearch server to ambar_logsearch_admin

2016-05-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47022/ --- (Updated May 5, 2016, 6:26 p.m.) Review request for Ambari, Robert Nettleton

Re: Review Request 47022: Change default username for Logsearch server to ambari_admin

2016-05-05 Thread Oliver Szabo
> On May 5, 2016, 5:30 p.m., Robert Nettleton wrote: > > The patch looks fine to me, just needs a minor fix listed below. > > > > Regarding the open question, I don't think there is much that can be done > > in the short term on this one. The Ambari Integration code must use a > > separate

Re: Review Request 47022: Change default username for Logsearch server to ambari_admin

2016-05-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47022/ --- (Updated May 5, 2016, 6:18 p.m.) Review request for Ambari, Robert Nettleton

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-05 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 5, 2016, 5:59 p.m.) Review request for Ambari, Di Li and Richard

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-05 Thread Keta Patel
> On May 5, 2016, 12:57 a.m., Richard Zang wrote: > > After applying the patch. > > Created a group "mygroup", assigned role "Cluster User" to this group. > > Created user "aaa", "bbb", "ccc" and assigned all users to "mygroup" > > Changed user "aaa"'s role to Cluster Administrator. (Success) >

Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-05 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore,

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-05 Thread Keta Patel
> On May 5, 2016, 12:57 a.m., Richard Zang wrote: > > After applying the patch. > > Created a group "mygroup", assigned role "Cluster User" to this group. > > Created user "aaa", "bbb", "ccc" and assigned all users to "mygroup" > > Changed user "aaa"'s role to Cluster Administrator. (Success) >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-05 Thread Matt
> On May 4, 2016, 2:37 p.m., Matt wrote: > > We have tested the following changes: > > - The logic for stack_advisor which was pulled into service_advisor works > > well. > > - Inheritance between stacks works well. We tested inheritance from > > common-services into stack 2.3, and then

Re: Review Request 47018: [preview] Ambari Upgrade shouldn't automatically add stack configs

2016-05-05 Thread Sumit Mohanty
> On May 5, 2016, 5:20 p.m., Nate Cole wrote: > > It feels to me like we should not be touching the stack for this, but > > rather use the config-upgrade.xml or the upgrade pack to hold this > > information. Then you can have ADD/DELETE/SKIP isolated in it's own file. > > That logic could

Review Request 47034: Alert Targets Should Be Allowed To Be Disabled Without Deleting Them

2016-05-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47034/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-16277

Re: Review Request 47025: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Admin changes

2016-05-05 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47025/#review131900 ---

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-05 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review131800 --- Ship it! Ship It! - Laszlo Puskas On May 4, 2016, 9:09

Review Request 47006: Storm python tests are brocken

2016-05-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47006/ --- Review request for Ambari, Dmitro Lisnichenko and Dmytro Sen. Bugs:

Re: Review Request 46999: AMBARI-16261: LogFeeder logs are not showing up in LogSearch

2016-05-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46999/#review131804 --- Ship it! Ship It! - Oliver Szabo On May 5, 2016, 12:49

Re: Review Request 47006: Storm python tests are brocken

2016-05-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47006/#review131801 --- Ship it! Ship It! - Dmitro Lisnichenko On May 5, 2016,

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/ --- (Updated May 5, 2016, 12:47 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 47011: Added top navbar on login page.

2016-05-05 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47011/ --- Review request for Ambari, Don Bosco Durai, Jaimin Jetly, Oliver Szabo, and

Review Request 47009: Falcon server start fails

2016-05-05 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47009/ --- Review request for Ambari, Sumit Mohanty and Venkat Ranganathan. Bugs:

Re: Review Request 47011: Added top navbar on login page.

2016-05-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47011/#review131816 --- Ship it! Ship It! - Oliver Szabo On May 5, 2016, 12:46

Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-05 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nate Cole, and

Re: Review Request 46770: Capacity Scheduler View: New UI - queues save integration

2016-05-05 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46770/#review131811 ---

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-05 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/ --- (Updated May 5, 2016, 8:19 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

2016-05-05 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47014/#review131828 --- Fix it, then Ship it!

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-05 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review131829 --- Ship it! Ship It! - Sebastian Toader On May 5, 2016, 3:26

Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

2016-05-05 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47014/ --- Review request for Ambari, Daniel Gergely, Laszlo Puskas, Sandor Magyari,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-05 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated May 5, 2016, 2:50 p.m.) Review request for Ambari, Alexander

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

2016-05-05 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47014/ --- (Updated May 5, 2016, 4:44 p.m.) Review request for Ambari, Daniel Gergely,

Review Request 47020: Coverity Scan Tracking.

2016-05-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47020/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-16273

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-05 Thread Tim Thorpe
> On May 4, 2016, 9:37 p.m., Matt wrote: > > We have tested the following changes: > > - The logic for stack_advisor which was pulled into service_advisor works > > well. > > - Inheritance between stacks works well. We tested inheritance from > > common-services into stack 2.3, and then

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review131818 --- Ship it!

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-05-05 Thread Jonathan Hurley
> On April 28, 2016, 10:50 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, > > lines 36-39 > > > > > > As these are

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/#review131824 ---

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

2016-05-05 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47014/ --- (Updated May 5, 2016, 5:55 p.m.) Review request for Ambari, Daniel Gergely,

Review Request 47022: Change default username for Logsearch server to ambari_admin

2016-05-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47022/ --- Review request for Ambari, Robert Nettleton and Sumit Mohanty. Bugs:

Re: Review Request 47010: Allow roles to be treated like principals in Ambari DB

2016-05-05 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47010/#review131817 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 5, 2016, 12:19

Review Request 47013: Increase retry count for ranger functions

2016-05-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47013/ --- Review request for Ambari, Dmitro Lisnichenko and Dmytro Sen. Bugs:

Re: Review Request 47013: Increase retry count for ranger functions

2016-05-05 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47013/#review131825 --- Ship it! Ship It! - Dmytro Sen On Май 5, 2016, 1:56 п.п.,

Re: Review Request 47013: Increase retry count for ranger functions

2016-05-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47013/#review131826 --- Ship it! Ship It! - Dmitro Lisnichenko On May 5, 2016, 4:56

Re: Review Request 47025: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Admin changes

2016-05-05 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47025/#review131910 ---

Re: Review Request 47022: Change default username for Logsearch server to ambar_logsearch_admin

2016-05-05 Thread Robert Nettleton
> On May 5, 2016, 5:30 p.m., Robert Nettleton wrote: > > The patch looks fine to me, just needs a minor fix listed below. > > > > Regarding the open question, I don't think there is much that can be done > > in the short term on this one. The Ambari Integration code must use a > > separate

Re: Review Request 47038: Re-installation of components when there are no INSTALL_FAILED components returns 500 error

2016-05-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47038/#review131915 --- Fix it, then Ship it! So the web client can correctly handle a

Re: Review Request 47038: Re-installation of components when there are no INSTALL_FAILED components returns 500 error

2016-05-05 Thread Nate Cole
> On May 5, 2016, 4:10 p.m., Jonathan Hurley wrote: > > So the web client can correctly handle a NSRE correctly here? It would be > > nice to have been able to return a 2xx code, like 204. Yes, the UpdateHandler uses exception-catching as logic (ugh) and propagates a NSRE for collection-based

Re: Review Request 47025: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Admin changes

2016-05-05 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47025/#review131908 ---

Re: Review Request 46963: AMBARI-16243: Create ZOOKEEPER service versions in common-services

2016-05-05 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46963/#review131928 --- Ship it! Ship It! - Sumit Mohanty On May 4, 2016, 1:59

Re: Review Request 47048: Show background op window when Interactive query is enabled/disabled

2016-05-05 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47048/#review131975 --- Ship it! Ship It! - Srimanth Gunturi On May 6, 2016, 12:16

Re: Review Request 47048: Show background op window when Interactive query is enabled/disabled

2016-05-05 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47048/ --- (Updated May 6, 2016, 12:16 a.m.) Review request for Ambari and Srimanth

Review Request 47048: Show background op window when Interactive query is enabled/disabled

2016-05-05 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47048/ --- Review request for Ambari and Srimanth Gunturi. Bugs: AMBARI-16269

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

2016-05-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47014/#review131851 --- Don't the subsequent CG calls need to do an update vs create?

Re: Review Request 46973: Amanded handling of excluded config-types handling in case of blueprint deployments

2016-05-05 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46973/ --- (Updated May 5, 2016, 4:20 p.m.) Review request for Ambari, Robert Levas,

Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes

2016-05-05 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47023/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore,

Review Request 47025: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Admin changes

2016-05-05 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47025/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore,

Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-05 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore,