Re: Review Request 47304: Provide default VDF for enabled stacks

2016-05-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47304/#review132900 --- Fix it, then Ship it!

Re: Review Request 47177: Hive view : Upload Table : On unchecking "Is first row header ?" checkbox, the column name should be changed to some default values instead of the first row.

2016-05-12 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47177/#review132903 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 10, 2016, 10:49

Re: Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

2016-05-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47315/#review132908 --- Ship it! Ship It! - Dmytro Sen On Май 12, 2016, 2:07 п.п.,

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

2016-05-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47175/#review132883 --- Ship it! Ship It! - Pallav Kulshreshtha On May 10, 2016,

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

2016-05-12 Thread DIPAYAN BHOWMICK
> On May 12, 2016, 1:59 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Remove the console.logs - DIPAYAN --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47175/#review132901

Re: Review Request 47271: Use consistent names for Log Search service

2016-05-12 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47271/#review132909 --- Ship it! Ship It! - Miklos Gergely On May 12, 2016, 12:28

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review132892 --- Thanks for contributing this patch. I believe that some more

Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

2016-05-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47315/ --- Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sumit Mohanty.

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/ --- (Updated May 12, 2016, 12:58 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 47306: Ambari Admin Privilege required for Pig and Hive View. 403 error received when opening Pig View by a non-admin user

2016-05-12 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47306/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav

Re: Review Request 46661: Put HBase master UI into readonly mode for secure deployment for HDP 2.5

2016-05-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46661/#review132907 ---

Re: Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

2016-05-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47315/ --- (Updated Травень 12, 2016, 2:28 після полудня) Review request for Ambari,

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

2016-05-12 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47175/#review132901 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 12, 2016, 12:51

Re: Review Request 47178: Hive view : Upload Table throws exception when 'stored as' is set to 'INPUTFORMAT'

2016-05-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47178/#review132882 --- Ship it! Ship It! - Pallav Kulshreshtha On May 10, 2016,

Re: Review Request 47178: Hive view : Upload Table throws exception when 'stored as' is set to 'INPUTFORMAT'

2016-05-12 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47178/#review132898 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 10, 2016, 11:05

Re: Review Request 47316: Ambari should delete the ambarismoketest table

2016-05-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47316/#review132912 --- Ship it! Ship It! - Vitalyi Brodetskyi On Травень 12, 2016,

Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock

2016-05-12 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47305/ --- Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Mahadev Konar,

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

2016-05-12 Thread Robert Levas
> On May 12, 2016, 10:40 a.m., Jonathan Hurley wrote: > > ambari-server/docs/api/v1/permission-get.md, line 75 > > > > > > The official label is going to have an abbreviated word in it? Yup.. :| > On May 12, 2016,

Re: Review Request 47134: HAWQ Password handling updated

2016-05-12 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47134/ --- (Updated May 12, 2016, 4:26 p.m.) Review request for Ambari, Alexander

Re: Review Request 47134: HAWQ Password handling updated

2016-05-12 Thread bhuvnesh chaudhary
> On May 12, 2016, 4:43 a.m., Matt wrote: > > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py, line 31 > > > > > > This is not required. Refer comment on the test_hawqsegment.py file. Thanks Matt

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#review132935 --- Ship it! Ship It! - Jayush Luniya On May 12, 2016, 12:41

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-12 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47252/#review132943 --- ambari-web/app/messages.js (line 2659)

Re: Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

2016-05-12 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47315/#review132917 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 12,

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

2016-05-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47237/#review132916 --- Ship it! ambari-server/docs/api/v1/permission-get.md (line

Re: Review Request 47271: Use consistent names for Log Search service

2016-05-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47271/ --- (Updated May 12, 2016, 3:46 p.m.) Review request for Ambari, Don Bosco Durai,

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review132890 --- Ship it! Ship It! - Sebastian Toader On May 12, 2016, 2:58

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

2016-05-12 Thread Robert Levas
> On May 12, 2016, 10:40 a.m., Jonathan Hurley wrote: > > ambari-server/docs/api/v1/permission-get.md, line 75 > > > > > > The official label is going to have an abbreviated word in it? > > Robert Levas wrote: >

Re: Review Request 47271: Use consistent names for Log Search service

2016-05-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47271/#review132922 --- Ship it! Ship It! - Robert Nettleton On May 12, 2016, 12:28

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review132928 ---

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review132915 --- Ship it! Ship It! - Jonathan Hurley On May 12, 2016, 8:58

Re: Review Request 47304: Provide default VDF for enabled stacks

2016-05-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47304/#review132945 --- Ship it! good feature - Dmitro Lisnichenko On May 12, 2016,

Re: Review Request 47009: Falcon server start fails

2016-05-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47009/#review132953 --- Ship it! Ship It! - Sumit Mohanty On May 11, 2016, 8:52

Review Request 47294: Upgrading ambari server fails when trying to create cluster_type column

2016-05-12 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47294/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav

Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco

Re: Review Request 47294: Upgrading ambari server fails when trying to create cluster_type column

2016-05-12 Thread Ashwin Rajeev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47294/#review132847 --- Ship it! Ship It! - Ashwin Rajeev On May 12, 2016, 7:55

Review Request 47290: [Hive view] Break in UI for Query Settings in Firefox

2016-05-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47290/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review132838 --- Fix it, then Ship it!

Re: Review Request 47224: [Hive View] - Save Default Settings should not permit empty parameter values

2016-05-12 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47224/#review132836 ---

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-12 Thread Keta Patel
> On May 10, 2016, 10:28 p.m., Richard Zang wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js, > > line 181 > > > > > > loadUser() needs to be called

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-12 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 12, 2016, 7:57 p.m.) Review request for Ambari, Di Li and Richard

Review Request 47322: AMBARI-16640. jdeb does not preserve permissions for Solr deb package

2016-05-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47322/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-12 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47252/ --- (Updated May 12, 2016, 9:19 p.m.) Review request for Ambari, Alexander

Re: Review Request 47322: AMBARI-16640. jdeb does not preserve permissions for Solr deb package

2016-05-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47322/#review132969 --- Ship it! Ship It! - Robert Nettleton On May 12, 2016, 8:04

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

2016-05-12 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review133026 --- Ship it! Please add unit tests in a new jira asap! - Mahadev

Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes

2016-05-12 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47331/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar,

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

2016-05-12 Thread Gautam Borad
> On May 13, 2016, 4 a.m., Mahadev Konar wrote: > > Please add unit tests in a new jira asap! Thanks Mahadev. Create https://issues.apache.org/jira/browse/AMBARI-16650 for the unit test cases. Thanks. - Gautam --- This is an

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review132862 ---

Re: Review Request 47229: [UI Issue]Execution of empty pig script allowed from UI

2016-05-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47229/ --- (Updated May 12, 2016, 9:32 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47299: Ambari should check if the PID changes after restart, to confirm the process has been restarted

2016-05-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47299/#review132869 --- Ship it! Ship It! - Dmitro Lisnichenko On May 12, 2016,

Re: Review Request 47322: AMBARI-16640. jdeb does not preserve permissions for Solr deb package

2016-05-12 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47322/#review132984 --- Ship it! Ship It! - Miklos Gergely On May 12, 2016, 8:04

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-12 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47252/ --- (Updated May 12, 2016, 9:26 p.m.) Review request for Ambari, Alexander

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-12 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review132985 ---

Re: Review Request 45507: Enhance blueprint support for using references

2016-05-12 Thread Amruta Borkar
> On April 19, 2016, 8:47 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java, > > line 87 > > > > > > If the default top-level

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-12 Thread Goutam Tadi
> On May 12, 2016, 4:51 a.m., Matt wrote: > > Would you like to add tests for this new widget? Added - Goutam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47252/#review132815

Re: Review Request 45507: Enhance blueprint support for using references

2016-05-12 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45507/ --- (Updated May 12, 2016, 9:40 p.m.) Review request for Ambari, Jayush Luniya,

Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

2016-05-12 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47328/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi,

Re: Review Request 47060: AMBARI-16285 Ranger Tagsync stack changes to sync tags from Atlas

2016-05-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47060/#review132998 --- @Mugdha, In your patch for AMBARI-13349 you had add logic in

Review Request 47300: Included few more steps in "Take a tour" feature and few more enhancements

2016-05-12 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47300/ --- Review request for Ambari, Don Bosco Durai, Jaimin Jetly, Oliver Szabo, and

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review132875 --- Ship it! Ship It! - Oliver Szabo On May 12, 2016, 11:31

Re: Review Request 47299: Ambari should check if the PID changes after restart, to confirm the process has been restarted

2016-05-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47299/ --- (Updated May 12, 2016, 11:11 a.m.) Review request for Ambari and Dmitro

Re: Review Request 47299: Ambari should check if the PID changes after restart, to confirm the process has been restarted

2016-05-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47299/#review132871 --- Ship it! Ship It! - Dmitro Lisnichenko On May 12, 2016,

Review Request 47304: Provide default VDF for enabled stacks

2016-05-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47304/ --- Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. Bugs:

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/ --- (Updated May 12, 2016, 11:31 a.m.) Review request for Ambari, Alejandro

Re: Review Request 47297: Extend logging for ActionQueue's retry logic

2016-05-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47297/#review132877 --- Ship it! Ship It! - Sebastian Toader On May 12, 2016, 11:05

Re: Review Request 47297: Extend logging for ActionQueue's retry logic

2016-05-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47297/#review132878 --- Ship it! Ship It! - Oliver Szabo On May 12, 2016, 9:05

Re: Review Request 47226: AMBARI-16444 Solr collection router field is not configurable in solr-client

2016-05-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47226/ --- (Updated May 12, 2016, 12:17 p.m.) Review request for Ambari, Don Bosco Durai,