Re: Review Request 47300: Included few more steps in "Take a tour" feature and few more enhancements

2016-05-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47300/#review133071 --- Ship it! Ship It! - Oliver Szabo On May 12, 2016, 11:06

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review133070 --- Ship it! Ship It! - Robert Levas On May 9, 2016, 5:56 a.m.,

Re: Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes

2016-05-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47331/#review133073 --- Ship it! Ship It! - Andrew Onischuk On May 13, 2016, 9:46

Review Request 47343: DevDeploy: Cannot connect to the server using SSLv3

2016-05-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47343/ --- Review request for Ambari and Robert Levas. Bugs: AMBARI-16658

Review Request 47345: yarn.timeline-service.enabled is set to false in secure cluster

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47345/ --- Review request for Ambari, Oliver Szabo, Sandor Magyari, and Swapan Shridhar.

Re: Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes

2016-05-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47331/#review133077 --- Ship it! Ship It! - Nate Cole On May 13, 2016, 5:46 a.m.,

Re: Review Request 47343: DevDeploy: Cannot connect to the server using SSLv3

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47343/#review133078 --- Ship it! Ship It! - Robert Levas On May 13, 2016, 7:55

Review Request 47342: Error while loading slider view: Unable to initialize Slider view

2016-05-13 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47342/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav

Re: Review Request 47345: yarn.timeline-service.enabled is set to false in secure cluster

2016-05-13 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47345/#review133080 --- Ship it! Ship It! - Sandor Magyari On May 13, 2016, 12:38

Review Request 47344: Log count text on Log level select boxes in Service Logs Tab not getting updated while checking and unchecking

2016-05-13 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47344/ --- Review request for Ambari, Don Bosco Durai, Jaimin Jetly, Oliver Szabo, and

Re: Review Request 47344: Log count text on Log level select boxes in Service Logs Tab not getting updated while checking and unchecking

2016-05-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47344/#review133082 --- Ship it! Ship It! - Oliver Szabo On May 13, 2016, 12:01

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/ --- (Updated May 13, 2016, 6:48 a.m.) Review request for Ambari, Alejandro

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
> On May 12, 2016, 1:35 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java, > > line 56 > >

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
> On May 12, 2016, 3:37 p.m., Sumit Mohanty wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java, > > line 147 > > > > > > Any reason this is being removed?

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

2016-05-13 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46738/ --- (Updated May 13, 2016, 7:09 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47322: AMBARI-16640. jdeb does not preserve permissions for Solr deb package

2016-05-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47322/ --- (Updated May 13, 2016, 1:18 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 47342: Error while loading slider view: Unable to initialize Slider view

2016-05-13 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47342/#review133090 --- Ship it! Ship It! - Nitiraj Rathore On May 13, 2016, 11:57

Re: Review Request 47338: Ambari admin test fails with Error : Unexpected request: GET /api/v1/remoteclusters

2016-05-13 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47338/#review133085 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 13, 2016, 8:43

Re: Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes

2016-05-13 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47331/#review133105 --- Ship it! Ship It! - Srimanth Gunturi On May 13, 2016, 9:46

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Robert Nettleton
> On May 12, 2016, 1:35 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java, > > line 46 > > > > > > This change is problematic, since

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review133099 --- Ship it! Ship It! - Robert Nettleton On May 13, 2016, 6:48

Re: Review Request 47347: Zeppelin View has issues in opening iFrame, when zeppelin view is installed on non-gateway node

2016-05-13 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47347/#review133108 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 13, 2016, 2:22

Re: Review Request 47342: Error while loading slider view: Unable to initialize Slider view

2016-05-13 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47342/#review133089 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 13, 2016, 11:57

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45169/ --- (Updated May 13, 2016, 1:46 p.m.) Review request for Ambari, Alejandro

Re: Review Request 47347: Zeppelin View has issues in opening iFrame, when zeppelin view is installed on non-gateway node

2016-05-13 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47347/#review133107 --- Ship it! Ship It! - Rohit Choudhary On May 13, 2016, 2:22

Re: Review Request 47338: Ambari admin test fails with Error : Unexpected request: GET /api/v1/remoteclusters

2016-05-13 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47338/#review133087 --- Ship it! Ship It! - Nitiraj Rathore On May 13, 2016, 8:43

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47237/ --- (Updated May 13, 2016, 11:04 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-13 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47332/ --- (Updated May 13, 2016, 3:56 p.m.) Review request for Ambari, Alejandro

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

2016-05-13 Thread Robert Levas
> On May 12, 2016, 11:34 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java, > > lines 387-388 > > > > > > Should this be changed to "Cluster Admin" for

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/ --- (Updated May 13, 2016, 11:25 a.m.) Review request for Ambari, Aravindan

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-05-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/#review133132 --- Ship it! Ship It! - Sumit Mohanty On May 13, 2016, 3:25

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Administrator"

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47237/ --- (Updated May 13, 2016, 11:09 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 47321: Ambari to download repo file besides creating it.

2016-05-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47321/#review133112 --- Can you add documentation to all new methods. Also, I'm curious

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47237/ --- (Updated May 13, 2016, 11:07 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/ --- (Updated May 13, 2016, 3:14 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47252/#review133160 --- Ship it! Ship It! - Matt On May 12, 2016, 2:26 p.m., Goutam

Re: Review Request 47350: use schematool from hive2

2016-05-13 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47350/#review133152 --- Ship it! Ship It! - Dmytro Sen On Май 13, 2016, 4:56 п.п.,

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

2016-05-13 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47328/#review133146 ---

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-13 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/ --- (Updated May 13, 2016, 5:29 p.m.) Review request for Ambari, Di Li and Richard

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-13 Thread Keta Patel
> On May 12, 2016, 9:33 p.m., Richard Zang wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js, > > line 189 > > > > > > Please move hard-coded texts like

Review Request 47350: use schematool from hive2

2016-05-13 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47350/ --- Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

2016-05-13 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47328/#review133154 --- Ship it! Ship It! - Alexander Denissov On May 13, 2016,

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

2016-05-13 Thread Matt
> On May 13, 2016, 10:08 a.m., Alexander Denissov wrote: > > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py, line > > 2041 > > > > > > should HAWQ/PXF tests be now moved to separate service

Re: Review Request 47060: AMBARI-16285 Ranger Tagsync stack changes to sync tags from Atlas

2016-05-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47060/#review133167 --- Ship it! Ship It! - Jayush Luniya On May 13, 2016, 10:50

Review Request 47384: Cluster deployment fails when using base stack version

2016-05-13 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47384/ --- Review request for Ambari, Nate Cole, Richard Zang, and Srimanth Gunturi.

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

2016-05-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47377/#review133235 --- You can add the test later but can you add the JIRA ID to the

Review Request 47379: PXF operations considers the agent status

2016-05-13 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47379/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki,

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

2016-05-13 Thread Swapan Shridhar
> On May 14, 2016, 12:20 a.m., Sumit Mohanty wrote: > > You can add the test later but can you add the JIRA ID to the review > > request? > > Sumit Mohanty wrote: > +1. Did not realize that JIRA is inaccessible. Once you have a JIRA > update the review and commit it. Updated JIRA. -

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

2016-05-13 Thread Swapan Shridhar
> On May 14, 2016, 12:19 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 240 > > > > > > We should add an

Re: Review Request 47377: AMBARI-16673. Fix for parsing multiple lines in output while looking for created 'llap package' name.

2016-05-13 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47377/ --- (Updated May 14, 2016, 1:55 a.m.) Review request for Ambari, Jaimin Jetly and

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

2016-05-13 Thread Sumit Mohanty
> On May 14, 2016, 12:20 a.m., Sumit Mohanty wrote: > > You can add the test later but can you add the JIRA ID to the review > > request? +1. Did not realize that JIRA is inaccessible. Once you have a JIRA update the review and commit it. - Sumit

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-13 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/ --- (Updated May 14, 2016, 12:56 a.m.) Review request for Ambari, Alejandro

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-13 Thread Keta Patel
> On May 13, 2016, 10:24 p.m., Richard Zang wrote: > > Ship It! Thank you Richard! Could you please help me push in the changes. - Keta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46270: AMBARI-15917 : Add ability to specify a custom trust store for ranger admin via ambari config

2016-05-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46270/#review133192 --- Ship it! Ship It! - Nate Cole On May 4, 2016, 3:12 a.m.,

Review Request 47369: AMBARI-16666 : AMS Service check fails because collector takes too long to start up.

2016-05-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47369/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-13 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46808/#review133219 --- Ship it! Ship It! - Richard Zang On May 13, 2016, 5:29

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

2016-05-13 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47328/#review133178 --- Ship it! Ship It! - bhuvnesh chaudhary On May 13, 2016,

Review Request 47355: Unable to Deploy Cluster on redhat7 Family OSs

2016-05-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47355/ --- Review request for Ambari, Jayush Luniya and Nate Cole. Bugs: AMBARI-16664

Re: Review Request 47138: stackadvisor uses getHostsForSlaveComponent with wrong parameter name

2016-05-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47138/#review133185 --- Ship it! Ship It! - Jayush Luniya On May 9, 2016, 11:43

Re: Review Request 47355: Unable to Deploy Cluster on redhat7 Family OSs

2016-05-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47355/#review133186 --- Ship it! Ship It! - Jayush Luniya On May 13, 2016, 7:53

Re: Review Request 47355: Unable to Deploy Cluster on redhat7 Family OSs

2016-05-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47355/#review133190 --- Ship it! Ship It! - Nate Cole On May 13, 2016, 3:53 p.m.,

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

2016-05-13 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47175/ --- (Updated May 14, 2016, 5:59 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,