Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-16 Thread Juanjo Marron
> On May 14, 2016, 9:09 a.m., Jayush Luniya wrote: > > Ship It! > > Jayush Luniya wrote: > @Juanjo, > I have committed this to trunk. However, I think we can skip this for > branch-2.4 as it is not required for branch-2.4. Can you update the > fixVersion for the JIRA to Ambari 3.0

Review Request 47417: Replace '*' to hdp version in lzo packages

2016-05-16 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47417/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

2016-05-16 Thread Keta Patel
> On May 13, 2016, 10:24 p.m., Richard Zang wrote: > > Ship It! > > Keta Patel wrote: > Thank you Richard! > Could you please help me push in the changes. Thank you Richard! Committed to Trunk: https://github.com/apache/ambari/commit/e306c393d05ea3d6c28f004a4528f522b5e771cf

Re: Review Request 47417: Replace '*' to hdp version in lzo packages

2016-05-16 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47417/#review133378 ---

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133376 --- Minor code formatting comments.

Re: Review Request 47417: Replace '*' to hdp version in lzo packages

2016-05-16 Thread Andrew Onischuk
> On May 16, 2016, 4:42 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py, > > line 32 > > > > > > I think this should be os-depend. Otherwise

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

2016-05-16 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47175/ --- (Updated May 16, 2016, 2:33 p.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread DIPAYAN BHOWMICK
> On May 16, 2016, 1:58 p.m., DIPAYAN BHOWMICK wrote: > > ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java, > > line 367 > > > > > > Remove these lines Fixit and commit. -

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133352 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 4, 2016, 6:46

Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

2016-05-16 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47421/ --- Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

2016-05-16 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47420/#review133411 --- Ship it! Ship It! - Aravindan Vijayan On May 16, 2016, 6:49

Review Request 47420: Support grafana dashboards to be defined based on stack

2016-05-16 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47420/ --- Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Sumit Mohanty.

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133399 ---

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

2016-05-16 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47421/#review133407 ---

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#review133396 --- Ship it!

Review Request 47422: AMBARI-16688: Ambari users page is not showing type for users

2016-05-16 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47422/ --- Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. Bugs: AMBARI-16688

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

2016-05-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47420/#review133436 ---

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

2016-05-16 Thread Jonathan Hurley
> On May 16, 2016, 4:19 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml, > > line 40 > > > > > > Do we need a safeguard so that any

Review Request 43126: Ambari Upgrade should clean older RCA Database tables

2016-05-16 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/ --- Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

2016-05-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47421/#review133418 --- Ship it! Ship It! - Nate Cole On May 16, 2016, 2:50 p.m.,

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

2016-05-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47421/#review133444 --- Ship it! Ship It! - Jayush Luniya On May 16, 2016, 6:50

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

2016-05-16 Thread Nate Cole
> On May 16, 2016, 2:54 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml, > > line 1184 > > > > > > Wow ... just ... wow ! - Nate

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

2016-05-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/#review133441 --- ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

2016-05-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47421/#review133443 ---

Re: Review Request 47421: Configuration Tasks Are Being Skipped During Upgrade

2016-05-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47421/#review133427 ---

Re: Review Request 47422: AMBARI-16688: Ambari users page is not showing type for users

2016-05-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47422/#review133434 --- Ship it! Ship It! - Zhe (Joe) Wang On May 16, 2016, 7:08

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-16 Thread Alejandro Fernandez
> On May 16, 2016, 10:56 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml, > > line 184 > > > > > > hdp_2_5_0_0_upgrade_storm_1.0 needs to be called

Re: Review Request 47434: Remove unused parameters from hawq-site.xml

2016-05-16 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47434/#review133471 --- Ship it! Ship It! - Alexander Denissov On May 17, 2016,

Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

2016-05-16 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47438/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Srimanth

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

2016-05-16 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47438/ --- (Updated May 17, 2016, 12:51 a.m.) Review request for Ambari, Aravindan

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-16 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/ --- (Updated May 17, 2016, 1:19 a.m.) Review request for Ambari, Alejandro

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-16 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/ --- (Updated May 17, 2016, 12:17 a.m.) Review request for Ambari, Alejandro

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

2016-05-16 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/#review133450 --- What about RCA tables not a part of Ambari DB ? - Sid Wagle On

Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-05-16 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47428/ --- Review request for Ambari and Robert Levas. Bugs: AMBARI-16171

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

2016-05-16 Thread Ajit Kumar
> On May 16, 2016, 9:47 p.m., Sid Wagle wrote: > > What about RCA tables not a part of Ambari DB ? Only postgres-embedded-create.sql has ambarirca db. Users who are facing this issue have stand alone DB server and don't use postgres-embedded. Ideally we should remove ambarirca db from

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-16 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/ --- (Updated May 17, 2016, 12:11 a.m.) Review request for Ambari, Alejandro

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

2016-05-16 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47420/ --- (Updated May 16, 2016, 9:56 p.m.) Review request for Ambari, Aravindan

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-16 Thread Sriharsha Chintalapani
> On May 16, 2016, 10:56 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml, > > line 184 > > > > > > hdp_2_5_0_0_upgrade_storm_1.0 needs to be called

Review Request 47434: Remove unused parameters from hawq-site.xml

2016-05-16 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47434/ --- Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr

Review Request 47427: Atlas Server script error during upgrade.

2016-05-16 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47427/ --- Review request for Ambari, John Speidel and Robert Levas. Bugs: AMBARI-16693

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

2016-05-16 Thread Ajit Kumar
> On May 16, 2016, 9:57 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 337 > > > > > > Are both of these functions case

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

2016-05-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47420/#review133463 --- Ship it! Ship It! - Jayush Luniya On May 16, 2016, 9:56

Re: Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock

2016-05-16 Thread Jonathan Hurley
> On May 13, 2016, 8:34 a.m., Jonathan Hurley wrote: > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java, > > lines 87-89 > > > > > > Double-checked locking here; you'll need to make

Re: Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock

2016-05-16 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47305/#review133347 --- Ship it! Ship It! - Rohit Choudhary On May 12, 2016, 2:04

Re: Review Request 47124: Hive View : Upload Table- Error on uploading csv with 1 row

2016-05-16 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47124/#review133348 --- Ship it! Ship It! - Pallav Kulshreshtha On May 14, 2016,

Re: Review Request 47350: use schematool from hive2

2016-05-16 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47350/#review133349 --- Ship it! Ship It! - Andrew Onischuk On May 16, 2016, 12:18

Re: Review Request 47405: Sticky bit keeps getting changed back to 777 after restart causing security checks to fail

2016-05-16 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47405/#review133350 --- Ship it! Ship It! - Vitalyi Brodetskyi On May 16, 2016,

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

2016-05-16 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47438/#review133478 --- Just realized I am missing UpgradeCatalog changes, will add

Re: Review Request 47288: AMBARI-16225. Storm Ambari view should work with Firefox 25

2016-05-16 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47288/ --- (Updated May 17, 2016, 5:51 a.m.) Review request for Ambari and Srimanth

Re: Review Request 47306: Ambari Admin Privilege required for Pig and Hive View. 403 error received when opening Pig View by a non-admin user

2016-05-16 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47306/#review133340 --- Ship it! Ship It! - Nitiraj Rathore On May 12, 2016, 1:29

Re: Review Request 47235: Takeover script configs results in conflict message that look wrong

2016-05-16 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47235/ --- (Updated May 16, 2016, 9:19 a.m.) Review request for Ambari, Srimanth Gunturi

Re: Review Request 47350: use schematool from hive2

2016-05-16 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47350/ --- (Updated Травень 16, 2016, 12:18 після полудня) Review request for Ambari,

Re: Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock

2016-05-16 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47305/#review133346 --- Ship it! Ship It! - Jonathan Hurley On May 12, 2016, 10:04