Re: Review Request 48135: Ambari-server fails to start after reboot on Ubuntu

2016-06-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48135/#review135810 --- Ship it! Ship It! - Dmitro Lisnichenko On June 1, 2016,

Re: Review Request 47963: clean up import * for YARN service

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47963/#review135820 ---

Review Request 48136: AMBARI-16973 Print out configType has malformed json text as part of the ambari server startup error handling

2016-06-01 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48136/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-16973

Re: Review Request 48121: YARN default configs are invalid

2016-06-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48121/#review135809 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 1, 2016,

Re: Review Request 47964: clean up import * for ZOOKEEPER service

2016-06-01 Thread Juanjo Marron
> On June 1, 2016, 3:07 a.m., Jayush Luniya wrote: > > Ship It! Thanks for the reviews and fo commitying to trunk - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47964/#review135757

Re: Review Request 48091: Update derivation of hawq_rm_memory_limit_perseg

2016-06-01 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48091/#review135814 --- Ship it! Ship It! - Lav Jain On May 31, 2016, 8:31 p.m.,

Review Request 48135: Ambari-server fails to start after reboot on Ubuntu

2016-06-01 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48135/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-16989

Re: Review Request 48105: AMBARI-16977 VDF: couple UI bugs in Install Wiz

2016-06-01 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48105/#review135816 --- Ship it! Ship It! - Jaimin Jetly On June 1, 2016, 12:54

Re: Review Request 48135: Ambari-server fails to start after reboot on Ubuntu

2016-06-01 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48135/ --- (Updated June 1, 2016, 4:45 p.m.) Review request for Ambari and Dmitro

Re: Review Request 47705: AMBARI-16731 Should close file object in security.py

2016-06-01 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47705/#review135888 --- Could anyone review this? I think this isn't a difficult patch.

Re: Review Request 48125: AMBARI-16984 Add changes for Ranger Service to get previous_jdbc_jar_name

2016-06-01 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48125/#review135889 ---

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48157/ --- (Updated June 2, 2016, 1:25 a.m.) Review request for Ambari, Alejandro

Re: Review Request 48143: Missing import check_process_status for YARN nodemanager service

2016-06-01 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48143/ --- (Updated June 1, 2016, 6:26 p.m.) Review request for Ambari and Jayush Luniya.

Re: Review Request 48036: Service name shown instead of Host name on popup

2016-06-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48036/#review135840 --- Ship it! Ship It! - Nate Cole On June 1, 2016, 12:01 p.m.,

Re: Review Request 48147: Fix metric sink + rename misnamed zk-connect-string variables.

2016-06-01 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48147/ --- (Updated June 1, 2016, 6:57 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 48139: Required empty config is present after Upgrade from 2.1.2.1 to 2.4.0.0 for HIVE and HBASE

2016-06-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48139/#review135828 --- Ship it! Ship It! - Dmytro Sen On Июнь 1, 2016, 6:06 п.п.,

Review Request 48143: Missing import check_process_status for HDFS nodemanager service

2016-06-01 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48143/ --- Review request for Ambari and Jayush Luniya. Bugs: AMBARI-16849

Review Request 48147: Fix metric sink

2016-06-01 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48147/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 48122: History tab takes long to populate when there is more entry in history table.

2016-06-01 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48122/#review135825 --- Ship it! Ship It! - Rohit Choudhary On June 1, 2016, 1:53

Re: Review Request 47586: Log Feeder Global exclusion default filter configuration is not effective in the log search indexing.

2016-06-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47586/#review135836 --- Ship it! Ship It! - Robert Nettleton On June 1, 2016, 6:20

Re: Review Request 47963: clean up import * for YARN service

2016-06-01 Thread Juanjo Marron
> On June 1, 2016, 5:49 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py, > > line 91 > > > > > > @Juanjo, it looks like

Re: Review Request 47963: clean up import * for YARN service

2016-06-01 Thread Juanjo Marron
> On June 1, 2016, 5:49 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py, > > line 91 > > > > > > @Juanjo, it looks like

Review Request 48139: Required empty config is present after Upgrade from 2.1.2.1 to 2.4.0.0 for HIVE and HBASE

2016-06-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48139/ --- Review request for Ambari, Dmytro Sen, Sandor Magyari, and Sumit Mohanty.

Review Request 48154: Incorrect ports in WebHDFS HA config in Knox

2016-06-01 Thread Sumit Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48154/ --- Review request for Ambari, Alejandro Fernandez and Dmytro Sen. Bugs:

Re: Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

2016-06-01 Thread Qin Liu
> On May 26, 2016, 3:11 p.m., Dmytro Sen wrote: > > Ship It! > > Qin Liu wrote: > Thank you so much Dmytro! Hi Sid, Could you please review the patch at your earliest convenience? Thank you in advance! - Qin --- This is an

Re: Review Request 48143: Missing import check_process_status for YARN nodemanager service

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48143/#review135851 --- Ship it! Ship It! - Jayush Luniya On June 1, 2016, 6:26

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

2016-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47880/#review135852 --- Ship it! Ship It! - Alejandro Fernandez On May 30, 2016,

Re: Review Request 48134: Remove logsearch-solr-client dependency from Atlas

2016-06-01 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48134/#review135849 --- Ship it! Looks good to me. Thanks for doing that! - Tom

Re: Review Request 47858: Cache service advisors when stack advisor is loaded

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135854 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 7:11

Re: Review Request 48073: Exception while detecting JMX protocol for HISTORYSERVER

2016-06-01 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48073/ --- (Updated June 1, 2016, 4:26 p.m.) Review request for Ambari and Vitalyi

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Jaimin Jetly
> On June 1, 2016, 9:40 p.m., Zhe (Joe) Wang wrote: > > ambari-web/app/controllers/wizard/step7/assign_master_controller.js, line > > 161 > > > > > > Typo? This is intended change to address scenario 1 stated in

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Jaimin Jetly
> On June 1, 2016, 9:41 p.m., Zhe (Joe) Wang wrote: > > ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js, > > line 152 > > > > > > Typo? unit test change needed to accomodate the change

Re: Review Request 48123: Update default ambari view read timeout to a larger value

2016-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48123/#review135878 --- Ship it! Ship It! - Alejandro Fernandez On June 1, 2016,

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Jaimin Jetly
> On June 1, 2016, 9:40 p.m., Zhe (Joe) Wang wrote: > > ambari-web/app/controllers/wizard/step7/assign_master_controller.js, line > > 161 > > > > > > Typo? > > Jaimin Jetly wrote: > This is intended change to

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48156/#review135880 --- Ship it! Ship It! - Zhe (Joe) Wang On June 1, 2016, 9:36

Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48157/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and

Re: Review Request 48147: Fix metric sink + rename misnamed zk-connect-string variables.

2016-06-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48147/#review135877 --- Ship it! Ship It! - Oliver Szabo On June 1, 2016, 7 p.m.,

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-01 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/ --- (Updated June 1, 2016, 11:06 p.m.) Review request for Ambari, Alejandro

Review Request 48155: Recommend hawq_rm_nvcore_limit_perseg in HAWQ service advisor

2016-06-01 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48155/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-06-01 Thread Juanjo Marron
> On June 1, 2016, 2:33 a.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly. Can you rebase the patch and resolve conflicts? New patch submitted to https://issues.apache.org/jira/browse/AMBARI-16672. Waiting for HAdoop QA review - Juanjo

Re: Review Request 48154: Incorrect ports in WebHDFS HA config in Knox

2016-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48154/#review135860 --- Fix it, then Ship it!

Re: Review Request 48155: Recommend hawq_rm_nvcore_limit_perseg in HAWQ service advisor

2016-06-01 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48155/#review135863 --- Ship it! Ship It! - bhuvnesh chaudhary On June 1, 2016,

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48156/#review135868 ---

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-06-01 Thread Juanjo Marron
> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly. Can you rebase the patch? Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797. Waiting for Hadoop QA review - Juanjo --- This is an

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48156/#review135867 ---

Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48156/ --- Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-06-01 Thread Juanjo Marron
> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly. Can you rebase the patch? > > Juanjo Marron wrote: > Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797. > Waiting for Hadoop QA review Patch applied cleanly by Hadoop QA Hadoop QA

Re: Review Request 48134: Remove logsearch-solr-client dependency from Atlas

2016-06-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48134/ --- (Updated June 2, 2016, 12:13 a.m.) Review request for Ambari, Robert

Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-01 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48162/ --- Review request for Ambari and Robert Levas. Bugs: AMBARI-16171

Re: Review Request 47586: Log Feeder Global exclusion default filter configuration is not effective in the log search indexing.

2016-06-01 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47586/ --- (Updated June 2, 2016, 5:42 a.m.) Review request for Ambari, Alejandro

Review Request 47586: Log Feeder Global exclusion default filter configuration is not effective in the log search indexing.

2016-06-01 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47586/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco

Review Request 48121: YARN default configs are invalid

2016-06-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48121/ --- Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi. Bugs:

Review Request 48124: Host checkboxes getting unselected when user clicks on search host button and few minor issues

2016-06-01 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48124/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco

Review Request 48122: History tab takes long to populate when there is more entry in history table.

2016-06-01 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48122/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Review Request 48119: View Instance: Data Migration

2016-06-01 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48119/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 47978: VDF should use package-version for the os, not the release

2016-06-01 Thread Jonathan Hurley
> On June 1, 2016, 9:03 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java, > > lines 113-114 > > > > > > m_ Ugh - didn't mean to make

Re: Review Request 48121: YARN default configs are invalid

2016-06-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48121/ --- (Updated Июнь 1, 2016, 1:16 п.п.) Review request for Ambari, Andrew Onischuk

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-06-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47428/#review135792 --- Ship it! Ship It! - Nate Cole On May 27, 2016, 6:48 p.m.,

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-06-01 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47428/#review135794 --- Ship it! Ship It! - Robert Levas On May 27, 2016, 6:48

Re: Review Request 47978: VDF should use package-version for the os, not the release

2016-06-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47978/#review135789 --- Fix it, then Ship it!

Re: Review Request 48124: Host checkboxes getting unselected when user clicks on search host button and few minor issues

2016-06-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48124/#review135793 --- Ship it! Ship It! - Oliver Szabo On June 1, 2016, 12:13

Re: Review Request 48063: Redundant info under config tab for falcon

2016-06-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48063/#review135796 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 1, 2016,

Re: Review Request 47586: Log Feeder Global exclusion default filter configuration is not effective in the log search indexing.

2016-06-01 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47586/#review135797 --- Ship it! Ship It! - Miklos Gergely On June 1, 2016, 6:20