Re: Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

2016-06-07 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48065/#review136413 --- Ship it! - Sid Wagle On June 3, 2016, 12:43 a.m., Jungtaek

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-07 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 7, 2016, 7:47 de) Review request for Ambari, Laszlo Puskas,

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-07 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/ --- (Updated June 7, 2016, 6:16 a.m.) Review request for Ambari, Jayush Luniya and

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-07 Thread Sid Wagle
> On June 7, 2016, 6:07 a.m., Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine

Review Request 48319: Hive View : Upload Table : Support for Date and Timestamp type detection according to hive specs

2016-06-07 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48319/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/#review136439 ---

Re: Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin

2016-06-07 Thread Gautam Borad
> On June 6, 2016, 5:09 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py, > > lines 74-78 > > > > > > You're uploading things to

Review Request 48334: takeover_config_merge.py should provide XML, yaml, properties-diff capability

2016-06-07 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48334/ --- Review request for Ambari and Sid Wagle. Bugs: AMBARI-17087

Re: Review Request 48325: Unit tests failing because of the order of hash sets/maps

2016-06-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48325/#review136445 ---

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 7, 2016, 8:17 a.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48321/#review136443 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 7, 2016,

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 7, 2016, 9:18 a.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Andrew Onischuk
> On June 7, 2016, 8:53 a.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, > > line 130 > > > > > > I don't think we have ts in sudo permissions.

Review Request 48332: Log search capability for Nifi

2016-06-07 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48332/ --- Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-07 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136446 --- Wouldn't better to fire these events only on component state

Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48321/ --- Review request for Ambari, Andrew Onischuk, Robert Nettleton, and Vitalyi

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 7, 2016, 8:02 a.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Andrew Onischuk
> On June 7, 2016, 8:53 a.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, > > line 130 > > > > > > I don't think we have ts in sudo permissions.

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 7, 2016, 8:03 a.m.) Review request for Ambari, Andrew Onischuk,

Review Request 48330: Hive View : Error in persisting JobImpl while submitting Hive Job

2016-06-07 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48330/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 48350: Atlas Integration : Ambari overwrites users-credentials.properties and policy-store.txt

2016-06-07 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48350/#review136519 --- Ship it! Ship It! - Robert Levas On June 7, 2016, 12:33

Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17051

Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/ --- (Updated June 7, 2016, 2:13 p.m.) Review request for Ambari and Alejandro

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-07 Thread Jungtaek Lim
> On 6 7, 2016, 6:07 오전, Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine grained?

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/#review136568 ---

Re: Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

2016-06-07 Thread Jungtaek Lim
> On 6 7, 2016, 3:07 오후, Aravindan Vijayan wrote: > > Has this been checked in? If you need help doing that, I can do that for > > you. No it's not checked in yet. Please check this in. Thanks! - Jungtaek --- This is an automatically

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-07 Thread Jeff Zhang
> On June 8, 2016, 1:08 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py, > > line 63 > > > > > > Why replace_existing_files=True? >

Re: Review Request 48379: EU - HDP 2.4 to 2.5 fails restarting DRPC server on a kerberized cluster, need to use org.apache.storm.security.auth.KerberosPrincipalToLocal

2016-06-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48379/ --- (Updated June 7, 2016, 11:58 p.m.) Review request for Ambari and Sriharsha

Review Request 48361: VDF: install wizard "Select Version" UI issues

2016-06-07 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48361/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.

Re: Review Request 48361: VDF: install wizard "Select Version" UI issues

2016-06-07 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48361/#review136541 --- Ship it! Ship It! - Zhe (Joe) Wang On June 7, 2016, 9:08

Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/ --- (Updated June 7, 2016, 2 p.m.) Review request for Ambari and Alejandro

Re: Review Request 48147: Fix metric sink + rename misnamed zk-connect-string variables.

2016-06-07 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48147/#review136591 --- Ship it! AbstractTimelineMetricsSink changes look good with no

Review Request 48379: EU - HDP 2.4 to 2.5 fails restarting DRPC server on a kerberized cluster, need to use org.apache.storm.security.auth.KerberosPrincipalToLocal

2016-06-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48379/ --- Review request for Ambari and Sriharsha Chintalapani. Bugs: AMBARI-17100

Re: Review Request 48379: EU - HDP 2.4 to 2.5 fails restarting DRPC server on a kerberized cluster, need to use org.apache.storm.security.auth.KerberosPrincipalToLocal

2016-06-07 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48379/#review136560 --- Ship it! Ship It! - Sriharsha Chintalapani On June 7, 2016,

Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/#review136554 --- Ship it! Ship It! - Alejandro Fernandez On June 7, 2016,

Review Request 48382: AMBARI-17101 Select Stack Page : "Next" button disabled for blank repo fields

2016-06-07 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48382/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang,

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-07 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48284/ --- (Updated June 7, 2016, 11:47 a.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 7, 2016, 12:14 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Dharmesh Makwana
> On June 7, 2016, 1:15 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java, > > line 38 > > > > > > It looks like all these properties

Review Request 48335: Zeppelin service: Update default zeppelin_pid_dir to /var/run/zeppelin

2016-06-07 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48335/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush

Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48321/#review136457 --- Fix it, then Ship it! Thanks for providing this patch. I do

Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48338/ --- (Updated June 7, 2016, 1:25 p.m.) Review request for Ambari, Alejandro

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-07 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48284/#review136452 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 7, 2016,

Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Robert Nettleton
> On June 7, 2016, 1:15 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java, > > line 38 > > > > > > It looks like all these properties

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/ --- (Updated June 7, 2016, 12:15 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48284/#review136466 --- Ship it!

Re: Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

2016-06-07 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48065/#review136468 --- Ship it! Has this been checked in? If you need help doing

Re: Review Request 48292: VDF: exception when trying to register -> add versions

2016-06-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48292/#review136465 --- Ship it! Ship It! - Jonathan Hurley On June 6, 2016, 5:34

Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48321/#review136481 --- Ship it! LGTM - Aravindan Vijayan On June 7, 2016, 2:25

Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder on a newly installed cluster with log search

2016-06-07 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48348/ --- Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton,

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-07 Thread Sriharsha Chintalapani
> On June 7, 2016, 6:07 a.m., Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine

Re: Review Request 48096: AMBARI-16935: Retry and recover from component install failures

2016-06-07 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48096/ --- (Updated June 7, 2016, 8:51 a.m.) Review request for Ambari, Ajit Kumar,

Re: Review Request 48332: Log search capability for Nifi

2016-06-07 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48332/#review136499 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 10:05

Re: Review Request 48279: Visual explain unit tests

2016-06-07 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48279/#review136500 --- Ship it! Ship It! - Nitiraj Rathore On June 6, 2016, 2:24

Re: Review Request 48306: AMBARI-17077 - Unable to change user role in list view

2016-06-07 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48306/#review136498 --- Ship it! Ship It! - Zhe (Joe) Wang On June 7, 2016, 2:29

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-07 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136492 --- Ship it! Ship It! - Matt On June 7, 2016, 9:09 a.m., Juanjo

Re: Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin

2016-06-07 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48273/#review136503 --- Ship it! Ship It! - Jonathan Hurley On June 6, 2016, 11:26

Re: Review Request 47746: Update Moment.js to latest stable version 2.13.0

2016-06-07 Thread Sangeeta Ravindran
> On June 7, 2016, 5:44 p.m., Di Li wrote: > > Ship It! Thank you Di! - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47746/#review136501

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136516 --- Ship it! Ship It! - Alejandro Fernandez On June 7, 2016,

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/#review136517 ---

Re: Review Request 47746: Update Moment.js to latest stable version 2.13.0

2016-06-07 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47746/#review136501 --- Ship it! Ship It! - Di Li On June 7, 2016, 5:23 p.m.,

Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-07 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48289/#review136512 --- Ship it! Ship It! - Richard Zang On June 6, 2016, 6:22