Re: Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh

2016-06-15 Thread Jayush Luniya
> On June 10, 2016, 9:35 p.m., Jayush Luniya wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! Could you commit this ? Committed, thanks for your contribution. Can you close the review? - Jayush --- This is an

Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-15 Thread Victor Galgo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48734/ --- Review request for Ambari, Andriy Babiichuk, Alexandr Antonenko, Andrew

Re: Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/#review137754 --- Ship it! Ship It! - Sebastian Toader On June 15, 2016, 5:04

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
> On June 15, 2016, 5:54 p.m., Andrew Onischuk wrote: > > ambari-agent/src/main/python/ambari_agent/Controller.py, line 281 > > > > > > Do we really want to do this only if there are tasks pending. > > > >

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137750 --- ambari-agent/src/main/python/ambari_agent/Controller.py (line

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137751 --- Ship it! Ship It! - Sandor Magyari On June 15, 2016, 2:55

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137749 ---

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137752 --- Also is there any benchmarks if this really increases the deploy

Re: Review Request 48659: Fix Spark2 thriftserver Ambari definition bug

2016-06-15 Thread Jayush Luniya
> On June 15, 2016, 4:40 p.m., Jayush Luniya wrote: > > Ship It! Committed patch. Please close CR - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48659/#review137762

Re: Review Request 48706: 'ambari-server --version' command does not show build number

2016-06-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48706/#review137696 --- Ship it! Ship It! - Dmitro Lisnichenko On June 15, 2016,

Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/#review137705 --- Ship it! The patch looks good to me. Also I think it worth

Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Robert Levas, Sandor

Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed

2016-06-15 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/ --- (Updated jún. 15, 2016, 8:50 de) Review request for Ambari, Oliver Szabo,

Re: Review Request 48708: Namenode start step failed during EU with RetriableException

2016-06-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48708/#review137699 --- Ship it! Ship It! - Dmitro Lisnichenko On June 15, 2016,

Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search

2016-06-15 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/#review137708 --- Ship it! Ship It! - Daniel Gergely On jún. 15, 2016, 9:24

Re: Review Request 48706: 'ambari-server --version' command does not show build number

2016-06-15 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48706/ --- (Updated Червень 15, 2016, 8:43 до полудня) Review request for Ambari, Dmitro

Re: Review Request 48706: 'ambari-server --version' command does not show build number

2016-06-15 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48706/#review137693 --- Ship it! Ship It! - Dmytro Sen On Июнь 15, 2016, 8:43 д.п.,

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137713 --- Ship it! Ship It! - Sebastian Toader On June 15, 2016, 1:33

Review Request 48725: Supervisor start failed after Ambari upgrade (intermittent)

2016-06-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48725/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-17252

Re: Review Request 48725: Supervisor start failed after Ambari upgrade (intermittent)

2016-06-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48725/#review137719 --- Ship it! Ship It! - Dmitro Lisnichenko On June 15, 2016,

Review Request 48726: AMBARI-17250 : Use right principals for Hbase Master in Kerberos enabled Ranger Hbase Plugin

2016-06-15 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48726/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Srimanth

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-15 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48549/ --- (Updated June 15, 2016, 12:41 p.m.) Review request for Ambari, Gautam Borad,

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review137714 --- Ship it! Ship It! - Sebastian Toader On June 14, 2016, 3:45

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review137716 ---

Review Request 48727: Log Search default log levels can not be altered

2016-06-15 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48727/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 15, 2016, 11:33 de) Review request for Ambari, Laszlo Puskas,

Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/#review137710 --- Ship it! Ship It! - Sebastian Toader On June 15, 2016, 1:41

Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed

2016-06-15 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/ --- (Updated jún. 15, 2016, 11:41 de) Review request for Ambari, Oliver Szabo,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137717 --- Ship it! Ship It! - Robert Levas On June 15, 2016, 5:46

Re: Review Request 48702: Add ability to set GET request directives

2016-06-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137720 --- Ship it! Ship It! - Nate Cole On June 14, 2016, 7:12 p.m.,

Re: Review Request 48726: AMBARI-17247 : Populate audit to solr / hdfs properties for Atlas

2016-06-15 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48726/ --- (Updated June 15, 2016, 12:42 p.m.) Review request for Ambari, Alejandro

Re: Review Request 48702: Add ability to set GET request directives

2016-06-15 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137721 --- Ship it! Ship It! - Di Li On June 14, 2016, 11:12 p.m.,

Re: Review Request 48730: AMBARI-17250 : Use right principals for Hbase Master in Kerberos enabled Ranger Hbase Plugin

2016-06-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48730/#review137741 --- Ship it! Ship It! - Jonathan Hurley On June 15, 2016, 10:26

Re: Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments

2016-06-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/#review137745 --- Ship it! - Robert Nettleton On June 15, 2016, 3:04 p.m.,

Re: Review Request 48727: Log Search default log levels can not be altered

2016-06-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48727/#review137746 --- Ship it! Ship It! - Robert Nettleton On June 15, 2016,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- (Updated June 15, 2016, 4:55 p.m.) Review request for Ambari, Andrew Onischuk,

Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments

2016-06-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/ --- Review request for Ambari, Robert Nettleton, Sandor Magyari, and Sebastian

Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-15 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48729/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137729 --- Ship it! Ship It! - Sandor Magyari On June 15, 2016, 11:33

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-15 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/ --- (Updated June 15, 2016, 2:08 p.m.) Review request for Ambari, Alexander

Re: Review Request 48685: AMBARI-17218 Show message of Audit to DB Removal during upgrade for Ranger

2016-06-15 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48685/ --- (Updated June 15, 2016, 2:18 p.m.) Review request for Ambari, Gautam Borad,

Re: Review Request 48685: AMBARI-17218 Show message of Audit to DB Removal during upgrade for Ranger

2016-06-15 Thread Mugdha Varadkar
> On June 15, 2016, 1:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java, > > line 85 > > > > > > Let's bump this up to something like 100.0f for

Review Request 48731: Yarn service check fails after Ambari upgrade from 2.0.2 to 2.4.0.0

2016-06-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48731/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-17256

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48651/#review137765 --- Can you rebase patch to latest in trunk and submit the patch git

Re: Review Request 47858: Cache service advisors when stack advisor is loaded

2016-06-15 Thread Jayush Luniya
> On June 1, 2016, 8:55 p.m., Jayush Luniya wrote: > > Ship It! Lav, can you close the review if the patch is already committed? - Jayush --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 48636: Zeppelin Views are not working with Custom and Remote cluster view configuration

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48636/#review137769 --- contrib/views/zeppelin/src/main/resources/view.xml (line 35)

Re: Review Request 48335: Zeppelin service: Update default zeppelin_pid_dir to /var/run/zeppelin

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48335/#review137770 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 11:45

Re: Review Request 48735: Storm service check failed after Ambari upgrade

2016-06-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48735/#review137773 ---

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-15 Thread Saisai Shao
> On June 15, 2016, 4:47 p.m., Jayush Luniya wrote: > > Can you rebase patch to latest in trunk and submit the patch > > > > git apply ~/Downloads/AMBARI-16864.patch > > /Users/jluniya/Downloads/AMBARI-16864.patch:1114: trailing whitespace. > > "spark-javaopts-properties": {}, > >

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48308/#review137771 --- Ship it! Ship It! - Jayush Luniya On June 14, 2016, 4:10

Review Request 48735: Storm service check failed after Ambari upgrade

2016-06-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48735/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-17258

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-15 Thread Saisai Shao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48651/ --- (Updated June 15, 2016, 5:03 p.m.) Review request for Ambari and Jayush

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sumit Mohanty
> On June 15, 2016, 3:54 p.m., Andrew Onischuk wrote: > > ambari-agent/src/main/python/ambari_agent/Controller.py, line 281 > > > > > > Do we really want to do this only if there are tasks pending. > > > >

Review Request 48741: LogSearch Solr kerberos support

2016-06-15 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/ --- Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Levas,

Review Request 48739: Remove CascadeType in ServiceComponentHistoryEntity for ServiceComponentDesiredStateEntity

2016-06-15 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48739/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Gupta. Bugs:

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-15 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48609/ --- (Updated June 15, 2016, 10:51 a.m.) Review request for Ambari. Changes

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-15 Thread Jayush Luniya
> On June 15, 2016, 5:51 p.m., Jayush Luniya wrote: > > Ship It! For 2.4 and trunk, we should not have any hdp-select and hdp hardcodings. Everything should be stack config driven. - Jayush --- This is an automatically generated

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-15 Thread Venkat Ranganathan
> On June 13, 2016, 1:54 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml, > > line 28 > > > > > > Based on the latest

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/ --- (Updated Июнь 15, 2016, 1:30 п.п.) Review request for Ambari, Robert

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review137731 --- Fix it, then Ship it!

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/ --- (Updated Июнь 15, 2016, 2 п.п.) Review request for Ambari, Robert Nettleton,

Re: Review Request 48685: AMBARI-17218 Show message of Audit to DB Removal during upgrade for Ranger

2016-06-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48685/#review137735 --- Ship it! Ship It! - Jonathan Hurley On June 15, 2016, 10:18

Re: Review Request 48730: AMBARI-17250 : Use right principals for Hbase Master in Kerberos enabled Ranger Hbase Plugin

2016-06-15 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48730/#review137739 --- Ship it! Ship It! - Velmurugan Periasamy On June 15, 2016,

Re: Review Request 48607: AMBARI-17181: Add some of value-attributes to property files in AMBARI_METRICS

2016-06-15 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48607/#review137783 --- Masahiro, was this patch manually tested on a cluster? -

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-15 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/#review137821 --- Ship it!

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/#review137788 --- @Jeff Please rebase patch with latest in trunk. There are

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-15 Thread Prajwal Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review137790 ---

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-15 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48589/#review137800 --- Ship it! Ship It! - Oliver Szabo On June 14, 2016, 2:15

Re: Review Request 48735: Storm service check failed after Ambari upgrade

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48735/#review137808 --- Please include Sriharsha Chintalapani in the code review. -

Re: Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments

2016-06-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/ --- (Updated June 15, 2016, 7:15 p.m.) Review request for Ambari, Robert

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-15 Thread Oliver Szabo
> On June 15, 2016, 7:11 p.m., Don Bosco Durai wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 138 > > > > > > Ideally, we should just use our Hadoop

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-15 Thread Don Bosco Durai
> On June 15, 2016, 7:11 p.m., Don Bosco Durai wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py, > > line 82 > > > > > > We should set explicit

Review Request 48743: Remove {{atlas_conf_dir}} from HADOOP_CLASSPATH in hive-env.

2016-06-15 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48743/ --- Review request for Ambari and John Speidel. Bugs: AMBARI-17262

Re: Review Request 48735: Storm service check failed after Ambari upgrade

2016-06-15 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48735/#review137810 --- Ship it! Ship It! - Sriharsha Chintalapani On June 15,

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48609/#review137814 --- Ship it! Ship It! - Alejandro Fernandez On June 15, 2016,

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-15 Thread Jayush Luniya
> On June 2, 2016, 4:42 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py, > > line 1 > > > > > > Please add unit tests as mentioned in

Review Request 48712: AMBARI-17263. Fix for following for Hive Server Interactive : (1). Updates to 'llapstatus' command while querying LLAP app status. (2). Adding validation check for config 'hive.s

2016-06-15 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48712/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-15 Thread Oliver Szabo
> On June 15, 2016, 7:11 p.m., Don Bosco Durai wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py, > > line 82 > > > > > > We should set explicit

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137827 --- Ship it! Ship It! - Alejandro Fernandez On June 15, 2016,

Re: Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48750/#review137834 --- Ship it! Please make sure while building metrics, no other

Re: Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Aravindan Vijayan
> On June 15, 2016, 8:36 p.m., Ajit Kumar wrote: > > ambari-metrics/ambari-metrics-timelineservice/pom.xml, line 711 > > > > > > As far as I remember, I had changed pom.version to project.version > > because of a

Re: Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48750/ --- (Updated June 15, 2016, 8:59 p.m.) Review request for Ambari, Ajit Kumar,

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-15 Thread Jungtaek Lim
> On 6 15, 2016, 6:16 오후, Prajwal Rao wrote: > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js, line 40 > > > > > > There seems to be no way to disable Series Aggregation. We need to have > > a

Re: Review Request 48739: Remove CascadeType in ServiceComponentHistoryEntity for ServiceComponentDesiredStateEntity

2016-06-15 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48739/#review137903 --- Ship it! Ship It! - Nahappan Somasundaram On June 15, 2016,

Re: Review Request 48727: Log Search default log levels can not be altered

2016-06-15 Thread Miklos Gergely
> On June 15, 2016, 7:38 p.m., Don Bosco Durai wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java, > > line 133 > > > > > > Not sure I

Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.

2016-06-15 Thread Ajit Kumar
> On June 15, 2016, 9:23 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java, > > line 930 > > > > > > I also talked to Sumit,

Re: Review Request 48727: Log Search default log levels can not be altered

2016-06-15 Thread Don Bosco Durai
> On June 15, 2016, 7:38 p.m., Don Bosco Durai wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java, > > line 133 > > > > > > Not sure I

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-15 Thread Don Bosco Durai
> On June 15, 2016, 7:11 p.m., Don Bosco Durai wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py, > > line 82 > > > > > > We should set explicit

Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48670/#review137860 --- Ship it! Ship It! - Alejandro Fernandez On June 14, 2016,

Re: Review Request 48712: AMBARI-17263. Fix for following for Hive Server Interactive : (1). Updates to 'llapstatus' command while querying LLAP app status. (2). Adding validation check for config 'hi

2016-06-15 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48712/#review137829 --- Ship it! Ship It! - Sumit Mohanty On June 15, 2016, 6:47

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review137828 --- Ship it! Tim, let me know if you want me to commit this to

Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48750/ --- Review request for Ambari, Ajit Kumar, Dmytro Sen, Sumit Mohanty, and Sid Wagle.

Re: Review Request 48726: AMBARI-17247 : Populate audit to solr / hdfs properties for Atlas

2016-06-15 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48726/#review137869 --- Ship it! Ship It! - Srimanth Gunturi On June 15, 2016, 3:42

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/#review137885 ---

Re: Review Request 48739: Remove CascadeType in ServiceComponentHistoryEntity for ServiceComponentDesiredStateEntity

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48739/#review137891 ---

Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-15 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/ --- (Updated June 15, 2016, 11:06 p.m.) Review request for Ambari, Jayush Luniya

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Juanjo Marron
> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 54 > > > > > > We should probably do a

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/#review137881 --- Ship it! Ship It! - Alejandro Fernandez On June 15, 2016,

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Juanjo Marron
> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 54 > > > > > > We should probably do a

  1   2   >