Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

2016-07-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50287/#review143111 --- Ship it! Ship It! - Jayush Luniya On July 21, 2016, 10:19

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-07-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review143119 ---

Re: Review Request 50305: Views in Ambari UI don't render when proxied by Knox - contrib views

2016-07-21 Thread Ashwin Rajeev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50305/#review143126 --- Ship it! Ship It! - Ashwin Rajeev On July 21, 2016, 6:38

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Jayush Luniya
> On July 21, 2016, 3:30 p.m., Jonathan Hurley wrote: > > It would have been nice to break this type of server action out into > > something more generic for alert updates. That way, future changes like > > this won't need to worry about broadcasting events. However, it's not > > necessary

Review Request 50306: UI does not allow to delete service is some host components are in INSTALLED_FAILED state

2016-07-21 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50306/ --- Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Vivek Ratnavel

Re: Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

2016-07-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50289/#review143112 --- Ship it! Ship It! - Alejandro Fernandez On July 21, 2016,

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

2016-07-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50256/#review143121 ---

Re: Review Request 50306: UI does not allow to delete service is some host components are in INSTALLED_FAILED state

2016-07-21 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50306/#review143135 --- Ship it! Ship It! - Zhe (Joe) Wang On July 21, 2016, 7:36

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50140/#review143116 ---

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

2016-07-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50287/#review143114 ---

Re: Review Request 50305: Views in Ambari UI don't render when proxied by Knox - contrib views

2016-07-21 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50305/#review143124 --- Ship it! Ship It! - Rohit Choudhary On July 21, 2016, 6:27

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-07-21 Thread Anita Jebaraj
> On July 21, 2016, 6:30 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 242 > > > > > > Why is 'SASL' hardcoded here?

Re: Review Request 50309: AMBARI-17823: Increase default interval between retries for oozie actions

2016-07-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50309/#review143141 --- Ship it! Ship It! - Alejandro Fernandez On July 21, 2016,

Re: Review Request 50302: EU POST Call Takes More Than 3 Minutes on 900 Node Cluster

2016-07-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50302/ --- (Updated July 21, 2016, 5:10 p.m.) Review request for Ambari, Alejandro

Review Request 50312: AMBARI-17844: Update the content of various llap log4j properties.

2016-07-21 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50312/ --- Review request for Ambari, Sumit Mohanty and Siddharth Seth. Bugs:

Re: Review Request 50312: AMBARI-17844: Update the content of various llap log4j properties.

2016-07-21 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50312/#review143152 --- Ship it! Ship It! - Sumit Mohanty On July 21, 2016, 11

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

2016-07-21 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50256/ --- (Updated July 21, 2016, 1:29 p.m.) Review request for Ambari and Alejandro

Review Request 50309: AMBARI-17823: Increase default interval between retries for oozie actions

2016-07-21 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50309/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17823

Re: Review Request 49387: Support password type for custom properties

2016-07-21 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/ --- (Updated July 21, 2016, 11:11 p.m.) Review request for Ambari, Alexandr

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

2016-07-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50256/#review143137 --- Ship it! Ship It! - Alejandro Fernandez On July 21, 2016,

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

2016-07-21 Thread Venkat Ranganathan
> On July 21, 2016, 8:56 a.m., Venkat Ranganathan wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 331 > > > > > > Do we need this. Isn't OOZIE added in

Re: Review Request 49387: Support password type for custom properties

2016-07-21 Thread Keta Patel
> On July 20, 2016, 11:17 p.m., Alexandr Antonenko wrote: > > ambari-web/app/utils/config.js, line 264 > > > > > > I do not see FINAL populated anywhere. I think this code will trigger > > fatal error. Have you

Re: Review Request 49387: Support password type for custom properties

2016-07-21 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/ --- (Updated July 21, 2016, 11:05 p.m.) Review request for Ambari, Alexandr

Re: Review Request 50302: EU POST Call Takes More Than 3 Minutes on 900 Node Cluster

2016-07-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50302/ --- (Updated July 21, 2016, 5:11 p.m.) Review request for Ambari, Alejandro

Re: Review Request 50309: AMBARI-17823: Increase default interval between retries for oozie actions

2016-07-21 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50309/#review143148 --- Ship it! Ship It! - Swapan Shridhar On July 21, 2016, 8:50

Re: Review Request 50314: Show existing views under relevant service page as tabs

2016-07-21 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50314/#review143159 --- ambari-web/app/app.js (lines 292 - 299)

Re: Review Request 50225: the history versions of config can't be showed in the screen fully

2016-07-21 Thread wuhui
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50225/ --- (Updated 七月 22, 2016, 1:42 a.m.) Review request for Ambari. Bugs:

Review Request 50314: Show existing views under relevant service page as tabs

2016-07-21 Thread Manasi Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50314/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.

Re: Review Request 50314: Show existing views under relevant service page as tabs

2016-07-21 Thread Manasi Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50314/ --- (Updated July 21, 2016, 11:53 p.m.) Review request for Ambari, Alejandro

Re: Review Request 49387: Support password type for custom properties

2016-07-21 Thread Alexandr Antonenko
> On July 20, 2016, 11:17 p.m., Alexandr Antonenko wrote: > > ambari-web/app/utils/config.js, line 248 > > > > > > FYI: this can be also simplified > > > > var attributes = []; > > ['FINAL',

Review Request 50294: AMBARI-17833 EU fails during restart of Ranger Admin at setup_ranger_audit_solr

2016-07-21 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50294/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya,

Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-21 Thread Hemanth Yamijala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50297/ --- Review request for Ambari. Bugs: AMBARI-17788

Re: Review Request 48850: Views in Ambari UI don't render when proxied by Knox

2016-07-21 Thread Ashwin Rajeev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48850/#review143056 --- Ship it! Just adds the site root to view URL's, looks fine -

Re: Review Request 50239: Spark Livy should wait for ATS start for BP deployments

2016-07-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50239/ --- (Updated Июль 21, 2016, 9:49 д.п.) Review request for Ambari, Dmitro

Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

2016-07-21 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50287/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya,

Re: Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

2016-07-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50289/#review143081 --- Ship it! Ship It! - Dmytro Sen On Июль 21, 2016, 12:57

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50140/ --- (Updated July 21, 2016, 12:36 p.m.) Review request for Ambari, Alejandro

Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

2016-07-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50289/ --- Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy. Bugs:

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

2016-07-21 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50287/#review143089 ---

Re: Review Request 50300: AMBARI-17828 : Nimbus, Storm UI server stopped after disabling ranger plugins

2016-07-21 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50300/#review143095 --- Ship it! Ship It! - Velmurugan Periasamy On July 21, 2016,

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50140/#review143087 --- Ship it! It would have been nice to break this type of server

Review Request 50300: AMBARI-17828 : Nimbus, Storm UI server stopped after disabling ranger plugins

2016-07-21 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50300/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Sumit Mohanty,

Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

2016-07-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50299/ --- Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy. Bugs:

Re: Review Request 50294: AMBARI-17833 EU fails during restart of Ranger Admin at setup_ranger_audit_solr

2016-07-21 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50294/#review143093 --- Ship it! Ship It! - Gautam Borad On July 21, 2016, 2:15

Review Request 50302: EU POST Call Takes More Than 3 Minutes on 900 Node Cluster

2016-07-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50302/ --- Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole,

Re: Review Request 50302: EU POST Call Takes More Than 3 Minutes on 900 Node Cluster

2016-07-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50302/#review143096 --- ambari-agent/src/main/python/ambari_agent/ActionQueue.py

Re: Review Request 50302: EU POST Call Takes More Than 3 Minutes on 900 Node Cluster

2016-07-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50302/#review143098 --- Ship it! Ship It! - Nate Cole On July 21, 2016, 12:39 p.m.,

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-07-21 Thread Anita Jebaraj
> On July 18, 2016, 10:58 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, > > line 18 > > > > > > This is redundant... > > > >

Re: Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

2016-07-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50299/#review143105 --- Ship it! Ship It! - Dmitro Lisnichenko On July 21, 2016,

Re: Review Request 50294: AMBARI-17833 EU fails during restart of Ranger Admin at setup_ranger_audit_solr

2016-07-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50294/#review143101 --- Ship it! Ship It! - Jayush Luniya On July 21, 2016, 2:15

Re: Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

2016-07-21 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50299/#review143106 --- Ship it! Ship It! - Dmytro Grinenko On July 21, 2016, 3:35

Re: Review Request 50300: AMBARI-17828 : Nimbus, Storm UI server stopped after disabling ranger plugins

2016-07-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50300/#review143109 --- Ship it! Ship It! - Jayush Luniya On July 21, 2016, 4:14