Review Request 50651: Zeppelin start fails in non-root

2016-08-01 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50651/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-17973

Re: Review Request 50654: Coverity Scan Security Vulnerability - Resource Leak defects

2016-08-01 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50654/#review144321 --- Ship it! Ship It! - Andrew Onischuk On Aug. 1, 2016, 11:05

Re: Review Request 50646: Add kerberos.json file for Sqoop in HDP 2.5 needed by Atlas

2016-08-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50646/#review144323 --- Ship it! Ship It! - Jonathan Hurley On July 31, 2016, 8:09

Re: Review Request 50647: Changed oozie.authentication.kerberos.principal and oozie.authentication.kerberos.keytab are reverted while regenerating keytab files

2016-08-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50647/#review144325 --- Ship it! Ship It! - Jonathan Hurley On July 31, 2016, 10

Review Request 50656: Improvements/fixes for AMBARI_INFRA initial service definition

2016-08-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50656/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert

Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date

2016-08-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50653/#review144326 --- Ship it! Ship It! - Oliver Szabo On Aug. 1, 2016, 10:23

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-08-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50297/#review144332 --- Ship it! Ship It! - Oliver Szabo On Aug. 1, 2016, 1:10

Re: Review Request 50646: Add kerberos.json file for Sqoop in HDP 2.5 needed by Atlas

2016-08-01 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50646/#review144313 --- Ship it! Ship It! - Robert Levas On July 31, 2016, 8:09

Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date

2016-08-01 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50653/ --- Review request for Ambari, Daniel Gergely, Dmytro Sen, Oliver Szabo, and

Review Request 50654: Coverity Scan Security Vulnerability - Resource Leak defects

2016-08-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50654/ --- Review request for Ambari, Dmitro Lisnichenko and Dmytro Sen. Bugs:

Re: Review Request 50651: Zeppelin start fails in non-root

2016-08-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50651/#review144320 --- Ship it! Ship It! - Vitalyi Brodetskyi On Сер. 1, 2016,

Re: Review Request 50656: Improvements/fixes for AMBARI_INFRA initial service definition

2016-08-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50656/#review144335 --- Ship it! Ship It! - Robert Nettleton On Aug. 1, 2016, 12:22

Review Request 50663: Add snappy package dependency for AMS collector

2016-08-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50663/ --- Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.

Review Request 50660: YARN restart icon appeared after long time after deleting ZK server

2016-08-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50660/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and

Re: Review Request 50616: Coverity Scan Security Vulnerability - SQL injection

2016-08-01 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50616/#review144343 --- Ship it! Ship It! - Mahadev Konar On July 29, 2016, 9:19

Re: Review Request 50616: Coverity Scan Security Vulnerability - SQL injection

2016-08-01 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50616/#review144346 --- Ship it! Ship It! - Sumit Mohanty On July 29, 2016, 9:19

Re: Review Request 50663: Add snappy package dependency for AMS collector

2016-08-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50663/ --- (Updated Авг. 1, 2016, 4:53 п.п.) Review request for Ambari, Aravindan

Re: Review Request 50663: Add snappy package dependency for AMS collector

2016-08-01 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50663/#review144351 --- Ship it! Ship It! - Aravindan Vijayan On Aug. 1, 2016, 4:53

Re: Review Request 50646: Add kerberos.json file for Sqoop in HDP 2.5 needed by Atlas

2016-08-01 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50646/#review144353 --- Ship it! Ship It! - Swapan Shridhar On Aug. 1, 2016, 12:09

Re: Review Request 50616: Coverity Scan Security Vulnerability - SQL injection

2016-08-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50616/#review144362 --- Ship it! Ship It! - Oliver Szabo On July 29, 2016, 9:19

Re: Review Request 50645: Ambari upgrade to 2.4.0 adds several config properties that are not necessary and some are incorrect

2016-08-01 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50645/ --- (Updated Aug. 1, 2016, 8:17 p.m.) Review request for Ambari, Alejandro

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/#review144358 --- ambari-server/src/main/python/ambari_server/dbConfiguration.py

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
> On July 31, 2016, 4:34 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line > > 1131 > > > > > > We should remove the version from the jar name This is

Re: Review Request 50656: Improvements/fixes for AMBARI_INFRA initial service definition

2016-08-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50656/#review144371 --- Ship it! Ship It! - Jayush Luniya On Aug. 1, 2016, 12:22

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated Aug. 1, 2016, 10:38 a.m.) Review request for Ambari and Alejandro

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated Aug. 1, 2016, 11:38 a.m.) Review request for Ambari and Alejandro

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50594/#review144416 --- Ship it! Ship It! - Sumit Mohanty On Aug. 1, 2016, 1:22

Re: Review Request 50645: Ambari upgrade to 2.4.0 adds several config properties that are not necessary and some are incorrect

2016-08-01 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50645/ --- (Updated Aug. 2, 2016, 12:20 a.m.) Review request for Ambari, Alejandro

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50594/#review144421 ---

Re: Review Request 50666: AMBARI-10145 : Add support for tee to another Storage service?

2016-08-01 Thread Jameel Mohamed
> On Aug. 1, 2016, 6:52 p.m., Ajit Kumar wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TimelineMetricsAggregatorMemorySink.java, > > line 68 > >

Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date

2016-08-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50653/#review144381 ---

Re: Review Request 50679: AMBARI-17983. (1). Revert AMBARI-16031 (Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP), and (2). Remove the config 'hive.llap.daemon.work.d

2016-08-01 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50679/ --- (Updated Aug. 1, 2016, 11:26 p.m.) Review request for Ambari, Alejandro

Re: Review Request 50679: AMBARI-17983. (1). Revert AMBARI-16031 (Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP), and (2). Remove the config 'hive.llap.daemon.work.d

2016-08-01 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50679/#review144404 --- Ship it! Ship It! - Jaimin Jetly On Aug. 1, 2016, 11:26

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Saisai Shao
> On Aug. 1, 2016, 9:27 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py, > > line 130 > > > > > > The addition of -Dhdp.version should also be

Re: Review Request 50679: AMBARI-17983. (1). Revert AMBARI-16031 (Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP), and (2). Remove the config 'hive.llap.daemon.work.d

2016-08-01 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50679/#review144410 ---

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50594/#review144418 ---

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Saisai Shao
> On Aug. 2, 2016, 12:34 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 2273 > > > > > > We need to replace hdp_full_version with

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Jayush Luniya
> On Aug. 2, 2016, 12:34 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 2273 > > > > > > We need to replace hdp_full_version with

Review Request 50666: AMBARI-10145 : Add support for tee to another Storage service?

2016-08-01 Thread Jameel Mohamed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50666/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.

Re: Review Request 50666: AMBARI-10145 : Add support for tee to another Storage service?

2016-08-01 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50666/#review144370 ---

Re: Review Request 50653: AMBARI-17308 Ambari Logfeeder outputs a lot of errors due to parse date

2016-08-01 Thread Oliver Szabo
> On Aug. 1, 2016, 12:35 p.m., Oliver Szabo wrote: > > Ship It! i will test this out a bit more, my logs looks like this locally: 2016-08-01T17:41:29.739Z, User(null), RemoteIp(192.168.64.1), Operation(User login), Roles( ), Status(Failed), Reason(Authentication required) ... based on that

Re: Review Request 50666: AMBARI-10145 : Add support for tee to another Storage service?

2016-08-01 Thread Jameel Mohamed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50666/ --- (Updated Aug. 1, 2016, 10:05 p.m.) Review request for Ambari, Aravindan

Re: Review Request 50666: AMBARI-10145 : Add support for tee to another Storage service?

2016-08-01 Thread Jameel Mohamed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50666/ --- (Updated Aug. 1, 2016, 10:11 p.m.) Review request for Ambari, Aravindan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated Aug. 1, 2016, 2:21 p.m.) Review request for Ambari and Alejandro

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50594/#review144388 ---

Review Request 50679: AMBARI-17983. (1). Revert AMBARI-16031 (Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP), and (2). Remove the config 'hive.llap.daemon.work.dirs

2016-08-01 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50679/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Saisai Shao
> On Aug. 1, 2016, 9:27 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py, > > line 130 > > > > > > The addition of -Dhdp.version should also be

Re: Review Request 50679: AMBARI-17983. (1). Revert AMBARI-16031 (Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP), and (2). Remove the config 'hive.llap.daemon.work.d

2016-08-01 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50679/#review144411 --- Ship it! Ship It! - Sumit Mohanty On Aug. 1, 2016, 11:26

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50594/#review144425 --- It doesnt look like you have verified ambari-server upgrade

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Saisai Shao
> On Aug. 2, 2016, 12:59 a.m., Jayush Luniya wrote: > > It doesnt look like you have verified ambari-server upgrade scenarios with > > the patch. This is very important to validate. You need to ensure backward > > compatibility is maintained > > > > Please test the following scenarios > >

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Jayush Luniya
> On Aug. 2, 2016, 12:59 a.m., Jayush Luniya wrote: > > It doesnt look like you have verified ambari-server upgrade scenarios with > > the patch. This is very important to validate. You need to ensure backward > > compatibility is maintained > > > > Please test the following scenarios > >

Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Saisai Shao
> On Aug. 2, 2016, 12:34 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 2273 > > > > > > We need to replace hdp_full_version with