Re: Review Request 50870: Introduce validation of hostgroup mapping for active/standby namenode

2016-08-08 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50870/#review145107 --- Fix it, then Ship it! Thanks for submitting this patch.

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Oliver Szabo
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > > > > > I wanted S3Util as a singleton

Re: Review Request 50475: AMBARI-17778 Add usage information in ambari-server script

2016-08-08 Thread Nate Cole
> On July 27, 2016, 9:56 a.m., Nate Cole wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you for reviewing. Could you commit it? Should it be committed to trunk? - Nate --- This is an automatically generated e-mail. To

Re: Review Request 50801: AMBARI-18026 : Restart of plugin enabled services fails in secured env with Ranger HA

2016-08-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50801/#review145127 --- Ship it! Ship It! - Jayush Luniya On Aug. 8, 2016, 7:09

Re: Review Request 50893: Review the implementation of the Falcon/Atlas hook enabling/disabling

2016-08-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50893/#review145121 --- What tests were performed on the cluster? - Alejandro Fernandez

Re: Review Request 50801: AMBARI-18026 : Restart of plugin enabled services fails in secured env with Ranger HA

2016-08-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50801/#review145123 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 8, 2016,

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-08 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145155 --- Ship it! Agree we should switch to three possibilities but

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

2016-08-08 Thread Kuldeep Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145173 ---

Re: Review Request 50860: ambari-server upgrade should report all the config properties it added/modified

2016-08-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50860/#review145096 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 5, 2016,

Review Request 50893: Review the need of HDP-2.3.99 support and the implementation of the Falcon/Atlas hook enabling/disabling

2016-08-08 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50893/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18062

Re: Review Request 50893: Review the need of HDP-2.3.99 support and the implementation of the Falcon/Atlas hook enabling/disabling

2016-08-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50893/#review145099 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 8, 2016,

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Oliver Szabo
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > > > > > I wanted S3Util as a singleton

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-08 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50753/ --- (Updated Aug. 8, 2016, 11:43 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 49755: AMBARI-17602: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-08-08 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/ --- (Updated Aug. 8, 2016, 11:28 a.m.) Review request for Ambari, DIPAYAN

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-08 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50753/ --- (Updated Aug. 8, 2016, 11:31 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Hemanth Yamijala
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > > > > > I wanted S3Util as a singleton

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Hayat Behlim
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > > > > > I wanted S3Util as a singleton

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Hayat Behlim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50884/#review145084 --- Ship it! Ship It! - Hayat Behlim On Aug. 8, 2016, 5:07

Re: Review Request 50850: Pig view - Pig script creation fails

2016-08-08 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50850/ --- (Updated Aug. 8, 2016, 2:03 p.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 50850: Pig view - Pig script creation fails

2016-08-08 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50850/#review145101 --- Ship it! Ship It! - Pallav Kulshreshtha On Aug. 8, 2016,

Re: Review Request 50894: Remove code for debugging memory leaks not to flood up the disk

2016-08-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50894/#review145102 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 8, 2016,

Review Request 50894: Remove code for debugging memory leaks not to flood up the disk

2016-08-08 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50894/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18063

Re: Review Request 50850: Pig view - Pig script creation fails

2016-08-08 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50850/#review145103 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Aug. 8, 2016, 2:03