Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147167 ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147170 --- A management pack for a custom service can be installed after a

Re: Review Request 51498: Multiple Aggregate Alerts For JournalNode Exist With Some Being Incorrect

2016-08-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51498/#review147169 --- Ship it! Ship It! - Nate Cole On Aug. 29, 2016, 12:54 p.m.,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147173 ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > I was under the impression that applying an m-pack would DIRECTLY update > > repoinfo.xml on the filesystem. Has the design changed since then? > > > > What is the purpose of carrying service version around with the repo? When > > updating

Re: Review Request 51498: Multiple Aggregate Alerts For JournalNode Exist With Some Being Incorrect

2016-08-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51498/ --- (Updated Aug. 29, 2016, 3:43 p.m.) Review request for Ambari, Nate Cole,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > I was under the impression that applying an m-pack would DIRECTLY update > > repoinfo.xml on the filesystem. Has the design changed since then? > > > > What is the purpose of carrying service version around with the repo? When > > updating

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
> On Aug. 29, 2016, 5:34 p.m., Nate Cole wrote: > > In addition, why not just keep repos with the service, then check for them > > when formulating the command. Seems easier than munging everything else. What exactly do you mean? - Balázs Bence

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
> On Aug. 29, 2016, 5:58 p.m., Jayush Luniya wrote: > > A management pack for a custom service can be installed after a cluster is > > already deployed. Can you also test this scenario i.e. if installing a new > > management pack will it add this new repository for the cluster? Yes, it is

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
> On Aug. 29, 2016, 6:14 p.m., Jayush Luniya wrote: > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml, > > line 24 > > > > > > Is it mandatory to

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
> On Aug. 29, 2016, 6:11 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java, > > line 562 > > > > > > Why do we need to

Re: Review Request 51498: Multiple Aggregate Alerts For JournalNode Exist With Some Being Incorrect

2016-08-29 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51498/#review147205 --- Ship it! Ship It! - Robert Nettleton On Aug. 29, 2016, 7:43

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > I was under the impression that applying an m-pack would DIRECTLY update > > repoinfo.xml on the filesystem. Has the design changed since then? > > > > What is the purpose of carrying service version around with the repo? When > > updating

Re: Review Request 51284: Remove Redundant Embedded Postgres SQL

2016-08-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51284/#review147133 --- Ship it! Ship It! - Jonathan Hurley On Aug. 25, 2016, 8:49

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147153 --- I was under the impression that applying an m-pack would DIRECTLY

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147162 --- In addition, why not just keep repos with the service, then check

Review Request 51498: Multiple Aggregate Alerts For JournalNode Exist With Some Being Incorrect

2016-08-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51498/ --- Review request for Ambari, Nate Cole, Robert Levas, and Robert Nettleton.

Re: Review Request 51498: Multiple Aggregate Alerts For JournalNode Exist With Some Being Incorrect

2016-08-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51498/#review147147 ---