Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-06 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51647/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath

Re: Review Request 51600: WebHCat service check should not depend on Pig

2016-09-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51600/#review147916 ---

Re: Review Request 51354: Clean up Log Feeder

2016-09-06 Thread Oliver Szabo
> On Sept. 6, 2016, 5:45 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/CompressionUtil.java, > > line 33 > > > > > > I'm seeing this

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

2016-09-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51629/ --- (Updated Вер. 6, 2016, 10:29 після полудня) Review request for Ambari, Andrew

Re: Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)

2016-09-06 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51678/ --- (Updated Sept. 6, 2016, 10:56 p.m.) Review request for Ambari, Alejandro

Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

2016-09-06 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51677/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-18327

Re: Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

2016-09-06 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51677/ --- (Updated Sept. 6, 2016, 10:41 p.m.) Review request for Ambari, Alexandr

Re: Review Request 51354: Clean up Log Feeder

2016-09-06 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51354/ --- (Updated Sept. 6, 2016, 10:51 p.m.) Review request for Ambari, Hayat Behlim,

Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)

2016-09-06 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51678/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and

Re: Review Request 51597: Desired state of client component should not be changed in case configuration changes are applied through a "Restart"

2016-09-06 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51597/#review147796 --- Ship it! Ship It! - Sebastian Toader On Sept. 2, 2016, 2:11

Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing

2016-09-06 Thread alice alice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51640/ --- (Updated 九月 6, 2016, 8:01 a.m.) Review request for Ambari, Andrew Onischuk and

Re: Review Request 51632: Refactor logsearch portal code

2016-09-06 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51632/#review147797 --- Ship it! Ship It! - Sebastian Toader On Sept. 5, 2016, 6:46

Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

2016-09-06 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51685/ --- Review request for Ambari, Sumit Mohanty and Sid Wagle. Bugs: AMBARI-18328

Re: Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

2016-09-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51685/#review147964 --- Ship it! Ship It! - Sumit Mohanty On Sept. 7, 2016, 2:14

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

2016-09-06 Thread Vitalyi Brodetskyi
> On Вер. 5, 2016, 9:41 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > line 328 > > > > > > This does't look right, the

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

2016-09-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51629/ --- (Updated Вер. 6, 2016, 12:06 після полудня) Review request for Ambari, Andrew

Re: Review Request 51354: Clean up Log Feeder skeleton

2016-09-06 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51354/ --- (Updated Sept. 6, 2016, 12:13 p.m.) Review request for Ambari, Hayat Behlim,

Re: Review Request 51597: Desired state of client component should not be changed in case configuration changes are applied through a "Restart"

2016-09-06 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51597/#review147821 --- Ship it! Ship It! - Sandor Magyari On Sept. 2, 2016, 12:11

Re: Review Request 51354: Clean up Log Feeder skeleton

2016-09-06 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51354/ --- (Updated Sept. 6, 2016, 1:20 p.m.) Review request for Ambari, Hayat Behlim,

Re: Review Request 51648: Ambari server start should log the class path being used

2016-09-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51648/#review147811 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 6, 2016,

Re: Review Request 51370: DB consistency check should tolerate services with no configuration

2016-09-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51370/#review147829 ---

Re: Review Request 51632: Refactor logsearch portal code

2016-09-06 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51632/#review147833 --- Ship it! Ship It! - Miklos Gergely On Sept. 5, 2016, 4:46

Re: Review Request 51370: DB consistency check should tolerate services with no configuration

2016-09-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51370/#review147839 --- Ship it! Ship It! - Laszlo Puskas On Sept. 6, 2016, 2:28

Re: Review Request 51370: DB consistency check should tolerate services with no configuration

2016-09-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51370/#review147830 ---

Review Request 51659: Ambari cannot install HDP from mirror list

2016-09-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51659/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-18325

Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

2016-09-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51657/ --- Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-17456

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-09-06 Thread Dmytro Sen
> On Авг. 19, 2016, 6:20 п.п., Sid Wagle wrote: > > The path does everythong expected for the 0.0.0.0:6188 revert and the alert > > definition, however not sure about the param.py changes for 1 host these > > should not be required since we should be gettign all collectors as > >

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

2016-09-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51629/#review147849 ---

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-09-06 Thread Dmytro Sen
> On Авг. 19, 2016, 6:18 п.п., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, > > line 497 > > > > > > We have sharding on sink side, so we

Re: Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

2016-09-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51657/ --- (Updated Сен. 6, 2016, 4:53 п.п.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-09-06 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51207/#review147867 --- Ship it! Ship It! - Aravindan Vijayan On Aug. 18, 2016,

Review Request 51663: Add custom jdbc path to ambari-server classpath

2016-09-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51663/ --- Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.

Re: Review Request 51354: Clean up Log Feeder

2016-09-06 Thread Miklos Gergely
> On Sept. 6, 2016, 5:45 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/CompressionUtil.java, > > line 33 > > > > > > I'm seeing this

Re: Review Request 51354: Clean up Log Feeder

2016-09-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51354/#review147866 --- Fix it, then Ship it! Overall, the patch looks fine to me.

Re: Review Request 51659: Ambari cannot install HDP from mirror list

2016-09-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51659/#review147878 --- What is the format of the mirror list? - Alejandro Fernandez

Re: Review Request 51657: Support round-robin scheduling with failover for monitors with distributed collector

2016-09-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51657/#review147868 --- Fix it, then Ship it!

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

2016-09-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51629/#review147879 ---

Re: Review Request 51354: Clean up Log Feeder

2016-09-06 Thread Miklos Gergely
> On Sept. 6, 2016, 5:45 p.m., Robert Nettleton wrote: > > Overall, the patch looks fine to me. Just a few minor issues that should > > be addressed. > > > > More generally, I would recommend that refactorings like this be submitted > > in smaller chunks. The current patch's size makes a

Re: Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format

2016-09-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51550/#review147905 --- Ping. Can this be pushed and close this review? - Nate Cole

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-09-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51562/#review147888 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 1, 2016,

Re: Review Request 51663: Add custom jdbc path to ambari-server classpath

2016-09-06 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51663/ --- (Updated Вер. 6, 2016, 7 після полудня) Review request for Ambari, Andrew

Re: Review Request 49804: improve resourcemanager HA description

2016-09-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49804/#review147904 --- Ship it! Ship It! - Nate Cole On Sept. 6, 2016, 5:57 a.m.,

Re: Review Request 51659: Ambari cannot install HDP from mirror list

2016-09-06 Thread Nate Cole
> On Sept. 6, 2016, 2:04 p.m., Alejandro Fernandez wrote: > > What is the format of the mirror list? +1 for this - I would prefer if mirrors is not just some CSV but was structured (set of items, etc). - Nate --- This is an

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

2016-09-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51575/#review147915 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 1, 2016,

Review Request 51648: Ambari server start should log the class path being used

2016-09-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51648/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18315

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

2016-09-06 Thread Sid Wagle
> On Sept. 6, 2016, 11:55 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > line 332 > > > > > > This query is not correct. >

Re: Review Request 51600: WebHCat service check should not depend on Pig

2016-09-06 Thread Andrew Onischuk
> On Sept. 6, 2016, 8:52 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, > > line 578 > > > > > > If a service is deleted, so

Re: Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

2016-09-06 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51677/#review147972 --- In step-4 the flag "nextBtnClickInProgress" was not set anywhere

Re: Review Request 51663: Add custom jdbc path to ambari-server classpath

2016-09-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51663/#review147895 --- Ship it! Ship It! - Sumit Mohanty On Sept. 6, 2016, 7 p.m.,

Re: Review Request 51678: Code review request for AMBARI-18290 (Ambari does not support HBase on HTTPS mode)

2016-09-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51678/#review147946 ---

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

2016-09-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51629/#review147948 --- Ship it! Ship It! - Sid Wagle On Sept. 6, 2016, 10:29 p.m.,

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

2016-09-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51629/#review147949 ---

Re: Review Request 49804: improve resourcemanager HA description

2016-09-06 Thread wang yaoxin
> On 九月 6, 2016, 7:41 p.m., Nate Cole wrote: > > Ship It! Thank you , but I don't have the authority to ship, so i will trouble you to commit the patch! - wang --- This is an automatically generated e-mail. To reply, visit: