Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-13 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51725/ --- (Updated Sept. 13, 2016, 3:55 p.m.) Review request for Ambari, Attila

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 5292-5294 > > > > > > Why not just return here which

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51838/#review148735 --- Ship it! I believe that the original case for this `hdp-select

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-13 Thread Anita Jebaraj
> On Sept. 13, 2016, 12:37 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, lines > > 138-140 > > > > > > Again, I'm not sure what you're fixing here. Every execution

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Jayush Luniya
> On Sept. 13, 2016, 6:42 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py, > > line 49 > > > > > > Has this been tested on

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2586 > > > > > > Although I understand the motivation, I

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-13 Thread Balázs Bence Sári
> On Sept. 13, 2016, 6:13 p.m., Robert Levas wrote: > > I am concerned with the use of the HDFS *admin* user. Why not use the > > revo(?) user's identity instead? Revo doesn't have its own user. We need to ensure that the /user/RevoShare exists on hdfs, that's what we need the HDFS admin

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
> On Sept. 13, 2016, 8:29 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 1334-1336 > > > > > > Is this specifically for SPNEGO, or any

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51838/#review148757 ---

Re: Review Request 51846: AMBARI-18375 Ranger Plugin configs is not generated for Hive interactive

2016-09-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51846/#review148768 --- Ship it! Ship It! - Jayush Luniya On Sept. 13, 2016, 1:39

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51838/#review148753 --- Ship it! Ship It! - Jayush Luniya On Sept. 13, 2016, 1:22

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Alejandro Fernandez
> On Sept. 13, 2016, 4:34 p.m., Jonathan Hurley wrote: > > I believe that the original case for this `hdp-select set all` was when > > adding a host back to the cluster after an upgrade. Because prior symlinks > > existed, new components will not have their symlink pointers created by > >

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-13 Thread Nate Cole
> On Sept. 13, 2016, 8:37 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py, lines > > 138-140 > > > > > > Again, I'm not sure what you're fixing here. Every execution

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51725/#review148751 --- Ship it! I am concerned with the use of the HDFS *admin* user.

Review Request 51851: AMBARI-18332: Blueprints: API should make available "setting" property from blueprint

2016-09-13 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51851/ --- Review request for Ambari, Robert Nettleton and Sumit Mohanty. Bugs:

Re: Review Request 51863: AMBARI-18383 : Oozie spark failed due to incomplete spark share-lib directory

2016-09-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51863/#review148798 --- Ship it! Ship It! - Sumit Mohanty On Sept. 13, 2016, 9:56

Re: Review Request 51863: AMBARI-18383 : Oozie spark failed due to incomplete spark share-lib directory

2016-09-13 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51863/#review148807 --- Ship it! Ship It! - Venkat Ranganathan On Sept. 13, 2016,

Re: Review Request 51863: AMBARI-18383 : Oozie spark failed due to incomplete spark share-lib directory

2016-09-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51863/#review148790 ---

Re: Review Request 51833: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51833/ --- (Updated Sept. 13, 2016, 10:32 p.m.) Review request for Ambari, Sumit Mohanty

Re: Review Request 51846: AMBARI-18375 Ranger Plugin configs is not generated for Hive interactive

2016-09-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51846/#review148772 ---

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/ --- (Updated Sept. 13, 2016, 4:44 p.m.) Review request for Ambari, Alejandro

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/#review148785 --- Ship it! Ship It! - Jonathan Hurley On Sept. 13, 2016, 4:44

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Jonathan Hurley
> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 5292-5294 > > > > > > Why not just return here which

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Jonathan Hurley
> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2586 > > > > > > Although I understand the motivation, I

Re: Review Request 51844: Audit logs should not be filtered by Log Feeder

2016-09-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51844/#review148774 --- Ship it! Ship It! - Oliver Szabo On Sept. 13, 2016, 12:37

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-13 Thread Amruta Borkar
> On Sept. 13, 2016, 2:07 p.m., Di Li wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java, > > line 103 > > > > > > do you support other type of checks ? such as the

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-13 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/ --- (Updated Sept. 13, 2016, 9:28 p.m.) Review request for Ambari, Shantanu

Re: Review Request 51863: AMBARI-18383 : Oozie spark failed due to incomplete spark share-lib directory

2016-09-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51863/ --- (Updated Sept. 13, 2016, 9:36 p.m.) Review request for Ambari, Andrew

Review Request 51859: Enable Kerberos Wizard: Metrics collector fails to start on a cluster with Ranger installed

2016-09-13 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51859/ --- Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.

Re: Review Request 51859: Enable Kerberos Wizard: Metrics collector fails to start on a cluster with Ranger installed

2016-09-13 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51859/#review148777 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 13, 2016, 8:40

Re: Review Request 51859: Enable Kerberos Wizard: Metrics collector fails to start on a cluster with Ranger installed

2016-09-13 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51859/#review148778 --- Ship it! Ship It! - Yusaku Sako On Sept. 13, 2016, 8:40

Re: Review Request 51859: Enable Kerberos Wizard: Metrics collector fails to start on a cluster with Ranger installed

2016-09-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51859/#review148779 --- Ship it! Ship It! - Sumit Mohanty On Sept. 13, 2016, 8:40

Re: Review Request 51863: AMBARI-18383 : Oozie spark failed due to incomplete spark share-lib directory

2016-09-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51863/ --- (Updated Sept. 13, 2016, 9:56 p.m.) Review request for Ambari, Andrew

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review148773 --- Ship it! Verfied following scenarios 1. Add additional repo

Re: Review Request 51540: Expose Disabling of Alert Targets in Web Client

2016-09-13 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51540/#review148775 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 9, 2016, 10:07

Review Request 51863: AMBARI-18383 : Oozie spark failed due to missing py4j and/or pyspark zip files in share lib

2016-09-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51863/ --- Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Sumit Mohanty, and

Re: Review Request 51833: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51833/ --- (Updated Sept. 13, 2016, 10:11 p.m.) Review request for Ambari, Sumit Mohanty

Re: Review Request 49804: improve resourcemanager HA description

2016-09-13 Thread Aleksandr Kovalenko
> On Сен. 12, 2016, 9:08 д.п., Aleksandr Kovalenko wrote: > > ambari-web/app/models/host_component.js, line 333 > > > > > > What is the reason for this change? > > Why we decide to not show Enable label if HA is

Re: Review Request 49804: improve resourcemanager HA description

2016-09-13 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49804/#review148726 --- Ship it! Ship It! - Aleksandr Kovalenko On Сен. 12, 2016,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/ --- (Updated Sept. 13, 2016, 9:31 a.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Balázs Bence Sári
> On Sept. 7, 2016, 6:35 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java, > > lines 166-169 > > > > > > Objects.equals() for simplicity. Fixed. > On

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/ --- (Updated Sept. 13, 2016, 5 a.m.) Review request for Ambari, Alejandro

Re: Review Request 51811: All classes recompiled due to Maven bug, even if none changed

2016-09-13 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51811/#review148702 --- Ship it! Ship It! - Laszlo Puskas On Sept. 12, 2016, 3:56

Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-13 Thread wang yaoxin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/ --- Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sebastian

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/#review148701 --- Ship it! LGTM, just confirming that if these are properties

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/#review148699 ---

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

2016-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51705/#review148705 ---

Review Request 51844: Audit logs should not be filtered by Log Feeder

2016-09-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51844/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 49804: improve resourcemanager HA description

2016-09-13 Thread wang yaoxin
> On 九月 12, 2016, 9:08 a.m., Aleksandr Kovalenko wrote: > > ambari-web/app/models/host_component.js, line 333 > > > > > > What is the reason for this change? > > Why we decide to not show Enable label if HA is

Re: Review Request 51811: All classes recompiled due to Maven bug, even if none changed

2016-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51811/#review148700 --- Ship it! Ship It! - Nate Cole On Sept. 12, 2016, 11:56

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/#review148703 ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/ --- (Updated Sept. 13, 2016, 9:25 a.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51838/#review148686 --- Ship it! Ship It! - Andrew Onischuk On Sept. 13, 2016, 7:56

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Balázs Bence Sári
> On Sept. 7, 2016, 6:35 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java, > > lines 42-43 > > > > > > Syntax. Fixed. > On Sept. 7, 2016, 6:35 p.m.,

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review148721 ---

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review148722 --- Please add Shantanu as a reviewer - Di Li On Sept. 12, 2016,

Review Request 51846: AMBARI-18375 Ranger Plugin configs is not generated for Hive interactive

2016-09-13 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51846/ --- Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and

Re: Review Request 51818: YAML Maps For Storm Are Not Being Escaped Correctly

2016-09-13 Thread Jonathan Hurley
> On Sept. 13, 2016, 8:48 a.m., Nate Cole wrote: > > ambari-common/src/main/python/ambari_commons/yaml_utils.py, lines 22-28 > > > > > > NOW I know who to go to for regex shenanigans ;) I always say, "If you need to

Re: Review Request 51846: AMBARI-18375 Ranger Plugin configs is not generated for Hive interactive

2016-09-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51846/#review148720 --- Ship it! Ship It! - Sumit Mohanty On Sept. 13, 2016, 1:39

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/ --- (Updated Sept. 13, 2016, 4:59 a.m.) Review request for Ambari, Alejandro

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review148709 --- Ship it! Ship It! - Nate Cole On Sept. 13, 2016, 5:31 a.m.,

Re: Review Request 51844: Audit logs should not be filtered by Log Feeder

2016-09-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51844/#review148717 --- Ship it! Ship It! - Robert Nettleton On Sept. 13, 2016,

Re: Review Request 51818: YAML Maps For Storm Are Not Being Escaped Correctly

2016-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51818/#review148708 --- Ship it!

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-13 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51725/ --- (Updated Sept. 13, 2016, 1:29 p.m.) Review request for Ambari, Attila

Review Request 51837: Make Execute timeout to be able to kill process trees which doesn't respond to SIGTERM

2016-09-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51837/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18369

Re: Review Request 51837: Make Execute timeout to be able to kill process trees which doesn't respond to SIGTERM

2016-09-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51837/#review148668 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 13, 2016,

Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51838/ --- Review request for Ambari, Andrew Onischuk, Jayush Luniya, and Sumit Mohanty.