Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52068/#review149673 --- Fix it, then Ship it!

Re: Review Request 51894: View instance cloning functionality

2016-09-20 Thread Sangeeta Ravindran
> On Sept. 18, 2016, 11:51 a.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Alexandr. Can you please help push the fix? Thanks Alexandr for pushing this. - Sangeeta --- This is an

Re: Review Request 52072: AMBARI-18390 : Configuration warnings during "Add Service" Wizard includes seemingly nonsensical heapsize recommendations for AMS heap sizes.

2016-09-20 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52072/ --- (Updated Sept. 20, 2016, 5:11 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52044/ --- (Updated Вер. 20, 2016, 8:59 до полудня) Review request for Ambari, Andrew

Re: Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

2016-09-20 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52038/#review149632 --- Ship it! Ship It! - Balázs Bence Sári On Sept. 19, 2016,

Re: Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

2016-09-20 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52038/#review149633 --- Ship it! Ship It! - Oliver Szabo On Sept. 19, 2016, 2:28

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52044/#review149645 --- Ship it!

Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52068/ --- (Updated Sept. 20, 2016, 2:26 p.m.) Review request for Ambari, Jonathan

Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52068/#review149684 --- Ship it! ambari-server/pom.xml (lines 1403 - 1411)

Re: Review Request 51894: View instance cloning functionality

2016-09-20 Thread Alexandr Antonenko
> On Sept. 18, 2016, 11:51 a.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Alexandr. Can you please help push the fix? > > Sangeeta Ravindran wrote: > Thanks Alexandr for pushing this. np - Alexandr

Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-20 Thread Robert Levas
> On Sept. 20, 2016, 1:26 p.m., Nate Cole wrote: > > ambari-server/pom.xml, lines 1403-1411 > > > > > > How will this affect the size of Ambari? The KerberosName class is > > pretty lightweight, so hopefully we

Re: Review Request 51903: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51903/#review149685 --- What's the status of this review? Can it be marked Submitted? -

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-20 Thread Jayush Luniya
> On Sept. 16, 2016, 3:44 p.m., Robert Nettleton wrote: > > Thanks for providing this patch. This is a feature in Blueprints that is > > sorely needed, and will be beneficial for Blueprints generally. > > > > I would ask, if possible, that some consideration be put into making the > > XML

Re: Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

2016-09-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52038/#review149742 --- Ship it! Ship It! - Jayush Luniya On Sept. 19, 2016, 2:28

Review Request 52102: UI for user home directory creation

2016-09-20 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-15059

Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-20 Thread Robert Levas
> On Sept. 20, 2016, 12:59 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/AmbariEntryPoint.java, > > lines 39-41 > > > > > > Should this check to see if an auth token

Re: Review Request 52072: AMBARI-18390 : Configuration warnings during "Add Service" Wizard includes seemingly nonsensical heapsize recommendations for AMS heap sizes.

2016-09-20 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52072/#review149725 --- Ship it! Ship It! - Sid Wagle On Sept. 20, 2016, 5:11 p.m.,

Re: Review Request 52102: UI for user home directory creation

2016-09-20 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/ --- (Updated Sept. 21, 2016, 12:04 a.m.) Review request for Ambari and Zhe (Joe)

Re: Review Request 52102: UI for user home directory creation

2016-09-20 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/#review149764 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 21, 2016, 12:04

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-20 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/ --- (Updated Sept. 20, 2016, 11:18 p.m.) Review request for Ambari, Shantanu

Re: Review Request 52102: UI for user home directory creation

2016-09-20 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/#review149757 ---

Re: Review Request 51599: AMBARI-18292 Support dispatching notifications of assigned alert states for script-based alert dispatcher

2016-09-20 Thread yao lei
> On 九月 3, 2016, 7:17 p.m., Jonathan Hurley wrote: > > This is not the correct way to accomplish this. Instead, when you create > > the alert target, you can specify which alert states the alert target cares > > about: > > > > ``` > > { > > "AlertTarget": { > > "name": "Simple", > >

Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

2016-09-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52068/ --- (Updated Sept. 20, 2016, 10:41 a.m.) Review request for Ambari, Jonathan

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52044/#review149663 --- Ship it! Ship It! - Andrew Onischuk On Sept. 20, 2016, 2:16

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52044/ --- (Updated Вер. 20, 2016, 2:16 після полудня) Review request for Ambari, Andrew