Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-09-22 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52183/ --- Review request for Ambari, Jonathan Hurley, Zhe (Joe) Wang, and Oleg Tikhonov.

Re: Review Request 52178: Ambari create widget does not show what the error is

2016-09-22 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52178/#review150111 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 22, 2016, 11:55

Re: Review Request 52136: Add granular flags for sysprepped clusters to copy tarballs, Oozie share lib, fast jar, and create users

2016-09-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52136/ --- (Updated Sept. 22, 2016, 10:50 p.m.) Review request for Ambari, Dmytro

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Qin Liu
> On Sept. 22, 2016, 7:54 p.m., Robert Levas wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py, > > line 121 > > > > > > Possibly use `curl_krb_request` instead. > > Di Li

Review Request 52178: Ambari create widget does not show what the error is

2016-09-22 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52178/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread wang yaoxin
> On 九月 22, 2016, 4:21 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java, > > lines 204-207 > > > > > > Wouldn't this prevent the method from being

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread wang yaoxin
> On 九月 22, 2016, 4:21 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java, > > lines 204-207 > > > > > > Wouldn't this prevent the method from being

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread wang yaoxin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/ --- (Updated 九月 23, 2016, 4:58 a.m.) Review request for Ambari, Jonathan Hurley,

Review Request 52163: Enforce granular role-based access control for custom actions

2016-09-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52163/ --- Review request for Ambari, Ajit Kumar, Jonathan Hurley, Nate Cole, Sumit

Re: Review Request 52114: Atlas service check never fails

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52114/#review149967 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 21, 2016,

Re: Review Request 52114: Atlas service check never fails

2016-09-22 Thread Andrew Onischuk
> On Sept. 21, 2016, 5:23 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py, > > line 36 > > > > > > Why are we making it always

Re: Review Request 52136: Add granular flags for sysprepped clusters to copy tarballs, Oozie share lib, fast jar, and create users

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52136/#review149965 --- Ship it! sysprep_create_users_and_groups=true|false (default

Re: Review Request 52156: Python UT fail on trunk

2016-09-22 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52156/#review149981 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 22, 2016,

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2016-09-22 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52123/ --- (Updated Sept. 22, 2016, 8:59 a.m.) Review request for Ambari, Attila

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Qin Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51724/ --- (Updated Sept. 22, 2016, 10:14 a.m.) Review request for Ambari, Di Li, Dmytro

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Qin Liu
> On Sept. 8, 2016, 6:13 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py, > > line 25 > > > > > > I do not see a "import kerberos" anywhere in

Review Request 52156: Python UT fail on trunk

2016-09-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52156/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18442

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Qin Liu
> On Sept. 19, 2016, 9:18 a.m., Robert Levas wrote: > > I think this is incorrect. The Metrics Monitor should authenticate with > > its own service principal, not the SPNEGO principal. That is used for > > web-based services, like Ambari's web-based interface. There should be an > >

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2016-09-22 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52123/#review150044 ---

Re: Review Request 52170: NPE when installing secure cluster via Blueprints due to null logger

2016-09-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52170/#review150045 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 22, 2016,

Review Request 52170: NPE when installing secure cluster via Blueprints due to null logger

2016-09-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52170/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.

Review Request 52158: On restarting service using APIs in Ambari, Ambari still says that service needs to be restarted on the UI

2016-09-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52158/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18444

Review Request 52159: SmartSense error during host assignment

2016-09-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52159/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18445

Re: Review Request 52158: On restarting service using APIs in Ambari, Ambari still says that service needs to be restarted on the UI

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52158/#review149990 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 22, 2016,

Re: Review Request 52160: Review necessity of xmllint and remove libxml2-utils package from Oozie manifest

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52160/#review149991 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 22, 2016,

Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread wang yaoxin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/ --- Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Qin Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51724/ --- (Updated Sept. 22, 2016, 12:44 p.m.) Review request for Ambari, Di Li, Dmytro

Review Request 52161: Fix typographical error in hive-mysql dependency

2016-09-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52161/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18119

Review Request 52160: Review necessity of xmllint and remove libxml2-utils package from Oozie manifest

2016-09-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52160/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18446

Re: Review Request 52159: SmartSense error during host assignment

2016-09-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52159/#review149992 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 22, 2016,

Re: Review Request 52163: Enforce granular role-based access control for custom actions

2016-09-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52163/#review150007 --- Ship it! Ship It! - Nate Cole On Sept. 22, 2016, 10:26

Re: Review Request 52163: Enforce granular role-based access control for custom actions

2016-09-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52163/#review150009 --- Ship it! Ship It! - Jonathan Hurley On Sept. 22, 2016,

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-09-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/#review150021 ---

Re: Review Request 52163: Enforce granular role-based access control for custom actions

2016-09-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52163/#review150012 --- Ship it! Ship It! - Sebastian Toader On Sept. 22, 2016,

Re: Review Request 52170: NPE when installing secure cluster via Blueprints due to null logger

2016-09-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52170/#review150060 --- Ship it! Ship It! - Jonathan Hurley On Sept. 22, 2016, 2:33

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51724/#review150057 ---

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Di Li
> On Sept. 22, 2016, 7:54 p.m., Robert Levas wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py, > > line 121 > > > > > > Possibly use `curl_krb_request` instead. Qin, please

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Tim Thorpe
> On Sept. 22, 2016, 7:54 p.m., Robert Levas wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py, > > lines 119-120 > > > > > > These shoud not be hardcoded. The aths to

Re: Review Request 52163: Enforce granular role-based access control for custom actions

2016-09-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52163/ --- (Updated Sept. 22, 2016, 12:28 p.m.) Review request for Ambari, Ajit Kumar,