Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Swapan Shridhar
> On Oct. 12, 2016, 5:42 p.m., Alejandro Fernandez wrote: > > How much was the improvement? After the fix, improved timings are as follows: *ExecutionScheduleManagerTest :* After Improvements - ~11.3 secs Before Improvement - ~30.6 secs *UpgradeCatalog221Test :* After Improvements - ~11.0

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52747/#review152395 --- Thanks for moving the ambari bootstrap override as unminified,

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

2016-10-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52758/ --- (Updated Oct. 12, 2016, 9:04 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Yusaku Sako
> On Oct. 11, 2016, 7:42 p.m., Yusaku Sako wrote: > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js, > > line 44 > > > > > > glyphicon is duplicated. This probably has no material

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

2016-10-12 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52758/#review152405 --- Ship it! Ship It! - Sid Wagle On Oct. 12, 2016, 9:04 p.m.,

Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart

2016-10-12 Thread Sreenath Somarajapuram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52688/#review152284 ---

Re: Review Request 52749: Ambari should be able to create arbitrary Kerberos identities for itself as declared in the Kerberos Descriptor

2016-10-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52749/ --- (Updated Oct. 12, 2016, 4:59 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

2016-10-12 Thread Jonathan Hurley
> On Oct. 11, 2016, 9:28 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java, > > line 45 > > > > > > Why is exists query appropiate here, instead of stageId

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review152312 --- Which branch are you developing this against? The reason I ask is

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-12 Thread Jonathan Hurley
> On Oct. 7, 2016, 2:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java, > > line 50 > > > > > > There should be a default prefix > > Attila Doroszlai

Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52757/#review152307 --- Ship it! Ship It! - Sumit Mohanty On Oct. 11, 2016, 11:17

Review Request 52785: Fix problem on Suse for ambari-agent installation

2016-10-12 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52785/ --- Review request for Ambari. Bugs: AMBARI-18577

Re: Review Request 52752: Hive shows restart indicator after RU

2016-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52752/#review152304 --- Ship it! Ship It! - Jonathan Hurley On Oct. 11, 2016, 5:13

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52183/#review152301 --- I can't really comment on the front-end work since that's not an

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-10-12 Thread Dmytro Sen
> On Сен. 22, 2016, 7:54 п.п., Robert Levas wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py, > > line 33 > > > > > > See `curl_krb_request` I think, we don't

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52183/#review152389 --- This will not impact the new "create alert wizard" because this

Re: Review Request 52555: AMBARI-18535 Ambari is not picking up the latest repo for HDP-2.4

2016-10-12 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52555/#review152392 --- Ship it! Ship It! - Richard Zang On Oct. 5, 2016, 3:25

Re: Review Request 52788: Grafana fails to start after deployment

2016-10-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52788/#review152346 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 12, 2016,

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52747/ --- (Updated Окт. 12, 2016, 7:05 п.п.) Review request for Ambari, Alexandr

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-10-12 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/ --- (Updated Oct. 12, 2016, 11:42 p.m.) Review request for Ambari, Shantanu

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-10-12 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49838/ --- (Updated Oct. 13, 2016, 12:35 a.m.) Review request for Ambari, Aleksandr

Review Request 52791: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52791/ --- Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit

Review Request 52792: AMBARI-18581 Oozie start script ignores sysprep_skip_copy_oozie_share_lib_to_hdfs flag

2016-10-12 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52792/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Laszlo Puskas,

Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52757/#review152353 --- Ship it! How much was the improvement? - Alejandro Fernandez

Re: Review Request 52791: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52791/#review152355 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 12, 2016,

Re: Review Request 52792: AMBARI-18581 Oozie start script ignores sysprep_skip_copy_oozie_share_lib_to_hdfs flag

2016-10-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52792/#review152357 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 12, 2016,

Review Request 52788: Grafana fails to start after deployment

2016-10-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52788/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18579

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread yao lei
> On 十月 12, 2016, 1:48 p.m., Jonathan Hurley wrote: > > I can't really comment on the front-end work since that's not an area I'm > > familiar with. However, I do believe there are Jiras scoping a new "wizard" > > workflow for alerts in Ambari 3.0 which this may impact. Thanks for your

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread yao lei
> On 十月 12, 2016, 8:15 p.m., Xi Wang wrote: > > This will > > not impact the new "create alert wizard" because this is part of alert > > notifications management. Thanks for your comment. But I wonder whether I need to mark this jira as duplicatie if some relevent jiras have existed - yao