Re: Review Request 47954: AMBARI-16907 Ambari web UI does not auto-set all required properties when user toggles on the Yarn CPU isolation feature on the web UI

2016-06-02 Thread Alejandro Fernandez
/configuration/yarn-site.xml (line 205) <https://reviews.apache.org/r/47954/#comment201007> cc @Vinod Vivilapalli to review these - Alejandro Fernandez On May 27, 2016, 2:24 p.m., Di Li wrote: > > --- > This is a

Re: Review Request 48178: AMBARI-17017. Fixing open issues for 'Hive Server Interactive' in Kerberized environment. / AMBARI-17020. Use 'llapstatus' comand after starting llap to check its status befo

2016-06-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48178/#review136002 --- Ship it! Ship It! - Alejandro Fernandez On June 2, 2016, 10

Re: Review Request 48136: AMBARI-16973 Print out configType has malformed json text as part of the ambari server startup error handling

2016-06-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48136/#review136001 --- Ship it! Ship It! - Alejandro Fernandez On June 1, 2016, 5

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-02 Thread Alejandro Fernandez
-catch-finally can do some cleanup and delete the tarball. Start command should be a no-op if the service is already running - Alejandro Fernandez On May 27, 2016, 3:33 a.m., Jeff Zhang wrote: > > --- > This is an automatically g

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Alejandro Fernandez
this. Thank you - Alejandro Fernandez On June 3, 2016, 4:54 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-03 Thread Alejandro Fernandez
ache.org/r/47656/#comment201122> Let's be consistent with the name, UQ_* - Alejandro Fernandez On June 3, 2016, 4:54 p.m., Tim Thorpe wrote: > > --- > This is an automatically ge

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-03 Thread Alejandro Fernandez
290) <https://reviews.apache.org/r/48207/#comment201108> Restarting is dangerous to do, especially if it happens during kerberization or RU/EU. If there's a memory leak, then that's the problem we should be fixing. - Alejandro Fernandez On June 3, 2016, 2:38 p.m., Andrew Onischuk

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-07 Thread Alejandro Fernandez
check the length before accessing [1] ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py (line 63) <https://reviews.apache.org/r/47941/#comment201655> Why replace_existing_files=True? This will make it slower on Start - Alejandro Fernande

Re: Review Request 48379: EU - HDP 2.4 to 2.5 fails restarting DRPC server on a kerberized cluster, need to use org.apache.storm.security.auth.KerberosPrincipalToLocal

2016-06-07 Thread Alejandro Fernandez
559031 Diff: https://reviews.apache.org/r/48379/diff/ Testing (updated) --- Verified during EU from HDP 2.4 to 2.5 on a Kerberized cluster with Storm that the property was changed. Thanks, Alejandro Fernandez

Review Request 48379: EU - HDP 2.4 to 2.5 fails restarting DRPC server on a kerberized cluster, need to use org.apache.storm.security.auth.KerberosPrincipalToLocal

2016-06-07 Thread Alejandro Fernandez
8379/diff/ Testing --- Verified during EU from HDP 2.4 to 2.5 on a Kerberized cluster with Storm. Thanks, Alejandro Fernandez

Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/#review136554 --- Ship it! Ship It! - Alejandro Fernandez On June 7, 2016, 9

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-06 Thread Alejandro Fernandez
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/#review136136 --- On June 6, 2016, 8:04 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically ge

Re: Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-06 Thread Alejandro Fernandez
will commit this patch and retest once it is stable again in Hadoop Core. Thanks, Alejandro Fernandez

Re: Review Request 48288: Microsoft-r install script should use Ambari libraries instead of direct shell calls

2016-06-06 Thread Alejandro Fernandez
-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/microsoft_r.py (line 30) <https://reviews.apache.org/r/48288/#comment201351> Ambari QA user should not be hardcoded since it can be changed during installation. - Alejandro Fernandez On June 6, 2016, 5:

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Alejandro Fernandez
/resource_management/libraries/functions/hdp_select.py (line 136) <https://reviews.apache.org/r/48044/#comment201354> Please add a comment as to why this was done. - Alejandro Fernandez On June 6, 2016, 3:15 p.m., Laszlo Puskas

Re: Review Request 48242: Takes long time to start or fail to start service after enabling SSL due to "dfs.https.enable"

2016-06-06 Thread Alejandro Fernandez
.org/r/48242/ > --- > > (Updated June 3, 2016, 11:56 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit > Mohanty. > > > Bugs: AMBARI-17039 > https://issues.apache.org/jira/browse/AMBARI-17039 > > > Repository: ambari > &

Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Alejandro Fernandez
-web/app/messages.js (line 2403) <https://reviews.apache.org/r/48289/#comment201348> "that cannot be deleted ..." ambari-web/app/messages.js (line 2407) <https://reviews.apache.org/r/48289/#comment201349> "Communication" is singular. - Alejandro Ferna

Re: Review Request 48229: Refactor service_advisor apis to remove passing of stack_advisor

2016-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48229/#review136342 --- Ship it! Ship It! - Alejandro Fernandez On June 6, 2016, 6

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-10 Thread Alejandro Fernandez
t is being restarted twice! - Alejandro Fernandez On June 10, 2016, 12:47 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Alejandro Fernandez
OK Thanks, Alejandro Fernandez

Re: Review Request 48562: Allow option to skip duplicate URL checking when creating VDF

2016-06-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48562/#review137052 --- Ship it! Ship It! - Alejandro Fernandez On June 10, 2016, 6

Re: Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Alejandro Fernandez
:1055 Total errors:0 Total failures:0 OK Thanks, Alejandro Fernandez

Re: Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Alejandro Fernandez
To reply, visit: https://reviews.apache.org/r/48561/#review137067 ------- On June 10, 2016, 9 p.m., Alejandro Fernandez wrote: > > --- > This is an automatical

Re: Review Request 48532: AMBARI-17157 Storm 1.0 log4j config update

2016-06-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48532/#review137082 --- Ship it! Ship It! - Alejandro Fernandez On June 10, 2016, 2

Re: Review Request 48454: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as

2016-06-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48454/#review136860 --- Ship it! Ship It! - Alejandro Fernandez On June 9, 2016, 4

Re: Review Request 48506: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as

2016-06-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48506/#review136887 --- Ship it! Ship It! - Alejandro Fernandez On June 9, 2016, 8

Re: Review Request 47673: Wrong memory conf in spark-env.xml

2016-06-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47673/#review136884 --- Ship it! Ship It! - Alejandro Fernandez On June 3, 2016, 11

Re: Review Request 47673: Wrong memory conf in spark-env.xml

2016-06-09 Thread Alejandro Fernandez
branch-2.4, commit 078833a360bd32c26349ba11b684f8344d173b84 - Alejandro Fernandez On June 3, 2016, 11:01 p.m., Weiqing Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 48234: Falcon server fails to start, HDP 2.4 to use data-mirroring directory, HDP 2.5 to use extensions

2016-06-03 Thread Alejandro Fernandez
again in Hadoop Core. Thanks, Alejandro Fernandez

Re: Review Request 47673: Wrong memory conf in spark-env.xml

2016-06-03 Thread Alejandro Fernandez
/configuration/spark-env.xml (line 92) <https://reviews.apache.org/r/47673/#comment201145> For existing clusters with HDP 2.x, should they change this value when they upgrade Ambari and/or the stack to HDP 2.(x+1)? - Alejandro Fernandez On June 3, 2016, 11:01 p.m., Weiqing Yang

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-25 Thread Alejandro Fernandez
-2.5.xml (line 866) <https://reviews.apache.org/r/47332/#comment199768> hdp_2_5_0_0_remove_ranger_storm_audit_db was removed from RU 2.3 -> 2.5 Was this intentional? - Alejandro Fernandez On May 20, 2016, 7:17 p.m., Sriharsha Chintalap

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-25 Thread Alejandro Fernandez
-2.5.xml <https://reviews.apache.org/r/47332/#comment199773> Why was STORM_REST_API deleted? - Alejandro Fernandez On May 20, 2016, 7:17 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically g

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-25 Thread Alejandro Fernandez
<https://reviews.apache.org/r/47332/#comment199775> DRPC_SERVER is only calling delete_storm_local_data during upgrade but not downgrade, is that intended? - Alejandro Fernandez On May 20, 2016, 7:17 p.m., Sriharsha Chinta

Re: Review Request 47847: AMBARI-16755 Add spark.driver.extraLibraryPath

2016-05-25 Thread Alejandro Fernandez
preted from this xml file. - Alejandro Fernandez On May 25, 2016, 7:37 p.m., Weiqing Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-25 Thread Alejandro Fernandez
.0/package/scripts/setup_spark.py (line 25) <https://reviews.apache.org/r/47579/#comment199752> Use explicit import - Alejandro Fernandez On May 23, 2016, 2:55 a.m., Saisai Shao wrote: > > --- > This is an automatically generated

Re: Review Request 47833: ZKFC restart failed during EU with 'upgrade_type' not defined error

2016-05-25 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47833/#review134804 --- Ship it! Ship It! - Alejandro Fernandez On May 25, 2016, 4

Re: Review Request 47790: Failed to install packages for HDP 2.4 and 2.5

2016-05-25 Thread Alejandro Fernandez
ng 2.4 after any 2.5 has been installed is problematic. - Alejandro Fernandez On May 25, 2016, 2:07 a.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47830: AMBARI-16874 Add capability to derive required core-site.xml properties in case if not already available

2016-05-25 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47830/#review134818 --- Ship it! Ship It! - Alejandro Fernandez On May 25, 2016, 2

Re: Review Request 47845: "Zeppelin service check" was scheduled before "Zeppelin Notebook Start"

2016-05-25 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47845/#review134815 --- Ship it! Ship It! - Alejandro Fernandez On May 25, 2016, 7

Re: Review Request 47815: Handle the scenario when 'capacity-scheduler' configs is passed in as dictionary to Stack Advisor (generally on 1st invocation) in order to create 'llap' queue for Hive Serve

2016-05-25 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47815/#review134879 --- Ship it! Ship It! - Alejandro Fernandez On May 25, 2016, 11

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-13 Thread Alejandro Fernandez
> On June 7, 2016, 6:49 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, > > line 130 > > <https://reviews.apache.org/r/48044/diff/6/?file=1408744#file1408744line130> > > > >

Re: Review Request 48624: Ambari upgrade from 2.2.2 to 2.4.0 fails if cluster name was changed

2016-06-13 Thread Alejandro Fernandez
/UpgradeCatalog240.java (line 2439) <https://reviews.apache.org/r/48624/#comment202504> Move these properties out of the for-loop. If they are empty, should be be an error instead of a "continue" - Alejandro Fernandez On June 13, 2016, 9:41 a.m., Ga

Re: Review Request 48657: Allow option to skip duplicate URL checking when creating VDF (part 2)

2016-06-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48657/#review137344 --- Ship it! Ship It! - Alejandro Fernandez On June 13, 2016, 5

Re: Review Request 48659: Fix Spark2 thriftserver Ambari definition bug

2016-06-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48659/#review137343 --- Ship it! Ship It! - Alejandro Fernandez On June 13, 2016, 6

Re: Review Request 48654: Upgrading Ambari Causes Alert Fields Not To Save Thresholds

2016-06-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48654/#review137388 --- Ship it! Ship It! - Alejandro Fernandez On June 13, 2016, 8

Re: Review Request 48624: Ambari upgrade from 2.2.2 to 2.4.0 fails if cluster name was changed

2016-06-13 Thread Alejandro Fernandez
/UpgradeCatalog240.java (line 2439) <https://reviews.apache.org/r/48624/#comment202506> Sorry, I read it too quickly, I thought these were Ambari usernames and passwords. - Alejandro Fernandez On June 13, 2016, 9:41 a.m., Gaurav Nagar

Re: Review Request 48624: Ambari upgrade from 2.2.2 to 2.4.0 fails if cluster name was changed

2016-06-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48624/#review137354 --- Ship it! Ship It! - Alejandro Fernandez On June 13, 2016, 9

Re: Review Request 48655: ATLAS conf dir needs to be present in all ATLAS hook deployed hosts

2016-06-13 Thread Alejandro Fernandez
/configuration/hive-env.xml (line 238) <https://reviews.apache.org/r/48655/#comment202514> Does this need to change for existing clusters? What about the different stacks? I don't believe ATLAS is even available on HDP 2.2 - Alejandro Fernandez On June 13, 2016, 5:51 p.m

Re: Review Request 48532: AMBARI-17157 Storm 1.0 log4j config update

2016-06-13 Thread Alejandro Fernandez
branch-2.4, commit 3535972f1b98f0898b808ee6a0efd5c97f8f8964 - Alejandro Fernandez On June 10, 2016, 2:45 a.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://review

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-13 Thread Alejandro Fernandez
609/#comment202515> Based on the latest code, we no longer need I believe you want, and take any other defaults. - Alejandro Fernandez On June 13, 2016, 4:02 a.m., Venkat Ranganathan wrote: > > --- > This is a

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/#review137374 --- Ship it! Ship It! - Alejandro Fernandez On June 13, 2016

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-13 Thread Alejandro Fernandez
> On June 10, 2016, 5:40 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml, > > line 889 > > <https://reviews.apache.org/r/48549/diff/1/?file=1414725#file1414725line889> > > > > hos

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136516 --- Ship it! Ship It! - Alejandro Fernandez On June 7, 2016, 4

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Alejandro Fernandez
python/resource_management/libraries/functions/hdp_select.py (line 129) <https://reviews.apache.org/r/48044/#comment201581> Change this to hdp-select status to make it evident what it is doing. - Alejandro Fernandez On June 7, 2016, 12:56 p.m., Laszlo

Re: Review Request 48081: Prefix command execution log lines in agent log

2016-05-31 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48081/#review135682 --- Ship it! Ship It! - Alejandro Fernandez On May 31, 2016, 7

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

2016-05-31 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/#review135701 --- Ship it! Ship It! - Alejandro Fernandez On May 31, 2016, 8

Re: Review Request 47884: Ambari install failure due to zeppelin service install bug

2016-05-31 Thread Alejandro Fernandez
branch-2.4, commit 2ed744dbb2d863c86c73ce51cfa6d9d1d2ba6642 - Alejandro Fernandez On May 27, 2016, 4:03 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47867: RU: install version should be blocked while upgrade in progress

2016-05-25 Thread Alejandro Fernandez
/controller/internal/ClusterStackVersionResourceProvider.java (line 287) <https://reviews.apache.org/r/47867/#comment199843> Nitpicking here, but should check size > 1 - Alejandro Fernandez On May 26, 2016, 12:54 a.m., Nate C

Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-25 Thread Alejandro Fernandez
https://reviews.apache.org/r/47871/diff/ Testing --- Testing on EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm Thanks, Alejandro Fernandez

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Alejandro Fernandez
-2.5.xml (lines 897 - 899) <https://reviews.apache.org/r/47871/#comment200011> During upgrade, the message is shown on the first Storm component, which is NIMBUS. On downgrade, the first component to run is SUPERVISOR - Alejandro Fernandez On May 26, 2016, 1:54 a.m., Ale

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Alejandro Fernandez
nerated e-mail. To reply, visit: https://reviews.apache.org/r/47871/#review135001 ------- On May 26, 2016, 1:54 a.m., Alejandro Fernandez wrote: > > --- > This i

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

2016-05-26 Thread Alejandro Fernandez
--- > > (Updated May 26, 2016, 11:50 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-16890 > https://issues

Re: Review Request 47884: Ambari install failure due to zeppelin service install bug

2016-05-26 Thread Alejandro Fernandez
/0.6.0.2.5/package/scripts/master.py (line 40) <https://reviews.apache.org/r/47884/#comment18> May want to use os.path.join(params.service_packagedir, "scripts/setup_snapshot.sh") since it's safer. - Alejandro Fernandez On May 26, 2016, 12:55 p.m., Renj

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Alejandro Fernandez
: > > ``` > > Delete Storm data on ZK only once > > Delete Storm local data on all Storm hosts > > ``` > > > > Nimbus's cardinality is 1, right? If so, then that's fine - I just want > > to make sure we can't possible be deleting ZK

Re: Review Request 47949: AMBARI-16923. Fix for getting the 'hive.llap.daemon.queue.name' config Property Attributes updated if there is a change in 'capacity-scheduler'.

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47949/#review135264 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 4

Re: Review Request 47963: clean up import * for YARN service

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47963/#review135267 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 4

Re: Review Request 47965: clean up import * for RANGER service

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47965/#review135265 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 4

Re: Review Request 47964: clean up import * for ZOOKEEPER service

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47964/#review135266 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 4

Re: Review Request 47934: clean up import * for SLIDER service scripts in common-services

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47934/#review135271 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 12

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135270 --- Ship it! Ship It! - Alejandro Fernandez On May 26, 2016, 11

Re: Review Request 47962: clean up import * for STORM, TEZ and ZEPPELIN services

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47962/#review135277 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 4

Re: Review Request 47914: AMBARI-16910. Hive Server Interactive. Change the timeout to 120 secs for LLAP alert command.

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47914/#review135272 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 12

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-05-27 Thread Alejandro Fernandez
/functions/copy_tarball.py (line 63) <https://reviews.apache.org/r/47941/#comment200289> Why is the tarball source coming from /tmp? - Alejandro Fernandez On May 27, 2016, 3:33 a.m., Jeff Zhang wrote: > > --- > This is a

Re: Review Request 47955: AMBARI-16906 Express upgrade: Oozie failed to start when user name and group are none-default values

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47955/#review135275 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 2

Re: Review Request 47922: clean up import * for KNOX service scripts in common-services

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47922/#review135269 --- Ship it! Ship It! - Alejandro Fernandez On May 26, 2016, 10

Re: Review Request 47884: Ambari install failure due to zeppelin service install bug

2016-05-27 Thread Alejandro Fernandez
behalf. - Alejandro Fernandez On May 27, 2016, 4:03 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47847: AMBARI-16755 Add spark.driver.extraLibraryPath

2016-05-27 Thread Alejandro Fernandez
> On May 27, 2016, 9:36 p.m., Alejandro Fernandez wrote: > > Ship It! Let me know when you want me to commit this. Also, is this for Ambari 2.4.0 to ship with HDP 2.5? - Alejandro --- This is an automatically generat

Re: Review Request 47847: AMBARI-16755 Add spark.driver.extraLibraryPath

2016-05-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47847/#review135327 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 9

Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers

2016-05-27 Thread Alejandro Fernandez
lue will simply go ahead and change the test anyway. Instead, we should assert that the default values are within a reasonable range. - Alejandro Fernandez On May 27, 2016, 7:18 p.m., Jonathan Hurley wrote: > > --- > This is an automat

Re: Review Request 47526: Hive View : History tab in hive view does not show recent jobs

2016-05-31 Thread Alejandro Fernandez
/controllers/index.js (line 146) <https://reviews.apache.org/r/47526/#comment200775> js can still interpet without the semicolons, but better to add them. - Alejandro Fernandez On May 19, 2016, 10:22 a.m., Nitiraj Rathore

Re: Review Request 48169: Ensure smokeuser HDFS folder exists before running MR, YARN, PIG, OOZIE service checks

2016-06-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48169/#review135964 --- Ship it! Ship It! - Alejandro Fernandez On June 2, 2016, 2

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-02 Thread Alejandro Fernandez
/functions/copy_tarball.py (line 63) <https://reviews.apache.org/r/47941/#comment200977> This tarball should be deleted and recreated every time the service is restarted. - Alejandro Fernandez On May 27, 2016, 3:33 a.m., Jeff Zhang

Re: Review Request 48168: Check new jdbc functionality for SQLA and provide additional testing

2016-06-02 Thread Alejandro Fernandez
;https://reviews.apache.org/r/48168/#comment200982> Can remove this print statement - Alejandro Fernandez On June 2, 2016, 2:28 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-02 Thread Alejandro Fernandez
/functions/hdp_select.py (line 129) <https://reviews.apache.org/r/48044/#comment200970> This cannot assume the directory will be /usr/hdp, instead use stack_root variable. - Alejandro Fernandez On June 2, 2016, 12:55 p.m., Laszlo Puskas

Re: Review Request 48168: Check new jdbc functionality for SQLA and provide additional testing

2016-06-02 Thread Alejandro Fernandez
-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 73) <https://reviews.apache.org/r/48168/#comment200992> If path_to_jdbc is None, should fail here instead of attemping to run the command, which will have the string "None" - Alejandro Fernandez On

Re: Review Request 47913: VDF builder script and XSD should be updated for package-version changes

2016-05-26 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47913/#review135052 --- Ship it! Ship It! - Alejandro Fernandez On May 26, 2016, 7

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Alejandro Fernandez
grades/upgrade-2.5.xml d90d76d Diff: https://reviews.apache.org/r/47871/diff/ Testing (updated) --- Verified EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm Thanks, Alejandro Fernandez

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

2016-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47880/#review135852 --- Ship it! Ship It! - Alejandro Fernandez On May 30, 2016, 9

Re: Review Request 48123: Update default ambari view read timeout to a larger value

2016-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48123/#review135878 --- Ship it! Ship It! - Alejandro Fernandez On June 1, 2016, 11

Re: Review Request 48154: Incorrect ports in WebHDFS HA config in Knox

2016-06-01 Thread Alejandro Fernandez
g/r/48154/#comment200888> This is accessing index 1 without first checking the length - Alejandro Fernandez On June 1, 2016, 8:49 p.m., Sumit Gupta wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 47847: AMBARI-16755 Add spark.driver.extraLibraryPath

2016-05-27 Thread Alejandro Fernandez
branch-2.4, commit c0e8e43f095079784f6b72b2e3e6b926d806eb9c - Alejandro Fernandez On May 27, 2016, 9:11 p.m., Weiqing Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48710: atlas.authentication.principal should be set to atlas/_h...@example.com

2016-06-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48710/#review137620 --- Ship it! Ship It! - Alejandro Fernandez On June 14, 2016

Re: Review Request 48697: AMBARI-17229. Add config 'tez.lib.uris' in tez_hive2/tez-site's pointing to tez_hive2 path jar.

2016-06-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48697/#review137619 --- Ship it! Ship It! - Alejandro Fernandez On June 14, 2016

Re: Review Request 48735: Storm service check failed after Ambari upgrade

2016-06-15 Thread Alejandro Fernandez
. - Alejandro Fernandez On June 15, 2016, 4:59 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48609/#review137814 --- Ship it! Ship It! - Alejandro Fernandez On June 15, 2016, 5

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137621 --- Ship it! Ship It! - Alejandro Fernandez On June 14, 2016

Re: Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

2016-06-14 Thread Alejandro Fernandez
/package/scripts/resourcemanager.py (line 241) <https://reviews.apache.org/r/48683/#comment202819> What guarantees that hdfs keytab will be on the RM host? - Alejandro Fernandez On June 14, 2016, 10:59 a.m., Andrew Onischuk

Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.

2016-06-14 Thread Alejandro Fernandez
/internal/HostResourceProvider.java <https://reviews.apache.org/r/48670/#comment202816> How is this a fix? If a host has any masters, we shouldn't allow deleting it. Slaves must be stopped. Clients can be in any state. - Alejandro Fernandez On June 14, 2016, 12:29 a.m., Ajit

Re: Review Request 48708: Namenode start step failed during EU with RetriableException

2016-06-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48708/#review137623 --- Ship it! Ship It! - Alejandro Fernandez On June 14, 2016, 9

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-14 Thread Alejandro Fernandez
> On June 3, 2016, 9:46 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 32 > > <https://reviews.apache.org/r/47656/diff/5/?file=1405816#file1405816line32> > > > > Let's be consistent with the name, UQ_*

  1   2   3   4   5   6   7   8   9   10   >