Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

2016-05-30 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47995/#review135496 --- committed to trunk and branch-2.4 - Alexandr Antonenko On May

Re: Review Request 49204: Incorrect error message for invalid category in Host Combo Search Box

2016-06-24 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49204/#review139385 --- Ship it! Ship It! - Alexandr Antonenko On June 24, 2016, 4

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

2016-06-27 Thread Alexandr Antonenko
that you changed? If that is so, than why do we need this changes ? p.s. patch looks good and can be committed. - Alexandr Antonenko On Июнь 27, 2016, 3:31 п.п., Di Li wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 49204: Incorrect error message for invalid category in Host Combo Search Box

2016-06-27 Thread Alexandr Antonenko
> On June 24, 2016, 5:07 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you help push it? done - Alexandr --- This is an automatically generated e-mail. To r

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

2016-06-27 Thread Alexandr Antonenko
> On June 27, 2016, 3:45 p.m., Alexandr Antonenko wrote: > > As I understand there was no issue with the logic that you changed? > > If that is so, than why do we need this changes ? > > > > p.s. patch looks good and can be committed. > > Di Li wrote: &g

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123470 --- Ship it! Ship It! - Alexandr Antonenko On March 14, 2016, 3

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Alexandr Antonenko
-- > > (Updated March 14, 2016, 3:59 p.m.) > > > Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr > Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, > Newton Alex, Oleksandr Di

Re: Review Request 45405: AMBARI-15610 Add Service Wizard: invalid host name doesn't prevent proceeding to next page

2016-03-29 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45405/#review125893 --- Ship it! Ship It! - Alexandr Antonenko On March 28, 2016

Re: Review Request 45405: AMBARI-15610 Add Service Wizard: invalid host name doesn't prevent proceeding to next page

2016-03-29 Thread Alexandr Antonenko
> On March 29, 2016, 4:16 p.m., Alexandr Antonenko wrote: > > Ship It! Tested manually, good UX improvement. - Alexandr --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45405/#rev

Re: Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat Satellite option out of experimental

2016-04-06 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45781/#review127306 --- Ship it! Ship It! - Alexandr Antonenko On April 5, 2016, 10

Re: Review Request 45291: When saving repository changes, confirm dialog shows message key instead of actual message

2016-03-24 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45291/#review125277 --- Ship it! Ship It! - Alexandr Antonenko On March 24, 2016, 3

Re: Review Request 44966: In IE, logging out of Ambari Admin View doesn't log user out of web console.

2016-03-21 Thread Alexandr Antonenko
reproduce, and the fix is even more strange. What version of IE you are using ? - Alexandr Antonenko On March 18, 2016, 4:52 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 44966: In IE, logging out of Ambari Admin View doesn't log user out of web console.

2016-03-21 Thread Alexandr Antonenko
/services/Auth.js (line 21) <https://reviews.apache.org/r/44966/#comment187210> next time don't forget to remove unused variable $window - Alexandr Antonenko On March 18, 2016, 4:52 p.m., Sangeeta Ravindran

Re: Review Request 44966: In IE, logging out of Ambari Admin View doesn't log user out of web console.

2016-03-21 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44966/#review124579 --- Ship it! Ship It! - Alexandr Antonenko On March 18, 2016, 4

Re: Review Request 44724: AMBARI-12906: Alert notifications are created even if credential fields are left empty

2016-03-29 Thread Alexandr Antonenko
ly, visit: > https://reviews.apache.org/r/44724/ > --- > > (Updated March 26, 2016, 6:28 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, Jonathan Hurley, and > Richard Zang. > > > Bugs: AMBAR

Re: Review Request 45294: Add OS button on Edit repository version page shows extra space when no repositories have been selected for removal

2016-03-28 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45294/#review125711 --- Ship it! Ship It! - Alexandr Antonenko On March 27, 2016, 8

Re: Review Request 46144: AMBARI-15844: Add conf property UI to show warning of potential duplications among all confType for the service

2016-04-13 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46144/#review128669 --- Ship it! Ship It! - Alexandr Antonenko On April 13, 2016, 1

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Alexandr Antonenko
> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks > > Zhe (Joe) Wang wrote: > Agree. That's why I use FE to set the init

Re: Review Request 46398: Name in create Alert Notification should be restricted to use only alphanumerics, hyphens, spaces and underscores

2016-04-25 Thread Alexandr Antonenko
> On April 20, 2016, 9:46 a.m., Alexandr Antonenko wrote: > > Ship It! > > Anita Jebaraj wrote: > Can you please push the code to trunk, I don't have the priviledge for > that. yes, ofc - Alexandr --- Thi

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130071 --- Ship it! Ship It! - Alexandr Antonenko On April 21, 2016, 6

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Alexandr Antonenko
this out of 2.4. As BE is pretty heavy loaded with tasks - Alexandr Antonenko On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

2016-05-19 Thread Alexandr Antonenko
> On May 18, 2016, 4:01 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks, can you please help push the fix. yes ofc, will do it - Alexandr --- This is an automatically generate

Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

2016-05-19 Thread Alexandr Antonenko
/ambariViews/listTable.html (line 86) <https://reviews.apache.org/r/47539/#comment198586> class="col-sm-3;padding-left-30" --> class names should be delimited by simple space, using sign ";" is wrong. I commit with that change. - Alexandr Antonenko On May 18, 2016,

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

2016-05-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47514/#review133814 --- Ship it! Ship It! - Alexandr Antonenko On May 18, 2016, 7

Re: Review Request 47599: Add validation for alert name edit

2016-05-19 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47599/#review133961 --- Ship it! Ship It! - Alexandr Antonenko On May 19, 2016, 4

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

2016-05-19 Thread Alexandr Antonenko
> On May 18, 2016, 9:15 p.m., Alexandr Antonenko wrote: > > Ship It! > > Anita Jebaraj wrote: > Thank you Alex, can you please help me to push the changes no problem. yes ofc, I will commit - Alexandr --- This i

Re: Review Request 47480: AMBARI-16714: Pull 'Groups' txt shown on Alert details filters from the messages.js file

2016-05-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47480/#review133758 --- Ship it! Ship It! - Alexandr Antonenko On May 17, 2016, 6

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

2016-05-18 Thread Alexandr Antonenko
/step1_controller.js (line 130) <https://reviews.apache.org/r/47514/#comment198353> Please use setEach options.forEach(function (option) { option.preConditions.setEach('checked', false) }) - Alexandr Antonenko On May 18, 2016, 5:21 a.m., Anita Jebaraj

Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

2016-05-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47539/#review133757 --- Ship it! Ship It! - Alexandr Antonenko On May 18, 2016, 3

Re: Review Request 46398: Name in create Alert Notification should be restricted to use only alphanumerics, hyphens, spaces and underscores

2016-04-20 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46398/#review129717 --- Ship it! Ship It! - Alexandr Antonenko On April 19, 2016, 6

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-20 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review129716 --- Ship it! Ship It! - Alexandr Antonenko On April 19, 2016, 8

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-21 Thread Alexandr Antonenko
> On April 21, 2016, 11:23 a.m., Alexandr Antonenko wrote: > > ambari-web/app/mixins/wizard/assign_master_components.js, line 978 > > <https://reviews.apache.org/r/46405/diff/1/?file=1351600#file1351600line978> > > > > This check can be simplified, after you

Re: Review Request 49387: Support password type for custom properties

2016-07-26 Thread Alexandr Antonenko
> On July 25, 2016, 9:08 p.m., Alexandr Antonenko wrote: > > Ship It! > > Keta Patel wrote: > Thank you Alexandr! > Could you please help with pushing in the changes? done - Alexandr --- This is an auto

Re: Review Request 49387: Support password type for custom properties

2016-07-25 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review143428 --- Ship it! Ship It! - Alexandr Antonenko On July 25, 2016, 8

Re: Review Request 49387: Support password type for custom properties

2016-07-25 Thread Alexandr Antonenko
> On July 20, 2016, 11:17 p.m., Alexandr Antonenko wrote: > > ambari-web/app/utils/config.js, line 264 > > <https://reviews.apache.org/r/49387/diff/3-4/?file=1445954#file1445954line264> > > > > I do not see FINAL populated anywhere. I think this code will t

Re: Review Request 49387: Support password type for custom properties

2016-07-20 Thread Alexandr Antonenko
ip cheking attributes[0][FINAL][index], just check attributes[0][FINAL][index] === "true". If property "attributes[0][FINAL][index]" does not exist attributes[0][FINAL][index] === "true" will not trigger any error - Alexan

Re: Review Request 49387: Support password type for custom properties

2016-07-20 Thread Alexandr Antonenko
tps://reviews.apache.org/r/49387/#comment208608> When you see so many if statements, the first thing that comes to mind that this needs to be optimized ))) Please put "final", "password", "user" and other to array and use this array in cycle - Alexandr Antonenko

Re: Review Request 49393: Incorrect error message for view URL name and short URL validation

2016-07-05 Thread Alexandr Antonenko
> On July 5, 2016, 2:23 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Alexandr. Can you help commit the change. done - Alexandr --- This is an automatically generate

Re: Review Request 49385: Hive and Oozie db displayed incorrectly on the installer review page

2016-07-06 Thread Alexandr Antonenko
> On July 6, 2016, 1:52 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you help push the fix. done - Alexandr --- This is an automatically generated e-mail. To r

Re: Review Request 49385: Hive and Oozie db displayed incorrectly on the installer review page

2016-07-06 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49385/#review140987 --- Ship it! Ship It! - Alexandr Antonenko On June 30, 2016, 8

Re: Review Request 49393: Incorrect error message for view URL name and short URL validation

2016-07-05 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49393/#review140777 --- Ship it! Ship It! - Alexandr Antonenko On June 29, 2016, 7

Re: Review Request 50542: AMBARI-17936 Log search tab seems to be visible for all user roles

2016-07-28 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50542/#review143957 --- Ship it! Ship It! - Alexandr Antonenko On Июль 27, 2016, 11

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-06-30 Thread Alexandr Antonenko
(line 196) <https://reviews.apache.org/r/49287/#comment205425> this will not work out, as there is no hive-env, only "hive-site". You have to do a request to get this config - Alexandr Antonenko On June 27, 2016, 11:20 p.m., Ani

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-07-01 Thread Alexandr Antonenko
> On June 30, 2016, 8:23 a.m., Alexandr Antonenko wrote: > > ambari-web/app/views/main/host/details/host_component_view.js, line 196 > > <https://reviews.apache.org/r/49287/diff/1/?file=1431320#file1431320line196> > > > > this will not work out, as there is n

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-07-01 Thread Alexandr Antonenko
> On July 1, 2016, 2:58 p.m., Alexandr Antonenko wrote: > > Ship It! > > Anita Jebaraj wrote: > can you please help in pushing the code. done - Alexandr --- This is an automatically generated e-mail. To r

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-07-01 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49287/#review140362 --- Ship it! Ship It! - Alexandr Antonenko On June 27, 2016, 11

Re: Review Request 55586: Cannot change group/user privileges in list view if the user has VIEW.USER privilege

2017-01-25 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55586/#review162944 --- Ship it! Ship It! - Alexandr Antonenko On Jan. 23, 2017, 5

Re: Review Request 56772: Storm config change results in Consistency check failed

2017-02-16 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56772/#review165892 --- Ship it! Ship It! - Alexandr Antonenko On Feb. 16, 2017, 11

Re: Review Request 57066: Ambari Web unit tests aren't running

2017-02-25 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57066/#review166809 --- Ship it! Ship It! - Alexandr Antonenko On Feb. 25, 2017, 11

Re: Review Request 57051: Move spinner for Next and Back button in Kerberos Wizard

2017-02-24 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57051/#review166774 --- Ship it! Ship It! - Alexandr Antonenko On Feb. 24, 2017, 10

Re: Review Request 56985: Ambari logo is not displayed

2017-02-23 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56985/#review166534 --- Ship it! Ship It! - Alexandr Antonenko On Feb. 23, 2017, 4

Re: Review Request 55628: Add/delete host component: visual changes for configuration popup

2017-01-17 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55628/#review161882 --- Ship it! Ship It! - Alexandr Antonenko On Jan. 17, 2017, 4

Re: Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

2016-09-06 Thread Alexandr Antonenko
is slow, which would allow enough time to click the Next button multiple times -> Even when I set throttling to 50 kb/s and delay 500ms (the slowest setting in chrome network tab) I'm unable to reproduce I think what we have in router for step 4 is enough to prevent multiple clicks - Al

Re: Review Request 51677: AMBARI-18327: multiple clicks on "Next" button of Step-4 (Choose Services) causes skipping of steps while installing a cluster

2016-09-08 Thread Alexandr Antonenko
> On Sept. 7, 2016, 4:56 a.m., Alexandr Antonenko wrote: > > In step-4 the flag "nextBtnClickInProgress" was not set anywhere -> We set > > nextBtnClickInProgress in router for step 4 > > > > So if a timeout was manually added in the "submit&quo

Re: Review Request 52397: Delete group button always shows tooltip "Cannot Delete Group"

2016-09-29 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52397/#review150874 --- Ship it! Ship It! - Alexandr Antonenko On Sept. 29, 2016, 4

Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered

2016-09-29 Thread Alexandr Antonenko
> On Sept. 29, 2016, 5:26 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you please help push the fix. np done - Alexandr --- This is an automatically generate

Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered

2016-09-29 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52396/#review150877 --- Ship it! Ship It! - Alexandr Antonenko On Sept. 29, 2016, 4

Re: Review Request 52430: Include an option to download the saved query in hive view

2016-10-04 Thread Alexandr Antonenko
from java developer - Alexandr Antonenko On Oct. 3, 2016, 11:25 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52455: Ambari UI changes to support PAM authentication

2016-10-04 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review151355 --- Ship it! Ship It! - Alexandr Antonenko On Oct. 4, 2016, 4

Re: Review Request 52455: Ambari UI changes to support PAM authentication

2016-10-04 Thread Alexandr Antonenko
> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote: > > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162 > > <https://reviews.apache.org/r/52455/diff/1/?file=1517321#file1517321line162> > > > > I don't see this newly created file

Re: Review Request 51894: View instance cloning functionality

2016-09-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51894/#review149364 --- Ship it! Ship It! - Alexandr Antonenko On Sept. 16, 2016

Re: Review Request 51894: View instance cloning functionality

2016-09-15 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51894/#review149041 --- Ship it! Ship It! - Alexandr Antonenko On Sept. 14, 2016, 6

Re: Review Request 51894: View instance cloning functionality

2016-09-20 Thread Alexandr Antonenko
> On Sept. 18, 2016, 11:51 a.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Alexandr. Can you please help push the fix? > > Sangeeta Ravindran wrote: > Thanks Alexandr for pus

Re: Review Request 52455: Ambari UI changes to support PAM authentication

2016-10-03 Thread Alexandr Antonenko
(line 162) <https://reviews.apache.org/r/52455/#comment219386> I don't see this newly created file in diff files list. You were able to build UI without this files ? UI should fail upon building because of declared file that does not exist - Alexandr Antonenko On Sept. 30, 2016, 10:

Re: Review Request 52397: Delete group button always shows tooltip "Cannot Delete Group"

2016-10-03 Thread Alexandr Antonenko
> On Sept. 29, 2016, 5:25 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you please help push the fix? done - Alexandr --- This is an automatically generate

Re: Review Request 53647: Issues after fast switching service page tabs

2016-11-11 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53647/#review155714 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 11, 2016, 1

Re: Review Request 53647: Issues after fast switching service page tabs

2016-11-10 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53647/#review155590 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 10, 2016, 2

Re: Review Request 53140: Include an option to upload query in hive-view

2016-10-24 Thread Alexandr Antonenko
> On Oct. 24, 2016, 6:57 p.m., Alexandr Antonenko wrote: > > Ship It! > > Anita Jebaraj wrote: > Thank you...Can you please help in pushing the code? done - Alexandr --- This is an automatically generated e-mai

Re: Review Request 53140: Include an option to upload query in hive-view

2016-10-24 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53140/#review153724 --- Ship it! Ship It! - Alexandr Antonenko On Oct. 24, 2016, 4

Re: Review Request 54127: Create smart config tab for Hive and Oozie Database settings

2016-11-28 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54127/#review157040 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 28, 2016, 3

Re: Review Request 53880: Can't change capacity-scheduler's queue capacity from the YARN config page, even though its shown as text box

2016-11-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53880/#review156334 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 18, 2016, 4

Re: Review Request 53907: Add Service wizard: Allow adding slave components from different service conditionally

2016-11-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53907/#review156351 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 18, 2016, 11

Re: Review Request 54491: Manage Journalnode Wizard: incorrect number of installed JournalNodes

2016-12-07 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54491/#review158382 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 7, 2016, 7

Re: Review Request 54734: BG operations modal windows are too small to show the content (in certain scenarios) [Chrome]

2016-12-14 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54734/#review159127 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 14, 2016, 10

Re: Review Request 54738: Kerberos advanced tab. Page wasn't refreshed after save changes. Save button is disabled.

2016-12-14 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54738/#review159137 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 14, 2016, 11

Re: Review Request 54789: Integrate karma with babel preprocessor

2016-12-15 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54789/#review159344 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 15, 2016, 5

Re: Review Request 54703: Add host component should show configs being changed in recommendation popup modal

2016-12-13 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54703/#review158994 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 13, 2016, 1

Re: Review Request 54707: Metrics Collector Move Wizard should no longer Restart All Services

2016-12-13 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54707/#review159013 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 13, 2016, 4

Re: Review Request 54704: Remove UI logic to set or expect hive_server_interactive_host

2016-12-13 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54704/#review159047 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 13, 2016, 6

Re: Review Request 54482: Tooltip is not hidden on host alerts page

2016-12-07 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54482/#review158337 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 7, 2016, 3

Re: Review Request 54668: Version in process of downgrade isn't displayed by selecting any filter

2016-12-12 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54668/#review158891 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 12, 2016, 5

Re: Review Request 54667: Add Service Page in Atlas doesn't show config on change

2016-12-12 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54667/#review158882 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 12, 2016, 5

Re: Review Request 55523: When viewing details of a group, the group type is sometimes empty

2017-01-13 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55523/#review161640 --- Ship it! Ship It! - Alexandr Antonenko On Jan. 13, 2017, 9

Re: Review Request 54163: Add Service Wizard: error thrown during transition on deploy step

2016-11-29 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54163/#review157245 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 29, 2016, 1

Re: Review Request 54202: Add Host Wizard: validation failed on Assign Slaves step

2016-11-30 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54202/#review157394 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 30, 2016, 10

Re: Review Request 55052: Dependent configurations are not loaded if value is set via "Set recommended" button

2016-12-30 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55052/#review160295 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 27, 2016, 7

Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

2016-12-20 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54911/#review159782 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 20, 2016, 8

Re: Review Request 54855: Delete host component should show configs being changed in recommendation popup modal

2016-12-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54855/#review159589 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 19, 2016, 7

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

2017-03-22 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57721/#review169780 --- Ship it! Ship It! - Alexandr Antonenko On March 22, 2017, 1

Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-17 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/#review169303 --- Ship it! Ship It! - Alexandr Antonenko On March 16, 2017

Re: Review Request 58591: Roles page in Ambari UI shows extra rows in IE browser

2017-04-21 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58591/#review172589 --- Ship it! Ship It! - Alexandr Antonenko On April 20, 2017, 8

Re: Review Request 57525: Assign Slaves and Clients page displays incorrect configuration unless a change is made in Assign Masters page

2017-03-13 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57525/#review168781 --- Ship it! Ship It! - Alexandr Antonenko On March 11, 2017

Re: Review Request 57280: While Comparing versions, value in latest version is not shown for custom property

2017-03-03 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57280/#review167810 --- Ship it! Ship It! - Alexandr Antonenko On March 3, 2017, 11

Re: Review Request 57290: Despite user selecting not to apply Config Changes, Changes are being applied

2017-03-03 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57290/#review167830 --- Ship it! Ship It! - Alexandr Antonenko On March 3, 2017, 3

Re: Review Request 57214: Unexpected popup after disable kerberos "You are in the process of disabling security on your cluster"

2017-03-01 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57214/#review167566 --- Ship it! Ship It! - Alexandr Antonenko On March 1, 2017, 8

Re: Review Request 58637: AMBARI-20826 - HIVE "Quick Links" section showing Graphana related quicklinks when Graphana is not installed

2017-04-24 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58637/#review172782 --- Ship it! Ship It! - Alexandr Antonenko On April 22, 2017, 2

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

2017-05-11 Thread Alexandr Antonenko
roller'), because I didn't saw any chekings regaring this in your code - Alexandr Antonenko On May 11, 2017, 7:02 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

2017-05-16 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58864/#review175111 --- Ship it! Ship It! - Alexandr Antonenko On May 11, 2017, 7

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

2017-05-17 Thread Alexandr Antonenko
> On May 16, 2017, 3:14 p.m., Alexandr Antonenko wrote: > > Ship It! > > Amruta Borkar wrote: > Thank you Alexandr. Could you please help me push this to trunk? done - Alexandr --- This is an automaticall

Re: Review Request 59756: Delete view privileges from the Groups page

2017-06-27 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59756/#review178957 --- Ship it! Ship It! - Alexandr Antonenko On June 2, 2017, 6

  1   2   >