Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48262/#review136289 --- Ship it! Ship It! - Aravindan Vijayan On June 6, 2016, 6:26

Re: Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

2016-06-07 Thread Aravindan Vijayan
that, I can do that for you. - Aravindan Vijayan On June 3, 2016, 12:43 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48321/#review136481 --- Ship it! LGTM - Aravindan Vijayan On June 7, 2016, 2:25 p.m

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Aravindan Vijayan
. - Aravindan Vijayan On June 9, 2016, 1:58 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

2016-06-09 Thread Aravindan Vijayan
> On June 7, 2016, 3:07 p.m., Aravindan Vijayan wrote: > > Has this been checked in? If you need help doing that, I can do that for > > you. > > Jungtaek Lim wrote: > No it's not checked in yet. Please check this in. Thanks! Thank you Jungtaek. Patch has been

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-10 Thread Aravindan Vijayan
here M1 - t1 - 5.0 M1 - t2 - 5.0 M2 - t2 - 5.0 M3 - t3 - 5.0 The graph will show up like (t1, 5.0) -> (t2,10.0) -> (t3,5.0) That is why we do some "interpolation" while we aggregate data. - Aravindan Vijayan On June 10

Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread Aravindan Vijayan
/timeline/HadoopTimelineMetricsSink.java 0580088 Diff: https://reviews.apache.org/r/48508/diff/ Testing --- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review136855 --- Please add Dmitry Sen as well. Thanks - Aravindan Vijayan

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread Aravindan Vijayan
-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 0580088 Diff: https://reviews.apache.org/r/48508/diff/ Testing --- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Aravindan Vijayan
> On June 9, 2016, 5:42 p.m., Aravindan Vijayan wrote: > > Please add Dmitry Sen as well. Thanks > > Jungtaek Lim wrote: > Could you tell what's Dmitry's ID? Auto-complete can't find Dmitry Sen.

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Aravindan Vijayan
for the UI changes. - Aravindan Vijayan On June 8, 2016, 6:27 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

2016-05-25 Thread Aravindan Vijayan
ly tested on cluster. Added unit tests. Thanks, Aravindan Vijayan

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-14 Thread Aravindan Vijayan
It' from a UI developer as well. - Aravindan Vijayan On June 10, 2016, 12:50 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-31 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review135658 --- Ship it! Ship It! - Aravindan Vijayan On May 31, 2016, 2:54

Re: Review Request 48079: Capture user based metrics for Namenode fair call queue.

2016-05-31 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48079/#review135659 --- Ship it! Ship It! - Aravindan Vijayan On May 31, 2016, 5:07

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-27 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review135239 --- Ship it! Ship It! - Aravindan Vijayan On May 27, 2016, 2:28

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

2016-05-26 Thread Aravindan Vijayan
g/r/47856/diff/ Testing --- Manually tested on cluster. Added unit tests. Thanks, Aravindan Vijayan

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

2016-05-26 Thread Aravindan Vijayan
nterpolation. I will remove it. - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47856/#review134988 ------- On May

Re: Review Request 47953: Add ability to query all hosts using hostname=% through AMS API.

2016-05-27 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47953/#review135240 --- Ship it! Ship It! - Aravindan Vijayan On May 27, 2016, 12

Review Request 48087: AMBARI-16969 : Provide ability in AMS to filter tracked metrics through a whitelist metic file.

2016-05-31 Thread Aravindan Vijayan
. Thanks, Aravindan Vijayan

Re: Review Request 48607: AMBARI-17181: Add some of value-attributes to property files in AMBARI_METRICS

2016-06-15 Thread Aravindan Vijayan
? - Aravindan Vijayan On June 13, 2016, 12:18 a.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 49030: Ambari agent log contains failures for AMS status commands

2016-06-21 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49030/#review138873 --- Ship it! Ship It! - Aravindan Vijayan On June 21, 2016, 4

Review Request 48985: AMBARI-17325 : Ambari Metrics service check failed exceed timeout due to invalid Phoenix JARS

2016-06-20 Thread Aravindan Vijayan
--server.jar Diffs - ambari-metrics/ambari-metrics-timelineservice/pom.xml a68d08f ambari-metrics/pom.xml b216635 Diff: https://reviews.apache.org/r/48985/diff/ Testing --- mvn clean package. Thanks, Aravindan Vijayan

Re: Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Aravindan Vijayan
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/48750/#review137834 ------- On June 15, 2016, 8:29 p.m., Aravindan Vijayan wrote: > > --- > This is an au

Re: Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Aravindan Vijayan
:38.840s [INFO] Finished at: Wed Jun 15 13:13:20 PDT 2016 [INFO] Final Memory: 206M/1529M [INFO] Thanks, Aravindan Vijayan

Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Aravindan Vijayan
] Total time: 8:38.840s [INFO] Finished at: Wed Jun 15 13:13:20 PDT 2016 [INFO] Final Memory: 206M/1529M [INFO] Thanks, Aravindan Vijayan

Re: Review Request 48607: AMBARI-17181: Add some of value-attributes to property files in AMBARI_METRICS

2016-06-16 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48607/#review138067 --- Ship it! Ship It! - Aravindan Vijayan On June 16, 2016, 3

Review Request 49282: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents process shutdown

2016-06-27 Thread Aravindan Vijayan
-MASTER.j2 481bafa ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 becfa7a Diff: https://reviews.apache.org/r/49282/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Aravindan Vijayan
/UpgradeCatalog222.java (line 90) <https://reviews.apache.org/r/44792/#comment185708> Minor. Most of these variables will not be required after this change. - Aravindan Vijayan On March 14, 2016, 5:25 p.m., Dmytro Sen

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44792/#review123463 --- Ship it! Ship It! - Aravindan Vijayan On March 14, 2016, 5

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Aravindan Vijayan
--- On March 14, 2016, 5:25 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44792/ > --- > > (Update

Review Request 44811: AMBARI-15413 : Metrics Grafana Failed to start

2016-03-14 Thread Aravindan Vijayan
/test_metrics_grafana.py 43d5ad0 Diff: https://reviews.apache.org/r/44811/diff/ Testing --- Manual testing done. Python unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 44811: AMBARI-15413 : Metrics Grafana Failed to start

2016-03-14 Thread Aravindan Vijayan
ge/scripts/metrics_grafana_util.py 593591c ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py 43d5ad0 Diff: https://reviews.apache.org/r/44811/diff/ Testing --- Manual testing done. Python unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 44817: Grafana password is required field after upgrade from 2.2.0 to 2.2.2

2016-03-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44817/#review123559 --- Ship it! Ship It! - Aravindan Vijayan On March 15, 2016, 12

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Aravindan Vijayan
-metrics-collector (line 376) <https://reviews.apache.org/r/44525/#comment184895> Quick question, why do we need a leading ":" in these statements? - Aravindan Vijayan On March 9, 2016, 8:59 p.m., Shanta

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44525/#review122828 --- Ship it! Ship It! - Aravindan Vijayan On March 9, 2016, 8

Re: Review Request 45447: AMBARI-15621 : Cluster Second aggregator taking more than 2 mins to execute on large clusters, thereby causing lag.

2016-03-30 Thread Aravindan Vijayan
ggregators/AbstractTimelineAggregatorTest.java 21b9839 ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py b8e2c45 Diff: https://reviews.apache.org/r/45447/diff/ Testing --- Manually tested on a large cluster. Unit tests pass. Thanks, Aravindan Vijayan

Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

2016-03-30 Thread Aravindan Vijayan
n/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java e67a5b8 Diff: https://reviews.apache.org/r/45518/diff/ Testing --- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

2016-04-07 Thread Aravindan Vijayan
/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java 6bf15c7 Diff: https://reviews.apache.org/r/45845/diff/ Testing --- Manually tested all charts in Ambari Web in all time ranges. Triggered exception message through Grafana. Thanks, Aravindan

Re: Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.

2016-04-07 Thread Aravindan Vijayan
. Thanks, Aravindan Vijayan

Review Request 45772: AMBARI-15638 [AMS] Sum Calculation Incorrect (Patch 2)

2016-04-05 Thread Aravindan Vijayan
://reviews.apache.org/r/45772/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

2016-04-06 Thread Aravindan Vijayan
-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 6a231c2 Diff: https://reviews.apache.org/r/45845/diff/ Testing --- Thanks, Aravindan Vijayan

Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-12 Thread Aravindan Vijayan
CESS [INFO] [INFO] Total time: 1:03:35.031s [INFO] Finished at: Mon Apr 11 11:03:19 PDT 2016 [INFO] Final Memory: 102M/1015M [INFO] Thanks, Aravindan Vijayan

Re: Review Request 45772: AMBARI-15638 [AMS] Sum Calculation Incorrect (Patch 2)

2016-04-05 Thread Aravindan Vijayan
ted e-mail. To reply, visit: https://reviews.apache.org/r/45772/#review127209 ------- On April 5, 2016, 8:14 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically gener

Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.

2016-04-07 Thread Aravindan Vijayan
46bc6f8 ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java 512a7db Diff: https://reviews.apache.org/r/45846/diff/ Testing --- Manually tested. Added unit tests.

Re: Review Request 46018: HDFS script alerts moved to UNKNOWN status with "Unable to calculate the standard deviation for 1 datapoints"

2016-04-11 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46018/#review128160 --- Ship it! Ship It! - Aravindan Vijayan On April 11, 2016, 11

Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Aravindan Vijayan
/org/apache/ambari/server/controller/utilities/PropertyHelper.java 87a1ab1 Diff: https://reviews.apache.org/r/46037/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Aravindan Vijayan
anks, Aravindan Vijayan

Review Request 46047: AMBARI-15812 : Changes to widgets to incorporate "rate" function in AMS not done in Upgrade path.

2016-04-11 Thread Aravindan Vijayan
2Test.java cc5a04d Diff: https://reviews.apache.org/r/46047/diff/ Testing --- UpgradeCatalog tests pass. Manual testing pending. Thanks, Aravindan Vijayan

Re: Review Request 46047: AMBARI-15812 : Changes to widgets to incorporate "rate" function in AMS not done in Upgrade path.

2016-04-11 Thread Aravindan Vijayan
INFO [main] UpgradeCatalog222:601 - Update widget definition for HDFS corrupted blocks metric 11 Apr 2016 20:26:00,494 INFO [main] AbstractUpgradeCatalog:464 - Applying configuration with tag 'version1460406360491' to cluster 'c1' Thanks, Aravindan Vijayan

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

2016-03-21 Thread Aravindan Vijayan
unit tests. Thanks, Aravindan Vijayan

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

2016-03-21 Thread Aravindan Vijayan
: https://reviews.apache.org/r/45150/diff/ Testing --- Manual testing done. Added unit tests. Thanks, Aravindan Vijayan

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

2016-03-22 Thread Aravindan Vijayan
eviews.apache.org/r/45150/#review124856 --- On March 22, 2016, 7:44 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

2016-03-22 Thread Aravindan Vijayan
-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 599ac3e ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 41da868 Diff: https://reviews.apache.org/r/45150/diff/ Testing --- Manual testing done. Added unit tests. Thanks, Aravindan

Review Request 45250: AMBARI-15540 : NAMENODE critical alert is present [Percentage standard deviation] after upgrade from 2.0.2/ 2.2.1.0 etc to 2.2.2.0 and disabling security

2016-03-23 Thread Aravindan Vijayan
ard deviation value 218.17% is beyond the critical threshold of 200.00%" } }, {code} Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py f62c4a3 Diff: https://reviews.apache.org/r/45250/diff/ Testing --- Thanks, Aravindan Vijayan

Re: Review Request 45250: AMBARI-15540 : NAMENODE critical alert is present [Percentage standard deviation] after upgrade from 2.0.2/ 2.2.1.0 etc to 2.2.2.0 and disabling security

2016-03-23 Thread Aravindan Vijayan
text" : "CRITICAL. Percentage standard deviation value 218.17% is beyond the critical threshold of 200.00%" } }, {code} Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py f62c4a3 Diff: https://reviews.apache.org/r/45250/diff/ Testing (updated) --- Manual testing done Thanks, Aravindan Vijayan

Re: Review Request 45250: AMBARI-15540 : NAMENODE critical alert is present [Percentage standard deviation] after upgrade from 2.0.2/ 2.2.1.0 etc to 2.2.2.0 and disabling security

2016-03-24 Thread Aravindan Vijayan
ps://reviews.apache.org/r/45250/#review125213 ------- On March 23, 2016, 8:46 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail.

Review Request 45322: AMBARI-15571 : Disable YARN Container metrics from AMS

2016-03-24 Thread Aravindan Vijayan
://reviews.apache.org/r/45322/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 45322: AMBARI-15571 : Disable YARN Container metrics from AMS

2016-03-24 Thread Aravindan Vijayan
/alert_metrics_deviation.py 3c9c5c5 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 fcd9b23 Diff: https://reviews.apache.org/r/45322/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

2016-04-04 Thread Aravindan Vijayan
sted. Unit tests pass. Thanks, Aravindan Vijayan

Review Request 45447: AMBARI-15621 : Cluster Second aggregator taking more than 2 mins to execute on large clusters, thereby causing lag.

2016-03-29 Thread Aravindan Vijayan
stacks/HDP/2.0.6/services/stack_advisor.py b8e2c45 Diff: https://reviews.apache.org/r/45447/diff/ Testing --- Manually tested on a large cluster. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

2016-03-31 Thread Aravindan Vijayan
L.java e67a5b8 Diff: https://reviews.apache.org/r/45518/diff/ Testing --- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

2016-03-31 Thread Aravindan Vijayan
D table, we have changed it in the read path. - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45518/#review126290 --------

Re: Review Request 45374: Use ">>" instead of ">" to write ambari-metrics-collector.out

2016-03-31 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45374/#review126492 --- Ship it! Ship It! - Aravindan Vijayan On March 30, 2016, 2

Re: Review Request 45665: AMBARI-15680 : METRICS_GRAFANA START failed with 401 Unauthorized Error

2016-04-04 Thread Aravindan Vijayan
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45665/#review126789 --- On April 4, 2016, 4:41 a.m., Aravindan Vijayan wrote: > > ---

Review Request 45696: AMBARI-15692 : AMS-HBase should explicitly set its HBASE_HOME path

2016-04-04 Thread Aravindan Vijayan
on cluster where AMS co-existed with cluster HBase. Thanks, Aravindan Vijayan

Re: Review Request 45696: AMBARI-15692 : AMS-HBase should explicitly set its HBASE_HOME path

2016-04-04 Thread Aravindan Vijayan
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 3723ff8 Diff: https://reviews.apache.org/r/45696/diff/ Testing --- Manually tested on cluster where AMS co-existed with cluster HBase. Thanks, Aravindan Vijayan

Review Request 45665: AMBARI-15680 : METRICS_GRAFANA START failed with 401 Unauthorized Error

2016-04-03 Thread Aravindan Vijayan
ore.exceptions.Fail: Ambari Metrics Grafana data source creation failed. POST request status: 401 Unauthorized \n{\"message\":\"Invalid username or password\"}", {code} Diffs - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py 012bdcb Diff: https://reviews.apache.org/r/45665/diff/ Testing --- Manual testing done Python unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Aravindan Vijayan
check if something similar is not already present in StackAdvisorResourceProvider or somewhere else? If there is no such method, we can go with this. - Aravindan Vijayan On April 22, 2016, 8:47 p.m., Robert Levas wrote

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Aravindan Vijayan
> On April 22, 2016, 8:58 p.m., Aravindan Vijayan wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 2433 > > <https://reviews.apache.org/r/46583/diff/1/?file=1357896#file1357896line2433> > > > &g

Review Request 46508: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics (Patch 2)

2016-04-21 Thread Aravindan Vijayan
/YARN_widgets.json c2acf1f ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java f543f18 Diff: https://reviews.apache.org/r/46508/diff/ Testing --- Unit tests passed. Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 46667: Ambari agent changes to push hive metrics to AMS

2016-04-26 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46667/#review130640 --- AMS changes LGTM. - Aravindan Vijayan On April 26, 2016, 4:08

Re: Review Request 46667: Ambari agent changes to push hive metrics to AMS

2016-04-26 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46667/#review130642 --- Ship it! Ship It! - Aravindan Vijayan On April 26, 2016, 4

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Aravindan Vijayan
/KerberosHelperImpl.java (line 2433) <https://reviews.apache.org/r/46583/#comment193862> I meant this method. - Aravindan Vijayan On April 22, 2016, 8:47 p.m., Robert Levas wrote: > > --- > This is an automatically g

Review Request 47734: AMBARI-15898 : Grafana fails to start when using custom data directory

2016-05-23 Thread Aravindan Vijayan
st.java 606fc72 Diff: https://reviews.apache.org/r/47734/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 47747: Support round-robin scheduling with failover for Sinks with distributed collector

2016-05-23 Thread Aravindan Vijayan
t; > (Updated May 23, 2016, 11:25 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-16828 > https://issues.apache.org/jira/browse/AMBARI-16828 > > > Repository: ambari > > > Descript

Review Request 47800: AMBARI-16860 : Disable HBase per user and per table metrics by default

2016-05-24 Thread Aravindan Vijayan
-hbase.properties-GANGLIA-MASTER.j2 3202605 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 5a91866 Diff: https://reviews.apache.org/r/47800/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Review Request 47811: AMBARI-16862 : [Grafana] Rename "HBase - Performance" dashboard to "HBase - RegionServers"

2016-05-24 Thread Aravindan Vijayan
/package/scripts/metrics_grafana_util.py a02c100 Diff: https://reviews.apache.org/r/47811/diff/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
views.apache.org/r/47142/diff/ Testing --- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
in hostname list is valid. Hence cannot use this util method. - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132515 -

Review Request 47184: AMBARI-16435 : Change Namenode Total File operations widget to request rate metric instead of actual metric.

2016-05-10 Thread Aravindan Vijayan
. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
-- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
-- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
icStore.java 16bbf0e ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java 277a98c Diff: https://reviews.apache.org/r/47142/diff/ Testing --- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132515 ------- On May 10, 2016, 6:41 p.m., Aravindan Vijayan wrote: > > --- &

Review Request 47244: AMBARI-16440 : Flush metrics to collector if metric system is stopped gracefully in the Sink daemon

2016-05-11 Thread Aravindan Vijayan
/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java 35b9459 Diff: https://reviews.apache.org/r/47244/diff/ Testing --- Manually tested. Unit tests pending. Thanks, Aravindan Vijayan

Re: Review Request 47438: HDFS Alerts: add minimum values to AMS alerts

2016-05-17 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47438/#review133661 --- Ship it! Ship It! - Aravindan Vijayan On May 17, 2016, 12

Re: Review Request 47420: Support grafana dashboards to be defined based on stack

2016-05-16 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47420/#review133411 --- Ship it! Ship It! - Aravindan Vijayan On May 16, 2016, 6:49

Review Request 47369: AMBARI-16666 : AMS Service check fails because collector takes too long to start up.

2016-05-13 Thread Aravindan Vijayan
. Thanks, Aravindan Vijayan

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
s an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132356 --- On May 9, 2016, 11:50 p.m., Aravindan Vijayan wrote: > > --- > This

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
-- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 46238: Refactor Metadata manager for supporting distributed collector

2016-04-15 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46238/#review129135 --- Ship it! Ship It! - Aravindan Vijayan On April 14, 2016, 11

Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

2016-04-14 Thread Aravindan Vijayan
19a112 Diff: https://reviews.apache.org/r/46219/diff/ Testing --- Unit tests pass. Manual widget testing done. Manual upgrade testing pending. Thanks, Aravindan Vijayan

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

2016-04-14 Thread Aravindan Vijayan
urces/stacks/HDP/2.3/services/HDFS/widgets.json a19a112 Diff: https://reviews.apache.org/r/46219/diff/ Testing (updated) --- Unit tests pass. Manual widget testing done. Manual upgrade testing done. Thanks, Aravindan Vijayan

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

2016-04-14 Thread Aravindan Vijayan
mark Ship It if the changes look ok? - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46219/#review128977 ------- On

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
k it up. It should also go into the Upgrade path so that this config gets added to the service on Upgrade. Perhaps, we can use another JIRA to track that. - Aravindan Vijayan On April 18, 2016, 7:04 p.m., Jian He wrote: > >

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
> On April 18, 2016, 8:19 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java, > > line 57 > > <https://reviews.apache.

Re: Review Request 46342: AMBARI-15952 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
the review. - Aravindan Vijayan On April 18, 2016, 11:24 p.m., Jian He wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 46413: AMBARI-15982 : AMS metrics gaps/inconsistencies in data

2016-04-19 Thread Aravindan Vijayan
/UpgradeCatalog240Test.java e3e8d35 Diff: https://reviews.apache.org/r/46413/diff/ Testing --- Manually tested upgrade. Thanks, Aravindan Vijayan

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129444 --- Ship it! Looks good to me. - Aravindan Vijayan On April 18

  1   2   3   4   >