Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmytro Grinenko
> On June 6, 2016, 6:04 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > lines 664-666 > > > > > > I know this isn't a part of your change - but can

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmytro Grinenko
> On June 6, 2016, 5:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. > > Dmytro Grinenko wrote: > no

Re: Review Request 48202: NPE during EU at Update Target Stack step

2016-06-03 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48202/#review136053 --- Ship it! Ship It! - Dmytro Grinenko On June 3, 2016, 10:05

Re: Review Request 48654: Upgrading Ambari Causes Alert Fields Not To Save Thresholds

2016-06-13 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48654/#review137371 --- Ship it! Ship It! - Dmytro Grinenko On June 13, 2016, 8:15

Re: Review Request 49087: After registering 2.5 HDP repo, it is hidden on UI

2016-06-22 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49087/#review139076 --- Ship it! Ship It! - Dmytro Grinenko On June 22, 2016, 4:09

Re: Review Request 49198: Support Atlas in kerberized environment, submit Service Check as smokeuser

2016-06-24 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49198/#review139370 --- Ship it! Ship It! - Dmytro Grinenko On June 24, 2016, 1:10

Re: Review Request 45485: Ambari2400: ambari-server install fails on Rhel7

2016-03-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45485/#review126101 --- Ship it! Ship It! - Dmytro Grinenko On March 30, 2016, 1:37

Re: Review Request 46698: HBase RegionServers go down after Ambari upgrade due to ClassCastException

2016-04-26 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46698/#review130620 --- Ship it! Ship It! - Dmytro Grinenko On April 26, 2016, 1:56

Re: Review Request 46678: Run hadoop haadmin commands with -ns option

2016-04-26 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46678/#review130624 --- Ship it! Ship It! - Dmytro Grinenko On April 26, 2016, 7:56

Re: Review Request 46698: HBase RegionServers go down after Ambari upgrade due to ClassCastException

2016-04-26 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46698/#review130625 --- Ship it! Ship It! - Dmytro Grinenko On April 26, 2016, 3:05

Re: Review Request 47488: Ambari copies jdbc driver jar into hadoop/lib and haoop-yarn/lib

2016-05-19 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47488/#review133964 --- Ship it! Ship It! - Dmytro Grinenko On May 19, 2016, 4:14

Re: Review Request 47248: DevDeploy: ambari-server start failed

2016-05-11 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47248/#review132726 --- Ship it! Ship It! - Dmytro Grinenko On May 11, 2016, 6:30

Re: Review Request 50539: EU to HDP 2.5 failed since config type 'sqoop-atlas-application.properties' has not been created

2016-07-28 Thread Dmytro Grinenko
-- > > (Updated July 27, 2016, 11:06 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, > Jonathan Hurley, Nate Cole, Sumit Mohanty, and Tim Thorpe. > > > Bugs: AMBARI-17935 > https://

Re: Review Request 50526: NameNode High Availability Health Alert Issue

2016-07-27 Thread Dmytro Grinenko
om all hosts which means that result wcould be different from each host. How they would be aggregated then? - Dmytro Grinenko On July 27, 2016, 7:06 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Dmytro Grinenko
> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java, > > line 73 > > <https://reviews.apache.org/r/50532/diff/3/?file=1456907#file1456907line73> &g

Re: Review Request 50605: hadoop.security.* properties should not be set in hive-site.xml (hive-interactive-site)

2016-07-29 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50605/#review144113 --- Ship it! Ship It! - Dmytro Grinenko On July 29, 2016, 3:36

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review144256 --- Ship it! Ship It! - Dmytro Grinenko On July 29, 2016, 10:38

Re: Review Request 50710: Ambari agent unable to register with server when server response is too big

2016-08-10 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50710/#review145318 --- Ship it! Ship It! - Dmytro Grinenko On Aug. 9, 2016, 2:15

Re: Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

2016-07-21 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50299/#review143106 --- Ship it! Ship It! - Dmytro Grinenko On July 21, 2016, 3:35

Re: Review Request 50191: Spark service check fails on node with stopped Livy server

2016-07-19 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50191/#review142761 --- Ship it! Ship It! - Dmytro Grinenko On July 19, 2016, 4:15

Re: Review Request 50233: DataNode failed to start because of "small initial heap"

2016-07-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50233/#review142935 --- Ship it! Ship It! - Dmytro Grinenko On July 20, 2016, 1:39

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

2016-07-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50219/#review142930 --- Ship it! Ship It! - Dmytro Grinenko On July 20, 2016, 2:01

Re: Review Request 49856: yarn.exclude is placed on every host and path is not cutomizable

2016-07-09 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49856/#review141403 --- Ship it! Ship It! - Dmytro Grinenko On July 9, 2016, 2:08

Re: Review Request 49867: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 with Ubuntu 16 & JDK 8

2016-07-10 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49867/#review141609 --- Ship it! Ship It! - Dmytro Grinenko On July 10, 2016, 12:23

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Dmytro Grinenko
> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java, > > line 73 > > <https://reviews.apache.org/r/50532/diff/3/?file=1456907#file1456907line73> &g

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50606/#review144127 --- Ship it! Ship It! - Dmytro Grinenko On July 29, 2016, 4:16

Re: Review Request 49504: StackAdvisor fix for Oracle 12C and Add message if user forgot to set jdbc

2016-07-01 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49504/#review140332 --- Ship it! Ship It! - Dmytro Grinenko On July 1, 2016, 10:51

Re: Review Request 56023: Upgrade default JDK installed by Ambari to be >8u100

2017-01-27 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56023/#review163271 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 27, 2017, 3:14

Re: Review Request 56020: Ambari HDFS Metric alerts turns to UNKNOWN status with error "argument of type 'NoneType' is not iterable"

2017-01-27 Thread Dmytro Grinenko
cation. This should help use to debug issues here later - Dmytro Grinenko On Jan. 27, 2017, 2:22 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 56790: Getting Internal Server Error (500) on services API while trying to start all services with atleast one component in INSTALL_FAILED state

2017-02-22 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56790/#review166351 --- Ship it! Ship It! - Dmytro Grinenko On Feb. 22, 2017, 10:51

Re: Review Request 56950: Error during EU while updating Ranger Log4J service configs

2017-02-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56950/#review166516 --- Ship it! Ship It! - Dmytro Grinenko On Feb. 22, 2017, 9:11

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161689 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 12, 2017, 2:09

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-15 Thread Dmytro Grinenko
/serveraction/upgrades/UpgradeUserKerberosDescriptor.java (line 252) <https://reviews.apache.org/r/55424/#comment233001> should be this an atomic operation? - Dmytro Grinenko On Jan. 12, 2017, 2:09 p.m., Eugene Chekanskiy

Re: Review Request 52218: Fix ambari-server python test TestAmbariServer.py

2016-09-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52218/#review150172 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 23, 2016, 12

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

2016-08-18 Thread Dmytro Grinenko
> On Aug. 18, 2016, 8:22 p.m., Dmytro Grinenko wrote: > > Ship It! After fixing issue above. - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/#rev

Re: Review Request 52355: Add HDP-2.6 stack deriving from 2.5

2016-09-29 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52355/#review150828 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 28, 2016, 4:33

Re: Review Request 53050: Move ZEPPELIN role command order to common-services/ZEPPELIN

2016-10-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53050/#review153375 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:33

Re: Review Request 53052: Move ATLAS role command order to common-services/ATLAS

2016-10-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53052/#review153377 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:35

Re: Review Request 53054: Move AMBARI_INFRA role command order to common-services/AMBARI_INFRA

2016-10-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53054/#review153378 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:36

Re: Review Request 53051: Move LOGSEARCH role command order to common-services/LOGSEARCH

2016-10-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53051/#review153376 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:34

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153079 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 18, 2016, 12:36

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

2016-12-12 Thread Dmytro Grinenko
Because this is changing data, should the data manipulation be wrapped > > in an `executeInTransaction(Runnable)` ? > > Dmytro Grinenko wrote: > moreover, i'm not sure that @Transactional annotation will have any > effect on DDL changes via dbAccessor or any other way to make sch

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

2016-12-12 Thread Dmytro Grinenko
> On Dec. 12, 2016, 8:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1555 > > > > > > Because this is changing data, should the

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
https://reviews.apache.org/r/55424/ > --- > > (Updated Jan. 11, 2017, 1:32 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Robert Levas. > > > Bugs: AMBARI-19464 > https://issues.apache.org/jira/browse/AMBARI-19464 > > > Repository:

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
ed e-mail. To reply, visit: > https://reviews.apache.org/r/55424/ > --- > > (Updated Jan. 11, 2017, 1:32 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Robert Levas. > > > Bugs:

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
5424/#review161228 --- On Jan. 11, 2017, 1:32 p.m., Eugene Chekanskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55424/ > ---

Re: Review Request 55230: HOU Fails To Restart NameNode in non-HA Cluster

2017-01-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55230/#review160732 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 6, 2017, 2:21

Re: Review Request 55230: HOU Fails To Restart NameNode in non-HA Cluster

2017-01-06 Thread Dmytro Grinenko
> On Jan. 6, 2017, 7:29 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py, > > line 22 > > <https://reviews.apache.org/r/55230/diff/1/?file=1597766#file1597766line22> > > > >

Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

2016-12-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55002/#review160077 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 23, 2016, 12:35

Re: Review Request 55000: Perf: Deploy 3000 Agent cluster and find perf bugs. Part 4

2016-12-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55000/#review160076 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 23, 2016, 12:22

Re: Review Request 55018: Fix hive-site.xml and hive-env.sh permissions for /etc/hive/conf (client) folder from 600 to 644.

2016-12-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55018/#review160095 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 23, 2016, 6:30

Re: Review Request 54942: AMBARI-19272. Ignored mount points logged for each mount

2016-12-22 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54942/#review160018 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 21, 2016, 4:52

Re: Review Request 57940: JAVA_LIBRARY_PATH in hadoop-env.sh is different on host and downloaded configs

2017-03-26 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57940/#review170123 --- Ship it! Ship It! - Dmytro Grinenko On March 26, 2017, 9:34

Re: Review Request 57295: Atlas service check fails during EU on wire encrypted cluster

2017-03-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57295/#review168006 --- Ship it! Ship It! - Dmytro Grinenko On March 6, 2017, 2:57

Re: Review Request 61622: Begin Using Service Versions In Python stack_feature Code

2017-08-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61622/#review182913 --- Ship it! Ship It! - Dmytro Grinenko On Aug. 14, 2017, 9:01

Re: Review Request 61622: Begin Using Service Versions In Python stack_feature Code

2017-08-14 Thread Dmytro Grinenko
issue - Dmytro Grinenko On Aug. 14, 2017, 9:01 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60897: Add UID/GID related enhancements

2017-07-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60897/#review180641 --- Ship it! Ship It! - Dmytro Grinenko On July 16, 2017, 5:07

Re: Review Request 60866: AMBARI-21477: Remove Falcon proxy entries from Knox kerberos.json

2017-07-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60866/#review180558 --- Ship it! Ship It! - Dmytro Grinenko On July 14, 2017, 1:34

Re: Review Request 60919: AMBARI-21502. Cross-stack migration from BigInsights to HDP, EU needs to set hive-site custom.hive.warehouse.mode to 0770

2017-07-17 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60919/#review180748 --- Ship it! Ship It! - Dmytro Grinenko On July 17, 2017, 9:31

Re: Review Request 61146: Replace Hard Coded stack-select Structures

2017-07-27 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61146/#review181559 --- Ship it! Ship It! - Dmytro Grinenko On July 26, 2017, 7:04

Re: Review Request 61186: Service repos are not updated with "latest" url in repoinfo.xml

2017-07-27 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61186/#review181581 --- Ship it! Ship It! - Dmytro Grinenko On July 27, 2017, 5:05

Re: Review Request 61146: Replace Hard Coded stack-select Structures

2017-07-26 Thread Dmytro Grinenko
ources and sync on changes or post to agent initial version and after just post on changes? Current request r not small entites, and proly it is not good idea to make them even more larger. - Dmytro Grinenko On July 26, 2017, 7:04 p.m., Jonathan Hurley

Re: Review Request 61146: Replace Hard Coded stack-select Structures

2017-07-26 Thread Dmytro Grinenko
> On July 26, 2017, 7:39 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 131 (patched) > > <https://reviews.apache.org/r/61146/diff/1/?file=1782632#file1782632line175> > > > >

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

2017-06-28 Thread Dmytro Grinenko
ply, visit: > https://reviews.apache.org/r/60498/ > --- > > (Updated June 28, 2017, 12:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro > Lisnichenko, and Jonathan Hurley. > >

Re: Review Request 60543: DB consistency checker throws errors for missing 'parquet-logging' and 'product-info' configs after Ambari upgrade

2017-06-29 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60543/#review179275 --- Ship it! Ship It! - Dmytro Grinenko On June 29, 2017, 4:28

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

2017-06-28 Thread Dmytro Grinenko
check for this - Dmytro Grinenko On June 28, 2017, 8:59 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

2017-06-28 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/#review179096 --- Ship it! Ship It! - Dmytro Grinenko On June 28, 2017, 12:27

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

2017-06-28 Thread Dmytro Grinenko
> On June 28, 2017, 12:10 p.m., Dmytro Grinenko wrote: > > ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java > > Lines 683 (patched) > > <https://reviews.apache.org/r/60498/diff/1/?file=1766136#file1766136line683> > > > >

Re: Review Request 60543: DB consistency checker throws errors for missing 'parquet-logging' and 'product-info' configs after Ambari upgrade

2017-07-05 Thread Dmytro Grinenko
June 29, 2017, 4:28 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60543/ > --- > > (Updated June 29, 2017, 4:28 p.m.) > > > Rev

Re: Review Request 60543: DB consistency checker throws errors for missing 'parquet-logging' and 'product-info' configs after Ambari upgrade

2017-07-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60543/#review179631 --- Ship it! Ship It! - Dmytro Grinenko On June 29, 2017, 4:28

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-07 Thread Dmytro Grinenko
/org/apache/ambari/server/checks/AbstractCheckDescriptor.java Line 249 (original), 255 (patched) <https://reviews.apache.org/r/61490/#comment258234> could we put here some usefull information about request and kind of error occurs? - Dmytro Grinenko On Aug. 8, 2017, 3:48 a.m., Jo

Re: Review Request 59176: Add missing 'cluster_host_info' column to 'request' table to MSSQL DDL

2017-05-11 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59176/#review174642 --- Ship it! Ship It! - Dmytro Grinenko On May 11, 2017, 1:17

Re: Review Request 59176: Add missing 'cluster_host_info' column to 'request' table to MSSQL DDL

2017-05-11 Thread Dmytro Grinenko
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59176/ > --- > > (Updated May 11, 2017, 1:17 p.m.) > > > Review request for Ambari, Dmytro Grinenk

Re: Review Request 59277: Upgrades Should Be Associated With Repositories Instead of String Versions

2017-05-16 Thread Dmytro Grinenko
ply, visit: > https://reviews.apache.org/r/59277/ > --- > > (Updated May 15, 2017, 5:35 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-21022 > https://issues.apache.org/jira/browse/AMBAR

Re: Review Request 59912: Run status commands with real configurations and parameters information

2017-06-08 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59912/#review177293 --- Ship it! Ship It! - Dmytro Grinenko On June 8, 2017, 10:38

Re: Review Request 59835: Agent Host Disk Usage Alert Hardcodes the Stack Directory

2017-06-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59835/#review177020 --- Ship it! Ship It! - Dmytro Grinenko On June 6, 2017, 10:45

Re: Review Request 59394: Race condition: webhdfs call mkdir /tmp/druid-indexing before /tmp making tmp not writable.

2017-06-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59394/#review177018 --- Ship it! Ship It! - Dmytro Grinenko On May 19, 2017, 9:54

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62331/#review185412 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 14, 2017, 3:13

Re: Review Request 62259: Upgrade to IOP 4.2.5 from IOP 4.1 failed with combined Solr host names longer than item_text column size in table upgrade_item

2017-09-18 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62259/#review185573 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 18, 2017, 5:36

Re: Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI

2017-09-18 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62364/#review185580 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 18, 2017, 5:46

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

2017-10-04 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187081 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 3, 2017, 9:11

Re: Review Request 62996: Restart of random service could fail during express downgrade

2017-10-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62996/#review188112 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 16, 2017, 1:53

Re: Review Request 63032: YARN Service Checks Fails Because of Old hadoop-client Classpath Entry

2017-10-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63032/#review188152 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 16, 2017, 4:22

Re: Review Request 62934: Set current_version for Backward Compatibility

2017-10-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62934/#review187796 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 12, 2017, 1:57

Re: Review Request 62922: "ambari-server upgrade" failed on db schema [Upgrade]

2017-10-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62922/#review187768 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 12, 2017, 5:30

Re: Review Request 61715: package_regex in get_package_from_available() can match wrong pkg

2017-08-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61715/#review184142 --- Ship it! Ship It! - Dmytro Grinenko On Aug. 29, 2017, 3:07

Re: Review Request 62095: Installation should ignore OS that are not managed by Ambari

2017-09-05 Thread Dmytro Grinenko
ache commons instead of spring internals? - Dmytro Grinenko On Sept. 5, 2017, 9:04 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 62095: Installation should ignore OS that are not managed by Ambari

2017-09-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62095/#review184684 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 6, 2017, 1:55

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 145 (patched) > > <https://reviews.apache.org/r/62226/diff/2/?file=1819598#file1819598line145> > > >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
common/src/main/python/resource_management/libraries/functions/stack_select.py Lines 145 (patched) <https://reviews.apache.org/r/62226/#comment261466> while map function is present in python, using generators is more prefferable - Dmytro Grinenko On Sept. 11, 2017, 7:43

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 125 (patched) > > <https://reviews.apache.org/r/62226/diff/2/?file=1819598#file1819598line125> > >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62226/#review185207 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 12, 2017, 3:50

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-12 Thread Dmytro Grinenko
e moved to the top of the function and be used after for the check? - Dmytro Grinenko On Sept. 12, 2017, 8:10 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
/functions/stack_select.py Lines 126 (patched) <https://reviews.apache.org/r/62226/#comment261491> if not supported_packages: supported_packages = get_supported_packages() else no sence on this - Dmytro Grinenko On Sept. 12, 2017, 2:21 p.m., Jonathan Hurley

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
> On Sept. 12, 2017, 3:42 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 126 (patched) > > <https://reviews.apache.org/r/62226/diff/3/?file=1820189#file1820189line126> > >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62226/#review185197 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 12, 2017, 2:21

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 145 (patched) > > <https://reviews.apache.org/r/62226/diff/2/?file=1819598#file1819598line145> > > >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
142 (original), 142 (patched) <https://reviews.apache.org/r/62226/#comment261496> i like this way more than that big "stairs" - Dmytro Grinenko On Sept. 12, 2017, 3:50 p.m., Jonathan Hurley wrote: > > --- >

Re: Review Request 61746: Prevent New Clusters from Being Provisioned With PATCH/MAINT Repos

2017-08-21 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61746/#review183324 --- Ship it! Ship It! - Dmytro Grinenko On Aug. 19, 2017, 1:23

Re: Review Request 61715: PREVIEW: package_regex in get_package_from_available() can match wrong pkg

2017-08-28 Thread Dmytro Grinenko
ackage to respective os provider? - Dmytro Grinenko On Aug. 28, 2017, 3:49 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

  1   2   >