Re: Review Request 64083: Log Search: Adding new dynamic field for service logs

2017-11-27 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64083/#review191888 --- Ship it! Ship It! - Krisztian Kasa On Nov. 27, 2017, 2:54

Re: Review Request 64059: Initial implementation of Schedulable document deletion & archiving for Infra Solr

2017-11-27 Thread Krisztian Kasa
unit tests * manual test using docker-compose Thanks, Krisztian Kasa

Re: Review Request 64059: Initial implementation of Schedulable document deletion & archiving for Infra Solr

2017-11-24 Thread Krisztian Kasa
bari-logsearch/docker/test-config/logfeeder/logfeeder.properties fb7ddf2845 Diff: https://reviews.apache.org/r/64059/diff/2/ Changes: https://reviews.apache.org/r/64059/diff/1-2/ Testing --- * unit tests * manual test using docker-compose Thanks, Krisztian Kasa

Review Request 64059: Initial implementation of Schedulable document deletion & archiving for Infra Solr

2017-11-24 Thread Krisztian Kasa
eder/logfeeder.properties fb7ddf2845 Diff: https://reviews.apache.org/r/64059/diff/1/ Testing --- * unit tests * manual test using docker-compose Thanks, Krisztian Kasa

Re: Review Request 64156: Log Search: backend should not return with 302 redirect if authentication fails

2017-11-29 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64156/#review192117 --- Ship it! Ship It! - Krisztian Kasa On Nov. 29, 2017, 12:44

Re: Review Request 64091: Log Feeder: handle multiple '=' (split char) in key/value filter

2017-11-27 Thread Krisztian Kasa
/apache/ambari/logfeeder/filter/FilterKeyValue.java Line 140 (original), 140 (patched) <https://reviews.apache.org/r/64091/#comment269993> Why do we truncate the logmessage? Information can be lost. - Krisztian Kasa On Nov. 27, 2017, 8:54 p.m., Oliver Szabo

Re: Review Request 64206: Upgrade Ambari Infra to use Solr 5.5.5 for Ambari 2.6.1

2017-11-30 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64206/#review192280 --- Ship it! Ship It! - Krisztian Kasa On Nov. 30, 2017, 11:51

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot

2017-12-13 Thread Krisztian Kasa
pache/ambari/logfeeder/metrics/StatsLogger.java Lines 64 (patched) <https://reviews.apache.org/r/64553/#comment272239> Wouldn't be better to halt the entire application in case of an Error? So Errors would be rethrown but Excep

Review Request 64607: Ambari Infra Manager: solr data exporting jobs and integration test environment

2017-12-14 Thread Krisztian Kasa
* manual testing using docker containers and ide Thanks, Krisztian Kasa

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot

2017-12-13 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64553/#review193683 --- Ship it! Ship It! - Krisztian Kasa On Dec. 13, 2017, 3:24

Re: Review Request 64607: Ambari Infra Manager: solr data exporting jobs and integration test environment

2017-12-15 Thread Krisztian Kasa
, Krisztian Kasa

Re: Review Request 64660: Rafactor: Package Log Search and Log Feeder into jars + cleanup start scripts

2017-12-17 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64660/#review194039 --- Ship it! Ship It! - Krisztian Kasa On Dec. 16, 2017, 1:27

Re: Review Request 63793: Log Feeder: cleanup checkpoint files periodically

2017-11-14 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63793/#review190940 --- waitInterval -> waitIntervalMin - Krisztian Kasa On Nov.

Re: Review Request 63793: Log Feeder: cleanup checkpoint files periodically

2017-11-14 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63793/#review190941 --- Ship it! Ship It! - Krisztian Kasa On Nov. 14, 2017, 12:50

Re: Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md

2017-11-15 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63832/#review191057 --- Ship it! Ship It! - Krisztian Kasa On Nov. 15, 2017, 11:35

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

2017-11-03 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63525/#review190024 --- Ship it! Ship It! - Krisztian Kasa On Nov. 2, 2017, 9:35

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

2017-11-03 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63525/#review190025 --- Ship it! Ship It! - Krisztian Kasa On Nov. 2, 2017, 9:35

Re: Review Request 63696: Exclude test scope jars from Log Search / Log Feeder rpm/deb packages

2017-11-09 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63696/#review190574 --- Ship it! Ship It! - Krisztian Kasa On Nov. 9, 2017, 12:53

Re: Review Request 64412: Log Search IT: Expose the right port for Selenium in docker-compose file

2017-12-07 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64412/#review193110 --- Ship it! Ship It! - Krisztian Kasa On Dec. 7, 2017, 1:24

Re: Review Request 64513: Update the default storm log search configuration (use wildcards)

2017-12-11 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/#review193502 --- Ship it! Ship It! - Krisztian Kasa On Dec. 11, 2017, 11:47

Re: Review Request 64349: LogFeeder: filter objects for wildcard input paths need to be cloned

2017-12-06 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64349/#review192987 --- Ship it! Ship It! - Krisztian Kasa On Dec. 5, 2017, 8:50

Re: Review Request 63393: Log Search: Add docker compose file for Log Search server and Log Feeder

2017-10-29 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63393/#review189543 --- Ship it! Ship It! - Krisztian Kasa On Oct. 29, 2017, 10:19

Review Request 63416: Remove python & npm install from Log Search docker container

2017-10-30 Thread Krisztian Kasa
file 70e80b65e9 ambari-logsearch/docker/docker-compose.yml a6eeb0df6f ambari-logsearch/docker/logsearch-docker.sh b44e7ee43b Diff: https://reviews.apache.org/r/63416/diff/1/ Testing --- manully with docker-compose Thanks, Krisztian Kasa

Re: Review Request 63323: Get rid of deprecated Solr usages (infra + logsearch)

2017-10-26 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63323/#review189287 --- Ship it! Ship It! - Krisztian Kasa On Oct. 26, 2017, 9:24

Re: Review Request 63265: Log Feeder: allow applying grok filter on default fields (like type, path, host etc.)

2017-10-25 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63265/#review189175 --- Ship it! Ship It! - Krisztian Kasa On Oct. 24, 2017, 10:30

Re: Review Request 63429: Log Search: add descriptions about how to use Log Search environment with docker compose

2017-10-31 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63429/#review189695 --- Ship it! Ship It! - Krisztian Kasa On Oct. 30, 2017, 9:04

Re: Review Request 63328: Log Search: Add docker-compose file for creating ZooKeeper containers

2017-10-27 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63328/#review189424 --- Ship it! Ship It! - Krisztian Kasa On Oct. 27, 2017, 9:54

Re: Review Request 63360: Log Search: Add docker compose file for Solr

2017-10-27 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63360/#review189451 --- Ship it! Ship It! - Krisztian Kasa On Oct. 27, 2017, 1:19

Re: Review Request 63362: Fix Log Search configuration dependencies

2017-10-27 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63362/#review189452 --- Ship it! Ship It! - Krisztian Kasa On Oct. 27, 2017, 4:28

Review Request 64976: Ambari Infra Manager: hdfs upload support

2018-01-05 Thread Krisztian Kasa
using docker * integration test using vagrant, ambari and ide Thanks, Krisztian Kasa

Re: Review Request 64852: Ambari Infra Manager: deleting documents

2017-12-28 Thread Krisztian Kasa
/SolrQueryBuilderTest.java e9513dccd9 Diff: https://reviews.apache.org/r/64852/diff/3/ Changes: https://reviews.apache.org/r/64852/diff/2-3/ Testing --- * unit tests, * integration tests using docker containers * manual testing using docker containers and ide Thanks, Krisztian Kasa

Re: Review Request 64852: Ambari Infra Manager: deleting documents

2017-12-28 Thread Krisztian Kasa
tests using docker containers * manual testing using docker containers and ide Thanks, Krisztian Kasa

Review Request 64850: Fixing interface and file renaming issues

2017-12-27 Thread Krisztian Kasa
Diff: https://reviews.apache.org/r/64850/diff/1/ Testing --- maven build unit and integration tests Thanks, Krisztian Kasa

Re: Review Request 64850: Fixing interface and file renaming issues

2017-12-27 Thread Krisztian Kasa
https://reviews.apache.org/r/64850/diff/2/ Changes: https://reviews.apache.org/r/64850/diff/1-2/ Testing --- maven build unit and integration tests Thanks, Krisztian Kasa

Review Request 64852: Ambari Infra Manager: deleting documents

2017-12-27 Thread Krisztian Kasa
Diff: https://reviews.apache.org/r/64852/diff/1/ Testing --- * unit tests, * integration tests using docker containers * manual testing using docker containers and ide Thanks, Krisztian Kasa