Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
eviews.apache.org/r/48044/#review136336 ------- On June 6, 2016, 3:15 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
is configured with sudo on agents. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
commands.html Thanks, i am about to verify this. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/#review136436 ---------

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
e: > Execute(('ls','-la','/usr/hdp'), sudo=True) Thanks! - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/#review136439 ----------

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
/resource_management/libraries/functions/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing (updated) --- Unit tests passed. Manual testing underway. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
/resource_management/libraries/functions/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing --- Unit tests passed. Manual testing underway. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
if ls is configured with sudo on agents. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Laszlo Puskas
- ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing (updated) --- Unit tests passed. Thanks, Laszlo Puskas

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-06 Thread Laszlo Puskas
after the object is created. The only advantage of this would be to have a "uniform" aproach of setting memebers. - Laszlo Puskas On June 6, 2016, 8:47 a.m., Daniel Gergely wrote: > > --- > This is an automatically generat

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-06 Thread Laszlo Puskas
/TopologyManager.java (line 162) <https://reviews.apache.org/r/48266/#comment201269> I'd rather perform this check out of this method, in order to always have a boolean return value for this method. - Laszlo Puskas On June 6, 2016, 8:47 a.m., Daniel Gergely

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
t can be /usr/hdp. Using the stack_root to the log commands. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48044/#review135943 ---------

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
) - ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing --- Manual testing underway. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
/resource_management/libraries/functions/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing (updated) --- Unit tests passed. Manual testing underway please don't commit yet. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
/resource_management/libraries/functions/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing (updated) --- Unit tests passed. Manual testing underway. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-06 Thread Laszlo Puskas
/resource_management/libraries/functions/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing (updated) --- Unit tests passed. Manual testing underway please don't commit yet. // found some major differences between the branches / investigating it Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-13 Thread Laszlo Puskas
/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing --- Unit tests passed. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-13 Thread Laszlo Puskas
---------- On June 13, 2016, 8:28 a.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48044/ > ---

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-13 Thread Laszlo Puskas
information. The patch only applies for 2.2-next versions. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 9a3201e Diff: https://reviews.apache.org/r/48044/diff/ Testing --- Unit tests passed. Thanks, Laszlo Puskas

Re: Review Request 48691: Removing and re-adding hosts makes database inconsitent

2016-06-14 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48691/#review137527 --- Ship it! Ship It! - Laszlo Puskas On June 14, 2016, 2:51

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Laszlo Puskas
t.java (line 87) <https://reviews.apache.org/r/48266/#comment202953> The member annotated with @TestSubject is instantiated by the framework. Why do we need two instances here? - Laszlo Puskas On June 15, 2016, 11:33 a.m., Daniel G

Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments

2016-06-15 Thread Laszlo Puskas
/diff/ Testing --- Unit tests running; Manually tested on local env. Thanks, Laszlo Puskas

Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-05-30 Thread Laszlo Puskas
: https://reviews.apache.org/r/48044/diff/ Testing --- Manual testing underway. Thanks, Laszlo Puskas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-02 Thread Laszlo Puskas
, visit: https://reviews.apache.org/r/48044/#review135565 ------- On June 2, 2016, 12:55 p.m., Laszlo Puskas wrote: > > --- > This is an automatically gener

Re: Review Request 48169: Ensure smokeuser HDFS folder exists before running MR, YARN, PIG, OOZIE service checks

2016-06-02 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48169/#review135950 --- Ship it! Ship It! - Laszlo Puskas On June 2, 2016, 2:38 p.m

Re: Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments

2016-06-15 Thread Laszlo Puskas
: https://reviews.apache.org/r/48732/diff/ Testing (updated) --- Unit tests succeeded Manually tested on local env. Thanks, Laszlo Puskas

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138587 --- Ship it! Ship It! - Laszlo Puskas On June 16, 2016, 4:43

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Laszlo Puskas
/HeartBeatHandler.java (line 532) <https://reviews.apache.org/r/48722/#comment203792> This call here is superfluous. - Laszlo Puskas On June 16, 2016, 4:43 p.m., Sebastian Toader wrote: > > --- > This is an automatically g

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

2016-06-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/#review139578 --- Ship it! Ship It! - Laszlo Puskas On June 27, 2016, 2:01

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-29 Thread Laszlo Puskas
, Laszlo Puskas

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-29 Thread Laszlo Puskas
changed the test framework from Mockito to EasyMock. The test "logic" didn't change at all. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139909 --------

Re: Review Request 44572: Stack advisor empties out hive kerberos related properties

2016-03-10 Thread Laszlo Puskas
/stack_advisor.py f88eb0c Diff: https://reviews.apache.org/r/44572/diff/ Testing --- Tested manually, on local env. Thanks, Laszlo Puskas

Review Request 45220: /tmp hdfs folder created with mode 0777

2016-03-23 Thread Laszlo Puskas
under way Thanks, Laszlo Puskas

Re: Review Request 45220: /tmp hdfs folder created with mode 0777

2016-03-23 Thread Laszlo Puskas
n" permissions for the component creating the dir) - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45220/#review125069 --------

Re: Review Request 45220: /tmp hdfs folder created with mode 0777

2016-03-24 Thread Laszlo Puskas
/src/test/python/stacks/2.0.6/YARN/test_historyserver.py b1634d0 Diff: https://reviews.apache.org/r/45220/diff/ Testing --- Unit tests in progress. Manual testing under way Thanks, Laszlo Puskas

Re: Review Request 46148: NPE when deleting a host

2016-04-14 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46148/#review128879 --- Ship it! Ship It! - Laszlo Puskas On April 14, 2016, 11:41

Re: Review Request 46765: Killing hive metastore and webhcat might fail with "no process" error

2016-04-28 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46765/#review130897 --- Ship it! Ship It! - Laszlo Puskas On April 28, 2016, 9:06

Re: Review Request 46654: Auth-to-local rule generation duplicates default rules when adding case-insensitive default rules

2016-04-26 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46654/#review130606 --- Ship it! Ship It! - Laszlo Puskas On April 25, 2016, 7:03

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47596/#review134149 --- Ship it! Ship It! - Laszlo Puskas On May 20, 2016, 8:01 a.m

Re: Review Request 46899: Disable alternate user search functionality by default

2016-05-03 Thread Laszlo Puskas
/configuration/Configuration.java (line 201) <https://reviews.apache.org/r/46899/#comment195500> Typo: controlls - Laszlo Puskas On May 2, 2016, 8:01 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e

Re: Review Request 46899: Disable alternate user search functionality by default

2016-05-03 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46899/#review131493 --- Ship it! Ship It! - Laszlo Puskas On May 2, 2016, 8:01 p.m

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-05 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review131800 --- Ship it! Ship It! - Laszlo Puskas On May 4, 2016, 9:09 p.m

Re: Review Request 46973: Amanded handling of excluded config-types handling in case of blueprint deployments

2016-05-04 Thread Laszlo Puskas
/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 2759869 Diff: https://reviews.apache.org/r/46973/diff/ Testing --- In progress... Thanks, Laszlo Puskas

Re: Review Request 46973: Amanded handling of excluded config-types handling in case of blueprint deployments

2016-05-05 Thread Laszlo Puskas
/internal/BlueprintConfigurationProcessorTest.java 2759869 Diff: https://reviews.apache.org/r/46973/diff/ Testing (updated) --- Tested manually. Unit tests passed. Thanks, Laszlo Puskas

Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

2016-04-14 Thread Laszlo Puskas
--- Unit test done. (mvn test underway) Manually tested on local / openstack cluster. Thanks, Laszlo Puskas

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Laszlo Puskas
/TopologyManager.java (line 395) <https://reviews.apache.org/r/46496/#comment193458> Add the host to the log message - Laszlo Puskas On April 21, 2016, 3:19 p.m., Sebastian Toader wrote: > > --- > This is an automatica

Re: Review Request 46496: Host_status stuck in UNKNOWN status after blueprint deploy with host in heartbeat-lost

2016-04-21 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46496/#review129907 --- Ship it! Ship It! - Laszlo Puskas On April 21, 2016, 3:19

Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

2016-04-14 Thread Laszlo Puskas
Diff: https://reviews.apache.org/r/46198/diff/ Testing (updated) --- Unit test done. Tests ran successfully. Manually tested on local / openstack cluster. Thanks, Laszlo Puskas

Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

2016-04-14 Thread Laszlo Puskas
://reviews.apache.org/r/46198/diff/ Testing (updated) --- Unit test done. Tests ran successfully. Manually tested on local / openstack cluster. Java Results : Tests run: 4226, Failures: 0, Errors: 0, Skipped: 32 Python: Total run:959 Total errors:0 Total failures:0 OK Thanks, Laszlo Puskas

Re: Review Request 47117: HiveServer interactive fails to start

2016-05-09 Thread Laszlo Puskas
/stack_advisor.py (line 332) <https://reviews.apache.org/r/47117/#comment196461> Is there any function in python for min/max calculation instead of the "if" structure ... - Laszlo Puskas On May 9, 2016, 12:28 p.m., Dani

Re: Review Request 47117: HiveServer interactive fails to start

2016-05-09 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47117/#review132266 --- Ship it! Ship It! - Laszlo Puskas On May 9, 2016, 1:01 p.m

Re: Review Request 50336: Added namenode HA configuration adjustments to the upgrade configurations

2016-07-22 Thread Laszlo Puskas
bd1bef2 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 065a933 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml d152f34 Diff: https://reviews.apache.org/r/50336/diff/ Testing --- Manual testing underway. Thanks, Laszlo

Re: Review Request 50336: Added namenode HA configuration adjustments to the upgrade configurations

2016-07-22 Thread Laszlo Puskas
underway. Thanks, Laszlo Puskas

Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-03 Thread Laszlo Puskas
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java 0190478 Diff: https://reviews.apache.org/r/50753/diff/ Testing --- Manually, in progress. Thanks, Laszlo Puskas

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-03 Thread Laszlo Puskas
) - ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java a757010 ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java 0190478 Diff: https://reviews.apache.org/r/50753/diff/ Testing --- Manually, in progress. Thanks, Laszlo Puskas

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-04 Thread Laszlo Puskas
in progress. Thanks, Laszlo Puskas

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-28 Thread Laszlo Puskas
/server/controller/AmbariManagementControllerTest.java fd70df5 Diff: https://reviews.apache.org/r/49260/diff/ Testing (updated) --- Manually tested on dev-env. Unit tests running Thanks, Laszlo Puskas

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-28 Thread Laszlo Puskas
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139577 --- On June 28, 2016, 2:09 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-

Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Laszlo Puskas
- ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b60592d Diff: https://reviews.apache.org/r/49260/diff/ Testing --- Manually tested on dev-env. Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Laszlo Puskas
--- Manually tested on dev-env. Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Laszlo Puskas
) --- Manually tested on dev-env. OK -- Total run:1073 Total errors:0 Total failures:0 Thanks, Laszlo Puskas

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-05 Thread Laszlo Puskas
al won't interfere with the new method. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50753/#review144920 ----------

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-05 Thread Laszlo Puskas
st and when > > it's received by your subscriber method. > > > > If the problem only happens on registration, I think this solution is OK. > > But if a heartbeat from an agent can cause problems as well, then there is > > still a slight chance that the timing her

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-08 Thread Laszlo Puskas
/java/org/apache/ambari/server/topology/TopologyManager.java 9a6ee94 Diff: https://reviews.apache.org/r/50753/diff/ Testing --- Suceesfully tested. (Manually) Unit tests OK Thanks, Laszlo Puskas

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-08 Thread Laszlo Puskas
(updated) - ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java 9a6ee94 Diff: https://reviews.apache.org/r/50753/diff/ Testing --- Suceesfully tested. (Manually) Unit tests OK Thanks, Laszlo Puskas

Review Request 50336: Added namenode HA configuration adjustments to the upgrade configurations

2016-07-22 Thread Laszlo Puskas
-upgrade-2.5.xml 065a933 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml d152f34 Diff: https://reviews.apache.org/r/50336/diff/ Testing --- Manual testing underway. Thanks, Laszlo Puskas

Re: Review Request 49383: Add a validation of required services during a blueprint deployment

2016-06-30 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49383/#review140150 --- Ship it! Ship It! - Laszlo Puskas On June 29, 2016, 4:14

Re: Review Request 49455: Optimized classpath scannig for upgrade checks impelemtation

2016-06-30 Thread Laszlo Puskas
seconds) Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java e0bda13 Diff: https://reviews.apache.org/r/49455/diff/ Testing --- Unit tests running. Thanks, Laszlo Puskas

Review Request 49455: Optimized classpath scannig for upgrade checks impelemtation

2016-06-30 Thread Laszlo Puskas
: https://reviews.apache.org/r/49455/diff/ Testing --- Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelemtations

2016-06-30 Thread Laszlo Puskas
. Thanks, Laszlo Puskas

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelementations

2016-07-01 Thread Laszlo Puskas
e looked up with a single scan ... - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49455/#review140277 ------- On

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelementations

2016-07-01 Thread Laszlo Puskas
. Thanks, Laszlo Puskas

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelemtations

2016-07-01 Thread Laszlo Puskas
this shortens the startup time by ~25 seconds) Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java e0bda13 Diff: https://reviews.apache.org/r/49455/diff/ Testing --- Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 56175: Setup correct authentication and authorization mechanism between Yarn Registry and Zookeeper

2017-02-01 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56175/#review163842 --- Ship it! Ship It! - Laszlo Puskas On Feb. 1, 2017, 4:43 p.m

Re: Review Request 55762: Ambari db-cleanup tool fixed

2017-01-24 Thread Laszlo Puskas
been added, the related guice module hasn;t been set into the tool's injector. The fix is to add the missing module to the db-cleanup tool's injector. branch-2.5: commit 8111ba662e849c27e4a9a04305b3ef2260c030e9 Author: Laszlo Puskas <lpus...@hortonworks.com> Date:?? Fri Jan 20 19:18:10 2017

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-24 Thread Laszlo Puskas
a382bed7f55be632fd03e1b02bb8a01151234b24 Author: Laszlo Puskas <lpus...@hortonworks.com> Date: Fri Jan 20 12:41:02 2017 +0100 AMBARI-19613. ZKFC Zookeper connection is not secure. (Laszlo Puskas via stoader) branch-2.5 commit 00b2c42ccf6fe68267483a645f6e57e9c921f01b Author: Laszlo Puskas

Re: Review Request 55883: Post user creation hook - input csv generated with READ permissions

2017-01-25 Thread Laszlo Puskas
user (not root ...) - opened the generated csv as the newlycreated user Unit test created. Thanks, Laszlo Puskas

Re: Review Request 55983: AMBARI-19712. Cluster creation fails due to database exception

2017-01-26 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55983/#review163124 --- Ship it! Ship It! - Laszlo Puskas On Jan. 26, 2017, 1:31

Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-26 Thread Laszlo Puskas
/post-user-creation-hook.sh ee8d2d1 ambari-server/src/test/java/org/apache/ambari/server/hooks/users/UserHookServiceTest.java 293b22a Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-26 Thread Laszlo Puskas
/users/PostUserCreationHookServerActionTest.java f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 56064: Format ZKFC commands failing while enabling NameNode HA

2017-01-30 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56064/#review163483 --- Ship it! Ship It! - Laszlo Puskas On Jan. 29, 2017, 8:43

Review Request 55762: Ambari db-cleanup tool fixed

2017-01-20 Thread Laszlo Puskas
Diff: https://reviews.apache.org/r/55762/diff/ Testing --- Manually. Thanks, Laszlo Puskas

Re: Review Request 55762: Ambari db-cleanup tool fixed

2017-01-20 Thread Laszlo Puskas
been added, the related guice module hasn;t been set into the tool's injector. The fix is to add the missing module to the db-cleanup tool's injector. branch-2.5: commit 8111ba662e849c27e4a9a04305b3ef2260c030e9 Author: Laszlo Puskas <lpus...@hortonworks.com> Date:?? Fri Jan 20 19:18:10 2017

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
/server/serveraction/users/PostUserCreationHookServerActionTest.java f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerActionTest.java f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
/PostUserCreationHookServerActionTest.java f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing (updated) --- Unit tests succeeded. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-29 Thread Laszlo Puskas
f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing (updated) --- Unit tests succeeded. Manually tested changes. Thanks, Laszlo Puskas

Re: Review Request 56054: Inconsistent auth-to-local rules processing during Kerberos authentication

2017-01-29 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56054/#review163430 --- Ship it! Ship It! - Laszlo Puskas On Jan. 29, 2017, 12:50

Re: Review Request 56783: Removing secure ACLs from Kafka znodes during dekerberization

2017-02-17 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56783/#review165942 --- Ship it! Ship It! - Laszlo Puskas On Feb. 17, 2017, 3:16

Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-02-24 Thread Laszlo Puskas
be notified about the success/failure of the operation) Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 123486e Diff: https://reviews.apache.org/r/57040/diff/ Testing --- Manually. Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-02-24 Thread Laszlo Puskas
/test_namenode.py fae500f Diff: https://reviews.apache.org/r/57040/diff/ Testing (updated) --- Manually. Unit tests running... Thanks, Laszlo Puskas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-02-24 Thread Laszlo Puskas
://reviews.apache.org/r/57040/diff/ Testing (updated) --- Manually. Unit tests success. Thanks, Laszlo Puskas

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-13 Thread Laszlo Puskas
/UpgradeCatalog250Test.java (line 1666) <https://reviews.apache.org/r/56599/#comment237174> Instead mocking tehe injector itself, add a module where instances are bound to mocks. - Laszlo Puskas On Feb. 13, 2017, 1:48 p.m., Attila Magyar

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-13 Thread Laszlo Puskas
> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote: > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java, > > line 1672 > > <https://reviews.apache.org/r/56599/diff/1/?file=1631931#file1631931line1672> > > > > In

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-13 Thread Laszlo Puskas
> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote: > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java, > > line 1672 > > <https://reviews.apache.org/r/56599/diff/1/?file=1631931#file1631931line1672> > > > > In

Re: Review Request 56713: Ambari server start returns prematurely before extracting views.

2017-02-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56713/#review165719 --- Ship it! Ship It! - Laszlo Puskas On Feb. 15, 2017, 3:24

Review Request 55883: Post user creation hook - input csv generated with READ permissions

2017-01-24 Thread Laszlo Puskas
. Thanks, Laszlo Puskas

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

2017-01-24 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55833/#review162805 --- Ship it! Ship It! - Laszlo Puskas On Jan. 24, 2017, 1 p.m

Review Request 56600: Default group permissions for the user home directories created by the post user creation script should be 'hdfs' instead of 'hadoop'

2017-02-13 Thread Laszlo Puskas
/resources/scripts/post-user-creation-hook.sh 91511a0 Diff: https://reviews.apache.org/r/56600/diff/ Testing --- Manually, underway. Thanks, Laszlo Puskas

  1   2   3   >