Review Request 48290: Change HAWQ DFS Url from hawq_default to hawq_data

2016-06-06 Thread Matt
: https://reviews.apache.org/r/48290/diff/ Testing --- Waiting for results from Hadoop QA Thanks, Matt

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-07 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136492 --- Ship it! Ship It! - Matt On June 7, 2016, 9:09 a.m., Juanjo

Re: Review Request 48194: Update name of PXF component to PXF Agent

2016-06-03 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48194/#review136045 --- Ship it! Ship It! - Matt On June 2, 2016, 6:10 p.m

Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type

2016-06-03 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/#review136131 --- Ship it! Ship It! - Matt On June 3, 2016, 3:49 p.m

Review Request 47840: Change location of HAWQ tmp directories

2016-05-25 Thread Matt
or) ... ok test_getServiceConfigurationRecommendations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 53 tests in 0.248s OK ``` Thanks, Matt

Re: Review Request 47840: Change location of HAWQ tmp directories

2016-05-25 Thread Matt
ls) ... ok -- Ran 53 tests in 0.248s OK ``` Thanks, Matt

Re: Review Request 48664: Add logging for the command executed during PXF service check

2016-06-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48664/#review137415 --- Ship it! Ship It! - Matt On June 13, 2016, 3:30 p.m

Review Request 48663: Export PGHOST before any HAWQ Master or Standby custom command is executed

2016-06-13 Thread Matt
status_cmd (test_utils.TestUtils) ... ok -- Ran 53 tests in 0.485s OK ``` Thanks, Matt

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread Matt
/python/stacks/2.3/HAWQ/test_service_advisor.py (line 216) <https://reviews.apache.org/r/47802/#comment199885> This required? - Matt On May 25, 2016, 9:54 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automat

Re: Review Request 47975: BP deploy to put default password for hawq_password

2016-05-27 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47975/#review135320 --- Ship it! Ship It! - Matt On May 27, 2016, 12:48 p.m

Re: Review Request 47858: Cache service advisors when stack advisor is loaded

2016-05-27 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135321 --- Ship it! Ship It! - Matt On May 27, 2016, 12:11 p.m., Lav

Review Request 48155: Recommend hawq_rm_nvcore_limit_perseg in HAWQ service advisor

2016-06-01 Thread Matt
mendations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 53 tests in 0.226s OK ``` Thanks, Matt

Re: Review Request 44575: Enable bulk operation for HAWQ Segments and PXF on Hosts page

2016-03-09 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44575/#review122755 --- Ship it! Ship It! - Matt On March 9, 2016, 9:52 a.m

Re: Review Request 44577: Update descriptions for configs - HAWQ and PXF

2016-03-09 Thread Matt
ion/hawq-sysctl-env.xml (line 232) <https://reviews.apache.org/r/44577/#comment184974> Some changes going on for this one. Refer: https://reviews.apache.org/r/44576/diff/1#index_header - Matt On March 9, 2016, 9:24 a.m., Goutam Tadi wrote: > > --

Re: Review Request 44576: Update sysctl value for HAWQ

2016-03-10 Thread Matt
be incorporated [here](https://reviews.apache.org/r/44577/), to avoid merge conflicts. - Matt On March 9, 2016, 10:09 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 45391: HAWQ - Add option to enable or disabling exchanging keys during HAWQ start.

2016-03-28 Thread Matt
bari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py (line 60) <https://reviews.apache.org/r/45391/#comment188625> Do you think it would be better to provide the user the list of hosts on which ssh key exchange failed? - Matt On March 28, 2016,

Re: Review Request 45826: Descriptions for HAWQ sysctl params mention incorrect default values

2016-04-06 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45826/#review127390 --- Ship it! Ship It! - Matt On April 6, 2016, 11:04 a.m

Re: Review Request 45832: Add ignore-bad-hosts flag to hawq activate standby custom action

2016-04-06 Thread Matt
/HAWQ/2.0.0/package/scripts/hawqstandby.py (line 59) <https://reviews.apache.org/r/45832/#comment190934> Would a service restart be required afer bad hosts (which will get ignored) become 'good'? - Matt On April 6, 2016, 12:57 p.m., bhuvnesh chaudhary

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Matt
service level rather than the stack level. I will > attempt to do both of these tasks at the same time. May be this should inherit from service_advisor for that service under common-services? - Matt --- This is an automatically generate

Re: Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured

2016-04-12 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/#review128584 --- Ship it! Ship It! - Matt On April 12, 2016, 12:12 p.m

Re: Review Request 45899: After enabling NN HA with HAWQ installed, duplicate properties are seen on HAWQ config tab

2016-04-08 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45899/#review127761 --- Ship it! Ship It! - Matt On April 7, 2016, 3:26 p.m

Re: Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured

2016-04-12 Thread Matt
or configure? - Matt On April 11, 2016, 11:27 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 45878: Remove PHD references from HAWQ

2016-04-07 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45878/#review127717 --- Ship it! Ship It! - Matt On April 7, 2016, 9:48 a.m., Lav

Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect validation error shown

2016-04-11 Thread Matt
> On April 11, 2016, 1:32 p.m., Mahadev Konar wrote: > > Matt - any update on the testing? I just deployed the new build with my code. The issue has been fixed. I was just about to update the review.

Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect validation error shown

2016-04-11 Thread Matt
Deploying a cluster for manual testing. There is no validation error regarding METRICS MONITOR after following the **steps to reproduce** as mentioned on the JIRA. Thanks, Matt

Re: Review Request 46062: PXF service check must occur only after PXF is started

2016-04-11 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46062/#review128284 --- Ship it! Ship It! - Matt On April 11, 2016, 4:23 p.m

Re: Review Request 45188: update pxf-profile template with new fields and description

2016-03-22 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45188/#review124949 --- Ship it! Ship It! - Matt On March 22, 2016, 4:43 p.m

Re: Review Request 45719: Alert to notify if a HAWQ Segment is unregistered with HAWQ Master

2016-04-04 Thread Matt
file be closed after execution of this line? Better to use 'with open(HAWQ_SLAVES_FILE) as f', so that you can ensure that the file is closed and frees up system resources. - Matt On April 4, 2016, 5:41 p.m., Goutam Tadi wrote: > > --

Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%

2016-04-04 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45705/#review127001 --- Ship it! Ship It! - Matt On April 4, 2016, 2:48 p.m

Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%

2016-04-04 Thread Matt
ndent of the alert. The change to the UI is to keep the thresholds of the dashboard widget similar to that of the alert thresholds so that users see the same color coding (Alert - CRITICAL RED when 25% or more segments are down AND Dashboard widget shows

Review Request 45724: Activate Standby option should not be shown on HAWQ Standby component on host summary page

2016-04-04 Thread Matt
] [INFO] Total time: 55.352 s [INFO] Finished at: 2016-04-04T19:35:54-07:00 [INFO] Final Memory: 12M/311M [INFO] Thanks, Matt

Re: Review Request 45566: HAWQ config should not allow multiple Master/Segment directories

2016-04-01 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45566/#review126669 --- Ship it! Ship It! - Matt On April 1, 2016, 2:39 p.m., Lav

Re: Review Request 45124: Update logic for HAWQ 'output.replace-datanode-on-failure' property with threshold of 3

2016-03-21 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45124/#review124632 --- Ship it! Ship It! - Matt On March 21, 2016, 12:29 p.m

Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-22 Thread Matt
] Thanks, Matt

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

2016-04-21 Thread Matt
/HAWQ - Matt On April 21, 2016, 12:12 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 46742: Use additional flags for HAWQ Check

2016-04-27 Thread Matt
> On April 27, 2016, 10:45 a.m., Alexander Denissov wrote: > > Please add unit tests. Working on it - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46742/#rev

Re: Review Request 46857: 'Restart All' for HAWQ should follow role_command_order

2016-04-29 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46857/#review131234 --- Ship it! Ship It! - Matt On April 29, 2016, 3:20 p.m., Lav

Re: Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.

2016-04-28 Thread Matt
ent194919> Missing expect statement? - Matt On April 28, 2016, 2:57 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 46742: Use additional flags for HAWQ Check

2016-04-28 Thread Matt
by) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 50 tests in 0.347s OK Thanks, Matt

Review Request 47616: Remove ams-ssl-client from HAWQ metainfo.xml

2016-05-19 Thread Matt
/r/47616/diff/ Testing --- Manually tested. Thanks, Matt

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Matt
https://issues.apache.org/jira/browse/AMBARI-16663 - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47580/#review133974 --

Re: Review Request 47619: clean up import * for MAHOUT service scripts in common-services

2016-05-20 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47619/#review134111 --- Ship it! Ship It! - Matt On May 19, 2016, 4:27 p.m., Juanjo

Re: Review Request 47657: Hawq password to use !h flag to ensure that its only hidden and no special processing is done for it.

2016-05-20 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47657/#review134186 --- Ship it! Ship It! - Matt On May 20, 2016, 11:59 a.m

Review Request 47749: Warning for HAWQSTANDBY does not show up on Assign Masters page

2016-05-23 Thread Matt
ls) ... ok -- Ran 53 tests in 0.264s OK ``` Thanks, Matt

Re: Review Request 47541: clean up import * for HBase service scripts in common-services

2016-05-18 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47541/#review133825 --- Ship it! Ship It! - Matt On May 18, 2016, 9:41 a.m., Juanjo

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

2016-05-18 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47477/#review133827 --- Ship it! Ship It! - Matt On May 18, 2016, 9:49 a.m., Juanjo

Review Request 47564: Activate HAWQSTANDBY fails on retry

2016-05-18 Thread Matt
ls) ... ok -- Ran 52 tests in 0.199s OK Thanks, Matt

Re: Review Request 47570: Recommend value for hawq_rm_memory_limit_perseg for HAWQ

2016-05-18 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47570/#review133849 --- Ship it! Ship It! - Matt On May 18, 2016, 5:19 p.m

Re: Review Request 47573: Next button is disabled on assign master page in Add Hawq Standby wizard

2016-05-18 Thread Matt
/wizard_view.js (line 64) <https://reviews.apache.org/r/47573/#comment198511> Is this something new that applies only to trunk and branch-2.4? - Matt On May 18, 2016, 6:29 p.m., bhuvnesh chaudhary

Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Matt
/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console This message is automatically generated. ``` Thanks, Matt

Re: Review Request 47564: Activate HAWQSTANDBY fails on retry

2016-05-19 Thread Matt
t; assertResourceCalled can be defined using functools.partial I did think about refactoring while working on this JIRA. And I thought should do the refactoring separately as part of refactoring HAWQ's python unit tests. I did not want to overdo with th

Re: Review Request 47573: Next button is disabled on assign master page in Add Hawq Standby wizard

2016-05-19 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47573/#review133890 --- Ship it! Ship It! - Matt On May 18, 2016, 6:29 p.m

Review Request 47679: PXF operations considers the agent status

2016-05-20 Thread Matt
] ``` Thanks, Matt

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Matt
ntent text'} Recommendations: {'content': '# Some hbase-env content text'} ``` Thanks, Matt

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Matt
mendations: {'content': '# Some hbase-env content text'} ``` Thanks, Matt

Review Request 47642: Add HAWQ Standby wizard should recommend HAWQSTANDBY correctly

2016-05-20 Thread Matt
ls) ... ok -- Ran 53 tests in 0.240s OK Thanks, Matt

Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-11 Thread Matt
> On May 10, 2016, 12:13 p.m., jun aoki wrote: > > Do we have to Clean PXF from the previous NN node, if the node does no > > longer have any of PXF related ones? (DN, HAWQ etc.?) Did you mean to say, remove the rpms and files? I would be looking into this on a follow-up

Re: Review Request 47277: hawq_ssh_exkeys config should be a checkbox on UI

2016-05-11 Thread Matt
/HAWQ/2.0.0/configuration/hawq-env.xml (line 45) <https://reviews.apache.org/r/47277/#comment197066> - Matt On May 11, 2016, 6:05 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47434: Remove unused parameters from hawq-site.xml

2016-05-17 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47434/#review133630 --- Ship it! Ship It! - Matt On May 16, 2016, 5:14 p.m

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47252/#review133160 --- Ship it! Ship It! - Matt On May 12, 2016, 2:26 p.m., Goutam

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

2016-05-13 Thread Matt
AWQ/2.0.0/service_advisor.py, > > line 166 > > <https://reviews.apache.org/r/47328/diff/1/?file=1382035#file1382035line166> > > > > fancy, but this is a constant that we don;t have to calculate every > > time, why

Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

2016-05-12 Thread Matt
visor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 51 tests in 0.226s OK ``` Thanks, Matt

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-03 Thread Matt
the documentation in ambari-server/src/main/resources/stacks/service_advisor.py but it did not work as expected. - Matt On May 3, 2016, 12:04 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

2016-05-03 Thread Matt
> On May 3, 2016, 4:14 p.m., Matt wrote: > > Discussed this in person: This function is not used anywhere else, besides PXF service. Logging would be taken care of by PXF service component. - Matt --- This is an auto

Re: Review Request 42155: AMBARI-14605 '[RAM_DISK]' configured in dfs.datanode.data.dir fails to validate

2016-05-03 Thread Matt
. - Matt On May 2, 2016, 9:57 p.m., yao lei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42155/ > --- > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-05 Thread Matt
> On May 4, 2016, 2:37 p.m., Matt wrote: > > We have tested the following changes: > > - The logic for stack_advisor which was pulled into service_advisor works > > well. > > - Inheritance between stacks works well. We tested inheritance from > &g

Re: Review Request 46996: HAWQ service can be stopped and checked even when STANDBY MASTER is stopped

2016-05-04 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46996/#review131762 --- Ship it! Ship It! - Matt On May 4, 2016, 4:52 p.m

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-04 Thread Matt
> On May 3, 2016, 4:09 p.m., Matt wrote: > > The functionality of ServiceAdvisor works as expected. However more > > clarification is needed on how to use inheritance and override service > > advisor defined in common-services. > > For example: > > HAWQ2

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

2016-05-03 Thread Matt
ctions/namenode_ha_utils.py (line 143) <https://reviews.apache.org/r/46949/#comment195597> Do you need to log this explicitly using Logger.fail() or does it get logged automatically to std-err log, which shows up the UI? - Matt On May 3, 2016, 4:05 p.m., ju

Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread Matt
[INFO] Finished at: 2016-05-10T00:20:54-07:00 [INFO] Final Memory: 12M/310M [INFO] Thanks, Matt

Re: Review Request 47156: More information for Standby sync alert

2016-05-10 Thread Matt
alerts/alert_sync_status.py (line 102) <https://reviews.apache.org/r/47156/#comment196572> I believe you had to do resort to a separate query because you were not able to parse the error message when the message spanned over more than one line... - Matt On May 9, 2016, 9:27 p.m., ju

Re: Review Request 47156: More information for Standby sync alert

2016-05-10 Thread Matt
> On May 10, 2016, 12:10 a.m., Matt wrote: > > Please double check if any unit tests have to be updated. - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47156/#rev

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-05-04 Thread Matt
in the service_advisor.py file and specify the file path and class name in metainfo.xml under that stack, so that the class gets loaded. - Matt On May 4, 2016, 7:17 a.m., Tim Thorpe wrote: > > --- > This is an automatically generat

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread Matt
a better idea to find it out. > > bhuvnesh chaudhary wrote: > You can get the configuration as soon you reach onLoadConfigs, and then > you can use it which is before the start service ? That sounds better to me. Modi

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-02 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review131430 --- Ship it! Ship It! - Matt On April 29, 2016, 5:51 p.m

Re: Review Request 46283: hawq init master fails to syncup hawq-site xml if there is a segment host down

2016-04-15 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46283/#review129235 --- Ship it! Ship It! - Matt On April 15, 2016, 3:15 p.m

Re: Review Request 46253: Add ignore-bad-hosts flag to hawq remove standby custom action to avoid failures when a segment host is down

2016-04-15 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46253/#review129167 --- Ship it! Ship It! - Matt On April 14, 2016, 10:59 p.m

Re: Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

2016-04-18 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46294/#review129408 --- Ship it! Ship It! - Matt On April 15, 2016, 5:56 p.m., jun

Review Request 46359: HAWQ Immediate Stop cluster fails with key error

2016-04-18 Thread Matt
eyError: 'cluster' stdout: None Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 4ce0c94 Diff: https://reviews.apache.org/r/46359/diff/ Testing --- Manually Tested. Unit Tests passed. Thanks, Matt

Re: Review Request 46350: PXF Check fails on Kerberized cluster without a YARN component

2016-04-19 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46350/#review129631 --- Ship it! Ship It! - Matt On April 19, 2016, 2:18 p.m., Lav

Review Request 46181: Activate HAWQ standby wizard fails to delete previous hawq standby master

2016-04-13 Thread Matt
ll_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok -- Ran 34 tests in 0.357s OK Thanks, Matt

Re: Review Request 46176: Update group for postgres proxy user to * from hadoop

2016-04-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46176/#review128782 --- Ship it! Ship It! - Matt On April 13, 2016, 3:41 p.m

Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

2016-04-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46170/#review128771 --- Ship it! Ship It! - Matt On April 13, 2016, 2:55 p.m., Lav

Re: Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread Matt
/HAWQ/2.0.0/package/scripts/master_helper.py (line 53) <https://reviews.apache.org/r/47134/#comment196503> json.dumps ensures that quotes and special characters are escaped? Did you consider && and giving an additional command? Or is this a new JIRA? - Matt On May 9, 2

Re: Review Request 47138: stackadvisor uses getHostsForSlaveComponent with wrong parameter name

2016-05-09 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47138/#review132354 --- Ship it! Ship It! - Matt On May 9, 2016, 4:43 p.m., Lav

Re: Review Request 47781: clean up import * for PIG service scripts in common-services

2016-05-24 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47781/#review134646 --- Ship it! Ship It! - Matt On May 24, 2016, 9:39 a.m., Juanjo

Re: Review Request 50547: AMBARI-17939: Validations are missing for HDFS properties recommended by HAWQ

2016-07-28 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50547/#review144027 --- Ship it! Ship It! - Matt On July 28, 2016, 2:30 p.m

Re: Review Request 50545: Ambari should not recursively chown for HAWQ hdfs upon every start

2016-07-27 Thread Matt
imeout, considering ls command on hdfs is generally slow compared to Linux ls command? - Matt On July 27, 2016, 4:48 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50544: Ambari install/init should create a new gpadmin database

2016-07-27 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50544/#review143885 --- Ship it! Ship It! - Matt On July 27, 2016, 4:41 p.m., Lav

Review Request 50731: HAWQ service advisor shows wrong recommendations on edge cases

2016-08-02 Thread Matt
was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ``` Thanks, Matt

Re: Review Request 50731: HAWQ service advisor shows wrong recommendations on edge cases

2016-08-03 Thread Matt
iceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ``` Thanks, Matt

Re: Review Request 50965: Ambari unit tests for HAWQ are not being called

2016-08-11 Thread Matt
; https://www.python.org/dev/peps/pep-0008/#imports - Matt On Aug. 10, 2016, 5:43 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

2016-07-19 Thread Matt
entation for service HAWQ was loaded ServiceAdvisor implementation for service HAWQ was loaded ``` Thanks, Matt

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

2016-07-19 Thread Matt
e be set to hawq_rm_memory_limit_perseg? In YARN mode, hawq_rm_memory_limit_perseg is invisible. We would like to show the users the error that the memory is low regardless of which mode it is on. Hence we show the error on hawq_global_rm_type prope

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

2016-07-19 Thread Matt
sts["items"][2] instead of hosts["items"][3]? Same > > for line 390. They should all be 0,1,3 2 does not have HAWQ components. - Matt --- This is an automatically generated e-mail.

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

2016-07-19 Thread Matt
perty has no impact on the logic inside this if, maybe move it > > out of the if statement ? Moved it to another if statement - Matt --- This is an automatically generated e-mail. To reply, visit: htt

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

2016-07-19 Thread Matt
oaded ServiceAdvisor implementation for service HAWQ was loaded ``` Thanks, Matt

Re: Review Request 50097: HAWQ install should recommend required values for HDFS properties

2016-07-16 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50097/#review142478 --- Ship it! Ship It! - Matt On July 15, 2016, 5:06 p.m

Review Request 49362: Add additional parameters to hawq-site.xml

2016-06-29 Thread Matt
/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 1d27052 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json d7940a1 Diff: https://reviews.apache.org/r/49362/diff/ Testing --- Manually tested. Thanks, Matt

Re: Review Request 49387: Support password type for custom properties

2016-07-08 Thread Matt
operty,'propertyName').map(function(propType) { attributes[propType.toLowerCase()][Em.get(property,'name')] = true; }); } ``` - Matt On July 8, 2016, 2:15 p.m., Keta Patel wrote: > > --- > This is an automatica

  1   2   >