---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48540/#review137277
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Червень 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47979/#review135305
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48072/#review135629
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 31
/authorization/User.java
(line 49)
<https://reviews.apache.org/r/49119/#comment204361>
IMO user name should be stored and returned in original case.
Only comparison should be case insensitive.
- Myroslav Papirkovskyy
On Червень 23, 2016, 3:14 до полудня, Nahappan Somasundaram
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49199/#review139368
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Червень 24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45904/#review127749
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45930/#review127801
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 8
le wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45904/
> ---
>
> (Updated Квітень 8, 2016, 11:56 після
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46095/#review128403
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45815/#review127348
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45125/#review124642
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Березень 21
o work with AD specifically and it
will. But we need to document this well and, possibly, create another issue for
more generic approach.
- Myroslav Papirkovskyy
On Березень 25, 2016, 1:28 до полудня, Sebastian Toader
igType
So after adding this method to Cluster interface check will look like
following:
if ( cluster.getServiceByCOnfigType != null &&
clusterConfig.getServiceConfigVersions().isEmpty() )
- Myroslav Papirkovskyy
On Березень 21, 2016, 4:23 після полудня, Sebastia
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45545/#review126311
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Березень 31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45545/#review126319
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Березень 31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45284/#review125610
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Березень 27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47595/#review134361
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47417/#review134597
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47315/#review132917
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/#review132466
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46433/#review129726
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50195/#review142772
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142542
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 15
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49762/#review141170
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 7, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49805/#review141273
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 8, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49867/#review141610
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49884/#review141652
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49626/#review140797
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 5, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163663
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 31, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56407/#review164697
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Лют. 8, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56143/#review163737
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Лют. 1, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55851/#review162672
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 23, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56573/#review165249
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Лют. 11, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56412/#review164986
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Лют. 8, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55675/#review162093
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 18, 2017
. Theres limit
for complex key size in bytes, but in varchar length depends on encoding.
- Myroslav Papirkovskyy
On Жов. 5, 2016, 1:40 до полудня, Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52692/#review151978
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Жов. 10, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53030/#review153379
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Жов. 19, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52791/#review152481
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Жов. 12, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55422/#review161220
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 11, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55266/#review160720
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 6, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57910/#review170151
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Березень 27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57954/#review170159
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Березень 27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/#review171562
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/#review171440
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60897/#review180642
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Липень 16
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58790/#review173185
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58656/#review172767
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Квітень 24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60365/#review178985
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Червень 27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59367/#review175483
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59627/#review176292
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59684/#review176456
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61582/#review183386
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Сер. 21, 2017
/ServiceGroupRequest.java
Lines 29 (patched)
<https://reviews.apache.org/r/63051/#comment265484>
It will be nice to replace map with POJO:
Something like Set will make whole patch easier to read
and remove hardcoded key names.
- Myroslav Papirkovskyy
On Жов. 17, 2017, 11:38
a5f54a346379a8fa4252184321620557a06344d3
ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py
f4c550897d75d54d52810f3070cfc0e7c8742173
Diff: https://reviews.apache.org/r/64087/diff/1/
Testing
---
mvn clean test
Thanks,
Myroslav Papirkovskyy
00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
6e9e5efcd408b683224db46e668a44336a9cf167
Diff: https://reviews.apache.org/r/64216/diff/1/
Testing
---
mvn clean test
Thanks,
Myroslav
://reviews.apache.org/r/64216/diff/1/
Testing
---
mvn clean test
Thanks,
Myroslav Papirkovskyy
/
Testing
---
mvn clean test
Thanks,
Myroslav Papirkovskyy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64209/#review192371
---
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Лис. 30, 2017
: https://reviews.apache.org/r/63957/diff/2/
Changes: https://reviews.apache.org/r/63957/diff/1-2/
Testing
---
mvn clean test
Thanks,
Myroslav Papirkovskyy
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/64174/#review192169
---
On Лис. 29, 2017, 10:49 після полудня, Myroslav Papirkovskyy wrote:
>
> ---
> This is an
35f9f65dc89302aaf4c555d269beb221f2c0a793
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
c6111712c3f79347234d282461e0d9f0ed5a8b75
Diff: https://reviews.apache.org/r/64174/diff/1/
Testing
---
mvn clean test
manual check of described case
Thanks,
Myroslav
iews.apache.org/r/64652/diff/1/
Testing
---
mvn clean test
manual check
Thanks,
Myroslav Papirkovskyy
eply, visit:
https://reviews.apache.org/r/64652/#review193951
---
On Гру. 15, 2017, 7 після полудня, Myroslav Papirkovskyy wrote:
>
> ---
> This is an automati
> > These records should just be straight up deleted, not marked this way.
>
> Myroslav Papirkovskyy wrote:
> UI makes explicit call to delete host versions, which will fail if we
> just remove records.
>
> Jonathan Hurley wrote:
> If the UI is deleting the
-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py
9e0070458987ee490f3918fead5ef11d201c8612
Diff: https://reviews.apache.org/r/63957/diff/1/
Testing
---
mvn clean test
Thanks,
Myroslav Papirkovskyy
/server/topology/BlueprintValidatorImplTest.java
ea6bee314192f0665d4df652cf0c401e0218026f
Diff: https://reviews.apache.org/r/63955/diff/1/
Testing
---
mvn clean test
Thanks,
Myroslav Papirkovskyy
on file got moved between commits, so cannot
update rb correctly
- Myroslav
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#review191529
-----
863313b015f86b35fccdb8e83d9429e9be9b6f8f
Diff: https://reviews.apache.org/r/64346/diff/1/
Testing
---
manual
Thanks,
Myroslav Papirkovskyy
/stacks/PERF/1.0/properties/stack_packages.json
PRE-CREATION
Diff: https://reviews.apache.org/r/64302/diff/1/
Testing
---
mvn clean test
Thanks,
Myroslav Papirkovskyy
d5a1ac4fd06377a992a8286d6fca366536a25157
Diff: https://reviews.apache.org/r/64388/diff/2/
Changes: https://reviews.apache.org/r/64388/diff/1-2/
Testing
---
mvn clean test
manual check
Thanks,
Myroslav Papirkovskyy
/
Testing
---
mvn clean test
manual check
Thanks,
Myroslav Papirkovskyy
/test_hive_metastore.py
73f5fe62c870f79d2f55d39a06279e977fb61115
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py
4eb16c2a3c146ac4d2e61370eb5f3121c7a5331f
Diff: https://reviews.apache.org/r/64547/diff/1/
Testing
---
mvn clean test
manual check
Thanks,
Myroslav
/services/ServiceGroupKey.java
Lines 33 (patched)
<https://reviews.apache.org/r/63051/#comment265705>
Duplicated annotation on setter should not be required. AFAIK only one is
necessary, either on getter or on field.
- Myroslav Papirkovskyy
On Жов. 19, 2017, 5:58 після полудня, Vitalyi Brod
/StateUpdateListener.java
17e8c3d4692cdc0f3fd20ddd5606fef458048d96
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java
58bfcfca289cc2eec8fbef2321683a22eb91e00f
Diff: https://reviews.apache.org/r/64981/diff/1/
Testing
---
manual check
Thanks,
Myroslav
t:
https://reviews.apache.org/r/64984/#review194888
---
On Січ. 5, 2018, 8:59 після полудня, Myroslav Papirkovskyy wrote:
>
> ---
> This is an automatically generated e
9fdba33e9e36c37760619f2fe1c480e4a130dbbb
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
174604811311b08e93f41d807bf512b1235e8971
Diff: https://reviews.apache.org/r/64987/diff/1/
Testing
---
manual testing
Thanks,
Myroslav Papirkovskyy
/
Testing
---
manual testing
Thanks,
Myroslav Papirkovskyy
48864cc3baab7f7b0887f7dd68a5bbdcd9925698
Diff: https://reviews.apache.org/r/64984/diff/1/
Testing
---
manual testing
Thanks,
Myroslav Papirkovskyy
point for next refactoring though.
- Myroslav Papirkovskyy
On Січ. 5, 2018, 8:59 після полудня, Myroslav Papirkovskyy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/java/org/apache/ambari/server/events/listeners/upgrade/UpgradeUpdateListener.java
PRE-CREATION
Diff: https://reviews.apache.org/r/64990/diff/1/
Testing
---
manual testing
Thanks,
Myroslav Papirkovskyy
stResourceProvider.java
bd746f57c2dc6a9e948cbb387ce8329d6ff8eb18
Diff: https://reviews.apache.org/r/64979/diff/1/
Testing
---
manual check
Thanks,
Myroslav Papirkovskyy
/TopologyComponent.java
d96180dc02f362156d135d19e562e874f07545b6
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/TopologyHost.java
9cdf9442ff96fe730d456037ae05a7becf9a97e9
Diff: https://reviews.apache.org/r/64977/diff/1/
Testing
---
manual check
Thanks,
Myroslav
83 matches
Mail list logo