Re: Review Request 48540: Ubuntu 16, Hive Metastore Start failed

2016-06-13 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48540/#review137277 --- Ship it! Ship It! - Myroslav Papirkovskyy On Червень 10

Re: Review Request 47979: Deploy: UI: Hive_metastore not started

2016-05-27 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47979/#review135305 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 27

Re: Review Request 48072: Upgrade Catalog 2.4 is not idempotent

2016-05-31 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48072/#review135629 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 31

Re: Review Request 49119: AMBARI-17383: User names should be case insensitive

2016-06-23 Thread Myroslav Papirkovskyy
/authorization/User.java (line 49) <https://reviews.apache.org/r/49119/#comment204361> IMO user name should be stored and returned in original case. Only comparison should be case insensitive. - Myroslav Papirkovskyy On Червень 23, 2016, 3:14 до полудня, Nahappan Somasundaram

Re: Review Request 49199: Falcon client install failed

2016-06-24 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49199/#review139368 --- Ship it! Ship It! - Myroslav Papirkovskyy On Червень 24

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127749 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127801 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 8

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-11 Thread Myroslav Papirkovskyy
le wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45904/ > --- > > (Updated Квітень 8, 2016, 11:56 після

Re: Review Request 46095: On debian7 UI shows 'os not supported' in processor info

2016-04-12 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46095/#review128403 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 12

Re: Review Request 45815: Ambari DB schema upgrade fails with ORA-01408 error

2016-04-06 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45815/#review127348 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 6

Re: Review Request 45125: 'ambari-server check-database' has errors after upgrade to ambari 2.2.2.0 [grafana errors]

2016-03-21 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45125/#review124642 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 21

Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user

2016-03-25 Thread Myroslav Papirkovskyy
o work with AD specifically and it will. But we need to document this well and, possibly, create another issue for more generic approach. - Myroslav Papirkovskyy On Березень 25, 2016, 1:28 до полудня, Sebastian Toader

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

2016-03-21 Thread Myroslav Papirkovskyy
igType So after adding this method to Cluster interface check will look like following: if ( cluster.getServiceByCOnfigType != null && clusterConfig.getServiceConfigVersions().isEmpty() ) - Myroslav Papirkovskyy On Березень 21, 2016, 4:23 після полудня, Sebastia

Re: Review Request 45545: Output short logs summary on start/stop failure

2016-03-31 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45545/#review126311 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 31

Re: Review Request 45545: Output short logs summary on start/stop failure

2016-03-31 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45545/#review126319 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 31

Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user

2016-03-28 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45284/#review125610 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 27

Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase

2016-05-23 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47595/#review134361 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 23

Re: Review Request 47417: Replace '*' to hdp version in lzo packages

2016-05-24 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47417/#review134597 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 24

Re: Review Request 47315: Ambari upgrade fails because of new [cluster_type] column

2016-05-12 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47315/#review132917 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 12

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-10 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review132466 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 10

Re: Review Request 46433: spark history server fails to start after upgrading ambari 2.2.1.0 -> 2.2.2.0 and remaining on derg

2016-04-20 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46433/#review129726 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 20

Re: Review Request 50195: Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0

2016-07-19 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50195/#review142772 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 19

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-18 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review142542 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 15

Re: Review Request 49762: Oozie fails to start when Falcon is not on the same host

2016-07-07 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49762/#review141170 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 7, 2016

Re: Review Request 49805: Ambari server schema upgrade failed from 2.1.1 with ORA-12516 error

2016-07-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49805/#review141273 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 8, 2016

Re: Review Request 49867: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 with Ubuntu 16 & JDK 8

2016-07-10 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49867/#review141610 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 10

Re: Review Request 49884: Nodemanager is not started after installation

2016-07-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49884/#review141652 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 11

Re: Review Request 49626: NN HA enabling failed at 'Stop all Services' step

2016-07-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49626/#review140797 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 5, 2016

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55989/#review163663 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 31, 2017

Re: Review Request 56407: Upgrade: Package Install stuck in "Installing" state forever

2017-02-08 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56407/#review164697 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лют. 8, 2017

Re: Review Request 56143: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56143/#review163737 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лют. 1, 2017

Re: Review Request 55851: Dangling config-group hostmapping entries result in partial loading of config groups

2017-01-23 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55851/#review162672 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 23, 2017

Re: Review Request 56573: Increase default timeout for RM

2017-02-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56573/#review165249 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лют. 11, 2017

Re: Review Request 56412: HDP 3.0 TP - Support changed configs and scripts for YARN/MR

2017-02-09 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56412/#review164986 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лют. 8, 2017

Re: Review Request 55675: ambari-server setup failed

2017-01-18 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55675/#review162093 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 18, 2017

Re: Review Request 52532: blueprint_setting table incorrectly defines blueprint_name column in DDL for MySQL

2016-10-05 Thread Myroslav Papirkovskyy
. Theres limit for complex key size in bytes, but in varchar length depends on encoding. - Myroslav Papirkovskyy On Жов. 5, 2016, 1:40 до полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 52692: Ambari startup script doesn't work on SUSE and potentially other OS's.

2016-10-10 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52692/#review151978 --- Ship it! Ship It! - Myroslav Papirkovskyy On Жов. 10, 2016

Re: Review Request 53030: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

2016-10-20 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53030/#review153379 --- Ship it! Ship It! - Myroslav Papirkovskyy On Жов. 19, 2016

Re: Review Request 52791: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-13 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52791/#review152481 --- Ship it! Ship It! - Myroslav Papirkovskyy On Жов. 12, 2016

Re: Review Request 55422: Oozie Restart is not prompted on changing core-site.xml

2017-01-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55422/#review161220 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 11, 2017

Re: Review Request 55266: dfs.exclude file doesn't exist when deploying cluster with NN HA + kerberos via BP

2017-01-06 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55266/#review160720 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 6, 2017

Re: Review Request 57910: Create a base class for caching in ambari-agent.

2017-03-27 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57910/#review170151 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 27

Re: Review Request 57954: Single process executor possibly can cause deadlock

2017-03-27 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57954/#review170159 --- Ship it! Ship It! - Myroslav Papirkovskyy On Березень 27

Re: Review Request 58354: Handle caching of topologies, configs and metadata

2017-04-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58354/#review171562 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 11

Re: Review Request 58297: Add stab registering and heartbeating routine via stomp async calls.

2017-04-10 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58297/#review171440 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 10

Re: Review Request 60897: Add UID/GID related enhancements

2017-07-16 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60897/#review180642 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 16

Re: Review Request 58790: Create an ansynchronious status commands executor

2017-04-27 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58790/#review173185 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 27

Re: Review Request 58656: Heartbeat and register with real server instead of mock server

2017-04-24 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58656/#review172767 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 24

Re: Review Request 60365: Config update API should not need to have a unique tag, BE can auto add the tag when it is missing

2017-06-27 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60365/#review178985 --- Ship it! Ship It! - Myroslav Papirkovskyy On Червень 27

Re: Review Request 59367: Run execution commands sent to /user/commands

2017-05-19 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59367/#review175483 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 18

Re: Review Request 59627: Support CREATE/UPDATE/DELETE of topology, hashes and some events format changes

2017-05-30 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59627/#review176292 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 29

Re: Review Request 59684: Log more info about heartbeat message/response when server - agent communication gets out of sync

2017-05-31 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59684/#review176456 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 31

Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value

2017-08-21 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61582/#review183386 --- Ship it! Ship It! - Myroslav Papirkovskyy On Сер. 21, 2017

Re: Review Request 63051: Add service group dependencies

2017-10-18 Thread Myroslav Papirkovskyy
/ServiceGroupRequest.java Lines 29 (patched) <https://reviews.apache.org/r/63051/#comment265484> It will be nice to replace map with POJO: Something like Set will make whole patch easier to read and remove hardcoded key names. - Myroslav Papirkovskyy On Жов. 17, 2017, 11:38

Review Request 64087: Service config changes on hdp + hdf cluster throws Consistency check failed

2017-11-27 Thread Myroslav Papirkovskyy
a5f54a346379a8fa4252184321620557a06344d3 ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py f4c550897d75d54d52810f3070cfc0e7c8742173 Diff: https://reviews.apache.org/r/64087/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy

Re: Review Request 64216: . Repository validation fails for HDP-GPL

2017-11-30 Thread Myroslav Papirkovskyy
00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 6e9e5efcd408b683224db46e668a44336a9cf167 Diff: https://reviews.apache.org/r/64216/diff/1/ Testing --- mvn clean test Thanks, Myroslav

Review Request 64216: . Repository validation fails for HDP-GPL

2017-11-30 Thread Myroslav Papirkovskyy
://reviews.apache.org/r/64216/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy

Re: Review Request 64216: . Repository validation fails for HDP-GPL

2017-11-30 Thread Myroslav Papirkovskyy
/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192371 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лис. 30, 2017

Re: Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.

2017-11-22 Thread Myroslav Papirkovskyy
: https://reviews.apache.org/r/63957/diff/2/ Changes: https://reviews.apache.org/r/63957/diff/1-2/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy

Re: Review Request 64174: Upgrade from Ambari 2.5.2 to 2.6.0 fails.

2017-11-30 Thread Myroslav Papirkovskyy
enerated e-mail. To reply, visit: https://reviews.apache.org/r/64174/#review192169 --- On Лис. 29, 2017, 10:49 після полудня, Myroslav Papirkovskyy wrote: > > --- > This is an

Review Request 64174: Upgrade from Ambari 2.5.2 to 2.6.0 fails.

2017-11-29 Thread Myroslav Papirkovskyy
35f9f65dc89302aaf4c555d269beb221f2c0a793 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java c6111712c3f79347234d282461e0d9f0ed5a8b75 Diff: https://reviews.apache.org/r/64174/diff/1/ Testing --- mvn clean test manual check of described case Thanks, Myroslav

Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Myroslav Papirkovskyy
iews.apache.org/r/64652/diff/1/ Testing --- mvn clean test manual check Thanks, Myroslav Papirkovskyy

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Myroslav Papirkovskyy
eply, visit: https://reviews.apache.org/r/64652/#review193951 --- On Гру. 15, 2017, 7 після полудня, Myroslav Papirkovskyy wrote: > > --- > This is an automati

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Myroslav Papirkovskyy
> > These records should just be straight up deleted, not marked this way. > > Myroslav Papirkovskyy wrote: > UI makes explicit call to delete host versions, which will fail if we > just remove records. > > Jonathan Hurley wrote: > If the UI is deleting the

Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.

2017-11-20 Thread Myroslav Papirkovskyy
-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 9e0070458987ee490f3918fead5ef11d201c8612 Diff: https://reviews.apache.org/r/63957/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy

Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

2017-11-20 Thread Myroslav Papirkovskyy
/server/topology/BlueprintValidatorImplTest.java ea6bee314192f0665d4df652cf0c401e0218026f Diff: https://reviews.apache.org/r/63955/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy

Re: Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

2017-11-21 Thread Myroslav Papirkovskyy
on file got moved between commits, so cannot update rb correctly - Myroslav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63955/#review191529 -----

Review Request 64346: Jetty Session Timeout Is Overridden By Views Initialization. (mpapirkovskyy)

2017-12-05 Thread Myroslav Papirkovskyy
863313b015f86b35fccdb8e83d9429e9be9b6f8f Diff: https://reviews.apache.org/r/64346/diff/1/ Testing --- manual Thanks, Myroslav Papirkovskyy

Review Request 64302: PERF 1.0 stack deployment failure in ambari-2.6.1.

2017-12-04 Thread Myroslav Papirkovskyy
/stacks/PERF/1.0/properties/stack_packages.json PRE-CREATION Diff: https://reviews.apache.org/r/64302/diff/1/ Testing --- mvn clean test Thanks, Myroslav Papirkovskyy

Re: Review Request 64388: Tez service check hangs when adding service

2017-12-07 Thread Myroslav Papirkovskyy
d5a1ac4fd06377a992a8286d6fca366536a25157 Diff: https://reviews.apache.org/r/64388/diff/2/ Changes: https://reviews.apache.org/r/64388/diff/1-2/ Testing --- mvn clean test manual check Thanks, Myroslav Papirkovskyy

Review Request 64388: Tez service check hangs when adding service

2017-12-06 Thread Myroslav Papirkovskyy
/ Testing --- mvn clean test manual check Thanks, Myroslav Papirkovskyy

Review Request 64547: Hive MetaStore does not start even after passing the mysql-connector to ambari-server

2017-12-12 Thread Myroslav Papirkovskyy
/test_hive_metastore.py 73f5fe62c870f79d2f55d39a06279e977fb61115 ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 4eb16c2a3c146ac4d2e61370eb5f3121c7a5331f Diff: https://reviews.apache.org/r/64547/diff/1/ Testing --- mvn clean test manual check Thanks, Myroslav

Re: Review Request 63051: Add service group dependencies

2017-10-19 Thread Myroslav Papirkovskyy
/services/ServiceGroupKey.java Lines 33 (patched) <https://reviews.apache.org/r/63051/#comment265705> Duplicated annotation on setter should not be required. AFAIK only one is necessary, either on getter or on field. - Myroslav Papirkovskyy On Жов. 19, 2017, 5:58 після полудня, Vitalyi Brod

Review Request 64981: alert_definitions topic doesn't emit any events to client.

2018-01-05 Thread Myroslav Papirkovskyy
/StateUpdateListener.java 17e8c3d4692cdc0f3fd20ddd5606fef458048d96 ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java 58bfcfca289cc2eec8fbef2321683a22eb91e00f Diff: https://reviews.apache.org/r/64981/diff/1/ Testing --- manual check Thanks, Myroslav

Re: Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.

2018-01-05 Thread Myroslav Papirkovskyy
t: https://reviews.apache.org/r/64984/#review194888 --- On Січ. 5, 2018, 8:59 після полудня, Myroslav Papirkovskyy wrote: > > --- > This is an automatically generated e

Review Request 64987: Add event for changes in alert groups.

2018-01-05 Thread Myroslav Papirkovskyy
9fdba33e9e36c37760619f2fe1c480e4a130dbbb ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 174604811311b08e93f41d807bf512b1235e8971 Diff: https://reviews.apache.org/r/64987/diff/1/ Testing --- manual testing Thanks, Myroslav Papirkovskyy

Review Request 64983: Setup heartbeat for api endpoint.

2018-01-05 Thread Myroslav Papirkovskyy
/ Testing --- manual testing Thanks, Myroslav Papirkovskyy

Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.

2018-01-05 Thread Myroslav Papirkovskyy
48864cc3baab7f7b0887f7dd68a5bbdcd9925698 Diff: https://reviews.apache.org/r/64984/diff/1/ Testing --- manual testing Thanks, Myroslav Papirkovskyy

Re: Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.

2018-01-05 Thread Myroslav Papirkovskyy
point for next refactoring though. - Myroslav Papirkovskyy On Січ. 5, 2018, 8:59 після полудня, Myroslav Papirkovskyy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 64990: Add event for changes in upgrade

2018-01-05 Thread Myroslav Papirkovskyy
/java/org/apache/ambari/server/events/listeners/upgrade/UpgradeUpdateListener.java PRE-CREATION Diff: https://reviews.apache.org/r/64990/diff/1/ Testing --- manual testing Thanks, Myroslav Papirkovskyy

Review Request 64979: Delete host event doesn't have hostName property.

2018-01-05 Thread Myroslav Papirkovskyy
stResourceProvider.java bd746f57c2dc6a9e948cbb387ce8329d6ff8eb18 Diff: https://reviews.apache.org/r/64979/diff/1/ Testing --- manual check Thanks, Myroslav Papirkovskyy

Review Request 64977: UI receives a topology event when turning on/off maintenance mode for the host

2018-01-05 Thread Myroslav Papirkovskyy
/TopologyComponent.java d96180dc02f362156d135d19e562e874f07545b6 ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/TopologyHost.java 9cdf9442ff96fe730d456037ae05a7becf9a97e9 Diff: https://reviews.apache.org/r/64977/diff/1/ Testing --- manual check Thanks, Myroslav