Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Robert Nettleton
used in a multi-collector environment? If so, is the value expected to be a comma-separated list of collectors? - Robert Nettleton On June 7, 2016, 8:12 a.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Robert Nettleton
> On June 7, 2016, 1:15 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java, > > line 38 > > <https://reviews.apache.org/r/48338/diff/1/?file=1408745#file1408745line38> > > > >

Review Request 48553: Blueprint processor should handle manual stack definition changes without failing deployment

2016-06-10 Thread Robert Nettleton
without my patch applied, so these failures are not caused by this current patch. Thanks, Robert Nettleton

Re: Review Request 48553: Blueprint processor should handle manual stack definition changes without failing deployment

2016-06-10 Thread Robert Nettleton
rified that these failures occur on trunk without my patch applied, so these failures are not caused by this current patch. 3. Ran "mvn clean test" with this morning's latest trunk src, with this patch applied, and the full suite passed: "Results : Tests run: 4477, Failures: 0, Errors: 0, Skipped: 34" Thanks, Robert Nettleton

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48348/#review137013 --- Ship it! Ship It! - Robert Nettleton On June 10, 2016, 3:08

Re: Review Request 48555: Kerberization of a cluster deletes ATS service

2016-06-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48555/#review137014 --- Ship it! Ship It! - Robert Nettleton On June 10, 2016, 2:51

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-13 Thread Robert Nettleton
onitor the state of the LogicalRequest as the deployment progresses. I would recommend asking Sumit to review this as well, since it's not clear to me that this is the approach that should be taken. - Robert Nettleton On June 11, 2016, 6:43 a.m., Daniel Gergely

Re: Review Request 48650: Add recently added logs to HadoopServiceConfig.json too

2016-06-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48650/#review137329 --- Ship it! Ship It! - Robert Nettleton On June 13, 2016, 4:28

Re: Review Request 48691: Removing and re-adding hosts makes database inconsitent

2016-06-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48691/#review137520 --- Ship it! Ship It! - Robert Nettleton On June 14, 2016, 2:51

Re: Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments

2016-06-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/#review137745 --- Ship it! - Robert Nettleton On June 15, 2016, 3:04 p.m

Re: Review Request 48727: Log Search default log levels can not be altered

2016-06-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48727/#review137746 --- Ship it! Ship It! - Robert Nettleton On June 15, 2016, 12

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-13 Thread Robert Nettleton
> On June 13, 2016, 4:51 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java, > > line 191 > > <https://reviews.apache.org/r/48266/diff/5/?file=1415529#file1415529line191> > > > > I'

Re: Review Request 48173: Fix logfeeder filter name of logsearch

2016-06-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48173/#review135954 --- Ship it! Ship It! - Robert Nettleton On June 2, 2016, 4:17

Re: Review Request 48121: YARN default configs are invalid

2016-06-02 Thread Robert Nettleton
are we sure that there are no properties in an HDP cluster that may consider trailing spaces to be a valid property value? It's probably fine, but just wanted to make sure we double-check this. Thanks. - Robert Nettleton On June 2, 2016, 4:38 p.m., Dmytro Sen

Re: Review Request 47886: Log Search Server start failed with KeeperException

2016-05-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47886/#review134967 --- Ship it! Ship It! - Robert Nettleton On May 26, 2016, 1:11

Re: Review Request 47586: Log Feeder Global exclusion default filter configuration is not effective in the log search indexing.

2016-06-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47586/#review135836 --- Ship it! Ship It! - Robert Nettleton On June 1, 2016, 6:20

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Robert Nettleton
> On June 16, 2016, 2:56 p.m., Robert Nettleton wrote: > > I believe this patch might have some issues that need clarification prior > > to merging this. > > > > The review and bug don't specify why this change is necessary, so I'm a > > little confused

Re: Review Request 49036: Allow https prtotocol for Log Search

2016-06-21 Thread Robert Nettleton
will have to uptake this new configuration option before the UI integration will work properly with HTTPS. I can implement that during my next set of LogSearch Integration changes. Thanks. - Robert Nettleton On June 21, 2016, 6:03 p.m., Miklos Gergely wrote

Re: Review Request 49033: Clear /security.json config on solr znode when kerberos is disabled.

2016-06-21 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49033/#review138912 --- Ship it! Ship It! - Robert Nettleton On June 21, 2016, 7:14

Re: Review Request 49036: Allow https prtotocol for Log Search

2016-06-21 Thread Robert Nettleton
> On June 21, 2016, 7:28 p.m., Robert Nettleton wrote: > > This looks fine to me. > > > > One question: Have you tested out the Ambari UI integration once HTTPS is > > enabled? I would expect this to fail, since this configuration option did > > no

Re: Review Request 48953: Open Advanced logsearch-admin-json upon install

2016-06-20 Thread Robert Nettleton
somebody on the Ambari UI team review this change as well. - Robert Nettleton On June 20, 2016, 2:35 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Robert Nettleton
estigation, and some clarification from the Metrics team. - Robert Nettleton On June 15, 2016, 1:35 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated

Re: Review Request 49268: Put logsearch log level filter into smartconfigs

2016-06-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49268/#review139587 --- Ship it! Ship It! - Robert Nettleton On June 27, 2016, 3:39

Re: Review Request 45030: Replace 0.0.0.0 with hostname in ams-site/timeline.metrics.service.webapp.address

2016-03-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45030/#review124190 --- Ship it! Ship It! - Robert Nettleton On March 18, 2016, 1

Re: Review Request 45390: Database Changes to Support Alert Repeat Tolerance

2016-03-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45390/#review125719 --- Ship it! Ship It! - Robert Nettleton On March 28, 2016, 5

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Robert Nettleton
w request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin > Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and > Yusaku Sako. > > > Bugs: AMBARI-15807 > https://issues.apache.org/jira/browse/AMBARI-15807 > > > Repository: ambar

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Robert Nettleton
ply, visit: > https://reviews.apache.org/r/45979/ > --- > > (Updated April 11, 2016, 4:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin > Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and &

Re: Review Request 46032: Restarting ambari-server after successful blueprint deploy of large cluster makes it unresponsive

2016-04-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46032/#review128128 --- Ship it! Ship It! - Robert Nettleton On April 11, 2016, 2

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Robert Nettleton
t; This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45979/ > --- > > (Updated April 11, 2016, 4:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk,

Re: Review Request 45978: AMBARI-15679: Stack definition for Logsearch

2016-04-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128139 --- Ship it! Ship It! - Robert Nettleton On April 9, 2016, 11

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Robert Nettleton
s://issues.apache.org/jira/browse/AMBARI-15807 > > > Repository: ambari > > > Description > --- > > Logsearch support was splitted into 3 different commits: > https://github.com/apache/ambari/tree/branch-dev-logsearch > - integrate logsearch module &

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-11 Thread Robert Nettleton
h support was splitted into 3 different commits: > https://github.com/apache/ambari/tree/branch-dev-logsearch > - integrate logsearch module > - ambari server REST implementation for logsearch > - stack definition > > This one is the REST implementation. (by Robert Nettlet

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-11 Thread Robert Nettleton
s, I'm happy to resolve that in a future patch, but I think using the constant is sufficient for now. Thanks. - Robert Nettleton On April 11, 2016, 4:27 p.m., Oliver Szabo wrote: > > --- > This is an automatically gener

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Robert Nettleton
- On April 8, 2016, 6 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45892/ > ------- > > (Updated April 8, 2016, 6 p.m.) > >

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-22 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44725/#review124874 --- Ship it! Ship It! - Robert Nettleton On March 22, 2016, 6

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

2016-03-23 Thread Robert Nettleton
- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44725/ > --- > > (Updated March 23, 2016, 1:40 a.m.) > > > Review request for Ambari, Robert Levas and Robert

Re: Review Request 45549: Blueprint installation with Hive without Atlas fails

2016-03-31 Thread Robert Nettleton
a unit test to the BlueprintConfigurationProcessorTest, just to make sure this issue doesn't regress in the future. Thanks. - Robert Nettleton On March 31, 2016, 4:36 p.m., Andrew Onischuk wrote: > > --- > This is a

Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Robert Nettleton
seem to be installed/started as expected. 2. Currently running ambari-server's "mvn clean test" suite, and will update with results once that is completed. Thanks, Robert Nettleton

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Robert Nettleton
----- On April 13, 2016, 2:28 p.m., Robert Nettleton wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46147/ >

Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Robert Nettleton
[INFO] Final Memory: 38M/720M [INFO] ———————— " Thanks, Robert Nettleton

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Robert Nettleton
eviews.apache.org/r/46639/#review130431 --- On April 25, 2016, 3:28 p.m., Robert Nettleton wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review130409 --- Ship it! Ship It! - Robert Nettleton On April 22, 2016, 6

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Robert Nettleton
is too generic for me, can this be more specified ? (like > > SomethingUtils.java, i know its in a specified package, but maybe it would > > be easier to find with a less generic name) > > Robert Nettleton wrote: > I'm not sure I agree that the name is too generic, si

Re: Review Request 46639: Add counter limits to LogSearch integration error logs that occur during failed connection attempts

2016-04-25 Thread Robert Nettleton
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46639/#review130435 ------- On April 25, 2016, 3:28 p.m., Robert Nettleton wrote: > > --- > This is

Review Request 46507: Updates LogSearch Integration to obtain LogSearch credential from configuration

2016-04-21 Thread Robert Nettleton
0, Skipped: 32 Thanks, Robert Nettleton

Re: Review Request 46544: AMBARI-16028: Namenode marked as INITIAL standby could potentially never start if other namenode is down

2016-04-22 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46544/#review130117 --- Ship it! Ship It! - Robert Nettleton On April 21, 2016, 10

Re: Review Request 46746: AMBARI-16141 Add configuration dependencies for Logsearch components

2016-04-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46746/#review130910 --- Ship it! Ship It! - Robert Nettleton On April 27, 2016, 6

Re: Review Request 46709: Update LogSearch integration layer to use proper query parameter names for LogSearch

2016-04-27 Thread Robert Nettleton
ce. 2. Deployed a 3-node vagrant cluster successfully without LogSearch enabled. Verified that no LogSearch-related logging or errors appear in ambari-server.log or ambari-server.out. 3. Ran the ambari-server "mvn clean test" suite with my changes applied, with the suite passing completely. Thanks, Robert Nettleton

Re: Review Request 46789: Log_Feeder component logs not picked up

2016-04-28 Thread Robert Nettleton
I think this should be "ignore_failures". This seems like something the python unit tests should catch as well. - Robert Nettleton On April 28, 2016, 4:54 p.m., Oliver Szabo wrote: > > --- > This i

Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not getting reflected at the backend

2016-04-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46702/#review130632 --- Ship it! Ship It! - Robert Nettleton On April 26, 2016, 3

Re: Review Request 47726: Blueprint Export does not replace hive.llap.zk.sm.connectionString

2016-05-23 Thread Robert Nettleton
d here to verify this change. - Robert Nettleton On May 23, 2016, 2:07 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47726: Blueprint Export does not replace hive.llap.zk.sm.connectionString

2016-05-23 Thread Robert Nettleton
> On May 23, 2016, 2:59 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2395 > > <https://reviews.apache.org/r/47726/diff/1/?file=1391619#file1391619line2395> >

Re: Review Request 45507: Enhance blueprint support for using references

2016-05-23 Thread Robert Nettleton
comment above, it's my opinion that passwords should be excluded. The Blueprints processor already has checks to fail a deployment attempt if a password is missing, and already has the support for the "default password" feature in non-production environments. - Robert Nettleton On May 12

Re: Review Request 47726: Blueprint Export does not replace hive.llap.zk.sm.connectionString

2016-05-24 Thread Robert Nettleton
> On May 23, 2016, 2:59 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2395 > > <https://reviews.apache.org/r/47726/diff/1/?file=1391619#file1391619line2395> >

Re: Review Request 47766: Host name resolution for dfs_ha_initial_namenode_active and dfs_ha_initial_namenode_standby properties.

2016-05-24 Thread Robert Nettleton
tps://reviews.apache.org/r/47766/#comment199419> Minor issue: Can you please use explicit imports here? In Ambari, we generally try to avoid * imports for classes. Thanks. - Robert Nettleton On May 24, 2016, 12:19 p.m., Balázs Bence Sári

Re: Review Request 47226: AMBARI-16444 Ambari router field is not configurable in solr-client

2016-05-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47226/#review132657 --- Ship it! Ship It! - Robert Nettleton On May 11, 2016, 9:32

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Robert Nettleton
java (line 56) <https://reviews.apache.org/r/47296/#comment197174> Wouldn't it be simpler to just override the toString() methods for this enumerated type? - Robert Nettleton On May 12, 2016, 11:31 a.m., Dharmesh Makwana wrote: > > --- >

Re: Review Request 47271: Use consistent names for Log Search service

2016-05-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47271/#review132922 --- Ship it! Ship It! - Robert Nettleton On May 12, 2016, 12:28

Re: Review Request 47452: Do not use implicit routing by default in solr-client

2016-05-17 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47452/#review133578 --- Ship it! Ship It! - Robert Nettleton On May 17, 2016, 1:29

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Robert Nettleton
> On May 12, 2016, 1:35 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java, > > line 46 > > <https://reviews.apache.org/r/47296/diff/2/?file=1381276#file1381276line46> > > > >

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review133099 --- Ship it! Ship It! - Robert Nettleton On May 13, 2016, 6:48

Re: Review Request 46931: Updated grok lib version(0.1.1 to 0.1.4) to get latest fixes.

2016-05-03 Thread Robert Nettleton
> On May 3, 2016, 8:28 p.m., Sumit Mohanty wrote: > > Ship It! I've just pushed this patch to trunk. Could the submitter please close out this ReviewBoard as "Submitted"? Thanks. - Robert --- This is an automatically generated

Re: Review Request 47022: Change default username for Logsearch server to ambari_admin

2016-05-05 Thread Robert Nettleton
r something like that. The name proposed in this patch will probably be a little confusing for users, since "ambari_user" might appear to be a username for logging into Ambari, when in fact this username is specifically for the LogSearch server. - Robert Nettleton On May 5, 2016, 3:4

Re: Review Request 46999: AMBARI-16261: LogFeeder logs are not showing up in LogSearch

2016-05-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46999/#review131872 --- Ship it! Ship It! - Robert Nettleton On May 5, 2016, 12:49

Re: Review Request 47067: Separate number of shards and replication factor configurations for audit logs and service logs (logseach solr)

2016-05-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47067/#review132066 --- Ship it! Ship It! - Robert Nettleton On May 6, 2016, 2:59

Re: Review Request 46973: Amanded handling of excluded config-types handling in case of blueprint deployments

2016-05-04 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46973/#review131696 --- Ship it! Ship It! - Robert Nettleton On May 4, 2016, 3:11

Re: Review Request 46981: Logsearch: Basic stack advisor recommendation (shard/replication)

2016-05-04 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46981/#review131698 --- Ship it! Ship It! - Robert Nettleton On May 4, 2016, 3:30

Re: Review Request 47022: Change default username for Logsearch server to ambar_logsearch_admin

2016-05-05 Thread Robert Nettleton
> On May 5, 2016, 5:30 p.m., Robert Nettleton wrote: > > The patch looks fine to me, just needs a minor fix listed below. > > > > Regarding the open question, I don't think there is much that can be done > > in the short term on this one. The Ambari Integration co

Re: Review Request 46999: AMBARI-16261: LogFeeder logs are not showing up in LogSearch

2016-05-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46999/#review132427 --- Ship it! Ship It! - Robert Nettleton On May 10, 2016, 7:34

Re: Review Request 47163: AMBARI-16420: LogFeeder not using fully qualified domain name

2016-05-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47163/#review132425 --- Ship it! Ship It! - Robert Nettleton On May 10, 2016, 7:58

Review Request 46941: Add Zookeeper dependency to LogSearch components for better Blueprint validation

2016-05-03 Thread Robert Nettleton
loys properly as well. 2. Ran the ambari-server "mvn clean test" suite, which passed completely with this patch applied. Thanks, Robert Nettleton

Review Request 46387: Add Log Level count support to LogSearch integration

2016-04-19 Thread Robert Nettleton
. Deployed a single-node cluster with LogSearch included, verified that the cluster deployed successfully, and that the REST APIs are functioning as expected with respect to LogSearch. 3. I'm starting a local "mvn clean test" run now, and will post the results when available. Thanks, Robert Nettleton

Re: Review Request 46387: Add Log Level count support to LogSearch integration

2016-04-19 Thread Robert Nettleton
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/46387/#review129522 ------- On April 19, 2016, 1:27 p.m., Robert Nettleton wrote: > > --- > This is an au

Re: Review Request 46387: Add Log Level count support to LogSearch integration

2016-04-19 Thread Robert Nettleton
expected with respect to LogSearch. 3. I'm starting a local "mvn clean test" run now, and will post the results when available. Thanks, Robert Nettleton

Re: Review Request 46387: Add Log Level count support to LogSearch integration

2016-04-19 Thread Robert Nettleton
an expected failure on trunk, and is not caused by this current patch. Thanks, Robert Nettleton

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-19 Thread Robert Nettleton
tay, perhaps in some modified form. ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java <https://reviews.apache.org/r/45507/#comment193051> As above, I'd recommend re-introducing this test once the PasswordFilter has been r

Re: Review Request 46317: Basic authentication for Logsearch service

2016-04-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46317/#review129324 --- Ship it! Ship It! - Robert Nettleton On April 18, 2016, 10

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Robert Nettleton
I'm not certain that the tests using the public property should be modified. I'd recommend adding new unit tests to verify that the internal property being added here is handled properly. - Robert Nettleton On April 18, 2016, 1:07 p.m.

Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

2016-04-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46198/#review128886 --- Ship it! Ship It! - Robert Nettleton On April 14, 2016, 12

Re: Review Request 46196: Logsearch: reading config values from external property files

2016-04-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46196/#review128894 --- Ship it! Ship It! - Robert Nettleton On April 14, 2016, 11

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

2016-04-18 Thread Robert Nettleton
> On April 18, 2016, 1:39 p.m., Robert Nettleton wrote: > > Could we get some more background context as to why this change is > > necessary? I've checked the associated Apache JIRA, and there isn't much > > information there. > > > > In particular, can

Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Robert Nettleton
rvices/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 (line 21) <https://reviews.apache.org/r/47119/#comment196466> Should this property ever be configured by a user, or should this value always be "history"? - Robert Nettleton On May 9, 2016, 2 p.

Re: Review Request 47119: LogFeeder: enable/disable log level filter

2016-05-09 Thread Robert Nettleton
> On May 9, 2016, 2:42 p.m., Robert Nettleton wrote: > > Overal the patch looks fine to me, just with a few minor issues below that > > need clarification. > > > > One additional question: How is the filter itself configured to a specific > > log level?

Re: Review Request 47118: Fixed Typo in logfeeder property name

2016-05-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47118/#review132278 --- Ship it! Ship It! - Robert Nettleton On May 9, 2016, 12:53

Re: Review Request 50656: Improvements/fixes for AMBARI_INFRA initial service definition

2016-08-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50656/#review144335 --- Ship it! Ship It! - Robert Nettleton On Aug. 1, 2016, 12:22

Re: Review Request 50988: Ambari upgrade to Ambari 2.4.0.0 did not change the krb5.conf template

2016-08-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50988/#review145519 --- Ship it! Ship It! - Robert Nettleton On Aug. 11, 2016, 3:41

Re: Review Request 50753: Cleared cached resources from ambari-server on host removal

2016-08-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50753/#review144618 --- Ship it! Ship It! - Robert Nettleton On Aug. 3, 2016, 2:47

Review Request 50238: Fix NullPointerException in Ambari LogSearch integration

2016-07-20 Thread Robert Nettleton
st be a separate breakage in trunk, unrelated to this change. Thanks, Robert Nettleton

Re: Review Request 50241: Tech preview text added for Logsearch service definition description

2016-07-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50241/#review142957 --- Ship it! Ship It! - Robert Nettleton On July 20, 2016, 4:13

Review Request 50109: Add check for null LoggingRequestHelper in the LogSearch Integration LogSearchDataRetrievalService class

2016-07-16 Thread Robert Nettleton
ari-server "mvn clean test" suite on trunk with this patch applied, and the suite passes completely. Thanks, Robert Nettleton

Re: Review Request 49972: Check znode exits with retry during logsearch server setup too (for blueprints)

2016-07-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49972/#review142064 --- Ship it! Ship It! - Robert Nettleton On July 12, 2016, 11

Re: Review Request 50822: Enforce granular role-based access control for log search functions

2016-08-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50822/#review144926 --- Ship it! Ship It! - Robert Nettleton On Aug. 4, 2016, 11:04

Re: Review Request 50870: Introduce validation of hostgroup mapping for active/standby namenode

2016-08-08 Thread Robert Nettleton
e properties that are configured incorrectly. ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java (line 234) <https://reviews.apache.org/r/50870/#comment211297> Same as my comment above, regarding adding the property names here for simpler debugging in the

Re: Review Request 50865: Starting a Component After Pausing An Upgrade Can Take 9 Minutes

2016-08-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50865/#review144980 --- Ship it! Ship It! - Robert Nettleton On Aug. 5, 2016, 8:37

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/#review143979 --- Ship it! Ship It! - Robert Nettleton On July 28, 2016, 6:09

Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

2016-06-30 Thread Robert Nettleton
is not included in the cluster. Thanks, Robert Nettleton

Re: Review Request 49505: AMBARI-17521: If Solr is configured to use implicit routing, then replicationFactor is ignored

2016-07-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49505/#review140344 --- Ship it! Ship It! - Robert Nettleton On July 1, 2016, 11:20

Re: Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

2016-07-01 Thread Robert Nettleton
rly, and that the Ambari REST "host_components" resource returns properly when LogSearch is not included in the cluster. Thanks, Robert Nettleton

Re: Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

2016-07-01 Thread Robert Nettleton
151 > > <https://reviews.apache.org/r/49474/diff/1/?file=1434487#file1434487line149> > > > > Maybe only enqueue requests if the same request isn't on the queue. I agree with your suggestion, but would like to address this issue in a separate patch. I've filed the following J

Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie

2016-08-15 Thread Robert Nettleton
the review with the manual testing you've done with this patch applied? We'd probably need to make sure that the Blueprint cluster deployment, and a Blueprint export, both function properly with this change applied. Thanks. - Robert Nettleton On Aug. 12, 2016, 11:48 p.m., Amruta Borkar wrote

  1   2   3   4   >