Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-07 Thread Sebastian Toader
pe.Provision''' ? - Sebastian Toader On June 7, 2016, 9:47 a.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-09 Thread Sebastian Toader
ke "Cluster creation request X using Blueprint Y successfully completed !" for success. In case of failure "Cluster creation request X using Blueprint Y failed !" - Sebastian Toader On June 9, 2016, 2:54 p.m., Daniel Gergely wrote: > > --

Re: Review Request 48325: Unit tests failing because of the order of hash sets/maps

2016-06-07 Thread Sebastian Toader
ari/server/controller/internal/ComponentResourceProviderTest.java (lines 229 - 231) <https://reviews.apache.org/r/48325/#comment201502> Can you comment how this change relates to the hash/sets ordering? - Sebastian Toader On June 7, 20

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48348/#review137019 --- Ship it! Ship It! - Sebastian Toader On June 10, 2016, 5:08

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Sebastian Toader
imming strategies' into separate methods. Factor out into methods the logic that indetifies what the type properties and map what trimming strategy to be used for a property. - Sebastian Toader On June 9, 2016, 5:23 p.m., Dmytro Sen

Re: Review Request 48501: AMBARI-17147: OSError: [Errno 1] Operation not permitted with non-root ambari agent user

2016-06-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48501/#review136982 --- Ship it! Ship It! - Sebastian Toader On June 9, 2016, 8:56

Re: Review Request 47766: Host name resolution for dfs_ha_initial_namenode_active and dfs_ha_initial_namenode_standby properties.

2016-05-25 Thread Sebastian Toader
by Robert Nettleton through manual testing. - Sebastian Toader On May 24, 2016, 3:29 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137133 --- Ship it! Ship It! - Sebastian Toader On June 11, 2016, 8:43

Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed

2016-06-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/#review137315 --- Ship it! Ship It! - Sebastian Toader On June 13, 2016, 5:04

Re: Review Request 48691: Removing and re-adding hosts makes database inconsitent

2016-06-14 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48691/#review137521 --- Ship it! Ship It! - Sebastian Toader On June 14, 2016, 4:51

Re: Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/#review137754 --- Ship it! Ship It! - Sebastian Toader On June 15, 2016, 5:04

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
szlo do you see any issues with that? - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137750 -------

Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search

2016-06-15 Thread Sebastian Toader
making property names string costants in the java code. - Sebastian Toader On June 15, 2016, 11:24 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java 627ade9 Diff: https://reviews.apache.org/r/48722/diff/ Testing --- Manual testing. Unit tests in progress. Thanks, Sebastian Toader

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137713 --- Ship it! Ship It! - Sebastian Toader On June 15, 2016, 1:33

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review137714 --- Ship it! Ship It! - Sebastian Toader On June 14, 2016, 3:45

Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/#review137710 --- Ship it! Ship It! - Sebastian Toader On June 15, 2016, 1:41

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
, Sebastian Toader

Re: Review Request 48169: Ensure smokeuser HDFS folder exists before running MR, YARN, PIG, OOZIE service checks

2016-06-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48169/#review135956 --- Ship it! Ship It! - Sebastian Toader On June 2, 2016, 4:38

Re: Review Request 48121: YARN default configs are invalid

2016-06-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48121/#review135959 --- Ship it! Ship It! - Sebastian Toader On June 2, 2016, 6:38

Re: Review Request 48741: LogSearch Solr kerberos support

2016-06-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/#review138819 --- Ship it! Ship It! - Sebastian Toader On June 21, 2016, 12

Re: Review Request 49033: Clear /security.json config on solr znode when kerberos is disabled.

2016-06-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49033/#review139018 --- Ship it! Ship It! - Sebastian Toader On June 21, 2016, 9:14

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-22 Thread Sebastian Toader
: https://reviews.apache.org/r/48722/diff/ Testing --- Manual testing. Unit tests in succeeded. Thanks, Sebastian Toader

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-22 Thread Sebastian Toader
in succeeded. Thanks, Sebastian Toader

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-21 Thread Sebastian Toader
ws.apache.org/r/48722/#review138605 --- On June 21, 2016, 5:19 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-21 Thread Sebastian Toader
/ambari/server/state/cluster/ClusterImplTest.java 627ade9 Diff: https://reviews.apache.org/r/48722/diff/ Testing --- Manual testing. Unit tests in succeeded. Thanks, Sebastian Toader

Re: Review Request 48854: Logsearch: retry logic for znode creation during Solr startup

2016-06-20 Thread Sebastian Toader
.0/package/scripts/setup_ranger_xml.py (line 551) <https://reviews.apache.org/r/48854/#comment203742> Why the retry params are passed instead of using any of the rety annotations directly on the upload_configuration_to_zk function? - Sebastian Toader On June 17, 2016, 8:38

Re: Review Request 48854: Logsearch: retry logic for znode creation during Solr startup

2016-06-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48854/#review138575 --- Ship it! Ship It! - Sebastian Toader On June 20, 2016, 11

Re: Review Request 48866: Service check for logsearch server

2016-06-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48866/#review138599 --- Ship it! Ship It! - Sebastian Toader On June 20, 2016, 4:11

Re: Review Request 48866: Service check for logsearch server

2016-06-20 Thread Sebastian Toader
/package/scripts/params.py (line 332) <https://reviews.apache.org/r/48866/#comment203801> Will this work correctly if no 'logsearch_server' is added to the cluster? - Sebastian Toader On June 20, 2016, 3:41 p.m., Oliver Szabo

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Sebastian Toader
/state/cluster/ClusterImplTest.java 627ade9 Diff: https://reviews.apache.org/r/48722/diff/ Testing --- Manual testing. Unit tests in succeeded. Thanks, Sebastian Toader

Re: Review Request 48794: Ambari Server setup of proxyuser should set default values

2016-06-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48794/#review137986 --- Ship it! Ship It! - Sebastian Toader On June 16, 2016, 4:28

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-16 Thread Sebastian Toader
/ Testing --- Manual testing. Unit tests in succeeded. Thanks, Sebastian Toader

Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-24 Thread Sebastian Toader
. Added LSB to ambari-server and amabri-agent to define the default start and stop levels Diffs - ambari-agent/etc/init.d/ambari-agent b2c3109 ambari-server/sbin/ambari-server 72d94ed Diff: https://reviews.apache.org/r/49188/diff/ Testing --- Thanks, Sebastian Toader

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

2016-06-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/#review139675 --- Ship it! Ship It! - Sebastian Toader On June 27, 2016, 4:01

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-27 Thread Sebastian Toader
(updated) --- Manual testing disabeling/enabling ambari-server via 'update-rc.d ambari-server disable/enable' Thanks, Sebastian Toader

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-25 Thread Sebastian Toader
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49188/#review139390 --- On June 24, 2016, 9:56 a.m., Sebastian Toader wrote: > > --- > This is a

Re: Review Request 44969: After upgrading from Ambari 2.1.2 to 2.2.1, HDP from 2.3.0 to 2.3.4 , user is getting 'Consistency Check Failed' error while trying to save configuration in Ranger, Hive and

2016-03-18 Thread Sebastian Toader
c/test/python/stacks/2.2/common/test_stack_advisor.py unit test covers this test case. - Sebastian Toader On March 17, 2016, 6:50 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 44958: Increase Ambari Server Perm gen default value

2016-03-18 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44958/#review124026 --- Ship it! Ship It! - Sebastian Toader On March 17, 2016, 3

Re: Review Request 44956: Topology host info is not cleared when a host is removed

2016-03-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44956/#review124168 --- Ship it! Ship It! - Sebastian Toader On March 18, 2016, 10

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

2016-04-07 Thread Sebastian Toader
/test_webhcat_server.py 86f185d Diff: https://reviews.apache.org/r/45833/diff/ Testing --- Manual testing. Ambari server python unit tests: -- Total run:944 Total errors:0 Total failures:0 Thanks, Sebastian Toader

Re: Review Request 45538: Audit Log Code Cleanup & Safety

2016-04-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45538/#review127582 --- Ship it! Ship It! - Sebastian Toader On April 7, 2016, 1:47

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

2016-04-07 Thread Sebastian Toader
: -- Total run:944 Total errors:0 Total failures:0 Thanks, Sebastian Toader

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

2016-04-06 Thread Sebastian Toader
/test_webhcat_server.py 6fe49dc Diff: https://reviews.apache.org/r/45833/diff/ Testing --- Manual testing. Ambari server python unit tests: -- Total run:944 Total errors:0 Total failures:0 Thanks, Sebastian Toader

Review Request 45833: Webhcat Server failed to stop while stopping all the services

2016-04-06 Thread Sebastian Toader
6fe49dc Diff: https://reviews.apache.org/r/45833/diff/ Testing --- Manual testing. Ambari server python unit tests: -- Total run:944 Total errors:0 Total failures:0 Thanks, Sebastian Toader

Re: Review Request 45538: Audit Log Code Cleanup & Safety

2016-04-07 Thread Sebastian Toader
tDetails.Component directly? - Sebastian Toader On April 6, 2016, 6:08 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128625 --- Ship it! Ship It! - Sebastian Toader On April 12, 2016, 6

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-13 Thread Sebastian Toader
xmaple `StackManagerTest.testServicesWithRangerPluginRoleCommandOrder()` - Sebastian Toader On April 12, 2016, 6:27 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 46032: Restarting ambari-server after successful blueprint deploy of large cluster makes it unresponsive

2016-04-11 Thread Sebastian Toader
://reviews.apache.org/r/46032/diff/ Testing --- Manual testing using cluster creation templates with host groups with multiple hosts specified through fixed fqdn list and also host predicates. Unit tests: Results : Tests run: 3550, Failures: 0, Errors: 0, Skipped: 36 Thanks, Sebastian Toader

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128659 --- Ship it! Ship It! - Sebastian Toader On April 13, 2016, 1

Re: Review Request 46032: Restarting ambari-server after successful blueprint deploy of large cluster makes it unresponsive

2016-04-11 Thread Sebastian Toader
: Tests run: 3550, Failures: 0, Errors: 0, Skipped: 36 Thanks, Sebastian Toader

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Sebastian Toader
io to invoke this method for a wrong cluster and continue the running of the sever? - Sebastian Toader On April 11, 2016, 6:27 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-12 Thread Sebastian Toader
<https://reviews.apache.org/r/46021/#comment191771> Regex may give more flexivility (e.g handle white spaces, validate if the request URI is in the appropriate format before extracting hostname from it). - Sebastian Toader On April 11, 2016, 5:51 p.m., Daniel G

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-12 Thread Sebastian Toader
for `logsearch.py`. Applies here as well. - Sebastian Toader On April 11, 2016, 6:29 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-12 Thread Sebastian Toader
/request/eventcreator/HostEventCreator.java (line 153) <https://reviews.apache.org/r/46021/#comment191816> The equivalent for this is: `if (matcher.find())` - Sebastian Toader On April 12, 2016, 2:09 p.m., Daniel Gergely

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128389 --- Ship it! Ship It! - Sebastian Toader On April 11, 2016, 6

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review128398 --- Ship it! Ship It! - Sebastian Toader On April 11, 2016, 4

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/#review128399 --- Ship it! Ship It! - Sebastian Toader On April 12, 2016, 3

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review128417 --- Ship it! Ship It! - Sebastian Toader On April 12, 2016, 4

Re: Review Request 46000: Parallel execution should only be allowed on commands that have auto retry enabled

2016-04-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46000/#review128088 --- Ship it! Ship It! - Sebastian Toader On April 11, 2016, 6

Re: Review Request 44956: Topology host info is not cleared when a host is removed

2016-03-19 Thread Sebastian Toader
ne 175) <https://reviews.apache.org/r/44956/#comment186388> Looks like unfinished comment - Sebastian Toader On March 17, 2016, 1:59 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 43832: AMBARI-14627: Ability to automate setup-security and setup-ldap/sync-ldap

2016-03-22 Thread Sebastian Toader
- > > (Updated March 16, 2016, 6:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert > Levas, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-14627 > https://issues.apache.org/jira/browse/AMBARI-14627 &

Re: Review Request 45220: /tmp hdfs folder created with mode 0777

2016-03-23 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45220/#review125110 --- Ship it! Ship it once all unit test pass ! - Sebastian Toader

Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user

2016-03-24 Thread Sebastian Toader
bari server unit tests: Results : Tests run: 4035, Failures: 0, Errors: 0, Skipped: 33 Thanks, Sebastian Toader

Re: Review Request 45220: /tmp hdfs folder created with mode 0777

2016-03-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45220/#review125250 --- Ship it! Ship It! - Sebastian Toader On March 24, 2016, 1

Re: Review Request 45284: Ambari LDAP integration cannot handle LDAP directories with multiple entries for the same user

2016-03-24 Thread Sebastian Toader
, visit: https://reviews.apache.org/r/45284/#review125279 ------- On March 24, 2016, 2:04 p.m., Sebastian Toader wrote: > > --- > This is an automatically gener

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

2016-03-21 Thread Sebastian Toader
/ Testing (updated) --- Manual testing done. Unit tests results: Results : Tests run: 3534, Failures: 0, Errors: 0, Skipped: 36 Thanks, Sebastian Toader

Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

2016-03-21 Thread Sebastian Toader
/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java ac2fb22 Diff: https://reviews.apache.org/r/45101/diff/ Testing --- Manual testing done. Unit tests are running. Thanks, Sebastian Toader

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

2016-03-21 Thread Sebastian Toader
/45101/diff/ Testing --- Manual testing done. Unit tests are running. Thanks, Sebastian Toader

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

2016-03-21 Thread Sebastian Toader
ac2fb22 ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 80697f1 Diff: https://reviews.apache.org/r/45101/diff/ Testing --- Manual testing done. Unit tests results: Results : Tests run: 3534, Failures: 0, Errors: 0, Skipped: 36 Thanks, Sebastian Toader

Re: Review Request 44969: After upgrading from Ambari 2.1.2 to 2.2.1, HDP from 2.3.0 to 2.3.4 , user is getting 'Consistency Check Failed' error while trying to save configuration in Ranger, Hive and

2016-03-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44969/#review124196 --- Ship it! Ship it ! - Sebastian Toader On March 18, 2016, 4

Re: Review Request 45253: AMBARI-15544: Creating multinode cluster using Blueprints fails.

2016-03-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45253/#review125220 --- Ship it! Ship It! - Sebastian Toader On March 23, 2016, 11

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-24 Thread Sebastian Toader
/ldap/AmbariLdapDataPopulator.java (line 508) <https://reviews.apache.org/r/45208/#comment188019> Why not use regexp here? Regexp may just provide the functionallity and flexibilty needed here out of the box. - Sebastian Toader On March 23, 2016, 2:28 p.m., Oliver Szabo

Review Request 44509: Blueprints: NullPointerException when unncessary config types found with %HOSTGROUP% tags

2016-03-08 Thread Sebastian Toader
/r/44509/diff/ Testing --- 1.Unitest have been modified to cover this corner case as well. 2. Manual testing with Blueprints having configurations only in host groups. Thanks, Sebastian Toader

Re: Review Request 44509: Blueprints: NullPointerException when unncessary config types found with %HOSTGROUP% tags

2016-03-08 Thread Sebastian Toader
/java/org/apache/ambari/server/topology/TopologyManagerTest.java 69c1935 Diff: https://reviews.apache.org/r/44509/diff/ Testing --- 1.Unitest have been modified to cover this corner case as well. 2. Manual testing with Blueprints having configurations only in host groups. Thanks, Sebastian

Re: Review Request 45538: Audit Log Code Cleanup & Safety

2016-04-04 Thread Sebastian Toader
wice as the while loop above will log it as well. ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AbstractBaseEventCreator.java (line 28) <https://reviews.apache.org/r/45538/#comment189917> Documenr the purpose of this class. - Sebastian Toader On

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/#review126068 --- Ship it! Ship It! - Sebastian Toader On March 30, 2016, 11

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Sebastian Toader
2016, 5:20 p.m.) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor > Magyari, and Sebastian Toader. > > > Bugs: AMBARI-15241 > https://issues.apache.org/jira/browse/AMBARI-15241 > > > Repository: amb

Review Request 45544: During cluster creation using Blueprints the cluster creation request has incorrect COMPLETED state instead of PENDING.

2016-03-31 Thread Sebastian Toader
esourceProvider.java d00ce58 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 4a76a1c Diff: https://reviews.apache.org/r/45544/diff/ Testing --- Manual testing and unit tests: Results : Tests run: 3543, Failures: 0, Errors: 0, Skipped: 36 Thanks, Sebastian Toader

Re: Review Request 45548: Upgrading Kerberized JournalNode requires HDFS principal to perform 'role edits' task

2016-04-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45548/#review126562 --- Ship it! Ship It! - Sebastian Toader On March 31, 2016, 6

Re: Review Request 45579: Unable to Create Cluster Fails Due To Audit Logger

2016-04-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45579/#review126575 --- Ship it! Ship It! - Sebastian Toader On April 1, 2016, 12

Re: Review Request 45587: Upgrade to trunk fails due AuditLogger

2016-04-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45587/#review126578 --- Ship it! Ship It! - Sebastian Toader On April 1, 2016, 3:20

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Sebastian Toader
y/ldap/AmbariLdapDataPopulator.java (line 780) <https://reviews.apache.org/r/45208/#comment188949> I think it should be logged somewhere that this user will be ignored. Use 'out of scope of' instead 'out of scope from' - Sebastian Toader On March 29, 2016, 6:06 p.m., Oliver

Re: Review Request 45544: During cluster creation using Blueprints the cluster creation request has incorrect COMPLETED state instead of PENDING.

2016-03-31 Thread Sebastian Toader
eviews.apache.org/r/45544/#review126368 --- On March 31, 2016, 4:28 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 46148: NPE when deleting a host

2016-04-14 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46148/#review128869 --- Ship it! Ship It! - Sebastian Toader On April 14, 2016, 12

Re: Review Request 46148: NPE when deleting a host

2016-04-14 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46148/#review128880 --- Ship it! Ship It! - Sebastian Toader On April 14, 2016, 1

Review Request 46695: User imported from AD is unable to login to Ambari

2016-04-26 Thread Sebastian Toader
on both OpenLDAP and AD. Unit tests are in progress. Thanks, Sebastian Toader

Re: Review Request 46695: User imported from AD is unable to login to Ambari

2016-04-26 Thread Sebastian Toader
98b97b2 Diff: https://reviews.apache.org/r/46695/diff/ Testing --- Tested manually on both OpenLDAP and AD. Unit tests are in progress. Thanks, Sebastian Toader

Re: Review Request 46695: User imported from AD is unable to login to Ambari

2016-04-26 Thread Sebastian Toader
Diff: https://reviews.apache.org/r/46695/diff/ Testing --- Tested manually on both OpenLDAP and AD. Unit tests are in progress. Thanks, Sebastian Toader

Re: Review Request 46695: User imported from AD is unable to login to Ambari

2016-04-26 Thread Sebastian Toader
Total failures:0 Thanks, Sebastian Toader

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47596/#review134122 --- Ship it! Ship It! - Sebastian Toader On May 20, 2016, 10:01

Re: Review Request 47726: Blueprint Export does not replace hive.llap.zk.sm.connectionString

2016-05-23 Thread Sebastian Toader
/ambari/server/controller/internal/BlueprintConfigurationProcessor.java (line 2395) <https://reviews.apache.org/r/47726/#comment199146> Add unit test to ensure that we catch if this is removed accidentally. - Sebastian Toader On May 23, 2016, 4:07 p.m., Daniel Gergely

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-19 Thread Sebastian Toader
oesn't has to be changed in two places if the default value changes. As an example look at ```{{storm_thrift_transport}}``` in storm-site.xml and storm's params_linux.py - Sebastian Toader On May 19, 2016, 6:55 p.m., Daniel Gergely

Re: Review Request 47117: HiveServer interactive fails to start

2016-05-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47117/#review132677 --- Ship it! Ship It! - Sebastian Toader On May 11, 2016, 4:53

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review132890 --- Ship it! Ship It! - Sebastian Toader On May 12, 2016, 2:58

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

2016-05-12 Thread Sebastian Toader
uot; + ", clusterName=" + getClusterName() + ", clusterId=" + getClusterId() + ", serviceName=" + service.getName()); } ``` is not needed any more? Is it a valid use case to re-add a service to an existing cluster? - Se

Re: Review Request 47297: Extend logging for ActionQueue's retry logic

2016-05-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47297/#review132877 --- Ship it! Ship It! - Sebastian Toader On May 12, 2016, 11:05

Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered

2016-05-05 Thread Sebastian Toader
On May 5, 2016, 5:55 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47014/ > ---

Review Request 46899: Disable alternate user search functionality by default

2016-05-02 Thread Sebastian Toader
/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java b076e85 Diff: https://reviews.apache.org/r/46899/diff/ Testing --- Performed manual testing. Unit test results: Results : Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32 Thanks, Sebastian Toader

Re: Review Request 46973: Amanded handling of excluded config-types handling in case of blueprint deployments

2016-05-04 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46973/#review131700 --- Ship it! Ship It! - Sebastian Toader On May 4, 2016, 5:11

  1   2   3   4   5   6   >