/step3_controller.js
5ff2cdc1b4bb9da20565fe387765b4fc6728e096
ambari-web/test/controllers/wizard/step3_test.js
be1affe28fdcdb3404ebd3fb3fc6e61315483ed2
Diff: https://reviews.apache.org/r/64242/diff/1/
Testing
---
Tests were successful in ambari-web and ambari-server.
Thanks,
Sonia Garudi
192705
-------
On Dec. 1, 2017, 7:47 a.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/642
://reviews.apache.org/r/63945/diff/1/
Testing
---
Tests were successful in ambari-web and ambari-server.
Thanks,
Sonia Garudi
/
Testing
---
Tests were successful in ambari-web and ambari-server.
Thanks,
Sonia Garudi
e00012c
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/63945/diff/2/
Changes: https://reviews.apache.org/r/63945/diff/1-2/
Testing
---
Tests were successful in ambari-web and ambari-server.
Thanks,
Sonia Garudi
How many URLs are we talking about here. If more than one, should this
> > bet a Set?
>
> Sonia Garudi wrote:
> ambariRepoUrls is a json string having ambari repo URLs for each os type
> which is sent from the UI.
>
> Nate Cole wrote:
> Can I see an example?
&g
How many URLs are we talking about here. If more than one, should this
> > bet a Set?
>
> Sonia Garudi wrote:
> ambariRepoUrls is a json string having ambari repo URLs for each os type
> which is sent from the UI.
>
> Nate Cole wrote:
> Can I see an example?
/64769/diff/1-2/
Testing
---
Tests were successful in ambari-web
Thanks,
Sonia Garudi
/ajax.js 3f85dfdc
ambari-web/app/views/wizard/step3_view.js 3249b24
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/64769/diff/1/
Testing
---
Tests were successful in ambari-web
Thanks,
Sonia Garudi
3249b24
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/64769/diff/2/
Testing
---
Tests were successful in ambari-web
Thanks,
Sonia Garudi
entire new block seems to be doing repo
> > stuff that already is on the UI. Can you explain the gist here?
>
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This
> function makes an API call which gets information of all the bootstrapped
r the id. The API should be giving you
> > the id.
>
> Sonia Garudi wrote:
> Made the required change in next diff.
>
> Nate Cole wrote:
> Ok, please resolve review issues as they are fixed in diffs with "Fixed"
I made the change to ge
,
Sonia Garudi
/wizard/step3.hbs eb2733a
ambari-web/app/views/wizard/step3_view.js d788a61
ambari-web/test/controllers/wizard/step3_test.js 4fbcd2d
Diff: https://reviews.apache.org/r/65040/diff/1/
Testing
---
Tests were successful in ambari-web
Thanks,
Sonia Garudi
ambari-web/app/views/wizard/step3_view.js 3249b24
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/64769/diff/5/
Changes: https://reviews.apache.org/r/64769/diff/4-5/
Testing
---
Tests were successful in ambari-web
Thanks,
Sonia Garudi
r the id. The API should be giving you
> > the id.
>
> Sonia Garudi wrote:
> Made the required change in next diff.
>
> Nate Cole wrote:
> Ok, please resolve review issues as they are fixed in diffs with "Fixed"
>
> Sonia Garudi wrote
entire new block seems to be doing repo
> > stuff that already is on the UI. Can you explain the gist here?
>
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This
> function makes an API call which gets information of all the bootstrapped
2>
> >
> > ftp? I think it's fine to be only http or https.
Made the required change in next diff.
- Sonia
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/
://reviews.apache.org/r/64769/diff/2-3/
Testing
---
Tests were successful in ambari-web
Thanks,
Sonia Garudi
/views/wizard/step3_view.js 3249b24
ambari-web/test/controllers/wizard/step3_test.js b8bc794
Diff: https://reviews.apache.org/r/64769/diff/4/
Changes: https://reviews.apache.org/r/64769/diff/3-4/
Testing
---
Tests were successful in ambari-web
Thanks,
Sonia Garudi
20 matches
Mail list logo
