Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-07-14 Thread Vivek Ratnavel Subramanian
ing --- Local Ambari web test passed. 28944 tests complete (25 seconds) 154 tests pending Manual testing done. File Attachments Gif of latest changes https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif Thanks, Vivek Ratna

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-07-14 Thread Vivek Ratnavel Subramanian
igs/config_history_flow.hbs 73d6913 ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab Diff: https://reviews.apache.org/r/49838/diff/ Testing --- Local Ambari web test passed. 28944 tests complete (25 seconds) 154 tests pending Manual testing done. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-07-14 Thread Vivek Ratnavel Subramanian
est changes https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif Thanks, Vivek Ratnavel Subramanian

Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-07-08 Thread Vivek Ratnavel Subramanian
sts complete (25 seconds) 154 tests pending Manual testing done. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 56196: UI changes to resolve discrepancies between what the stack vs Ambari reports as "live" for NodeManagers

2017-02-01 Thread Vivek Ratnavel Subramanian
/services/hdfs_test.js 06d0e01 ambari-web/test/views/main/service/services/yarn_test.js 9c1cf7a Diff: https://reviews.apache.org/r/56196/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 30313 passing (23s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 56196: UI changes to resolve discrepancies between what the stack vs Ambari reports as "live" for NodeManagers

2017-02-01 Thread Vivek Ratnavel Subramanian
: https://reviews.apache.org/r/56196/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 30313 passing (23s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 56266: The user must be clearly communicated about YARN pre-emption requirements when Hive LLAP is enabled

2017-02-02 Thread Vivek Ratnavel Subramanian
-interactive-env.xml 787dcb1 Diff: https://reviews.apache.org/r/56266/diff/ Testing --- Verified Manually. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 56420: On certain actions, there's no feedback from the UI when API takes a long time to respond - not reassuring and the user is encouraged to keep triggering the same heavy action

2017-02-08 Thread Vivek Ratnavel Subramanian
. Ambari-web unit tests pass. 30312 passing (19s) 157 pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 56266: The user must be clearly communicated about YARN pre-emption requirements when Hive LLAP is enabled

2017-02-02 Thread Vivek Ratnavel Subramanian
ks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 89eccc6 ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml 787dcb1 Diff: https://reviews.apache.org/r/56266/diff/ Testing --- Verified Manually. Thanks, Vivek Ratnavel Subramanian

Review Request 56420: On certain actions, there's no feedback from the UI when API takes a long time to respond - not reassuring and the user is encouraged to keep triggering the same heavy action to

2017-02-07 Thread Vivek Ratnavel Subramanian
atch_scheduled_requests.js b8ae955 ambari-web/test/controllers/main/service_test.js d8c3365 Diff: https://reviews.apache.org/r/56420/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 30312 passing (19s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 55891: Axis units and aggregators are wrong in some graphs of ambari grafana dashboards

2017-01-24 Thread Vivek Ratnavel Subramanian
-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json 2cdd6d9 Diff: https://reviews.apache.org/r/55891/diff/ Testing --- Verified Manually. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 56033: Remove white border from the content area in popup wizards

2017-01-27 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56033/#review163321 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Jan. 27

Re: Review Request 55953: CS queue refresh happens before the user clicks on the restart button

2017-01-29 Thread Vivek Ratnavel Subramanian
passing (19s) 157 pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 55953: CS queue refresh happens before the user clicks on the restart button

2017-01-25 Thread Vivek Ratnavel Subramanian
, Vivek Ratnavel Subramanian

Review Request 55815: Refine Grafana dashboard(s) for AmbariServer to include server specific metric graphs

2017-01-20 Thread Vivek Ratnavel Subramanian
Ratnavel Subramanian

Review Request 55953: CS queue refresh happens before the user clicks on the restart button

2017-01-25 Thread Vivek Ratnavel Subramanian
: https://reviews.apache.org/r/55953/diff/ Testing --- Verified Manually. Ambari-web unit tests pass 30309 passing (19s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 55957: HDFS TopN Operations by User graph showing wrong data in grafana

2017-01-25 Thread Vivek Ratnavel Subramanian
nges of all the other graphs. Diffs - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json 688d113 Diff: https://reviews.apache.org/r/55957/diff/ Testing --- Verified Manually. Thanks, Vivek Ratn

Review Request 55700: Ranger load balancer url needs to be updated for dependent properties during HA

2017-01-18 Thread Vivek Ratnavel Subramanian
/r/55700/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 30297 passing (24s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 57201: Service Alert Popup - Unexpected User Experience

2017-03-01 Thread Vivek Ratnavel Subramanian
-web/app/templates/main/service/info/service_alert_popup.hbs 6ab6b3f Diff: https://reviews.apache.org/r/57201/diff/1/ Testing --- Verified Manually. Ambari-web unit tests pass 20571 passing (19s) 153 pending Thanks, Vivek Ratnavel Subramanian

Review Request 51540: Expose Disabling of Alert Targets in Web Client

2016-08-30 Thread Vivek Ratnavel Subramanian
19f9ca3 ambari-web/app/views/main/alerts/manage_alert_notifications_view.js 5b476a3 Diff: https://reviews.apache.org/r/51540/diff/ Testing --- Verified manually. Ambari-web unit tests pass. 30014 tests complete (26 seconds) 154 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 51540: Expose Disabling of Alert Targets in Web Client

2016-08-30 Thread Vivek Ratnavel Subramanian
/media/uploaded/files/2016/08/31/ad971a3a-3430-4caa-9e7f-df60cc75872c__AMBARI-18281.v1.patch Thanks, Vivek Ratnavel Subramanian

Re: Review Request 51540: Expose Disabling of Alert Targets in Web Client

2016-08-30 Thread Vivek Ratnavel Subramanian
en only "Enable" option is visible. - Vivek Ratnavel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51540/#review147365 ----------

Re: Review Request 51540: Expose Disabling of Alert Targets in Web Client

2016-08-30 Thread Vivek Ratnavel Subramanian
.patch Thanks, Vivek Ratnavel Subramanian

Review Request 51744: SmartSense Mandatory Install

2016-09-08 Thread Vivek Ratnavel Subramanian
tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 51540: Expose Disabling of Alert Targets in Web Client

2016-09-09 Thread Vivek Ratnavel Subramanian
Ratnavel Subramanian

Review Request 51937: Configuration Groups popup: Tooltip over properties number has too much content

2016-09-15 Thread Vivek Ratnavel Subramanian
/51937/diff/ Testing --- Verified manually. Ambari-web unit tests pass. 30365 tests complete (32 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 51937: Configuration Groups popup: Tooltip over properties number has too much content

2016-09-15 Thread Vivek Ratnavel Subramanian
ambari-web/app/templates/main/service/manage_configuration_groups_popup.hbs d0fd103 Diff: https://reviews.apache.org/r/51937/diff/ Testing --- Verified manually. Ambari-web unit tests pass. 30365 tests complete (32 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-09-29 Thread Vivek Ratnavel Subramanian
tps://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif AMBARI-17636.v5.patch https://reviews.apache.org/media/uploaded/files/2016/09/29/5f9a486d-f006-4a2a-890d-8cd2ac69efe9__AMBARI-17636.v5.patch Thanks, Vivek Ratnavel Subramanian

Review Request 52654: At "Add Service Wizard", when the installation is going on, if I click the close (X) on the wizard, the service will only get INSTALLED not STARTED.

2016-10-07 Thread Vivek Ratnavel Subramanian
ambari-web/app/routes/add_service_routes.js 30c8e07 Diff: https://reviews.apache.org/r/52654/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 30374 tests complete (26 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Review Request 52535: Advanced storm-atlas-application.properties panel is not opened by default upon filtering

2016-10-04 Thread Vivek Ratnavel Subramanian
mplete (27 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Review Request 52178: Ambari create widget does not show what the error is

2016-09-22 Thread Vivek Ratnavel Subramanian
Thanks, Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-09-29 Thread Vivek Ratnavel Subramanian
nks, Vivek Ratnavel Subramanian

Review Request 53211: Ranger Audit Handler not working as expected as NN HA wizard does not set a few properties correctly

2016-10-26 Thread Vivek Ratnavel Subramanian
Diff: https://reviews.apache.org/r/53211/diff/ Testing --- Verified Manually. Unit tests modified. Ambari-web unit tests pass. 30372 tests complete (28 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53565/#review155343 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Nov. 8

Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Vivek Ratnavel Subramanian
) <https://reviews.apache.org/r/53565/#comment225196> Variable is not used - Vivek Ratnavel Subramanian On Nov. 8, 2016, 3:29 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-10-17 Thread Vivek Ratnavel Subramanian
one. Local Ambari-web tests pass. 30364 tests complete (27 seconds) 151 tests pending Verified manually File Attachments Gif of latest changes https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif Thanks, Vivek Ratna

Review Request 54010: Unable to load Grafana Graphs in IE11

2016-11-22 Thread Vivek Ratnavel Subramanian
in Windows 8.1 and Internet Explorer 11. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 53788: HTTP responses needs to have the character encoding specified in the content type header

2016-11-23 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53788/#review156797 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Nov. 17

Re: Review Request 53904: Implement Create Alerts: step 1 select alert type

2016-11-21 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53904/#review156492 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Nov. 18

Re: Review Request 53969: When HS2Interactive is enabled, any hive config change results in a CS queue refresh

2016-11-21 Thread Vivek Ratnavel Subramanian
(updated) --- Verified Manually. Ambari-web unit tests pass. 25343 tests complete (19 seconds) 57 tests pending Thanks, Vivek Ratnavel Subramanian

Review Request 53969: When HS2Interactive is enabled, any hive config change results in a CS queue refresh

2016-11-21 Thread Vivek Ratnavel Subramanian
unit tests pass. 25343 tests complete (19 seconds) 57 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 53904: Implement Create Alerts: step 1 select alert type

2016-11-22 Thread Vivek Ratnavel Subramanian
> On Nov. 21, 2016, 7:21 p.m., Vivek Ratnavel Subramanian wrote: > > Ship It! Ambari-web unit tests pass 25461 tests complete (19 seconds) 57 tests pending - Vivek Ratnavel --- This is an automatically generated e-mail.

Review Request 53404: Component actions confirmation window (from host details page) don't have the details about action to be confirmed

2016-11-02 Thread Vivek Ratnavel Subramanian
t/details.js 848e6f8 ambari-web/app/messages.js b0ebddd Diff: https://reviews.apache.org/r/53404/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 30323 tests complete (28 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 52850: Icons don't display in Windows 10 Microsoft Edge or Internet Explorer 11

2016-11-03 Thread Vivek Ratnavel Subramanian
of Google Chrome Mac OS X, Google Chrome Windows 10, Microsoft Internet Explorer 11 and Microsoft Edge. Ambari web unit tests pass. 30374 tests complete (30 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 51744: SmartSense Mandatory Install

2016-11-01 Thread Vivek Ratnavel Subramanian
pass. 29244 tests complete (26 seconds) 154 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 53211: Ranger Audit Handler not working as expected as NN HA wizard does not set a few properties correctly

2016-10-31 Thread Vivek Ratnavel Subramanian
. 30372 tests complete (28 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Review Request 53312: Popover dialog displays raw html instead of rendering it

2016-10-31 Thread Vivek Ratnavel Subramanian
/ Testing --- Verified Manually. Ambari-web unit tests pass. 30368 tests complete (28 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Review Request 52850: Icons don't display in Windows 10 Microsoft Edge or Internet Explorer 11

2016-10-13 Thread Vivek Ratnavel Subramanian
/ Testing --- Verified Manually in the latest versions of Google Chrome Mac OS X, Google Chrome Windows 10, Microsoft Internet Explorer 11 and Microsoft Edge. Ambari web unit tests pass. 30374 tests complete (30 seconds) 151 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-10-12 Thread Vivek Ratnavel Subramanian
632-4471-bbf2-99bf05c5d275__bugfix.gif Thanks, Vivek Ratnavel Subramanian

Review Request 54733: Alerts: Create new Alerts Notification type for SNMP to handle Ambari MIB

2016-12-14 Thread Vivek Ratnavel Subramanian
alert_notification.hbs 342b247 ambari-web/app/views/main/alerts/manage_alert_notifications_view.js abb1694 Diff: https://reviews.apache.org/r/54733/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 19881 tests complete (23 seconds) 153 tests pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 55514: Improve "Install Wizard step 2-10" after new guidelines

2017-01-13 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55514/#review161562 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Jan. 13

Review Request 55527: Possibly too frequent calls to stack advisor as user changes sliders

2017-01-13 Thread Vivek Ratnavel Subramanian
.json-"type" : "yarn-site", ./60/services.json-"name" : "yarn.scheduler.minimum-allocation-mb", ./60/services.json-"old_value" : "1280" Diffs - ambari-web/app/views/common/controls_view.js dc91f36 Diff: https://reviews.apache.org/r/55527/diff/ Testing --- Verified Mannually in the latest version of Google Chrome, Mozilla Firefox and Safari browsers. Ambari-web unit tests pass 30298 passing (19s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 55528: Re-order rows in HDFS-TopN Grafana Dashboard

2017-01-13 Thread Vivek Ratnavel Subramanian
/HDP/grafana-hdfs-topn.json 5b90ae9 Diff: https://reviews.apache.org/r/55528/diff/ Testing --- Verified Manually. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 55527: Possibly too frequent calls to stack advisor as user changes sliders

2017-01-13 Thread Vivek Ratnavel Subramanian
anged-configurations" : [ { ./60/services.json-"type" : "yarn-site", ./60/services.json-"name" : "yarn.scheduler.minimum-allocation-mb", ./60/services.json-"old_value" : "1280" Diffs (updated) - ambari-web/app/views/common/controls_view.js dc91f36 Diff: https://reviews.apache.org/r/55527/diff/ Testing --- Verified Mannually in the latest version of Google Chrome, Mozilla Firefox and Safari browsers. Ambari-web unit tests pass 30298 passing (19s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 55399: Changing Capacity-scheduler configs while llap is enabled should warn the user if llap is affected

2017-01-10 Thread Vivek Ratnavel Subramanian
/main/service/configs/component_actions_by_configs.js ba30dcd ambari-web/app/models/configs/theme/config_action.js 905fecb Diff: https://reviews.apache.org/r/55399/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 30288 passing (18s) 154 pending Thanks, Vivek Ratnavel

Re: Review Request 55367: Improve "Install Wizard step 1" after new guidelines

2017-01-10 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55367/#review161104 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Jan. 10

Re: Review Request 53969: When HS2Interactive is enabled, any hive config change results in a CS queue refresh

2016-12-05 Thread Vivek Ratnavel Subramanian
/batch_scheduled_requests_test.js 20b190b Diff: https://reviews.apache.org/r/53969/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 25343 tests complete (19 seconds) 57 tests pending Thanks, Vivek Ratnavel Subramanian

Review Request 55232: Grafana datasource changes to accommodate new visualizations for TopN

2017-01-05 Thread Vivek Ratnavel Subramanian
/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json PRE-CREATION Diff: https://reviews.apache.org/r/55232/diff/ Testing --- Verified Manually using a canary build in a 5 node cluster. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 55232: Grafana datasource changes to accommodate new visualizations for TopN

2017-01-05 Thread Vivek Ratnavel Subramanian
ain/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json PRE-CREATION Diff: https://reviews.apache.org/r/55232/diff/ Testing --- Verified Manually using a canary build in a 5 node cluster. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 55233: Improve and Fix "Hosts page" after new guidelines

2017-01-05 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55233/#review160645 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Jan. 5

Review Request 55289: Auto refresh yarn queues when capacity scheduler config is changed from hive configs page

2017-01-06 Thread Vivek Ratnavel Subramanian
://reviews.apache.org/r/55289/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 30288 passing (16s) 154 pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 55290: Improve "Install Wizard step 0" after new guidelines

2017-01-07 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55290/#review160825 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Jan. 7

Re: Review Request 55095: Improve and Fix "Admin page" after new guidelines

2016-12-29 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55095/#review160290 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Dec. 30

Review Request 54887: Incorrect Method types displayed in the description of created Alert notification

2016-12-20 Thread Vivek Ratnavel Subramanian
roller_test.js a0a4ce4 Diff: https://reviews.apache.org/r/54887/diff/ Testing --- Verified Manually. Ambari-web unit tests pass. 19726 passing (14s) 153 pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 54922: Improve and Fix "Dashboard page" after new guidelines

2016-12-21 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54922/#review159847 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Dec. 21

Re: Review Request 55062: Improve and Fix "Services page" after new guidelines

2016-12-28 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55062/#review160241 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Dec. 28

Review Request 57892: Grafana dashboard changes for some new llap daemon metrics

2017-03-23 Thread Vivek Ratnavel Subramanian
, Vivek Ratnavel Subramanian

Review Request 57886: Warn users about pending requests while trying to enable Interactive Query immediately after disabling it

2017-03-23 Thread Vivek Ratnavel Subramanian
bc40a26 ambari-web/app/utils/ajax/ajax.js b856e44 ambari-web/app/views/common/configs/widgets/config_widget_view.js cb5d5b9 Diff: https://reviews.apache.org/r/57886/diff/1/ Testing --- Verified Manually. Ambari-web unit tests pass. 30369 passing (21s) 157 pending Thanks, Vivek Ratnavel

Re: Review Request 57892: Grafana dashboard changes for some new llap daemon metrics

2017-03-24 Thread Vivek Ratnavel Subramanian
Diff: https://reviews.apache.org/r/57892/diff/2/ Changes: https://reviews.apache.org/r/57892/diff/1-2/ Testing --- Verified Manually. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 57967: Test and fix new Accordions styles on Ambari

2017-03-27 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57967/#review170210 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On March 27

Re: Review Request 58000: Unable to scroll down collapsed navigation bar if it's higher that viewport

2017-03-29 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58000/#review170490 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On March 28

Re: Review Request 58405: Update the Accordion styles in horton style

2017-04-12 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58405/#review171827 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On April 12

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58596/#review172560 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On April 20

Re: Review Request 57493: Ambari Metrics Grafana Datasource plugin does not work when configured with a reverse proxy with subpath

2017-03-11 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57493/#review168711 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On March 10

Review Request 57567: Hive Server interactive not removed from Hive summary page after HSI is disabled

2017-03-13 Thread Vivek Ratnavel Subramanian
HSI is disabled Diffs - ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js b01c784 Diff: https://reviews.apache.org/r/57567/diff/1/ Testing --- Verified Manually. Ambari-web unit tests pass. 30367 passing (20s) 157 pending Thanks, Vivek Ratnavel

Re: Review Request 57567: Hive Server interactive not removed from Hive summary page after HSI is disabled

2017-03-13 Thread Vivek Ratnavel Subramanian
. Ambari-web unit tests pass. 30367 passing (20s) 157 pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 57201: Service Alert Popup - Unexpected User Experience

2017-03-01 Thread Vivek Ratnavel Subramanian
/ Testing --- Verified Manually. Ambari-web unit tests pass 20571 passing (19s) 153 pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 61386: AMBARI-21640 : Certain templated Grafana dashboards not showing data.

2017-08-03 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61386/#review182115 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Aug. 2

Re: Review Request 60265: Grafana Yarn Queue dashboard is not working due to incorrect startTime.

2017-06-21 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60265/#review178569 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On June 21

Re: Review Request 62427: Add service wizard stuck at step 8

2017-09-19 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62427/#review185766 --- Ship it! - Vivek Ratnavel Subramanian On Sept. 20, 2017, 2

Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-11-15 Thread Vivek Ratnavel Subramanian
pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 64020: AMBARI-22496. Admin View - Manage Versions page should show HDP-GPL repo if necessary

2017-11-22 Thread Vivek Ratnavel Subramanian
. Ambari-admin unit tests pass. Chrome 62.0.3202 (Mac OS X 10.11.6): Executed 76 of 76 SUCCESS (0.508 secs / 0.486 secs) Thanks, Vivek Ratnavel Subramanian

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-29 Thread Vivek Ratnavel Subramanian
Line 77 (original), 77 (patched) <https://reviews.apache.org/r/64186/#comment270242> Typo: INSTALLED - Vivek Ratnavel Subramanian On Nov. 30, 2017, 12:02 a.m., Sid Wagle wrote: > > --- > This is an automatically g

Review Request 64227: AMBARI-22570. Repository Fields missing when register version is clicked

2017-11-30 Thread Vivek Ratnavel Subramanian
n/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js c5f1a8c Diff: https://reviews.apache.org/r/64227/diff/1/ Testing --- Tested manually. Unit tests on ambari-admin web pass. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-11-30 Thread Vivek Ratnavel Subramanian
2d18396 Diff: https://reviews.apache.org/r/63847/diff/2/ Changes: https://reviews.apache.org/r/63847/diff/1-2/ Testing --- Manually tested. Ambari-web unit tests pass 30518 passing (27s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 64185: UI should pass repo_name for repository validation

2017-11-29 Thread Vivek Ratnavel Subramanian
- ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 46f4f42 ambari-web/app/controllers/installer.js afce91a Diff: https://reviews.apache.org/r/64185/diff/1/ Testing --- Manually tested. Thanks, Vivek Ratnavel Subramanian

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-29 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/#review192203 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Nov. 30

Review Request 64020: AMBARI-22496. Admin View - Manage Versions page should show HDP-GPL repo if necessary

2017-11-21 Thread Vivek Ratnavel Subramanian
/stackVersions/stackVersionPage.html aeaaa71 Diff: https://reviews.apache.org/r/64020/diff/1/ Testing --- Tested manually. Ambari-admin unit tests pass. Chrome 62.0.3202 (Mac OS X 10.11.6): Executed 76 of 76 SUCCESS (0.508 secs / 0.486 secs) Thanks, Vivek Ratnavel Subramanian

Re: Review Request 64017: Installer - Select Version page should show HDP-GPL repo if necessary

2017-11-21 Thread Vivek Ratnavel Subramanian
iff: https://reviews.apache.org/r/64017/diff/2/ Changes: https://reviews.apache.org/r/64017/diff/1-2/ Testing --- Manually tested and verified. Ambari-web unit tests pass 30518 passing (27s) 157 pending Thanks, Vivek Ratnavel Subramanian

Review Request 64017: Installer - Select Version page should show HDP-GPL repo if necessary

2017-11-21 Thread Vivek Ratnavel Subramanian
passing (27s) 157 pending Thanks, Vivek Ratnavel Subramanian

Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-12-01 Thread Vivek Ratnavel Subramanian
://reviews.apache.org/r/63847/diff/2-3/ Testing --- Manually tested. Ambari-web unit tests pass 30518 passing (27s) 157 pending Thanks, Vivek Ratnavel Subramanian