Re: Review Request 48185: Enabling interactive query in kerberized cluster after re-login results in HS2 interactive installation failure

2016-06-02 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48185/#review135992 --- Ship it! Ship It! - Zhe (Joe) Wang On June 2, 2016, 8:44

Re: Review Request 48177: AMBARI-17016 Removing OS doesn't work

2016-06-02 Thread Zhe (Joe) Wang
Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 48191: VDF: Register Version UI inconsistencies + bug

2016-06-02 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48191/#review136008 --- Ship it! Ship It! - Zhe (Joe) Wang On June 2, 2016, 11:25

Re: Review Request 48451: AMBARI-17132 - Typing the whole component name vs selecting drop down filter in hosts page gives 2 different results

2016-06-08 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48451/#review136734 --- Ship it! Ship It! - Zhe (Joe) Wang On June 9, 2016, 12:09

Re: Review Request 48361: VDF: install wizard "Select Version" UI issues

2016-06-07 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48361/#review136541 --- Ship it! Ship It! - Zhe (Joe) Wang On June 7, 2016, 9:08

Review Request 48382: AMBARI-17101 Select Stack Page : "Next" button disabled for blank repo fields

2016-06-07 Thread Zhe (Joe) Wang
/step1_view_test.js 3621aa9 Diff: https://reviews.apache.org/r/48382/diff/ Testing --- Modified unit test. Local ambari-web test passed. 28665 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Zhe (Joe) Wang
, Zhe (Joe) Wang

Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host

2016-06-06 Thread Zhe (Joe) Wang
) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 48306: AMBARI-17077 - Unable to change user role in list view

2016-06-07 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48306/#review136498 --- Ship it! Ship It! - Zhe (Joe) Wang On June 7, 2016, 2:29

Re: Review Request 48456: AMBARI-17134 - Add support flag for user type 'JWT'

2016-06-09 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48456/#review136850 --- Ship it! Ship It! - Zhe (Joe) Wang On June 9, 2016, 1:49

Review Request 48568: AMBARI-17176 VDF: include default version definition in list, even if Internet Access is available

2016-06-10 Thread Zhe (Joe) Wang
Testing --- ambari-web: 28670 tests complete (24 seconds) 154 tests pending ambari-admin: Executed 71 of 71 SUCCESS (0.142 secs / 0.356 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 48569: On Enabling HS Interactive default queue shown for llap is 'default' queue

2016-06-10 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48569/#review137090 --- Ship it! Ship It! - Zhe (Joe) Wang On June 11, 2016, 12:07

Re: Review Request 48517: AMBARI-17154 - Typo in SmartSense Warning Dialog

2016-06-09 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48517/#review136917 --- Ship it! Ship It! - Zhe (Joe) Wang On June 9, 2016, 10:24

Re: Review Request 48241: Enable kerberos wizard UI showing incorrect total of required fields

2016-06-03 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48241/#review136138 --- Ship it! Ship It! - Zhe (Joe) Wang On June 3, 2016, 11:43

Review Request 48698: AMBARI-17230 VDF: when registering version using Default Vers Def, need to set Name

2016-06-14 Thread Zhe (Joe) Wang
/ Testing --- ambari-admin: Executed 71 of 71 SUCCESS (0.164 secs / 0.379 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 48296: AMBARI-17073 HDF Management install does not allow one to select public repo

2016-06-06 Thread Zhe (Joe) Wang
/public_option_disabled_window_body.hbs 25cf49f ambari-web/app/views/wizard/step1_view.js 503d5ef Diff: https://reviews.apache.org/r/48296/diff/ Testing --- Local ambari-web test passed. 28646 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 48089: AMBARI-16972 Strange behavior of Add Version functionality

2016-05-31 Thread Zhe (Joe) Wang
ces/ui/admin-web/app/scripts/services/AddVersionModal.js 0af7004 Diff: https://reviews.apache.org/r/48089/diff/ Testing --- ambari-admin: Executed 71 of 71 SUCCESS (0.13 secs / 0.35 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 47993: VDF: support for selecting enabled + default Stacks

2016-05-27 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47993/#review135348 --- Ship it! Ship It! - Zhe (Joe) Wang On May 27, 2016, 11:14

Review Request 48105: AMBARI-16977 VDF: couple UI bugs in Install Wiz

2016-05-31 Thread Zhe (Joe) Wang
, Zhe (Joe) Wang

Review Request 48177: AMBARI-17016 Removing OS doesn't work

2016-06-02 Thread Zhe (Joe) Wang
testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 48177: AMBARI-17016 Removing OS doesn't work

2016-06-02 Thread Zhe (Joe) Wang
complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 47920: Enable HS2 Interactive > Select Hosts does not have Cancel and close

2016-05-26 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47920/#review135128 --- Ship it! Ship It! - Zhe (Joe) Wang On May 26, 2016, 10:36

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48156/#review135880 --- Ship it! Ship It! - Zhe (Joe) Wang On June 1, 2016, 9:36

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang
/assign_master_controller_test.js (line 152) <https://reviews.apache.org/r/48156/#comment200892> Typo? - Zhe (Joe) Wang On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang
/assign_master_controller.js (line 161) <https://reviews.apache.org/r/48156/#comment200891> Typo? - Zhe (Joe) Wang On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 48709: Nothing shows on the role section when user has the same role as its group

2016-06-14 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48709/#review137598 --- Ship it! Ship It! - Zhe (Joe) Wang On June 14, 2016, 10:39

Re: Review Request 48831: UI: 'llap' queue is not shown in dropdown even though recommendation says so. Shows 'llap' queue after save.

2016-06-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48831/#review138133 --- Ship it! Ship It! - Zhe (Joe) Wang On June 17, 2016, 12:30

Review Request 48830: AMBARI-17288 Redundant element on create version page

2016-06-16 Thread Zhe (Joe) Wang
://reviews.apache.org/r/48830/diff/ Testing --- ambari-admin: Executed 76 of 76 SUCCESS (0.121 secs / 0.368 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 48827: AMBARI-17286 Service config links should use public host name

2016-06-16 Thread Zhe (Joe) Wang
(Joe) Wang

Review Request 48834: AMBARI-17289 VDF: UI Edits #2

2016-06-16 Thread Zhe (Joe) Wang
/ui/admin-web/app/views/stackVersions/stackVersionPage.html e7bf01d Diff: https://reviews.apache.org/r/48834/diff/ Testing --- ambari-admin: Executed 76 of 76 SUCCESS (0.15 secs / 0.358 secs) Manual testing done Thanks, Zhe (Joe) Wang

Re: Review Request 48809: AMBARI-17266 - StackDeploys: Suse: after enabling ranger plugin save button is always present

2016-06-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48809/#review138070 --- Ship it! Ship It! - Zhe (Joe) Wang On June 16, 2016, 7:23

Re: Review Request 48998: AMBARI-17326 - Mark the role "(from group)" if there is no specific user level role set.

2016-06-21 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48998/#review138885 --- Ship it! Ship It! - Zhe (Joe) Wang On June 21, 2016, 2:38

Re: Review Request 48888: AMBARI-17305 - Local User not displaying in View All option in Ambari

2016-06-17 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review138354 --- Ship it! Ship It! - Zhe (Joe) Wang On June 17, 2016, 11:37

Review Request 49124: AMBARI-17387 Changing HDP repo URL does not leads to sending written URL to ambari-server while registering new HDP version

2016-06-22 Thread Zhe (Joe) Wang
cs / 0.378 secs) Manual testing done Thanks, Zhe (Joe) Wang

Re: Review Request 49126: AMBARI-17388 - Add Service Wizard stuck on Customize Services step

2016-06-22 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49126/#review139192 --- Ship it! Ship It! - Zhe (Joe) Wang On June 23, 2016, 12:34

Re: Review Request 48827: AMBARI-17286 Service config links should use public host name

2016-06-17 Thread Zhe (Joe) Wang
failures:0 OK Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 44681: AMBARI-15378 Create multiple version state filters instead of one combined one on host page for version page

2016-03-10 Thread Zhe (Joe) Wang
mplete (21 seconds) 145 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-18 Thread Zhe (Joe) Wang
in the list. But adding NFS_GATEWAY to this list may cause problem. - Zhe (Joe) Wang On March 18, 2016, 9:46 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-15 Thread Zhe (Joe) Wang
/experimental.js 9fa6da5 ambari-web/app/messages.js dc9c264 ambari-web/app/templates/experimental.hbs 2873679 Diff: https://reviews.apache.org/r/44880/diff/ Testing --- Local ambari-web test passed. 24578 tests complete (23 seconds) 145 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 44487: AMBARI-15327 Combo Search: Query for multiple facets and display label instead of value in search box

2016-03-08 Thread Zhe (Joe) Wang
. Local ambari-web test passed. 24565 tests complete (21 seconds) 145 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 44487: Combo Search: Query for multiple facets and display label instead of value in search box

2016-03-09 Thread Zhe (Joe) Wang
test. Local ambari-web test passed. 24565 tests complete (21 seconds) 145 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 44487: AMBARI-15327 Combo Search: Query for multiple facets

2016-03-09 Thread Zhe (Joe) Wang
/controllers/main/host_test.js 06a4813 Diff: https://reviews.apache.org/r/44487/diff/ Testing (updated) --- Modified unit test. Local ambari-web test passed. 24557 tests complete (21 seconds) 146 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 44723: AMBARI-15394 Add second parameter to App.format.role()

2016-03-11 Thread Zhe (Joe) Wang
pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-19 Thread Zhe (Joe) Wang
passed. 24578 tests complete (23 seconds) 145 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 45405: AMBARI-15610 Add Service Wizard: invalid host name doesn't prevent proceeding to next page

2016-03-28 Thread Zhe (Joe) Wang
l testing done. Thanks, Zhe (Joe) Wang

Review Request 45825: AMBARI-15136 Alert definitions: Percentage params are shown incrrectly

2016-04-06 Thread Zhe (Joe) Wang
tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Zhe (Joe) Wang
-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js c209fcc ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 4ba0fc1 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 39fabf6 Diff: https://reviews.apache.org/r/45903/diff/ Testing --- ambari-admin: Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat Tolerance Values Exposed In Web Client

2016-04-05 Thread Zhe (Joe) Wang
/definition_details_view.js 656021c ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b Diff: https://reviews.apache.org/r/45462/diff/ Testing --- Local ambari-web test passed. 25642 tests complete (22 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat Tolerance Values Exposed In Web Client

2016-04-05 Thread Zhe (Joe) Wang
seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 45774: AMBARI-15720 AGGREGATE Alerts Should Not Expose Repeat Tolerance or Tolerance Enabled Settings

2016-04-05 Thread Zhe (Joe) Wang
://reviews.apache.org/r/45774/diff/ Testing --- Local ambari-web test passed. 25609 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 46128: AMBARI-15851 FE work to integrate "Service version display should be based on Version Definition"

2016-04-12 Thread Zhe (Joe) Wang
7b55545 Diff: https://reviews.apache.org/r/46128/diff/ Testing --- Local ambari-web test passed. 25614 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat Satellite option out of experimental

2016-04-05 Thread Zhe (Joe) Wang
/ 0.299 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat Satellite option out of experimental

2016-04-06 Thread Zhe (Joe) Wang
1/#review127321 --- On April 5, 2016, 10:50 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 45791: AMBARI-15725: RBAC: Help page UI edits

2016-04-06 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45791/#review127374 --- Ship it! Ship It! - Zhe (Joe) Wang On April 6, 2016, 1:20

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Zhe (Joe) Wang
eCtrl.js 6feeeac ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js c209fcc ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 4ba0fc1 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 39fabf6 Diff: https://reviews.apache.org/r/45903/diff/ Testing --- ambari-admin: Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Zhe (Joe) Wang
eCtrl.js 6feeeac ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js c209fcc ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 4ba0fc1 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 39fabf6 Diff: https://reviews.apache.org/r/45903/diff/ Testing --- ambari-admin: Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text from description

2016-04-11 Thread Zhe (Joe) Wang
- ambari-server/src/main/resources/alerts.json 3b6ebbb Diff: https://reviews.apache.org/r/45974/diff/ Testing (updated) --- All alert unit test passed. mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false Thanks, Zhe (Joe) Wang

Review Request 46039: AMBARI-15809 Web Client Does Not Expose Parameters For All Alert Types

2016-04-11 Thread Zhe (Joe) Wang
tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text with more info

2016-04-11 Thread Zhe (Joe) Wang
=Alert* -Drat.ignoreErrors -DfailIfNoTests=false Thanks, Zhe (Joe) Wang

Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-19 Thread Zhe (Joe) Wang
passed. 24578 tests complete (23 seconds) 145 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45054: AMBARI-15443:Make Host bulk command menu item list stack driven instead of a hardcoded list in UI code

2016-03-19 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45054/#review124333 --- Ship it! Ship It! - Zhe (Joe) Wang On March 18, 2016, 9:46

Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page

2016-03-20 Thread Zhe (Joe) Wang
passed. 24578 tests complete (23 seconds) 145 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45187: AMBARI-15520 Add more warning on Pause button saying no topology changes.

2016-03-23 Thread Zhe (Joe) Wang
any add hosts/RM HA/others. Diffs (updated) - ambari-web/app/messages.js b4ca9b0 Diff: https://reviews.apache.org/r/45187/diff/ Testing --- Local ambari-web test passed. 10488 tests complete (10 seconds) 121 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 45187: AMBARI-15520 Add more warning on Pause button saying no topology changes.

2016-03-22 Thread Zhe (Joe) Wang
passed. 10488 tests complete (10 seconds) 121 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 44413: AMBARI-15308 UI: ability to perform bulk add host components

2016-03-08 Thread Zhe (Joe) Wang
/diff/ Testing --- Added unit test. Local ambari-web test passed. 24557 tests complete (21 seconds) 146 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 45593: AMBARI-15138 SCRIPT params should support visibility attribute

2016-04-01 Thread Zhe (Joe) Wang
lerts/alert_definition.js a730572 ambari-web/app/templates/main/alerts/configs.hbs dff1b53 Diff: https://reviews.apache.org/r/45593/diff/ Testing --- Local ambari-web test passed. 25602 tests complete (22 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 45462: AMBARI-15604 Alert Definitions Repeat Tolerance Values Exposed In Web Client

2016-03-29 Thread Zhe (Joe) Wang
passed. 25642 tests complete (22 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts

2016-04-01 Thread Zhe (Joe) Wang
s/alert_instance/status.hbs d82bc7b ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1 Diff: https://reviews.apache.org/r/45612/diff/ Testing --- Local ambari-web test passed. 25602 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45609: AMBARI-15675. Hosts page filtering: error if we filter component by Upgrade Failed state

2016-04-01 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45609/#review126667 --- Ship it! Ship It! - Zhe (Joe) Wang On April 1, 2016, 10:40

Review Request 45692: AMBARI-15603 Exposure of Global Alert Repeat Tolerance Value in Web Client

2016-04-04 Thread Zhe (Joe) Wang
f78c ambari-web/app/messages.js 1b2a02f ambari-web/app/styles/application.less a6b79ce ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65 Diff: https://reviews.apache.org/r/45692/diff/ Testing ------- Local ambari-web test passed. 25600 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts

2016-04-04 Thread Zhe (Joe) Wang
web test passed. 25602 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat Tolerance Values Exposed In Web Client

2016-04-04 Thread Zhe (Joe) Wang
/definition_details_view.js 2fc75c1 ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b Diff: https://reviews.apache.org/r/45462/diff/ Testing --- Local ambari-web test passed. 25642 tests complete (22 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45692: AMBARI-15603 Exposure of Global Alert Repeat Tolerance Value in Web Client

2016-04-04 Thread Zhe (Joe) Wang
n/alerts/alert_definitions_actions_controller.js dc9f78c ambari-web/app/messages.js 1b2a02f ambari-web/app/styles/application.less a6b79ce ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65 Diff: https://reviews.apache.org/r/45692/diff/ Testing ------- Local ambari-web test passed. 25600 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 45710: AMBARI-15701. Host filter: minor UX edits

2016-04-04 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45710/#review126958 --- Ship it! Ship It! - Zhe (Joe) Wang On April 4, 2016, 10:14

Re: Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts

2016-04-04 Thread Zhe (Joe) Wang
web test passed. 25602 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Zhe (Joe) Wang
> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks > > Zhe (Joe) Wang wrote: > Agree. That's why I use FE to set the init

Re: Review Request 46648: Add show_available property to dry_run directive

2016-04-25 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46648/#review130475 --- Ship it! Ship It! - Zhe (Joe) Wang On April 25, 2016, 5:50

Re: Review Request 46648: Add show_available property to dry_run directive

2016-04-25 Thread Zhe (Joe) Wang
> On April 25, 2016, 5:51 p.m., Zhe (Joe) Wang wrote: > > Ship It! Works as FE expects. - Zhe (Joe) --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46648/#rev

Re: Review Request 46128: AMBARI-15724 Integrate Version Registration in Select Stack Page

2016-04-25 Thread Zhe (Joe) Wang
g ambari-admin: Executed 64 of 64 SUCCESS (0.086 secs / 0.308 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 46651: AMBARI-16102: Inconsistency between grid and list view of roles page

2016-04-25 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46651/#review130499 --- Ship it! Ship It! - Zhe (Joe) Wang On April 25, 2016, 6:39

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-20 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45792/#review129802 --- Ship it! Ship It! - Zhe (Joe) Wang On April 20, 2016, 8:30

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Zhe (Joe) Wang
https://reviews.apache.org/r/46405/#review130109 --------------- On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-m

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Zhe (Joe) Wang
e. - Zhe (Joe) --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130129 --- On April 21, 2016, 6:50 p.m., Zhe (

Re: Review Request 46460: AMBARI-16002 Integrate Red Hat Satellite option in Ambari Web

2016-04-29 Thread Zhe (Joe) Wang
, visit: https://reviews.apache.org/r/46460/#review131215 ----------- On April 29, 2016, 11:12 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically gener

Review Request 46861: AMBARI-16193 Message with "null" shows up in showRestartRequiredPopup

2016-04-29 Thread Zhe (Joe) Wang
223376b ambari-web/app/mappers/component_config_mapper.js 8ff3416 Diff: https://reviews.apache.org/r/46861/diff/ Testing --- Local ambari-web test passed. 27451 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 46460: AMBARI-16002 Integrate Red Hat Satellite option in Ambari Web

2016-04-29 Thread Zhe (Joe) Wang
gt; > stack.use_redhat_satellite = > > !item.operating_systems[0].OperatingSystems.ambari_managed_repositories; > > > > Logiclly it's the same but this way it's just more readable. > > Zhe (Joe) Wang wrote: > The reason I wrote it that is: > if item.operating_sy

Re: Review Request 46460: AMBARI-16002 Integrate Red Hat Satellite option in Ambari Web

2016-04-29 Thread Zhe (Joe) Wang
/templates/wizard/step1.hbs 0476580 ambari-web/app/utils/ajax/ajax.js 83914a7 ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js 168e8db Diff: https://reviews.apache.org/r/46460/diff/ Testing --- Modified unit test. Local ambari-web test passed. 25660 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 46128: AMBARI-15724 Integrate Version Registration in Select Stack Page

2016-04-26 Thread Zhe (Joe) Wang
done. Thanks, Zhe (Joe) Wang

Review Request 47517: AMBARI-16724 Allow customizing Connection Timeout for METRIC Alerts

2016-05-17 Thread Zhe (Joe) Wang
(24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 47517: AMBARI-16724 Allow customizing Connection Timeout for METRIC Alerts

2016-05-18 Thread Zhe (Joe) Wang
test passed. 27819 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 47523: AMBARI-16725 Alert type = RECOVERY does not have connection timeout

2016-05-18 Thread Zhe (Joe) Wang
- ambari-web/app/controllers/main/alerts/definition_configs_controller.js 617f7cc Diff: https://reviews.apache.org/r/47523/diff/ Testing --- Local ambari-web test passed. 27819 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Review Request 47211: AMBARI-16442 VDF UI edits and bugs: #2

2016-05-10 Thread Zhe (Joe) Wang
--- ambari-web: 27794 tests complete (24 seconds) 154 tests pending ambari-admin: Executed 64 of 64 SUCCESS (0.325 secs / 0.323 secs) Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 47206: AMBARI-16441: RBAC UI Edits #6

2016-05-10 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47206/#review132589 --- Ship it! Ship It! - Zhe (Joe) Wang On May 11, 2016, 12:30

Re: Review Request 47439: Enabling/Disabling interactive query should sustain browser refreshes

2016-05-17 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47439/#review133575 --- Ship it! Ship It! - Zhe (Joe) Wang On May 17, 2016, 12:57

Re: Review Request 47422: AMBARI-16688: Ambari users page is not showing type for users

2016-05-16 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47422/#review133434 --- Ship it! Ship It! - Zhe (Joe) Wang On May 16, 2016, 7:08

Re: Review Request 47508: AMBARI-16721 - Host Filters : 'Alerts' value for 'HOST STATUS' filter is absent

2016-05-17 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47508/#review133698 --- Ship it! Ship It! - Zhe (Joe) Wang On May 18, 2016, 1:31

Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source

2016-05-17 Thread Zhe (Joe) Wang
t; + vdf_version" Diffs - ambari-web/app/controllers/installer.js 421f2dc ambari-web/app/mappers/stack_mapper.js 473c466 Diff: https://reviews.apache.org/r/47513/diff/ Testing --- Local ambari-web test passed. 27819 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source

2016-05-18 Thread Zhe (Joe) Wang
onds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang

Re: Review Request 46953: AMBARI-16239: Incorrect warning for not selecting nfs_gateway_hosts

2016-05-03 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46953/#review131597 --- Ship it! Ship It! - Zhe (Joe) Wang On May 4, 2016, 12:36

Review Request 46951: AMBARI-16238 VDF UI edits: #1

2016-05-03 Thread Zhe (Joe) Wang
pending ambari-admin: Executed 64 of 64 SUCCESS (0.115 secs / 0.335 secs) Manual testing done. Thanks, Zhe (Joe) Wang

  1   2   >