Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-18 Thread jun aoki
aster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 15:33:43,049 - Master c6401.ambari.apache.org started ok test_stop_default (test_hawqmaster.TestHawqMaster) ... ok Thanks, jun aoki

Re: Review Request 44868: Changed HAWQ directory descriptions

2016-03-15 Thread jun aoki
a verb of "the recommended number"? Sorry this is trivial but since you are enhancing the description. - jun aoki On March 15, 2016, 10:51 p.m., Alexander Denissov wrote: > > --- > This is an automatically genera

Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-18 Thread jun aoki
/HAWQ/2.0.0/package/scripts/master_helper.py 9482b35 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py 1bdc5aa Diff: https://reviews.apache.org/r/44987/diff/ Testing --- manually tested. Thanks, jun aoki

Re: Review Request 44528: Align PXF Alert description with other services

2016-03-08 Thread jun aoki
/44528/diff/ Testing --- Manually Done Thanks, jun aoki

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-19 Thread jun aoki
----- On March 17, 2016, 10:37 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44987/ > -

Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change

2016-03-19 Thread jun aoki
reate_dir_as_hawq_user(dir_paths) ``` I tried the code above but it does not work as commented. When I have "/tmp/hawq/segment2,/tmp/hawq/segment3" then "segment2," (with a comman) was created.(I know it is weird) I'd stick with my original. - jun

Re: Review Request 46062: PXF service check must occur only after PXF is started

2016-04-11 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46062/#review128288 --- Ship it! Ship It! - jun aoki On April 11, 2016, 11:23 p.m

Re: Review Request 45012: Recommendation and validation logic for HAWQ hdfs-client.xml output.replace-datanode-on-failure property

2016-03-19 Thread jun aoki
lif numSegments <= REPLACE_DATANODE_ON_FAILURE_THREASHOLD and value ... : ... ``` and you can use it on line 694 - jun aoki On March 18, 2016, 2:01 a.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mai

Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-13 Thread jun aoki
Test in progress. Thanks, jun aoki

Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-25 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46585/#review130526 --- Ship it! Ship It! - jun aoki On April 22, 2016, 11:51 p.m

Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-04-29 Thread jun aoki
/reassign/step4_controller_test.js 460726b Diff: https://reviews.apache.org/r/46860/diff/ Testing --- Unit test passed Calling set on destroyed view 27428 tests complete (35 seconds) 154 tests pending Manually tested Thanks, jun aoki

Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard

2016-04-29 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46852/#review131228 --- Ship it! Ship It! - jun aoki On April 29, 2016, 8:50 p.m

Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread jun aoki
does no longer have any of PXF related ones? (DN, HAWQ etc.?) - jun aoki On May 10, 2016, 7:26 a.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47156: More information for Standby sync alert

2016-05-10 Thread jun aoki
thon/stacks/2.3/HAWQ/test_alert_sync_status.py 7d030dc Diff: https://reviews.apache.org/r/47156/diff/ Testing --- Thanks, jun aoki

Re: Review Request 47156: More information for Standby sync alert

2016-05-10 Thread jun aoki
views.apache.org/r/47156/#review132384 --- On May 10, 2016, 9:54 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 47156: More information for Standby sync alert

2016-05-10 Thread jun aoki
> > ``` Lav, this is a good stuff. I actually have to use --no-align option to not to be aligned. - jun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47156/#

Re: Review Request 47156: More information for Standby sync alert

2016-05-10 Thread jun aoki
ps://reviews.apache.org/r/47156/#review132384 ------- On May 10, 2016, 4:27 a.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47156/ >

Re: Review Request 47156: More information for Standby sync alert

2016-05-10 Thread jun aoki
rver/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 7d030dc Diff: https://reviews.apache.org/r/47156/diff/ Testing --- Thanks, jun aoki

Re: Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.

2016-04-29 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46800/#review131186 --- Ship it! Ship It! - jun aoki On April 29, 2016, 8:46 p.m

Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard

2016-04-29 Thread jun aoki
/step4_controller.js (line 83) <https://reviews.apache.org/r/46852/#comment195105> Do you know how related services (or HAWQ) are restared after proeprties are changed? - jun aoki On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary

Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard

2016-04-29 Thread jun aoki
s works when HAWQ is not installed? - jun aoki On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-03 Thread jun aoki
g YARN as the scheduler, HAWQ may still be > > functional and we may need not restart HAWQ with the move of RM. > > So do you think should we restart it only when HAWQ is using > > hawq_global_rm_type as yarn ? > > jun aoki wrote: > I thought it'd be a good

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
the default values. - jun aoki On April 29, 2016, 11:57 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131391 --- On May 2, 2016, 9:47 p.m., jun aoki wrote: > > --

Re: Review Request 46996: HAWQ service can be stopped and checked even when STANDBY MASTER is stopped

2016-05-04 Thread jun aoki
(line 1005) <https://reviews.apache.org/r/46996/#comment195807> I'm not knowledgable on this but wonder if it takes care of service check being enabled ? - jun aoki On May 4, 2016, 11:52 p.m., Alexander Denissov

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131231 ------- On April 29, 2016, 11:57 p.m., jun aoki wrote: > > -

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 329249c Diff: https://reviews.apache.org/r/46860/diff/ Testing --- Unit test passed Calling set on destroyed view 27428 tests complete (35 seconds) 154 tests pending Manually tested Thanks, jun aoki

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

2016-05-04 Thread jun aoki
reply, visit: https://reviews.apache.org/r/46949/#review131705 ------- On May 4, 2016, 9:28 p.m., jun aoki wrote: > > --- > This is an automatically

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

2016-05-04 Thread jun aoki
too clear. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py ee16c9b Diff: https://reviews.apache.org/r/46949/diff/ Testing --- Manually tested. Thanks, jun aoki

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131403 ------- On May 3, 2016, 12:59 a.m., jun aoki wrote: > > --

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 329249c Diff: https://reviews.apache.org/r/46860/diff/ Testing --- Unit test passed Calling set on destroyed view 27428 tests complete (35 seconds) 154 tests pending Manually tested Thanks, jun aoki

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

2016-05-02 Thread jun aoki
g YARN as the scheduler, HAWQ may still be > > functional and we may need not restart HAWQ with the move of RM. > > So do you think should we restart it only when HAWQ is using > > hawq_global_rm_type as yarn ? > > jun aoki wrote: > I thought it'd be a good

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-14 Thread jun aoki
--------- On April 14, 2016, 2:19 a.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46186/ >

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-14 Thread jun aoki
/test_hawqsegment.py 17d7473 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 Diff: https://reviews.apache.org/r/46186/diff/ Testing --- Unit test has passed. Manual Test in progress. Thanks, jun aoki

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-14 Thread jun aoki
generated e-mail. To reply, visit: https://reviews.apache.org/r/46186/#review129024 ------- On April 14, 2016, 9:20 p.m., jun aoki wrote: > > --- > Thi

Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

2016-04-15 Thread jun aoki
with the current value. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py e2114d8 Diff: https://reviews.apache.org/r/46294/diff/ Testing --- Unit test passed. Manually tested. Thanks, jun aoki

Re: Review Request 46283: hawq init master fails to syncup hawq-site xml if there is a segment host down

2016-04-15 Thread jun aoki
/package/scripts/common.py (line 302) <https://reviews.apache.org/r/46283/#comment192655> ``` # utils.exec_hawq_operation(hawq_constants.INIT, "{0}".format(options_str)) utils.exec_hawq_operation(hawq_constants.INIT, options_str) ``` Do we need format()? - jun ao

Re: Review Request 46359: HAWQ Immediate Stop cluster fails with key error

2016-04-19 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46359/#review129576 --- Ship it! Ship It! - jun aoki On April 19, 2016, 1:20 a.m

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-14 Thread jun aoki
277 tests in 8.851s OK -- Total run:957 Total errors:0 Total failures:0 OK Manual Test in progress. Thanks, jun aoki

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-14 Thread jun aoki
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46186/#review128823 ------- On April 14, 2016, 2:19 a.m., jun aoki wrote: > > --- > This is

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-14 Thread jun aoki
/package/scripts/hawqstatus.py (line 25) <https://reviews.apache.org/r/46186/#comment192381> that's a good idea Matt. - jun aoki On April 14, 2016, 2:19 a.m., jun aoki wrote: > > --- > This is an automatically generated e

Re: Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread jun aoki
more https://en.wikipedia.org/wiki/Crypt_(C)#Key_Derivation_Functions_Supported_by_crypt - jun aoki On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Review Request 47156: More information for Standby sync alert

2016-05-09 Thread jun aoki
ocessing the request. : (1 row) {code} Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py c94be9e Diff: https://reviews.apache.org/r/47156/diff/ Testing --- Thanks, jun aoki