Re: Review Request 43049: Oozie should update war after adding Falcon

2016-03-23 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/#review125070
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 23, 2016, 4:04 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43049/
> ---
> 
> (Updated March 23, 2016, 4:04 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14863
> https://issues.apache.org/jira/browse/AMBARI-14863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
> server/libext  
> Oozie war should be updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/oozie_prepare_war.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  5587380 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  d26b89d 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  f92d90c 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py cbec3cf 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> ba61b3d 
> 
> Diff: https://reviews.apache.org/r/43049/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Re: Review Request 43049: Oozie should update war after adding Falcon

2016-03-23 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/#review125051
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 23, 2016, 6:04 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43049/
> ---
> 
> (Updated March 23, 2016, 6:04 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14863
> https://issues.apache.org/jira/browse/AMBARI-14863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
> server/libext  
> Oozie war should be updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/oozie_prepare_war.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  5587380 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  d26b89d 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  f92d90c 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py cbec3cf 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> ba61b3d 
> 
> Diff: https://reviews.apache.org/r/43049/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Re: Review Request 43049: Oozie should update war after adding Falcon

2016-03-22 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/#review124829
---




ambari-server/src/main/resources/scripts/Ambaripreupload.py (line 338)


This should be in a function to avoid duplicating code.
Or at a minimum, include a comment in both places indicating the other 
location to change.


- Alejandro Fernandez


On March 22, 2016, 2:57 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43049/
> ---
> 
> (Updated March 22, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14863
> https://issues.apache.org/jira/browse/AMBARI-14863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
> server/libext  
> Oozie war should be updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  c503a38 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 407bb2f 
> 
> Diff: https://reviews.apache.org/r/43049/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Re: Review Request 43049: Oozie should update war after adding Falcon

2016-03-22 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/#review124803
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 22, 2016, 4:57 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43049/
> ---
> 
> (Updated March 22, 2016, 4:57 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14863
> https://issues.apache.org/jira/browse/AMBARI-14863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
> server/libext  
> Oozie war should be updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  c503a38 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 407bb2f 
> 
> Diff: https://reviews.apache.org/r/43049/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Re: Review Request 43049: Oozie should update war after adding Falcon

2016-03-22 Thread Andrew Onischuk


> On Feb. 2, 2016, 12:14 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py,
> >  line 269
> > 
> >
> > The ls command will only list the file names. This  should also contain 
> > the size in bytes and date modified, remove blank lines, and should be 
> > sorted.
> > 
> > ls -l {oozie_libext_dir} | awk '{print $9, $5, $6, $7, $8}' | awk 'NF > 
> > 0' | sort

nice one will do that, except for sort as ls already sorts entries 
alphabetically according to the 'man ls'


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/#review117314
---


On March 22, 2016, 2:57 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43049/
> ---
> 
> (Updated March 22, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14863
> https://issues.apache.org/jira/browse/AMBARI-14863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
> server/libext  
> Oozie war should be updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  c503a38 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 407bb2f 
> 
> Diff: https://reviews.apache.org/r/43049/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Re: Review Request 43049: Oozie should update war after adding Falcon

2016-03-22 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/
---

(Updated March 22, 2016, 2:57 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-14863
https://issues.apache.org/jira/browse/AMBARI-14863


Repository: ambari


Description
---

After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
server/libext  
Oozie war should be updated.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 c503a38 
  ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 407bb2f 

Diff: https://reviews.apache.org/r/43049/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk