Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/#review135701 --- Ship it! Ship It! - Alejandro Fernandez On May 31, 2016, 8:32 p.m., Ajit Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43126/ > --- > > (Updated May 31, 2016, 8:32 p.m.) > > > Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-16692 > https://issues.apache.org/jira/browse/AMBARI-16692 > > > Repository: ambari > > > Description > --- > > RCA Database tables is not used anymore. This older, un-necessary data causes > many Ambari DB queries to return more slowly than necessary. If the database > gets large enough, it can have significant impact on the way ambari-server > functions. > The Ambari Server upgrade process should detect the presence of these older, > deprecated tables, and automate the process of cleaning up this data. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > d4272ba3760d5e5e0100f104159565bc28df02e5 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > 31dd8f23e4410da7ce65d7c746fb6eb740ee8536 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql > 3c4f1caa5df407b1e4735238cd330db44f019271 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql > f31af161b02fc44c398aa1371b639588b6c19c51 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql > d1147b7d956c65992e78e2daacd8b94fab4fc082 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 5a7a6a58978d347a8d3d68813e68866e489ce9b1 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-DROP.sql > a5380433131038abd15f1df05db8750e5e64ae0c > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > 2dba3b70e1669bce368109ac89344d540640167d > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > e769e5bd11230d8543ed82f80d4bb4be810b9385 > ambari-server/src/main/resources/AmbariRCA-DML-Oracle-CLEANUP.sql > 1f0f3c2b07a7d60be7c851b27dcde1777e5caa1f > ambari-server/src/main/resources/AmbariRCA-DML-Postgres-CLEANUP.sql > 3f07096ddf5e27b13ab0c8cd9dcc9e91ad500bee > > ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Oracle-UPGRADE.sql > f4027683bc5a8fc7ba7973d6270fc5ff3c9a4d0f > > ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Postgres-UPGRADE.sql > d9a7a758ab2a87d8d1ce8c8544926f7bb2a241e7 > > Diff: https://reviews.apache.org/r/43126/diff/ > > > Testing > --- > > manual testing > > > Thanks, > > Ajit Kumar > >
Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/ --- (Updated May 31, 2016, 8:32 p.m.) Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. Changes --- Removed rca tables from *-CREATE.sql. Now cleanup runs as part of SchemaUpgradeHelper. Bugs: AMBARI-16692 https://issues.apache.org/jira/browse/AMBARI-16692 Repository: ambari Description --- RCA Database tables is not used anymore. This older, un-necessary data causes many Ambari DB queries to return more slowly than necessary. If the database gets large enough, it can have significant impact on the way ambari-server functions. The Ambari Server upgrade process should detect the presence of these older, deprecated tables, and automate the process of cleaning up this data. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java d4272ba3760d5e5e0100f104159565bc28df02e5 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 31dd8f23e4410da7ce65d7c746fb6eb740ee8536 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3c4f1caa5df407b1e4735238cd330db44f019271 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31af161b02fc44c398aa1371b639588b6c19c51 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d1147b7d956c65992e78e2daacd8b94fab4fc082 ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5a7a6a58978d347a8d3d68813e68866e489ce9b1 ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-DROP.sql a5380433131038abd15f1df05db8750e5e64ae0c ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2dba3b70e1669bce368109ac89344d540640167d ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e769e5bd11230d8543ed82f80d4bb4be810b9385 ambari-server/src/main/resources/AmbariRCA-DML-Oracle-CLEANUP.sql 1f0f3c2b07a7d60be7c851b27dcde1777e5caa1f ambari-server/src/main/resources/AmbariRCA-DML-Postgres-CLEANUP.sql 3f07096ddf5e27b13ab0c8cd9dcc9e91ad500bee ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Oracle-UPGRADE.sql f4027683bc5a8fc7ba7973d6270fc5ff3c9a4d0f ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Postgres-UPGRADE.sql d9a7a758ab2a87d8d1ce8c8544926f7bb2a241e7 Diff: https://reviews.apache.org/r/43126/diff/ Testing (updated) --- manual testing Thanks, Ajit Kumar
Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/#review133850 --- Ship it! Ship It! - Jayush Luniya On May 16, 2016, 9:28 p.m., Ajit Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43126/ > --- > > (Updated May 16, 2016, 9:28 p.m.) > > > Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-16692 > https://issues.apache.org/jira/browse/AMBARI-16692 > > > Repository: ambari > > > Description > --- > > RCA Database tables is not used anymore. This older, un-necessary data causes > many Ambari DB queries to return more slowly than necessary. If the database > gets large enough, it can have significant impact on the way ambari-server > functions. > The Ambari Server upgrade process should detect the presence of these older, > deprecated tables, and automate the process of cleaning up this data. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 3547ad3 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > f36e640 > > Diff: https://reviews.apache.org/r/43126/diff/ > > > Testing > --- > > Unit test > > > Thanks, > > Ajit Kumar > >
Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables
> On May 16, 2016, 9:47 p.m., Sid Wagle wrote: > > What about RCA tables not a part of Ambari DB ? Only postgres-embedded-create.sql has ambarirca db. Users who are facing this issue have stand alone DB server and don't use postgres-embedded. Ideally we should remove ambarirca db from postgres-embedded-create.sql as well. - Ajit --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/#review133450 --- On May 16, 2016, 9:28 p.m., Ajit Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43126/ > --- > > (Updated May 16, 2016, 9:28 p.m.) > > > Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-16692 > https://issues.apache.org/jira/browse/AMBARI-16692 > > > Repository: ambari > > > Description > --- > > RCA Database tables is not used anymore. This older, un-necessary data causes > many Ambari DB queries to return more slowly than necessary. If the database > gets large enough, it can have significant impact on the way ambari-server > functions. > The Ambari Server upgrade process should detect the presence of these older, > deprecated tables, and automate the process of cleaning up this data. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 3547ad3 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > f36e640 > > Diff: https://reviews.apache.org/r/43126/diff/ > > > Testing > --- > > Unit test > > > Thanks, > > Ajit Kumar > >
Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/#review133450 --- What about RCA tables not a part of Ambari DB ? - Sid Wagle On May 16, 2016, 9:28 p.m., Ajit Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43126/ > --- > > (Updated May 16, 2016, 9:28 p.m.) > > > Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-16692 > https://issues.apache.org/jira/browse/AMBARI-16692 > > > Repository: ambari > > > Description > --- > > RCA Database tables is not used anymore. This older, un-necessary data causes > many Ambari DB queries to return more slowly than necessary. If the database > gets large enough, it can have significant impact on the way ambari-server > functions. > The Ambari Server upgrade process should detect the presence of these older, > deprecated tables, and automate the process of cleaning up this data. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 3547ad3 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > f36e640 > > Diff: https://reviews.apache.org/r/43126/diff/ > > > Testing > --- > > Unit test > > > Thanks, > > Ajit Kumar > >
