Re: Review Request 44285: AMBARI-15266 - Add configurable download retries for cache misses

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/#review123455
---


Ship it!




Ship It!

- Jayush Luniya


On March 3, 2016, 7:56 p.m., Greg Hill wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44285/
> ---
> 
> (Updated March 3, 2016, 7:56 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15266
> https://issues.apache.org/jira/browse/AMBARI-15266
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adds configuration options to tell ambari-agent to retry attempts to download 
> the custom script cache from ambari-server
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 05e898a 
>   ambari-agent/conf/windows/ambari-agent.ini e490f7c 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee 
>   ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa 
> 
> Diff: https://reviews.apache.org/r/44285/diff/
> 
> 
> Testing
> ---
> 
> New unit tests cover the behavior.
> 
> 
> Thanks,
> 
> Greg Hill
> 
>

Re: Review Request 44285: AMBARI-15266 - Add configurable download retries for cache misses

[Greg Hill]

> On March 4, 2016, 9:36 p.m., Jayush Luniya wrote:
> > ambari-agent/src/main/python/ambari_agent/FileCache.py, line 200
> > 
> >
> > Hmm, I was expecting it to be an annotation @retry. See 
> > https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L45

Does it matter?  It accomplishes the same thing.  There's literally no benefit 
to making another function inside of that method just to use it as a decorator.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/#review122152
---


On March 3, 2016, 7:56 p.m., Greg Hill wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44285/
> ---
> 
> (Updated March 3, 2016, 7:56 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15266
> https://issues.apache.org/jira/browse/AMBARI-15266
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adds configuration options to tell ambari-agent to retry attempts to download 
> the custom script cache from ambari-server
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 05e898a 
>   ambari-agent/conf/windows/ambari-agent.ini e490f7c 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee 
>   ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa 
> 
> Diff: https://reviews.apache.org/r/44285/diff/
> 
> 
> Testing
> ---
> 
> New unit tests cover the behavior.
> 
> 
> Thanks,
> 
> Greg Hill
> 
>