Re: Review Request 44577: Update descriptions for configs - HAWQ and PXF

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44577/
---

(Updated March 10, 2016, 10:51 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, 
and Matt.


Bugs: AMBARI-15311
https://issues.apache.org/jira/browse/AMBARI-15311


Repository: ambari


Description
---

Update descriptions for configs - HAWQ and PXF


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml
 9501a6a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
 e40caca 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml
 cd3d329 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 474f509 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 3ca9e87 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
 7518c6b 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml
 cd7e6be 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
 c87ce17 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml
 7b7e6c4 
  
ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-site.xml
 20ca06b 

Diff: https://reviews.apache.org/r/44577/diff/


Testing
---

Yes, done


Thanks,

Goutam Tadi

Re: Review Request 44577: Update descriptions for configs - HAWQ and PXF

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44577/#review122882
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 26)


From Ambari perspective, there is no default.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 53)


Same here. No default. 

The UI logic sets the property based on host component.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 150)


Please ensure that you mention **Native** and **YARN** in the description 
(refer the old description). 

These are the values that are shown in the dropdown on the theme



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 175)


Mention Native ('none')

Also mention **Resource Manager (hawq_global_rm_type)**. the display name 
on the theme is **Resource Manager**



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 188)


Mention Native ('none')

Also mention **Resource Manager (hawq_global_rm_type)**. the display name 
on the theme is **Resource Manager**



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 204)


Mention YARN ('yarn')

Also mention **Resource Manager (hawq_global_rm_type)**. the display name 
on the theme is **Resource Manager**



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 (line 224)


Mention YARN ('yarn')

Also mention **Resource Manager (hawq_global_rm_type)**. the display name 
on the theme is **Resource Manager**



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 (line 232)


Some changes going on for this one.

Refer: https://reviews.apache.org/r/44576/diff/1#index_header


- Matt


On March 9, 2016, 9:24 a.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44577/
> ---
> 
> (Updated March 9, 2016, 9:24 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, 
> and Matt.
> 
> 
> Bugs: AMBARI-15311
> https://issues.apache.org/jira/browse/AMBARI-15311
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update descriptions for configs - HAWQ and PXF
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml
>  9501a6a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
>  e40caca 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml
>  cd3d329 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  474f509 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  3ca9e87 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
>  7518c6b 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml
>  cd7e6be 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
>  c87ce17 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml
>  7b7e6c4 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-site.xml
>  20ca06b 
> 
> Diff: https://reviews.apache.org/r/44577/diff/
> 
> 
> Testing
> ---
> 
> Yes, done
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Re: Review Request 44577: Update descriptions for configs - HAWQ and PXF

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44577/#review122748
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On March 9, 2016, 5:24 p.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44577/
> ---
> 
> (Updated March 9, 2016, 5:24 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, 
> and Matt.
> 
> 
> Bugs: AMBARI-15311
> https://issues.apache.org/jira/browse/AMBARI-15311
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update descriptions for configs - HAWQ and PXF
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml
>  9501a6a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
>  e40caca 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml
>  cd3d329 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  474f509 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  3ca9e87 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml
>  7518c6b 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml
>  cd7e6be 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
>  c87ce17 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml
>  7b7e6c4 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-site.xml
>  20ca06b 
> 
> Diff: https://reviews.apache.org/r/44577/diff/
> 
> 
> Testing
> ---
> 
> Yes, done
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>