Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.
> On March 24, 2016, 4:24 p.m., Robert Levas wrote: > > What branch is this for - trunk and branch-2.2? There are two different patches for trunk and branch-2.2 as the code has been refactored in trunk. I do not have commit righs on trunk, I request you to push it to trunk once it gets 'ship it' from Alejandro. - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44972/#review125275 --- On March 23, 2016, 10:59 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44972/ > --- > > (Updated March 23, 2016, 10:59 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Robert Levas. > > > Bugs: AMBARI-15412 > https://issues.apache.org/jira/browse/AMBARI-15412 > > > Repository: ambari > > > Description > --- > > Improve error logging for install errors during blueprint deployments. > > Currently a severe error during install of a service component gets logged as > a WARNing > > E.g.: > > 09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - > Operation failed - may be retried. Service component host: KAFKA_BROKER, > host: hdtest159.svl.ibm.com Action id12-0 > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 24fea22 > > Diff: https://reviews.apache.org/r/44972/diff/ > > > Testing > --- > > There are no JUnit test cases, but attached the screenshot which shows > modified output. > > > File Attachments > > > Output > > https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png > AMBARI-15412_branch-2.2.patch > > https://reviews.apache.org/media/uploaded/files/2016/03/23/80355c33-2d5e-45f0-8f3d-1640f4386f05__AMBARI-15412_branch-2.2.patch > trunk patch > > https://reviews.apache.org/media/uploaded/files/2016/03/23/5c7a7d2f-fcf7-4858-9626-6a08ec9c7ba7__AMBARI-15412-trunk.patch > trunk--output > > https://reviews.apache.org/media/uploaded/files/2016/03/23/41b8327f-40ae-4a2f-b9c3-4e85eb9004c4__trunk-output.png > > > Thanks, > > Amruta Borkar > >
Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44972/ --- (Updated March 23, 2016, 10:54 p.m.) Review request for Ambari, Di Li and Sid Wagle. Changes --- Made siilar changes to address the issue in trunk. Trunk test output is attached. Bugs: AMBARI-15412 https://issues.apache.org/jira/browse/AMBARI-15412 Repository: ambari Description --- Improve error logging for install errors during blueprint deployments. Currently a severe error during install of a service component gets logged as a WARNing E.g.: 09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - Operation failed - may be retried. Service component host: KAFKA_BROKER, host: hdtest159.svl.ibm.com Action id12-0 Diffs - ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 24fea22 Diff: https://reviews.apache.org/r/44972/diff/ Testing --- There are no JUnit test cases, but attached the screenshot which shows modified output. File Attachments (updated) Output https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png AMBARI-15412_branch-2.2.patch https://reviews.apache.org/media/uploaded/files/2016/03/23/80355c33-2d5e-45f0-8f3d-1640f4386f05__AMBARI-15412_branch-2.2.patch trunk patch https://reviews.apache.org/media/uploaded/files/2016/03/23/5c7a7d2f-fcf7-4858-9626-6a08ec9c7ba7__AMBARI-15412-trunk.patch trunk--output https://reviews.apache.org/media/uploaded/files/2016/03/23/41b8327f-40ae-4a2f-b9c3-4e85eb9004c4__trunk-output.png Thanks, Amruta Borkar
Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44972/ --- (Updated March 17, 2016, 6:11 p.m.) Review request for Ambari, Di Li and Sumit Mohanty. Bugs: AMBARI-15412 https://issues.apache.org/jira/browse/AMBARI-15412 Repository: ambari Description (updated) --- Improve error logging for install errors during blueprint deployments. Currently a severe error during install of a service component gets logged as a WARNing E.g.: 09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - Operation failed - may be retried. Service component host: KAFKA_BROKER, host: hdtest159.svl.ibm.com Action id12-0 Diffs - ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 24fea22 Diff: https://reviews.apache.org/r/44972/diff/ Testing --- There are no JUnit test cases, but attached the screenshot which shows modified output. File Attachments Patch https://reviews.apache.org/media/uploaded/files/2016/03/17/2110d517-0cf4-4477-87e7-935c963e04de__AMBARI-15412.patch Output https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png Thanks, Amruta Borkar
Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44972/#review124288 --- Hello Amruta, You listed the branch as 2.2.2. There is no branch-2.2.2 if you look at https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=heads. The 2.2 related branches are branch-2.2 and branch-2.2.1. The line you changed also does not exist in trunk code. Could you please reconsider if the change is necessary for Ambari code and which branch it should go into? Thanks. - Di Li On March 18, 2016, 6:32 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44972/ > --- > > (Updated March 18, 2016, 6:32 p.m.) > > > Review request for Ambari, Di Li and Sid Wagle. > > > Bugs: AMBARI-15412 > https://issues.apache.org/jira/browse/AMBARI-15412 > > > Repository: ambari > > > Description > --- > > Improve error logging for install errors during blueprint deployments. > > Currently a severe error during install of a service component gets logged as > a WARNing > > E.g.: > > 09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - > Operation failed - may be retried. Service component host: KAFKA_BROKER, > host: hdtest159.svl.ibm.com Action id12-0 > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 24fea22 > > Diff: https://reviews.apache.org/r/44972/diff/ > > > Testing > --- > > There are no JUnit test cases, but attached the screenshot which shows > modified output. > > > File Attachments > > > Patch > > https://reviews.apache.org/media/uploaded/files/2016/03/17/2110d517-0cf4-4477-87e7-935c963e04de__AMBARI-15412.patch > Output > > https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png > > > Thanks, > > Amruta Borkar > >
Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44972/#review124176 --- Ship it! Ship It! - Di Li On March 17, 2016, 6:11 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44972/ > --- > > (Updated March 17, 2016, 6:11 p.m.) > > > Review request for Ambari, Di Li and Sumit Mohanty. > > > Bugs: AMBARI-15412 > https://issues.apache.org/jira/browse/AMBARI-15412 > > > Repository: ambari > > > Description > --- > > Improve error logging for install errors during blueprint deployments. > > Currently a severe error during install of a service component gets logged as > a WARNing > > E.g.: > > 09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - > Operation failed - may be retried. Service component host: KAFKA_BROKER, > host: hdtest159.svl.ibm.com Action id12-0 > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 24fea22 > > Diff: https://reviews.apache.org/r/44972/diff/ > > > Testing > --- > > There are no JUnit test cases, but attached the screenshot which shows > modified output. > > > File Attachments > > > Patch > > https://reviews.apache.org/media/uploaded/files/2016/03/17/2110d517-0cf4-4477-87e7-935c963e04de__AMBARI-15412.patch > Output > > https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png > > > Thanks, > > Amruta Borkar > >
