Re: Review Request 45215: HDFS Alerts for AMS Throw 'invalid literal for int() with base 10: '50.0''
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45215/#review125061 --- Ship it! Ship It! - Nate Cole On March 23, 2016, 11:08 a.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45215/ > --- > > (Updated March 23, 2016, 11:08 a.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-15533 > https://issues.apache.org/jira/browse/AMBARI-15533 > > > Repository: ambari > > > Description > --- > > SCRIPT alerts stuck in UNKNWN status with response message 'invalid literal > for int() with base 10: '50.0''. > > It is noticed that the error is thrown only after a PUT alertDefinition call > to update few parameters of alert definition since the numeric values are > changed into strings. > > The scripts need to safely cast their parameters; the fix is in the script > here. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py > f62c4a3 > > Diff: https://reviews.apache.org/r/45215/diff/ > > > Testing > --- > > Deployed on a cluster exibiting the cast problem. > > > Thanks, > > Jonathan Hurley > >
Re: Review Request 45215: HDFS Alerts for AMS Throw 'invalid literal for int() with base 10: '50.0''
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45215/#review125036 --- Ship it! Ship It! - Sid Wagle On March 23, 2016, 3:08 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45215/ > --- > > (Updated March 23, 2016, 3:08 p.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-15533 > https://issues.apache.org/jira/browse/AMBARI-15533 > > > Repository: ambari > > > Description > --- > > SCRIPT alerts stuck in UNKNWN status with response message 'invalid literal > for int() with base 10: '50.0''. > > It is noticed that the error is thrown only after a PUT alertDefinition call > to update few parameters of alert definition since the numeric values are > changed into strings. > > The scripts need to safely cast their parameters; the fix is in the script > here. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py > f62c4a3 > > Diff: https://reviews.apache.org/r/45215/diff/ > > > Testing > --- > > Deployed on a cluster exibiting the cast problem. > > > Thanks, > > Jonathan Hurley > >
