Re: Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45486/#review126426 --- Ship it! Ship It! - Jayush Luniya On March 30, 2016, 2:20 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45486/ > --- > > (Updated March 30, 2016, 2:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan > Hurley, Mahadev Konar, Sumit Mohanty, Vitalyi Brodetskyi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-15628 > https://issues.apache.org/jira/browse/AMBARI-15628 > > > Repository: ambari > > > Description > --- > > Updating Ranger, Ranger plugin for services (hdfs, hive, hbase, knox, storm, > kafka, yarn) and Ranger-KMS code to support real jdbc jar names. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 31e1757 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d6dec26 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 35c6be2 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc0d9a8 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > e3efe7c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > 5513757 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > b25549f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > db89664 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 74d0fe4 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > a5a57cf > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 4807dc5 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 1e55d4a > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 53aa4dd > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 40b076d > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 4b99081 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 741011c > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 9a61f99 > ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py > a5cc123 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > d415b6f > > Diff: https://reviews.apache.org/r/45486/diff/ > > > Testing > --- > > Installed Ranger, Ranger KMS and Enabled plugin on centos6 for Hdp-2.2 and > Hdp-2.5 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic
> On March 30, 2016, 5:43 p.m., Jayush Luniya wrote: > > - Can you add some more description in the Apache JIRA about change? > > - It looks like there is a dependent change that has been made in the past > > and the context is missing in the Apache JIRA > > Mugdha Varadkar wrote: > This Review is dependent on review request ID: 45458 only for flag > "stack_supports_config_versioning" which is introduced in that. I meant the JIRA where the jar name was parameterized. Looks like you updated the Apache JIRA with link to AMBARI-15390. So thats fine. - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45486/#review126147 --- On March 30, 2016, 2:20 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45486/ > --- > > (Updated March 30, 2016, 2:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan > Hurley, Mahadev Konar, Sumit Mohanty, Vitalyi Brodetskyi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-15628 > https://issues.apache.org/jira/browse/AMBARI-15628 > > > Repository: ambari > > > Description > --- > > Updating Ranger, Ranger plugin for services (hdfs, hive, hbase, knox, storm, > kafka, yarn) and Ranger-KMS code to support real jdbc jar names. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 31e1757 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d6dec26 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 35c6be2 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc0d9a8 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > e3efe7c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > 5513757 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > b25549f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > db89664 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 74d0fe4 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > a5a57cf > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 4807dc5 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 1e55d4a > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 53aa4dd > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 40b076d > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 4b99081 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 741011c > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 9a61f99 > ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py > a5cc123 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > d415b6f > > Diff: https://reviews.apache.org/r/45486/diff/ > > > Testing > --- > > Installed Ranger, Ranger KMS and Enabled plugin on centos6 for Hdp-2.2 and > Hdp-2.5 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45486/#review126301 --- Ship it! Ship It! - Jonathan Hurley On March 30, 2016, 10:20 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45486/ > --- > > (Updated March 30, 2016, 10:20 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan > Hurley, Mahadev Konar, Sumit Mohanty, Vitalyi Brodetskyi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-15628 > https://issues.apache.org/jira/browse/AMBARI-15628 > > > Repository: ambari > > > Description > --- > > Updating Ranger, Ranger plugin for services (hdfs, hive, hbase, knox, storm, > kafka, yarn) and Ranger-KMS code to support real jdbc jar names. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 31e1757 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d6dec26 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 35c6be2 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc0d9a8 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > e3efe7c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > 5513757 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > b25549f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > db89664 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 74d0fe4 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > a5a57cf > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 4807dc5 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 1e55d4a > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 53aa4dd > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 40b076d > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 4b99081 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 741011c > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 9a61f99 > ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py > a5cc123 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > d415b6f > > Diff: https://reviews.apache.org/r/45486/diff/ > > > Testing > --- > > Installed Ranger, Ranger KMS and Enabled plugin on centos6 for Hdp-2.2 and > Hdp-2.5 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic
> On March 30, 2016, 5:43 p.m., Jayush Luniya wrote: > > - Can you add some more description in the Apache JIRA about change? > > - It looks like there is a dependent change that has been made in the past > > and the context is missing in the Apache JIRA This Review is dependent on review request ID: 45458 only for flag "stack_supports_config_versioning" which is introduced in that. - Mugdha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45486/#review126147 --- On March 30, 2016, 2:20 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45486/ > --- > > (Updated March 30, 2016, 2:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan > Hurley, Mahadev Konar, Sumit Mohanty, Vitalyi Brodetskyi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-15628 > https://issues.apache.org/jira/browse/AMBARI-15628 > > > Repository: ambari > > > Description > --- > > Updating Ranger, Ranger plugin for services (hdfs, hive, hbase, knox, storm, > kafka, yarn) and Ranger-KMS code to support real jdbc jar names. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 31e1757 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d6dec26 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 35c6be2 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc0d9a8 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > e3efe7c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > 5513757 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > b25549f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > db89664 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 74d0fe4 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > a5a57cf > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 4807dc5 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 1e55d4a > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 53aa4dd > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 40b076d > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 4b99081 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 741011c > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 9a61f99 > ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py > a5cc123 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > d415b6f > > Diff: https://reviews.apache.org/r/45486/diff/ > > > Testing > --- > > Installed Ranger, Ranger KMS and Enabled plugin on centos6 for Hdp-2.2 and > Hdp-2.5 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45486/#review126150 --- Ship it! Ship It! - Alejandro Fernandez On March 30, 2016, 2:20 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45486/ > --- > > (Updated March 30, 2016, 2:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan > Hurley, Mahadev Konar, Sumit Mohanty, Vitalyi Brodetskyi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-15628 > https://issues.apache.org/jira/browse/AMBARI-15628 > > > Repository: ambari > > > Description > --- > > Updating Ranger, Ranger plugin for services (hdfs, hive, hbase, knox, storm, > kafka, yarn) and Ranger-KMS code to support real jdbc jar names. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 31e1757 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d6dec26 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 35c6be2 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc0d9a8 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > e3efe7c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > 5513757 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > b25549f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > db89664 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 74d0fe4 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > a5a57cf > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 4807dc5 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 1e55d4a > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 53aa4dd > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 40b076d > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 4b99081 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 741011c > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 9a61f99 > ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py > a5cc123 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > d415b6f > > Diff: https://reviews.apache.org/r/45486/diff/ > > > Testing > --- > > Installed Ranger, Ranger KMS and Enabled plugin on centos6 for Hdp-2.2 and > Hdp-2.5 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45486/#review126147 --- - Can you add some more description in the Apache JIRA about change? - It looks like there is a dependent change that has been made in the past and the context is missing in the Apache JIRA - Jayush Luniya On March 30, 2016, 2:20 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45486/ > --- > > (Updated March 30, 2016, 2:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan > Hurley, Mahadev Konar, Sumit Mohanty, Vitalyi Brodetskyi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-15628 > https://issues.apache.org/jira/browse/AMBARI-15628 > > > Repository: ambari > > > Description > --- > > Updating Ranger, Ranger plugin for services (hdfs, hive, hbase, knox, storm, > kafka, yarn) and Ranger-KMS code to support real jdbc jar names. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 31e1757 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d6dec26 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 35c6be2 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc0d9a8 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > e3efe7c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > 5513757 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > b25549f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > db89664 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 74d0fe4 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > a5a57cf > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 4807dc5 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 1e55d4a > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 53aa4dd > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 40b076d > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 4b99081 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 741011c > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 9a61f99 > ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py > a5cc123 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > d415b6f > > Diff: https://reviews.apache.org/r/45486/diff/ > > > Testing > --- > > Installed Ranger, Ranger KMS and Enabled plugin on centos6 for Hdp-2.2 and > Hdp-2.5 > > > Thanks, > > Mugdha Varadkar > >