Re: Review Request 45507: Enhance blueprint support for using references

2016-05-23 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45507/#review134360 --- I have some general concerns about this patch, and the proposed

Re: Review Request 45507: Enhance blueprint support for using references

2016-05-12 Thread Amruta Borkar
> On April 19, 2016, 8:47 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java, > > line 87 > > > > > > If the default top-level

Re: Review Request 45507: Enhance blueprint support for using references

2016-05-12 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45507/ --- (Updated May 12, 2016, 9:40 p.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-28 Thread Shantanu Mundkur
> On April 28, 2016, 9:17 p.m., Shantanu Mundkur wrote: > > Bob, Jayush, > > > > Thanks for reviewing this. > > > > Your review comments for the code changes are valid and Amruta will make > > changes or respond to those. > > > > I have prepared a document that has more details on the

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-25 Thread Amruta Borkar
> On April 19, 2016, 8:47 p.m., Robert Nettleton wrote: > > I've taken a quick look at this, and I have a few concerns with this patch: > > > > 1. I'm not sure there is that much utility in replacing the secret tokens > > with the "default_password" value specified in the Cluster Creation > >

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45507/#review129702 --- Agree with Bob's comments here. - Jayush Luniya On March 30,

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45507/#review129615 --- I've taken a quick look at this, and I have a few concerns with