Re: Review Request 45560: AMBARI-15655: Remove remaining hdp specific logic from resource_management library

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45560/#review126922
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 31, 2016, 9:16 p.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45560/
> ---
> 
> (Updated March 31, 2016, 9:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15655
> https://issues.apache.org/jira/browse/AMBARI-15655
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove remaining HDP specific logic from resource_management. 
> AMBARI-15420 didnt cover them as this need stack_featurization changes.
> 
> TODOs:
> 1. Cleanup HDP hardcodings in custom_actions scripts
> 2. Cleanup HDP hardcodings in configurations especially in common-services
> 3. Stack-driven configs for lzo-packages, list of repos etc.
> 
> 
> Diffs
> -
> 
>   
> ambari-agent/src/test/python/resource_management/TestListAmbariManagedRepos.py
>  8c590da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  d4e88e7 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  870bb0c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/list_ambari_managed_repos.py
>  bab6374 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  6169699 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  02cd7ca 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  9122a0e 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 4cbf2d7 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
>  38269cb 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py
>  4467114 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 4020ae0 
>   ambari-server/src/test/python/TestVersionSelectUtil.py 9fa24cc 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 338d3d3 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> b6a19ec 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 8c61b0b 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 67bbb9d 
> 
> Diff: https://reviews.apache.org/r/45560/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 45560: AMBARI-15655: Remove remaining hdp specific logic from resource_management library

[Jayush Luniya]

> On March 31, 2016, 8:27 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py,
> >  line 41
> > 
> >
> > Just to confirm, this is using unformatted, is that correct?

check_stack_feature() calls compare_version with format=True, so we dont need 
to format the version as such.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45560/#review126431
---


On March 31, 2016, 8:29 p.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45560/
> ---
> 
> (Updated March 31, 2016, 8:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15655
> https://issues.apache.org/jira/browse/AMBARI-15655
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove remaining HDP specific logic from resource_management. 
> AMBARI-15420 didnt cover them as this need stack_featurization changes.
> 
> TODOs:
> 1. Cleanup HDP hardcodings in custom_actions scripts
> 2. Cleanup HDP hardcodings in configurations especially in common-services
> 3. Stack-driven configs for lzo-packages, list of repos etc.
> 
> 
> Diffs
> -
> 
>   
> ambari-agent/src/test/python/resource_management/TestListAmbariManagedRepos.py
>  8c590da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  d4e88e7 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  870bb0c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/list_ambari_managed_repos.py
>  bab6374 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  ac2dbd9 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  02cd7ca 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  9122a0e 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 4cbf2d7 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 4020ae0 
>   ambari-server/src/test/python/TestVersionSelectUtil.py 9fa24cc 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 338d3d3 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> b6a19ec 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 8c61b0b 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 67bbb9d 
> 
> Diff: https://reviews.apache.org/r/45560/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 45560: AMBARI-15655: Remove remaining hdp specific logic from resource_management library

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45560/
---

(Updated March 31, 2016, 8:29 p.m.)


Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
Mohanty.


Bugs: AMBARI-15655
https://issues.apache.org/jira/browse/AMBARI-15655


Repository: ambari


Description
---

Remove remaining HDP specific logic from resource_management. 
AMBARI-15420 didnt cover them as this need stack_featurization changes.

TODOs:
1. Cleanup HDP hardcodings in custom_actions scripts
2. Cleanup HDP hardcodings in configurations especially in common-services
3. Stack-driven configs for lzo-packages, list of repos etc.


Diffs (updated)
-

  
ambari-agent/src/test/python/resource_management/TestListAmbariManagedRepos.py 
8c590da 
  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 d4e88e7 
  
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 870bb0c 
  
ambari-common/src/main/python/resource_management/libraries/functions/list_ambari_managed_repos.py
 bab6374 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 ac2dbd9 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 02cd7ca 
  
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
 9122a0e 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
4cbf2d7 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
4020ae0 
  ambari-server/src/test/python/TestVersionSelectUtil.py 9fa24cc 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 338d3d3 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py b6a19ec 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 8c61b0b 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
67bbb9d 

Diff: https://reviews.apache.org/r/45560/diff/


Testing
---


Thanks,

Jayush Luniya

Re: Review Request 45560: AMBARI-15655: Remove remaining hdp specific logic from resource_management library

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45560/#review126431
---




ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 (line 37)


Just to confirm, this is using unformatted, is that correct?


- Alejandro Fernandez


On March 31, 2016, 8:21 p.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45560/
> ---
> 
> (Updated March 31, 2016, 8:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15655
> https://issues.apache.org/jira/browse/AMBARI-15655
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove remaining HDP specific logic from resource_management. 
> AMBARI-15420 didnt cover them as this need stack_featurization changes.
> 
> TODOs:
> 1. Cleanup HDP hardcodings in custom_actions scripts
> 2. Cleanup HDP hardcodings in configurations especially in common-services
> 3. Stack-driven configs for lzo-packages, list of repos etc.
> 
> 
> Diffs
> -
> 
>   
> ambari-agent/src/test/python/resource_management/TestListAmbariManagedRepos.py
>  8c590da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  d4e88e7 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  870bb0c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/list_ambari_managed_repos.py
>  bab6374 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  ac2dbd9 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  02cd7ca 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  9122a0e 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 4cbf2d7 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 4020ae0 
>   ambari-server/src/test/python/TestVersionSelectUtil.py 9fa24cc 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 338d3d3 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> b6a19ec 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 8c61b0b 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 67bbb9d 
> 
> Diff: https://reviews.apache.org/r/45560/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 45560: AMBARI-15655: Remove remaining hdp specific logic from resource_management library

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45560/
---

(Updated March 31, 2016, 8:21 p.m.)


Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
Mohanty.


Bugs: AMBARI-15655
https://issues.apache.org/jira/browse/AMBARI-15655


Repository: ambari


Description (updated)
---

Remove remaining HDP specific logic from resource_management. 
AMBARI-15420 didnt cover them as this need stack_featurization changes.

TODOs:
1. Cleanup HDP hardcodings in custom_actions scripts
2. Cleanup HDP hardcodings in configurations especially in common-services
3. Stack-driven configs for lzo-packages, list of repos etc.


Diffs
-

  
ambari-agent/src/test/python/resource_management/TestListAmbariManagedRepos.py 
8c590da 
  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 d4e88e7 
  
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 870bb0c 
  
ambari-common/src/main/python/resource_management/libraries/functions/list_ambari_managed_repos.py
 bab6374 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 ac2dbd9 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 02cd7ca 
  
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
 9122a0e 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
4cbf2d7 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
4020ae0 
  ambari-server/src/test/python/TestVersionSelectUtil.py 9fa24cc 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 338d3d3 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py b6a19ec 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 8c61b0b 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
67bbb9d 

Diff: https://reviews.apache.org/r/45560/diff/


Testing
---


Thanks,

Jayush Luniya