Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-22 Thread Jayush Luniya
> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you, could you commit this? > > Jayush Luniya wrote: > Ok will commit today. Committed. Can you please close the review? - Jayush

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-22 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/ --- (Updated 4月 22, 2016, 9:35 a.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-20 Thread Jayush Luniya
> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you, could you commit this? Ok will commit today. - Jayush --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-20 Thread Masahiro Tanaka
> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote: > > Ship It! Thank you, could you commit this? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review129706

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review129706 --- Ship it! Ship It! - Jayush Luniya On April 19, 2016, 11:52

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-19 Thread Masahiro Tanaka
> On 4月 18, 2016, 5:33 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py, > > line 137 > > > > > > Add null checks and check reponse

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-19 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/ --- (Updated 4月 19, 2016, 11:52 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-18 Thread Jayush Luniya
> On April 18, 2016, 5:33 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py, > > line 137 > > > > > > Add null checks and check reponse

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-17 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review129295 ---

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-06 Thread Masahiro Tanaka
> On April 4, 2016, 6:37 p.m., Vitalyi Brodetskyi wrote: > > Ship It! Thank you. Could you commit this ? - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review126892

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-04 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/#review126892 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 4, 2016,