Re: Review Request 45677: Provide more intuitive error message when unable to change Ambari server pid or log dirs

2016-04-04 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45677/
---

(Updated April 4, 2016, 12:19 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15684
https://issues.apache.org/jira/browse/AMBARI-15684


Repository: ambari


Description
---

I am unable to change the Ambari Server log and pid directory and the error is
not very intuitive.

1\. Ran ambari server setup  
2\. changed ambari server daemon to ambaritest (from root)  
3\. edited the files to change log and pid  
4\. Not working. Might be related to #2. Need to confirm changing log and/or
pid working in all paths: root, non-root, after setup, after
setup->start->stop, etc.

vi /etc/ambari-server/conf/ambari.properties  
pid.dir=/tmp/run/ambari-server




[root@c6402 ~]# ambari-server start
Using python  /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
 Make sure that you include only one javax.servlet.jsp.jstl.jar in the java 
class path 
'/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
Server PID at: /tmp/run/ambari-server/ambari-server.pid
Server out at: /tmp/log/ambari-server/ambari-server.out
Server log at: /tmp/log/ambari-server/ambari-server.log
Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
No such file or directory
sh: /tmp/run/ambari-server/ambari-server.exitcode: Permission denied
.
ERROR: Exiting with exit code -1. 
REASON: Ambari Server java process died with exitcode -1. Check 
/tmp/log/ambari-server/ambari-server.out for more information.
[root@c6402 ~]# 


vi /etc/ambari-server/conf/log4j.properties  
ambari.log.dir=$

{ambari.root.dir}

/var/log/ambari-server




[root@c6402 ~]# ambari-server start
Using python  /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
 Make sure that you include only one javax.servlet.jsp.jstl.jar in the java 
class path 
'/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
Server PID at: /var/run/ambari-server/ambari-server.pid
Server out at: /tmp/log/ambari-server/ambari-server.out
Server log at: /tmp/log/ambari-server/ambari-server.log
Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
No such file or directory
.
ERROR: Exiting with exit code -1. 
REASON: Ambari Server java process died with exitcode 1. Check 
/tmp/log/ambari-server/ambari-server.out for more information.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 54db372 
  ambari-server/src/test/python/TestAmbariServer.py 091869f 
  ambari-server/src/test/python/TestOSCheck.py 1be783e 
  ambari-server/src/test/python/TestServerClassPath.py fc66e7c 
  ambari-server/src/test/python/TestServerUpgrade.py 04ec337 
  ambari-server/src/test/python/TestServerUtils.py c34bba5 

Diff: https://reviews.apache.org/r/45677/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk



Re: Review Request 45677: Provide more intuitive error message when unable to change Ambari server pid or log dirs

2016-04-04 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45677/#review126817
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 4, 2016, 12:12 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45677/
> ---
> 
> (Updated Квітень 4, 2016, 12:12 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15684
> https://issues.apache.org/jira/browse/AMBARI-15684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I am unable to change the Ambari Server log and pid directory and the error is
> not very intuitive.
> 
> 1\. Ran ambari server setup  
> 2\. changed ambari server daemon to ambaritest (from root)  
> 3\. edited the files to change log and pid  
> 4\. Not working. Might be related to #2. Need to confirm changing log and/or
> pid working in all paths: root, non-root, after setup, after
> setup->start->stop, etc.
> 
> vi /etc/ambari-server/conf/ambari.properties  
> pid.dir=/tmp/run/ambari-server
> 
> 
> 
> 
> [root@c6402 ~]# ambari-server start
> Using python  /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
> class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
> /usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
>  Make sure that you include only one javax.servlet.jsp.jstl.jar in the 
> java class path 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
> Server PID at: /tmp/run/ambari-server/ambari-server.pid
> Server out at: /tmp/log/ambari-server/ambari-server.out
> Server log at: /tmp/log/ambari-server/ambari-server.log
> Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
> No such file or directory
> sh: /tmp/run/ambari-server/ambari-server.exitcode: Permission denied
> .
> ERROR: Exiting with exit code -1. 
> REASON: Ambari Server java process died with exitcode -1. Check 
> /tmp/log/ambari-server/ambari-server.out for more information.
> [root@c6402 ~]# 
> 
> 
> vi /etc/ambari-server/conf/log4j.properties  
> ambari.log.dir=$
> 
> {ambari.root.dir}
> 
> /var/log/ambari-server
> 
> 
> 
> 
> [root@c6402 ~]# ambari-server start
> Using python  /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
> class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
> /usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
>  Make sure that you include only one javax.servlet.jsp.jstl.jar in the 
> java class path 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /tmp/log/ambari-server/ambari-server.out
> Server log at: /tmp/log/ambari-server/ambari-server.log
> Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
> No such file or directory
> .
> ERROR: Exiting with exit code -1. 
> REASON: Ambari Server java process died with exitcode 1. Check 
> /tmp/log/ambari-server/ambari-server.out for more information.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 2d49b9a 
>   ambari-server/src/test/python/TestAmbariServer.py ac24f7d 
>   ambari-server/src/test/python/TestOSCheck.py 1be783e 
>   ambari-server/src/test/python/TestServerClassPath.py fc66e7c 
>   ambari-server/src/test/python/TestServerUpgrade.py 04ec337 
>   ambari-server/src/test/python/TestServerUtils.py c34bba5 
> 
> Diff: https://reviews.apache.org/r/45677/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>