Re: Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45846/#review127773 --- Ship it! Ship It! - Dmytro Sen On Апрель 7, 2016, 11:38 п.п., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45846/ > --- > > (Updated Апрель 7, 2016, 11:38 п.п.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15749 > https://issues.apache.org/jira/browse/AMBARI-15749 > > > Repository: ambari > > > Description > --- > > Introduce 'diff' post processing function to compute difference between > points across time. > > Also, removed the first point from the series during rate and diff > calculation. > > > Diffs > - > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > a5204e1 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/Function.java > 6f408a5 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/FunctionTest.java > 46bc6f8 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java > 512a7db > > Diff: https://reviews.apache.org/r/45846/diff/ > > > Testing > --- > > Manually tested. > > Added unit tests. > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45846/#review127694 --- Ship it! Ship It! - Sid Wagle On April 7, 2016, 11:38 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45846/ > --- > > (Updated April 7, 2016, 11:38 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15749 > https://issues.apache.org/jira/browse/AMBARI-15749 > > > Repository: ambari > > > Description > --- > > Introduce 'diff' post processing function to compute difference between > points across time. > > Also, removed the first point from the series during rate and diff > calculation. > > > Diffs > - > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > a5204e1 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/Function.java > 6f408a5 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/FunctionTest.java > 46bc6f8 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java > 512a7db > > Diff: https://reviews.apache.org/r/45846/diff/ > > > Testing > --- > > Manually tested. > > Added unit tests. > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45846/ --- (Updated April 7, 2016, 11:38 p.m.) Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Changes --- Removed Rate related changes. Bugs: AMBARI-15749 https://issues.apache.org/jira/browse/AMBARI-15749 Repository: ambari Description (updated) --- Introduce 'diff' post processing function to compute difference between points across time. Also, removed the first point from the series during rate and diff calculation. Diffs (updated) - ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java a5204e1 ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/Function.java 6f408a5 ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/FunctionTest.java 46bc6f8 ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java 512a7db Diff: https://reviews.apache.org/r/45846/diff/ Testing --- Manually tested. Added unit tests. Thanks, Aravindan Vijayan
