Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/#review127661 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 5:55 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45877/ > --- > > (Updated April 7, 2016, 5:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-15764 > https://issues.apache.org/jira/browse/AMBARI-15764 > > > Repository: ambari > > > Description > --- > > There are 3 issues fixed in this, in order of importance: > * Add services/stack_services to the compatible_repository_versions endpoint. > * The Repository subresource was excluding Repository objects due to a typo > in the property for ClusterStackVersion > * Fix for the Predicate override that should be overriding ONLY the url > predicate, WITHOUT including the user predicate > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java > ba3a774 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1793ef2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java > b674e79 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 6221826 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java > 87e73c5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java > 1622a4d > > ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java > 6bbb4bd > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 05f3dcf > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java > 40d9b0b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > 48eeaf8 > > Diff: https://reviews.apache.org/r/45877/diff/ > > > Testing > --- > > Manual. Automated: > > Tests run: 4121, Failures: 0, Errors: 0, Skipped: 32 > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 36:36.787s > [INFO] Finished at: Thu Apr 07 13:19:04 EDT 2016 > [INFO] Final Memory: 35M/709M > [INFO] > > > > Thanks, > > Nate Cole > >
Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/#review127652 --- Ship it! Ship It! - Jonathan Hurley On April 7, 2016, 1:55 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45877/ > --- > > (Updated April 7, 2016, 1:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-15764 > https://issues.apache.org/jira/browse/AMBARI-15764 > > > Repository: ambari > > > Description > --- > > There are 3 issues fixed in this, in order of importance: > * Add services/stack_services to the compatible_repository_versions endpoint. > * The Repository subresource was excluding Repository objects due to a typo > in the property for ClusterStackVersion > * Fix for the Predicate override that should be overriding ONLY the url > predicate, WITHOUT including the user predicate > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java > ba3a774 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1793ef2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java > b674e79 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 6221826 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java > 87e73c5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java > 1622a4d > > ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java > 6bbb4bd > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 05f3dcf > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java > 40d9b0b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > 48eeaf8 > > Diff: https://reviews.apache.org/r/45877/diff/ > > > Testing > --- > > Manual. Automated: > > Tests run: 4121, Failures: 0, Errors: 0, Skipped: 32 > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 36:36.787s > [INFO] Finished at: Thu Apr 07 13:19:04 EDT 2016 > [INFO] Final Memory: 35M/709M > [INFO] > > > > Thanks, > > Nate Cole > >
Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/#review127647 --- Ping - Nate Cole On April 7, 2016, 1:55 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45877/ > --- > > (Updated April 7, 2016, 1:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-15764 > https://issues.apache.org/jira/browse/AMBARI-15764 > > > Repository: ambari > > > Description > --- > > There are 3 issues fixed in this, in order of importance: > * Add services/stack_services to the compatible_repository_versions endpoint. > * The Repository subresource was excluding Repository objects due to a typo > in the property for ClusterStackVersion > * Fix for the Predicate override that should be overriding ONLY the url > predicate, WITHOUT including the user predicate > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java > ba3a774 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1793ef2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java > b674e79 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 6221826 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java > 87e73c5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java > 1622a4d > > ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java > 6bbb4bd > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 05f3dcf > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java > 40d9b0b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > 48eeaf8 > > Diff: https://reviews.apache.org/r/45877/diff/ > > > Testing > --- > > Manual. Automated: > > Tests run: 4121, Failures: 0, Errors: 0, Skipped: 32 > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 36:36.787s > [INFO] Finished at: Thu Apr 07 13:19:04 EDT 2016 > [INFO] Final Memory: 35M/709M > [INFO] > > > > Thanks, > > Nate Cole > >
Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/ --- (Updated April 7, 2016, 1:55 p.m.) Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBARI-15764 https://issues.apache.org/jira/browse/AMBARI-15764 Repository: ambari Description --- There are 3 issues fixed in this, in order of importance: * Add services/stack_services to the compatible_repository_versions endpoint. * The Repository subresource was excluding Repository objects due to a typo in the property for ClusterStackVersion * Fix for the Predicate override that should be overriding ONLY the url predicate, WITHOUT including the user predicate Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java ba3a774 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 1793ef2 ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java b674e79 ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 6221826 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java 87e73c5 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java 1622a4d ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 6bbb4bd ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 05f3dcf ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java 40d9b0b ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 48eeaf8 Diff: https://reviews.apache.org/r/45877/diff/ Testing (updated) --- Manual. Automated: Tests run: 4121, Failures: 0, Errors: 0, Skipped: 32 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 36:36.787s [INFO] Finished at: Thu Apr 07 13:19:04 EDT 2016 [INFO] Final Memory: 35M/709M [INFO] Thanks, Nate Cole
