Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Oliver Szabo
> On April 11, 2016, 9:02 p.m., Alejandro Fernandez wrote: > > pom.xml, line 438 > > > > > > What's the additional build time? I noticed you comments, but i close this now. for the future use:

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review128262 --- Ship it! Ship It! - Alejandro Fernandez On April 8, 2016, 6

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Robert Nettleton
> On April 11, 2016, 9:02 p.m., Alejandro Fernandez wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java, > > line 42 > > > > > > Please add some

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review128244 ---

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-11 Thread Oliver Szabo
> On April 8, 2016, 7:43 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json, > > line 23 > > > > > > Use service-level RCO instead of adding to the HDP stack. This

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-09 Thread Oliver Szabo
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? > > Oliver Szabo wrote: > most of it is a move (the

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? > > Oliver Szabo wrote: > most of it is a move (the

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? > > Oliver Szabo wrote: > most of it is a move (the

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review127861 ---

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. > > Jayush Luniya wrote: > Can the patch be broken down in more granular chunks? most of it is a move (the logsearch module), so its pretty

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Jayush Luniya
> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote: > > This is a pretty massive patch. Please allow some time for the community to > > review. Can the patch be broken down in more granular chunks? - Jayush --- This is an

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/#review127828 --- This is a pretty massive patch. Please allow some time for the

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-08 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45892/ --- (Updated April 8, 2016, 6 p.m.) Review request for Ambari, Miklos Gergely,